mariadb

Tree: 4288e329dd

Author	SHA1	Message	Date
Alexander Nozdrin	16dfa2b16f	Make funcs_1.myisam_views experimental on Solaris due to Bug 50595.	16 years ago
Alexander Barkov	56dc1bd2e3	Fixing non-determenistic results.	16 years ago
Marc Alff	01b19dbbf4	Bug#51738 Unit test pfs_instr-t crashes The unit test pfs_instr-t: - generates a very long (10,000) bytes file name - calls find_or_create_file. This leads to a buffer overflow in mysys in my_realpath(), because my_realpath and mysys file APIs in general do not test for input parameters: mysys assumes every file name is less that FN_REFLEN in length. Calling find_or_create_file with a very long file name is likely to happen when instrumenting third party code that does not use mysys, so this test is legitimate. The fix is to make find_or_create_file in the performance schema more robust in this case.	16 years ago
Marc Alff	18884b02c0	Bug#51741 Unit test pfs-t failing in mysql-next-mr-bugfixing The root cause of the failure is that when Bug#51447 performance schema evil twin files was fixed, instrumented file names got normalized. The pfs-t unit test depends on this file normalization, but it was not updated. This fix aligns pfs-t.cc lookup_file_by_name() with the logic in pfs_instr.cc find_or_create_file().	16 years ago
Mattias Jonsson	1f77c7b49a	Bug#50392: insert_id is not reset for partitioned tables auto_increment on duplicate entry The bug was that when INSERT_ID was used and the storage engine was told to release any reserved but not used auto_increment values, it set the highest auto_increment value to INSERT_ID. The fix was to check if the auto_increment value was forced by user (INSERT_ID) or by slave-thread, i.e. not auto- generated. So that it is only allowed to release generated values. mysql-test/r/partition_error.result: Bug#50392: insert_id is not reset for partitioned tables auto_increment on duplicate entry updated result mysql-test/suite/parts/inc/partition_auto_increment.inc: Bug#50392: insert_id is not reset for partitioned tables auto_increment on duplicate entry Added test mysql-test/suite/parts/r/partition_auto_increment_archive.result: Bug#50392: insert_id is not reset for partitioned tables auto_increment on duplicate entry Added result, note that archive does only allow increasing auto_increment values mysql-test/suite/parts/r/partition_auto_increment_blackhole.result: Bug#50392: insert_id is not reset for partitioned tables auto_increment on duplicate entry Added result, note that blackhole accepts all inserts :) mysql-test/suite/parts/r/partition_auto_increment_innodb.result: Bug#50392: insert_id is not reset for partitioned tables auto_increment on duplicate entry Added result, note that innodb rolls back inserts on error, but keeps the auto_increment value. mysql-test/suite/parts/r/partition_auto_increment_memory.result: Bug#50392: insert_id is not reset for partitioned tables auto_increment on duplicate entry Added result, note that memory and myisam inserts all rows before the error. mysql-test/suite/parts/r/partition_auto_increment_myisam.result: Bug#50392: insert_id is not reset for partitioned tables auto_increment on duplicate entry Added result, note that memory and myisam inserts all rows before the error. mysql-test/suite/parts/r/partition_auto_increment_ndb.result: Bug#50392: insert_id is not reset for partitioned tables auto_increment on duplicate entry Added result, note that NDB does not seem to handle INSERT_ID as other engines. (Martin will look into it). mysql-test/t/partition_error.test: Bug#50392: insert_id is not reset for partitioned tables auto_increment on duplicate entry Added test sql/ha_partition.cc: Bug#50392: insert_id is not reset for partitioned tables auto_increment on duplicate entry If the next_insert_id comes from non generated (i.e forced by INSERT_ID or slave-thread) then we cannot lower the reserved auto_increment value, since it have not reserved any values.	16 years ago
Georgi Kodinov	d934426ff5	Bug #51357 : crash when using handler commands on spatial indexes Spatial indexes were not checking for out-of-record condition in the handler next command when the previous command didn't found rows. Fixed by making the rtree index to check for end of rows condition before re-using the key from the previous search. Fixed another crash if the tree has changed since the last search. Added a test case for the other error.	16 years ago
Alexander Nozdrin	9f17a0018f	Auto-merge from mysql-next-mr-bugfixing.	16 years ago
Alexander Nozdrin	366a68bb46	Auto-merge from mysql-next-mr-bugfixing.	16 years ago
Joerg Bruehe	61f118d1fe	Upmerge changes to "COPYING" (formatting, FSF addressi, still GPL v2 as of 1991) and "README" (header part: "This is a release of MySQL ...") from "trunk" to "next-mr".	16 years ago
Joerg Bruehe	91cfcb8a65	Update "README" (the list of contributed software and their licenses) by adding the header part "This is MySQL ...".	16 years ago
Joerg Bruehe	a53d419677	Upmerge the new formatting of "COPYING" from 5.1 to "trunk", the license remains to be the GPL Version 2, June 1991	16 years ago
Joerg Bruehe	145af23c04	Use a new version of "COPYING", the GPL text. This is no change in contents, the differences are formatting only and an address update of the FSF. It continues to be Version 2, June 1991.	16 years ago
Tatiana A. Nurnberg	d41ce6d696	auto-merge	16 years ago
Tatiana A. Nurnberg	62809e2a09	auto-merge	16 years ago
Tatiana A. Nurnberg	08d27b7c5c	auto-merge	16 years ago
Alexander Barkov	47aaf9c401	Bug#51675 Server crashes on inserting 4 byte char. after ALTER TABLE to 'utf8mb4' Bug#51676 Server crashes on SELECT, ORDER BY on 'utf8mb4' column An additional fix. We should use 0xFFFD as a weight for supplementary characters, not the "weight for character U+FFFD".	16 years ago
Mattias Jonsson	48d986f511	Bug#50104: Partitioned table with just 1 partion works with fk There was no check for foreign keys when altering partitioned tables. Added check for FK when altering partitioned tables. mysql-test/r/partition_innodb.result: Bug#50104: Partitioned table with just 1 partion works with fk Updated test result mysql-test/t/partition_innodb.test: Bug#50104: Partitioned table with just 1 partion works with fk Added test for adding FK on partitioned tables (both 1 and 2 partitions) sql/sql_partition.cc: Bug#50104: Partitioned table with just 1 partion works with fk Disabled adding foreign key when altering a partitioned table.	16 years ago
Alexander Barkov	d6edcf75a5	Bug#51166 mysql client defaults to charset 'ascii' Using latin1 client character set for ASCII locales: - because ascii is not a build-in character set - for better backward compatibility	16 years ago
Mattias Jonsson	e46d120e8e	Bug#48229: group by performance issue of partitioned table Problem was block_size on partitioned tables was not set, resulting in keys_per_block was not correct which affects the cost calculation for read time of indexes (including cost for group min/max).Which resulted in a bad optimizer decision. Fixed by setting stats.block_size correctly. mysql-test/r/partition_range.result: Bug#48229: group by performance issue of partitioned table Added result mysql-test/t/partition_range.test: Bug#48229: group by performance issue of partitioned table Added test sql/ha_partition.cc: Bug#48229: group by performance issue of partitioned table Added missing assignment of stats.block_size.	16 years ago
Alexander Barkov	922cdddeb0	A joint patch for: Bug#51675 Server crashes on inserting 4 byte char. after ALTER TABLE to 'utf8mb4' Bug#51676 Server crashes on SELECT, ORDER BY on 'utf8mb4' column include/m_ctype.h: Defining MY_CS_REPLACEMENT_CHARACTER mysql-test/r/ctype_utf8mb4.result: Adding tests mysql-test/t/ctype_utf8mb4.test: Adding tests strings/ctype-uca.c: Don't use UCA data for characters higher than 0xFFFF. strings/ctype-ucs2.c: Using newly defined MY_CS_REPLACEMENT_CHARACTER strings/ctype-utf8.c: Using newly defined MY_CS_REPLACEMENT_CHARACTER Removing unesed variable "plane".	16 years ago
Mattias Jonsson	5eaa7936f6	Bug#51347: assertion with show create table + partition by columns on decimal column The problem was that there was no check to disallow DECIMAL columns in the code (it was accepted as if it was INTEGER). Solution was to correctly disallow DECIMAL columns in COLUMNS partitioning. As documented. mysql-test/r/partition_column.result: Bug#51347: assertion with show create table + partition by columns on decimal column updated test result mysql-test/t/partition_column.test: Bug#51347: assertion with show create table + partition by columns on decimal column Added test to verify column types that is not supported sql/sql_partition.cc: Bug#51347: assertion with show create table + partition by columns on decimal column Moved DECIMAL types to be disallowed as column types in COLUMNS partitioning	16 years ago
Luis Soares	7768ccbb54	BUG#51055: Replication failure on duplicate key + traditional SQL mode When the master was executing in sql_mode='traditional' (which implies that really_abort_on_warning returns TRUE - because of MODE_STRICT_ALL_TABLES), the error code (ER_DUP_ENTRY in the reported case) was not being set in the Query_log_event. Therefore, even if a failure was to be expected when replaying the statement on the slave, a failure would occur, because the Query_log_event was not transporting the expected error code, but 0 instead. This was because when the master was getting the error code to set it in the Query_log_event, the executing thread would be assumed to have been killed: THD::killed==THD::KILL_BAD_DATA. This would make the error code fetch routine not to check thd->main_da.sql_errno(), but instead the thd->killed value. What's more, is that the server would thd->killed value if thd->killed == THD::KILL_BAD_DATA and return 0 instead. So this is a double inconsistency, as the we should not even check thd->killed but rather thd->main_da.sql_errno(). We fix this by extending the condition used to choose whether to check the thd->main_da.sql_errno() or thd->killed, so that it takes into consideration the case when: thd->killed==THD::KILL_BAD_DATA.	16 years ago
Horst.Hunger	a75a9eb133	Push the test to next-mr-bar2 to let them run in pushbuild.	16 years ago
Alexander Nozdrin	0b1d317b23	A follow-up on WL#5154 and WL#5182: remove forgotten options.	16 years ago
Vladislav Vaintroub	50608a0b4b	merge	16 years ago
Mattias Jonsson	689b00a4a5	Fix for debug print of null string (fails on pb for solaris debug_max)	16 years ago
Vladislav Vaintroub	87a1ad6310	merge	16 years ago
Luis Soares	d13db314dd	BUG#51226: mysqlbinlog replay: ERROR 1146 when using temp tables + failing statements Implicit DROP event for temporary table is not getting LOG_EVENT_THREAD_SPECIFIC_F flag, because, in the previous executed statement in the same thread, which might even be a failed statement, the thread_specific_used flag is set to FALSE (in mysql_reset_thd_for_next_command) and not set to TRUE before connection is shutdown. This means that implicit DROP event will take the FALSE value from thread_specific_used and will not set LOG_EVENT_THREAD_SPECIFIC_F in the event header. As a consequence, mysqlbinlog will not print the pseudo_thread_id from the DROP event, because one of the requirements for the printout is that this flag is set to TRUE. We fix this by setting thread_specific_used whenever we are binlogging a DROP in close_temporary_tables, and resetting it to its previous value afterward.	16 years ago
Vladislav Vaintroub	eb10125318	Fix a problem reported by Alik: when cmake is used for building in a symlinked directory, and confguration is later adjusted with "cmake-gui ." After it, GenServerSource fails with "no rule for <filename>". The reason for the error is that cmake-gui resolves "." as realpath and rules are generated accordingly, while "cmake" used symlinked path The fix uses ${CMAKE_CURRENT_BINARY_DIR} instead of ${CMAKE_BINARY_DIR}/sql for generated files. This causes CMake to use relative file names so relative file names when generating make rules. Using relative filenames avoids the problem of refering to the same directory using 2 different paths. Besides, using ${CMAKE_CURRENT_BINARY_DIR} is a commonly used style when working with generated files.	16 years ago
Vladislav Vaintroub	cd03a4625f	Bug #51488 :missing features and change behavior in cmake runs compared to autotools runs - Fix recognition of --with-debug=full in configure wrapper - Remove CMakeCache.txt in configure wrapper, to match the original - Fix recognition of max-no-ndb - Fix broken dependencies of mysql_fix_privilege_table.sql from mysql_system_tables.sql and mysql_system_tables_fix.sql - Add "distclean target" that informs user about appropriate bzr command cmake/configure.pl: - Recognize --with-debug=full, map to WITH_DEBUG_FULL - remove CMakeCache.txt, so the configuration is no more sticky (to match the original configure behavior) cmake/plugin.cmake: - Recognize WITH_MAX_NO_NDB, this fixes missing storage engines after BUILD/max-no-ndb scripts mysql-test/CMakeLists.txt: test-force uses the same macros (MTR_FORCE) as test-bt now scripts/CMakeLists.txt: - Fix broken dependency when producing mysql_fix_privilege_tables.sql, reported by Davi. We now concatenate 2 scripts in custom command that has dependency on both scripts rather than concatenating them at cmake time. sql/CMakeLists.txt: Address frequently asked question "where is distclean" by implementing distclean target that does nothing except pointing to appropriate bzr command. It is better not to call "bzr clean-tree" automatically, without user consent. It could clean new files that were meant to be added.	16 years ago
Sergey Vojtovich	1d2aeb3da2	BUG#48265 - MRG_MYISAM problem (works in 5.0.85, does't work in 5.1.40) MERGE engine fails to open child table from a different database if child table/database name contains characters that are subject for table name to filename encoding (WL1324). Another problem is that MERGE engine didn't properly open child table from the same database if child table name contains characters like '/', '#'. The problem was that table name to file name encoding was applied inconsistently: * On CREATE: encode table name + database name if child table is in different database; do not encode table name if child table is in the same database; * No decoding on open. With this fix child table/database names are always encoded on CREATE and decoded on open. Compatibility with older tables preserved. Along with this patch comes fix for SHOW CREATE TABLE, which used to show child table/database path instead of child table/database names. mysql-test/r/merge.result: A test case for BUG#48265. mysql-test/std_data/bug48265.frm: MERGE table from 5.0 to test fix for BUG#48265 compatibility. mysql-test/t/merge.test: A test case for BUG#48265. storage/myisammrg/ha_myisammrg.cc: On CREATE always write child table/database name encoded by table name to filename encoding to dot-MRG file. On open decode child table/database name. Compatibilty with previous versions preserved. Fixed ::append_create_info() to return child table/database name instead of path. storage/myisammrg/myrg_open.c: Move if (has_path) branch from myrg_parent_open() to myisammrg_parent_open_callback. The callback function needs to know if child table was written along with database name to dot-MRG file. Needed for compatibility reasons.	16 years ago
Jon Olav Hauglid	b0ab907b42	Bug #51376 Assert `! is_set()' failed in Diagnostics_area::set_ok_status on DROP FUNCTION This assert tests that the server is not trying to send "ok" to the client if an error has occured during statement processing. In this case, the assert was triggered by lock timeout errors when accessing system tables to do an implicit REVOKE after executing DROP FUNCTION/PROCEDURE. In practice, this was only likely to happen with very low values for "lock_wait_timeout" (in the bug report 1 second was used). These errors were ignored and the server tried to send "ok" to the client, triggering the assert. The patch for Bug#45225 introduced lock timeouts for metadata locks. This made it possible to get timeouts when accessing system tables. Note that a followup patch for Bug#45225 pushed after this bug was reported, changed accessing of system tables such that the user-supplied timeout value is ignored and the maximum timeout value is used instead. This exact bug was therefore only noticeable in the period between the initial Bug#45225 patch and the followup patch. However, the same problem could occur for any errors during revoking of privileges - not just timeouts. This patch fixes the problem by making sure that any errors during revoking of privileges are reported to the client. Test case added to sp-destruct.test. Since the original bug is not reproducable now that system tables are accessed using a a long timeout value, this test instead calls DROP FUNCTION with a grant system table missing.	16 years ago
Tatiana A. Nurnberg	f34e0df877	auto-merge	16 years ago
Tatiana A. Nurnberg	fa970541bb	auto-merge	16 years ago
Tatiana A. Nurnberg	a3edaa0cea	manual merge	16 years ago
Tatiana A. Nurnberg	c610e9783a	Bug#48295: explain extended crash with subquery and ONLY_FULL_GROUP_BY sql If an outer query is broken, a subquery might not even get set up. EXPLAIN EXTENDED did not expect this and merrily tried to de-ref all of the half-setup info. We now catch this case and print as much as we have, as it doesn't cost us anything (doesn't make regular execution slower). backport from 5.1 mysql-test/r/explain.result: Show that EXPLAIN EXTENDED with subquery and illegal out query doesn't crash. Show also that SHOW WARNINGS will render an additional Note in the hope of being, well, helpful. mysql-test/t/explain.test: If we have only half a query for EXPLAIN EXTENDED to print (i.e., incomplete subquery info as outer query is illegal), we should provide the user with as much info as we easily can if they ask for it. What we should not do is crash when they come asking for help, that violates etiquette in some countries. sql/item_subselect.cc: If the sub-query's actually set up, print it. Otherwise, elide.	16 years ago
Tatiana A. Nurnberg	42585b098e	auto-merge	16 years ago
Alexander Nozdrin	aca943f0b1	Auto-merge (empty) from mysql-trunk-bugfixing.	16 years ago
Alexander Nozdrin	d3755291ca	Manual merge from mysql-next-mr. Conflicts: - sql/sql_base.cc	16 years ago
Alexander Nozdrin	455d3dc459	Auto-merge from mysql-trunk.	16 years ago
Georgi Kodinov	ee4a3099b3	Moved the ndb related tests out of the per-push pb2 run to the daily pb2 run.	16 years ago
Sergey Vojtovich	a82cc50958	BUG#51307 - widespread corruption with partitions and insert...select Queries following bulk insert into an empty MyISAM table may break it. This was pure MyISAM problem. When bulk insert into an empty table is complete, MyISAM may want to enable indexes via repair by sort. If repair by sort fails (e.g. insufficient buffer), MyISAM failover to repair with key cache, requesting repair of data file. Repair of data file performs data file substitution. This means that current table instance will point to new data file. Other cached table instances are still pointing to an old, deleted data file. This is fixed by not requesting repair of data file during enable indexes. Explicit REPAIR is not affected, since it flushes all table instances. mysql-test/r/myisam.result: A test case for BUG#51307. mysql-test/t/myisam.test: A test case for BUG#51307. storage/myisam/ha_myisam.cc: When enabling indexes do not attempt to repair data file.	16 years ago
Dmitry Lenev	c843f58f04	Merged recent changed from mysql-next-mr-bugfixing into mysql-next-4284 tree.	16 years ago
Alexander Nozdrin	64b91b2698	Auto-merge from mysql-trunk-merge.	16 years ago
Alexander Nozdrin	61bd9ef648	Remove test from experimental because Bug 45578 and 46010 are fixed.	16 years ago
Vladislav Vaintroub	0139908c7e	merge	16 years ago
Vladislav Vaintroub	40e12231fe	Fix WITH_DEBUG problems in CMake build, so people who use configure wrappers do not suffer. The problem was that when custom C flags were defined with in environment variable CFLAGS, WITH_DEBUG did not have any effect. Also, switch from WITH_DEBUG=ON to WITH_DEBUG=OFF was not handled correctly .Expected is switch to with RelwithDebInfo or when custom compiler flags are defined, to None.	16 years ago
Marc Alff	77385a9136	Bug#51612 Un initialized locker_lost variable in pfs_instr.cc Fixed the missing initialization of locker_lost. This fix is not strictly necessary, but is desirable to re-align the code from 5.5 and 6.0, and reduce the spurious code differences. This will facilitate maintenance and help to apply patches cleanly, for merges.	16 years ago
Mattias Jonsson	11dab05ecd	merge	16 years ago
Mattias Jonsson	4bce198ce9	manual merge fix of bug#42438 in mysql-next-mr-merge	16 years ago

... 3 4 5 6 7 ...

61605 Commits (4288e329dd9676494a9e3927e61492e975277112) All Branches Search

61605 Commits (4288e329dd9676494a9e3927e61492e975277112)

All Branches