mariadb

Tree: 42282c10ce

Author	SHA1	Message	Date
Kent Boortz	e5ce023f57	Updated/added copyright headers	15 years ago
Magne Mahre	f2a42aee2e	Bug#48053 String::c_ptr has a race and/or does an invalid memory reference There are two issues present here. 1) There is a possibility that we test a byte beyond the allocated buffer 2) We compare a byte that might never have been initalized to see if it's 0. The first issue is not triggered by existing code, but an ASSERT has been added to safe-guard against introducing new code that triggers it. The second issue is what triggers the Valgrind warnings reported in the bug report. A buffer is allocated in class String to hold the value. This buffer is populated by the character data constituting the string, but is not zero-terminated in most cases. Testing if it is indeed zero-terminated means that we check a byte that has never been explicitly set, thus causing Valgrind to trigger. Note that issue 2 is not a serious problem. The variable is read, and if it's not zero, we will set it to zero. There are no further consequences. Note that this patch does not fix the underlying problems with issue 1, as it is deemed too risky to fix at this point (as noted in the bug report). As discussed in the report, the c_ptr() method should probably be replaced, but this requires a thorough analysis of the ~200 calls to the method.	15 years ago
Martin Hansson	3ef71bfac7	Bug#58165: "my_empty_string" gets modified and causes LOAD DATA to fail and other crashes Some string manipulating SQL functions use a shared string object intended to contain an immutable empty string. This object was used by the SQL function SUBSTRING_INDEX() to return an empty string when one argument was of the wrong datatype. If the string object was then modified by the sql function INSERT(), undefined behavior ensued. Fixed by instead modifying the string object representing the function's result value whenever string manipulating SQL functions return an empty string. Relevant code has also been documented.	15 years ago
Davi Arnaut	39e9bde2c0	Bug#45288: pb2 returns a lot of compilation warnings Tag or remove unused arguments and variables.	15 years ago
Gleb Shchepa	ed736379f5	Bug #55424 : convert_tz crashes when fed invalid data The CONVERT_TZ function crashes the server when the timezone argument is an empty SET field value. 1) The CONVERT_TZ may find a timezone string in the tz_names hash. 2) A string representation of the empty SET is a String of zero length with the NULL pointer. 3) If the key argument length is zero, hash functions do comparison using the length of the record being compared against. I.e. a zero-length String buffer is an invalid argument for hash search functions, and if String points to NULL buffer, hashcmp() fails with SEGV accessing that memory. The my_tz_find function has been modified to treat empty Strings as invalid timezone values to skip unnecessary hash search.	16 years ago
Gleb Shchepa	e642140b18	Bug# 30946: mysqldump silently ignores --default-character-set when used with --tab 1) New syntax: added CHARACTER SET clause to the SELECT ... INTO OUTFILE (to complement the same clause in LOAD DATA INFILE). mysqldump is updated to use this in --tab mode. 2) ESCAPED BY/ENCLOSED BY field parameters are documented as accepting CHAR argument, however SELECT .. INTO OUTFILE silently ignored rests of multisymbol arguments. For the symmetrical behavior with LOAD DATA INFILE the server has been modified to fail with the same error: ERROR 42000: Field separator argument is not what is expected; check the manual 3) Current LOAD DATA INFILE recognizes field/line separators "as is" without converting from client charset to data file charset. So, it is supposed, that input file of LOAD DATA INFILE consists of data in one charset and separators in other charset. For the compatibility with that [buggy] behaviour SELECT INTO OUTFILE implementation has been saved "as is" too, but the new warning message has been added: Non-ASCII separator arguments are not fully supported This message warns on field/line separators that contain non-ASCII symbols.	17 years ago
Jonathan Perkin	6e6d0c8216	Merge fix for bug#38296 into 5.0.66sp1	17 years ago
Marc Alff	394691cd90	Bug#38296 (low memory crash with many conditions in a query) This fix is for 5.0 only : back porting the 6.0 patch manually The parser code in sql/sql_yacc.yy needs to be more robust to out of memory conditions, so that when parsing a query fails due to OOM, the thread gracefully returns an error. Before this fix, a new/alloc returning NULL could: - cause a crash, if dereferencing the NULL pointer, - produce a corrupted parsed tree, containing NULL nodes, - alter the semantic of a query, by silently dropping token values or nodes With this fix: - C++ constructors are not executed with a NULL "this" pointer when operator new fails. This is achieved by declaring "operator new" with a "throw ()" clause, so that a failed new gracefully returns NULL on OOM conditions. - calls to new/alloc are tested for a NULL result, - The thread diagnostic area is set to an error status when OOM occurs. This ensures that a request failing in the server properly returns an ER_OUT_OF_RESOURCES error to the client. - OOM conditions cause the parser to stop immediately (MYSQL_YYABORT). This prevents causing further crashes when using a partially built parsed tree in further rules in the parser. No test scripts are provided, since automating OOM failures is not instrumented in the server. Tested under the debugger, to verify that an error in alloc_root cause the thread to returns gracefully all the way to the client application, with an ER_OUT_OF_RESOURCES error.	18 years ago
bar@mysql.com/bar.myoffice.izhnet.ru	f83cc8e6db	Bug#23924 general_log truncates queries with character set introducers. Problem: logging of utf8-incompatible binary strings didn't work Fix: hex-encoding of incompatible sequences.	18 years ago
kent@mysql.com/kent-amd64.(none)	226a5c833f	Many files: Changed header to GPL version 2 only	19 years ago
monty@mysql.com/narttu.mysql.fi	88dd873de0	Fixed compiler warnings detected by option -Wshadow and -Wunused: - Removed not used variables and functions - Added #ifdef around code that is not used - Renamed variables and functions to avoid conflicts - Removed some not used arguments Fixed some class/struct warnings in ndb Added define IS_LONGDATA() to simplify code in libmysql.c I did run gcov on the changes and added 'purecov' comments on almost all lines that was not just variable name changes	19 years ago
gkodinov/kgeorge@macbook.gmz	42cd956752	BUG#11927: Warnings shown for CAST( chr as signed) but not (chr + 0) When implicitly converting string fields to numbers the string-to-number conversion error was not sent to the client. Added code to send the conversion error as warning. We also need to prevent generation of warnings from the places where val_xxx() methods are called for the sole purpose of updating the Item::null_value flag. To achieve that a special function is added (and called) : update_null_value(). This function will set the no_errors flag and will call val_xxx(). The warning generation in Field_string::val_xxx() will use the flag when generating the conversion warnings.	19 years ago
bar@mysql.com/bar.intranet.mysql.r18.ru	0e3a1eece7	Bug#18908: ERROR 1406 (22001): Data too long for column :: using utf8 Problem: Too confusing error message when cannot convert between string and column character sets on INSERT and UPDATE. Fix: producing a better error message, instead of "Data too long" in such cases Additional changes: Adding "DROP TABLE IF EXISTS" into several tests to be safe against failures in previous tests.	19 years ago
cmiller@zippy.(none)	5039184e83	Bug#19006: 4.0 valgrind problems (in test func_str) On exactly-sized Strings, the String::c_ptr() function peeked beyond the end of the buffer, possibly into unititialized space to see whether the buffer was NUL-terminated. In a place that did peek improperly, we now use a c_ptr_safe() function, which doesn't peek where it shouldn't.	20 years ago
serg@serg.mylan	d00b56549c	String::set(double) and set(longlong) -> set_real() and set_int() fix Field::store(double) being used instead of store(longlong) NB: overloading functions is evil	20 years ago
serg@serg.mylan	99fd8f728b	cleanup String::set(integer)	20 years ago
anozdrin@mysql.com	c1113af15c	This is an implementation of two WL items: - WL#3158: IM: Instance configuration extensions; - WL#3159: IM: --bootstrap and --start-default-instance modes The following new statements have been added: - CREATE INSTANCE; - DROP INSTANCE; The behaviour of the following statements have been changed: - SET; - UNSET; - FLUSH INSTANCES; - SHOW INSTANCES; - SHOW INSTANCE OPTIONS;	20 years ago
jani@a193-229-222-105.elisa-laajakaista.fi	96f8db34a5	Netware specific changes.	20 years ago
bell@sanja.is.com.ua	806f9e24ff	Inefficient usage of String::append() fixed. Bad examples of usage of a string with its length fixed. The incorrect length in the trigger file configuration descriptor fixed (BUG#14090). A hook for unknown keys added to the parser to support old .TRG files.	20 years ago
bar@mysql.com	2df945d87b	Bug#8610: The ucs2_turkish_ci collation fails with upper('i') UPPER/LOWER now can return a string with different length. mi_test1.c: Adding new arguments. Many files: Changeing caseup/casedn to return a result with different length than argument. sql_string.h: Removing unused method, mysql_priv.h: Removing unused method	21 years ago
msvensson@neptunus.(none)	5b5565c30a	BUG#10241 cygwin port: invalid pragma interface directives - Introduce ifdefs so we can control when to use #pragma interface on cygwin	21 years ago
monty@mysql.com	a1ab786091	Cleanups during review of code Fixed newly introduced bug in rollup	21 years ago
bar@mysql.com	c6c887b990	# Bug#8785 Problem with nested concats and character set conversion of a string constant.	21 years ago
dlenev@brandersnatch.localdomain	a3c58bc964	Fixing failing -debug build. Since placement operator delete called only if exception was thrown in constructor and we don't use exceptions in MySQL, there is no sense to do anything in String::delete(void ptr_arg, MEM_ROOT mem_root).	21 years ago
konstantin@mysql.com	f7512e756f	Fix signatures of placement operator delete in places where placement delete is declared. As we don't use exceptions placement delete is never called and the fix only affects numerous warnings when compiling with MS Visual C++. For more info see http://www.gotw.ca/gotw/010.htm.	21 years ago
sergefp@mysql.com	38339e1c51	Fix for BUG#7716: in in_string::set() take into account that the value returned by item->val_str() may be a substring of the passed string. Disallow string=its_substring assignment in String::operator=().	21 years ago
serg@serg.mylan	f09429a4df	protection: TRASH in delete fixed a bug that it discovered	21 years ago
patg@patrick-galbraiths-computer.local	7df412160a	Needed for WL# 2094, MySQL Federated Storage Handler sql_string.h: simple string method to drop last character of a string (also decrements str_length)	21 years ago
bar@mysql.com	7577c8bfc9	A fix according to Monty's request: "uint *errors" is now a non-optional parameter in String:copy() and copy_and_convert().	21 years ago
bar@mysql.com	541883f9d8	Produce a "truncated" warning if a value cannot be converted into the column character set on INSERT/UPDATE.	21 years ago
monty@mysql.com	3afecef4df	Fix compiler warnings (detected by Intel's C++ compiler) Fixed checking of privilege handling in CREATE ... SELECT (Bug #6094)	21 years ago
serg@serg.mylan	3f2210c064	after merge fixes	22 years ago
ram@gw.mysql.r18.ru	74c64904c7	A fix (Bug #4878 : Service crashes on query execution)	22 years ago
bar@bar.intranet.mysql.r18.ru	d0c761e66b	sql_string.h: Not used code. , sql_string.cc: Not used code.	22 years ago
bar@bar.intranet.mysql.r18.ru	3f8996f88d	1. Some optimization when conversion is not needed. 2. One now must pass length argument into append(const char *str, uint length), length is not calculated internally anymore.	22 years ago
konstantin@mysql.com	f207b33a7b	Support for character set conversion in binary protocol: another go after Monty's review. - Item_param was rewritten. - it turns out that we can't convert string data to character set of connection on the fly, because they first should be written to the binary log. To support efficient conversion we need to rewrite prepared statements binlogging code first.	22 years ago
pem@mysql.comhem.se	52c820fbc5	Enforce standard declaration order in SPs. Added new test cases for this, and adjusted old tests accordingly, and new error codes and messages. Fixed bugs in some tests (bug2673 and use test). Added debug printing of instructions in SPs.	22 years ago
monty@mysql.com	8f093d0fb3	Portability fixes	22 years ago
monty@mashka.mysql.fi	afd8f38f4e	Optimized GIS functions	22 years ago
monty@mysql.com	f43093ec0e	After merge fixes Added more DBUG statements Ensure that we are comparing end space with BINARY strings Use 'any_db' instead of '' to mean any database. (For HANDLER command) Only strip ' ' when comparing CHAR, not other space-like characters (like \t)	22 years ago
monty@mysql.com	06432eac36	Added --compact to mysqlbinlog Fixed output from mysqlbinlog when using --skip-comments Fixed warnings from valgrind Fixed ref_length when used with HEAP tables More efficent need_conversion() Fixed error handling in UPDATE with not updateable tables Fixed bug in null handling in CAST to signed/unsigned	22 years ago
bar@bar.intranet.mysql.r18.ru	03d00c7da9	Further fixes for 2390: ucs2 alignment	22 years ago
bar@bar.intranet.mysql.r18.ru	f802ec0215	UCS-2 aligning 0xAA -> 0x00AA	22 years ago
bell@sanja.is.com.ua	c56e75e2c1	after review fix	22 years ago
gluh@gluh.mysql.r18.ru	5709ed20ab	SAPDB date/time finctions	23 years ago
monty@narttu.mysql.fi	23145cfed7	Added SQLSTATE to client/server protocol bmove_allign -> bmove_align Added OLAP function ROLLUP Split mysql_fix_privilege_tables to a script and a .sql data file Added new (MEMROOT*) functions to avoid calling current_thd() when creating some common objects. Added table_alias_charset, for easier --lower-case-table-name handling Better SQL_MODE handling (Setting complex options also sets sub options) New (faster) assembler string functions for x86	23 years ago
bar@bar.mysql.r18.ru	759214fa41	MY_CS_NONTEXT flag for sprintf() incompatible charsets (ucs2 if the only one now) Some default_charset_info were removed	23 years ago
monty@mashka.mysql.fi	6aa8929cf3	After merge fixes Added initialization of all important global variables	23 years ago
venu@myvenu.com	8eeecd9c86	Fix to support update + bianry logs with prepared statements (Dynamic query)	23 years ago
bar@bar.mysql.r18.ru	0137c812dc	SHOW CREATE TABLE didn't display field names in the proper charset	23 years ago

1 2

96 Commits (42282c10ce0e2c808d1818e77a6a72eadc3a560d)