mariadb

Tree: 42282c10ce

Author	SHA1	Message	Date
Mattias Jonsson	42282c10ce	Bug#13694811: THE OPTIMIZER WRONGLY USES THE FIRST INNODB PARTITION STATISTICS Problem was the fix for bug#11756867; It always used the first partitions, and stopped after it checked 10 [sub]partitions. (or until it found a partition which would contain a match). This results in bad statistics for tables where the first 10 partitions don't represent the majority of the data (like when the first 10 partitions only contained a few rows in total). The solution was to take statisics from the partitions containing the most rows instead: Added an array of partition ids which is sorted by number of records in descending order. this array is used in records_in_range to cover as many records as possible in as few calls as possible. Also changed the limit of how many partitions to use for the statistics from a static max of 10 partitions, into a dynamic model: Maximum number of partitions is now log2(total number of partitions) taken from the ordered array. It will continue calling partitions records_in_range until it has checked: (total rows in matching partitions) * (maximum number of partitions) / (number of used partitions) Also reverted the changes for ha_partition::scan_time() and ha_partition::estimate_rows_upper_bound() to before the fix of bug#11756867. Since they are not as slow as records_in_range.	14 years ago
Mattias Jonsson	1387f38969	Bug#56287: mysql5.1.50 crash when using Partition datetime in sub in query When having a sub query in partitioned innodb one could make the partitioning engine to search for a 'index_next_same' on a partition that had not been initialized. Problem was that the subselect function looks at table->status which was not set in the partitioning handler when it skipped scanning due to no matching partitions found. Fixed by setting table->status = STATUS_NOT_FOUND when there was no partitions to scan. (If there are partitions to scan, it will be set in the partitions handler.)	15 years ago
Mattias Jonsson	380c9d0dae	Bug#53806: Wrong estimates for range query in partitioned MyISAM table Bug#46754: 'rows' field doesn't reflect partition pruning Update of test results after fixing the above bugs. (fix in separate commit).	16 years ago
Alexey Botchkov	e1d54fc7a8	Bug#55146 Assertion `m_part_spec.start_part == m_part_spec.end_part' in index_read_idx_map As we check for the impossible partitions earlier, it's possible that we don't find any suitable partitions at all. So this assertion just has to be corrected for this case. per-file comments: mysql-test/r/partition_innodb.result Bug#55146 Assertion `m_part_spec.start_part == m_part_spec.end_part' in index_read_idx_map test result updated. mysql-test/t/partition_innodb.test Bug#55146 Assertion `m_part_spec.start_part == m_part_spec.end_part' in index_read_idx_map test case added. sql/ha_partition.cc Bug#55146 Assertion `m_part_spec.start_part == m_part_spec.end_part' in index_read_idx_map Assertion changed to '>=' as the prune_partition_set() in the get_partition_set() can do start_part= end_part+1 if no possible partitions were found.	16 years ago
MySQL Build Team	d37814c402	Backporting to 5.1.43sp1 patch	16 years ago
Mattias Jonsson	f83e302a13	Bug#51830: Incorrect partition pruning on range partition (regression) Problem was that partition pruning did not exclude the last partition if the range was beyond it (i.e. not using MAXVALUE) Fix was to not include the last partition if the partitioning function value was not within the partition range.	16 years ago
Mattias Jonsson	6e7539de29	Bug#50104: Partitioned table with just 1 partion works with fk There was no check for foreign keys when altering partitioned tables. Added check for FK when altering partitioned tables.	16 years ago
Mattias Jonsson	b1987bdcbf	Bug#47343: InnoDB fails to clean-up after lock wait timeout on REORGANIZE PARTITION There were several problems which lead to this this, all related to bad error handling. 1) There was several bugs preventing the ddl-log to be used for cleaning up created files on error. 2) The error handling after the copy partition rows did not close and unlock the tables, resulting in deletion of partitions which were in use, which lead InnoDB to put the partition to drop in a background queue.	16 years ago
Mikael Ronstrom	ea5d204370	Fix to ensure that all subpartitions gets deleted before renaming starts, BUG#47029	17 years ago
Sergey Vojtovich	f30480a695	BUG#46483 - drop table of partitioned table may leave extraneous file Online/fast ALTER TABLE of a partitioned table may leave temporary file in database directory. Fixed by removing unnecessary call to handler::ha_create_handler_files(), which was creating partitioning definition file.	17 years ago
Mattias Jonsson	a891c0e8f4	Bug#40595: Non-matching rows not released with READ-COMMITTED on tables with partitions Problem was that the handler function try_semi_consistent_read was not propagated to the innodb handler. Solution was to implement that function in the partitioning handler.	17 years ago
Mattias Jonsson	abd09620db	Bug#14326: No formatting of partitioning clause in SHOW CREATE TABLE output The partitioning clause is only a very long single line, which is very hard to interpret for a human. This patch breaks the partitioning syntax into one line for the partitioning type, and one line per partition/subpartition.	17 years ago
Mattias Jonsson	44630e09ee	Bug#37721: ORDER BY when WHERE contains non-partitioned index column There was actually two problems 1) when clustered pk, order by non pk index should also compare with pk as last resort to differ keys from each other 2) bug in the index search handling in ha_partition (was found when extending the test case Solution to 1 was to include the pk in key compare if clustered pk and search on other index. Solution for 2 was to remove the optimization from ordered scan to unordered scan if clustered pk.	17 years ago
tsmith@ramayana.hindu.god	54a492ecac	Apply innodb-5.1-ss2146 and innodb-5.1-ss2178 snapshots. Fixes: Bug #18942: DROP DATABASE does not drop an orphan FOREIGN KEY constraint Fix Bug#18942 by dropping all foreign key constraints at the end of DROP DATABASE. Usually, by then, there are no foreign constraints left because all of them are dropped when the relevant tables are dropped. This code is to ensure that any orphaned FKs are wiped too. Bug #29157: UPDATE, changed rows incorrect Return HA_ERR_RECORD_IS_THE_SAME from ha_innobase::update_row() if no columns were updated. Bug #32440: InnoDB free space info does not appear in SHOW TABLE STATUS or I_S Put information about the free space in a tablespace in INFORMATION_SCHEMA.TABLES.DATA_FREE. This information was previously available in INFORMATION_SCHEMA.TABLES.TABLE_COMMENT, but MySQL has removed it from there recently. The stored value is in kilobytes. This can be considered as a permanent workaround to http://bugs.mysql.com/32440. "Workaround" becasue that bug is about the data missing from TABLE_COMMENT and this is actually not solved.	18 years ago
mattiasj@client-10-129-10-137.upp.off.mysql.com	a6a9774849	Bug#31931 Partitions: unjustified 'mix of handlers' error message Problem was that the mix of handlers was not consistent between CREATE and ALTER changed so that it works like: - All partitions must use the same engine AND it must be the same as the table. - if one does NOT specify an engine on the table level then one must either NOT specify any engine on any partition/subpartition OR for ALL partitions/subpartitions Note: that after a table have been created, the storage engine is specified for all parts of the table (table/partition/subpartition) and so when using alter, one does not need to specify it (unless one wants to change the storage engine, then one have to specify it on the table level)	18 years ago
mattiasj@witty.ndb.mysql.com	c27d93c83a	Bug#32948: FKs allowed to reference partitioned table Problem: when alter to partitioned table, it does not see it as change of engine. Solution: If alter includes partitioning, check if it is possible to change engines (eg. is the table referenced by a FK)	18 years ago
holyfoot/hf@mysql.com/hfmain.(none)	bc08ff0421	test fixed	18 years ago
holyfoot/hf@mysql.com/hfmain.(none)	2b3947a6a5	'no innodb engine' test failure fixed	18 years ago
svoj@mysql.com/june.mysql.com	187b01a45f	BUG#30583 - Partition on DOUBLE key + INNODB + count() == crash Issuing SELECT COUNT() against partitioned InnoDB table may cause server crash. Fixed that not all required fields were included into read_set.	19 years ago
serg@janus.mylan	00479a441d	wl#2936 post-merge fixes	19 years ago
serg@sergbook.mysql.com	c53037af36	more wl#2936 fixes: removed implicit ha_thd() calls (too error-prone), fixed an assert crash	19 years ago
antony@ppcg5.local	dc24473cb2	WL#2936 "Server Variables for Plugins" Implement support for plugins to declare server variables. Demonstrate functionality by removing InnoDB specific code from sql/* New feature for HASH - HASH_UNIQUE flag New feature for DYNAMIC_ARRAY - initializer accepts preallocated ptr. Completed support for plugin reference counting.	19 years ago
sergefp@mysql.com	d61f9e2d89	BUG#26117 "index_merge sort-union over partitioned table crashes" Before the fix: ha_partition objects had ha_partition::m_part_info==NULL and that caused crash After: - The new ha_partition::clone() function makes the clones use parent's m_part_info value. - The parent ha_partition object remains responsible for deallocation of m_part_info.	19 years ago
malff/marcsql@weblab.(none)	2bd3c8fdcc	Bug#24392 (SHOW ENGINE MUTEX STATUS is a synonym for SHOW INNODB STATUS) Before this fix, the command SHOW ENGINE <name> STATUS would: - print a warning if the engine name is unknown, - proceed and implement the same behavior as SHOW ENGINE ALL STATUS, and list the status of all the storage engines registered. In particular, this behavior caused confusion about the command : SHOW ENGINE MUTEX STATUS, which as a side effect would print the status of the innodb engine when that engine is registered. Also, before this fix, every time an unknown engine name was substituted by the default engine (which happen unless SQL_MODE NO_ENGINE_SUBSTITUTION is set), a malformed warning was raised. For example, the command ALTER TABLE T1 ENGINE = X would print : Warnings: Error 1286 Unknown table engine 'X' With this fix: SHOW ENGINE <name> STATUS\|LOGS\|MUTEX always fails with an error when the engine <name> is unknown. For other commands, warnings about unknown engines are raised as: Warnings: Warning 1286 Unknown table engine 'X' In other words, engine substitution never affect the SHOW ENGINE command, since this would lead to very confusing results.	19 years ago
mikael/pappa@dator5.(none)	2b3a53e54e	Rearranged test cases, move InnoDB test cases to partition_innodb	20 years ago
mikael/pappa@dator5.(none)	e9ba287dc7	BUG#20852: Using update with full table scan causes mysqld to enter an eternal loop	20 years ago
bar@mysql.com	bfae7303d7	Bug#20086: Can't get data from key partitioned tables with VARCHAR key The problem appeared because the same values produced different hash during INSERT and SELECT for VARCHAR data type. Fix: VARCHAR required special treatment to avoid hashing of length bytes (leftmost one or two bytes) as well as trailing bytes beyond real length, which could contain garbage. Fix is done by introducing hash() - new method in the Field class.	20 years ago
mikael@c-870ae253.1238-1-64736c10.cust.bredbandsbolaget.se	1068ab153c	BUG#19310: Add partition using InnoDB crashes MySQL Server Added new test case	20 years ago
mikael@c-870ae253.1238-1-64736c10.cust.bredbandsbolaget.se	ee11e39fa1	BUG#19903: Add partition crashes Added new test cases	20 years ago
msvensson@shellback.(none)	d8d05f3142	Moving test that requires innodb to partition_innodb	20 years ago

29 Commits (42282c10ce0e2c808d1818e77a6a72eadc3a560d)