mariadb

Tree: 41e6a154ec

Author	SHA1	Message	Date
Marko Mäkelä	41e6a154ec	MDEV-14482 - Cache line contention on ut_rnd_interval() InnoDB RNG maintains global state, causing otherwise unnecessary bus traffic. Even worse, this is cross-mutex traffic. That is, different mutexes suffer from contention. Fixed delay of 4 was verified to give best throughput by OLTP update index and read-write benchmarks on Intel Broadwell (2/20/40) and ARM (1/46/46). This is a backport of `ce04790065` from MariaDB Server 10.3.	6 years ago
Marko Mäkelä	b1f2d3a8c8	MDEV-21256: Replace the 64-bit LCG with a 32-bit Galois LFSR We should not need anywhere near 32 bits of entropy, so we might just limit ourselves to a 32-bit random number generator. Also, it might be cheaper to use exclusive-or, bit shifting and conditional jumps, instead of multiplication and addition. We use relaxed atomic operations on the global random number generator state in order in an attempt to silence any warnings about race conditions. There is an obvious race condition between the load and store in ut_rnd_gen(), but we do not think that it matters much that the state of the random number generator could 'stutter'. This change seems makes the 'uncompress_ops' nondeterministic in innodb_zip.cmp_per_index after the restart. It looks like there is an inherent race condition in the test, because the table could be opened for InnoDB statistics recalculation already before innodb_cmp_per_index_enabled was set. We might end up having uncompress_ops anywhere between 0 and 9, or perhaps even more. Let us remove that part of the test.	6 years ago
Marko Mäkelä	d146e3dcfe	MDEV-21256: Simplify ut_rnd_interval() ut_rnd_interval(): Remove the first parameter, which was mostly passed as 0. Implement as a simple wrapper around ut_rnd_gen(). Trivially return 0 if the size of the interval is smaller than 2. ut_rnd_ulint_counter, ut_rnd_gen_next_ulint(), ut_rnd_gen_ulint(): Remove.	6 years ago
Marko Mäkelä	51fc8ab73e	MDEV-21256: Reduce the use of ut_rnd_gen_next_ulint() ut_rnd_set_seed(): Unused function; remove. ut_rnd_gen(): Renamed from page_cur_lcg_prng(). ut_rnd_current: The internal state of ut_rnd_gen(). page_cur_open_on_rnd_user_rec(): Replace linear search with page_rec_get_nth().	6 years ago
Eugene Kosov	4c0854f221	MDEV-21223 innodb_fts.sync_ddl fails in buildbot, server crashed in que_thr_step FreeState(): replace pointer to freed memory with NULL. This actually fixes a crash which is use-after-free as reported by ASAN DbugParse(): unconditionally lock mutex because we're touching shared init_settings.keywords	6 years ago
Oleksandr Byelkin	af650c76a6	MDEV-18460: Server crashed in strmake / tdc_create_key / THD::create_tmp_table_def_key When there is a WITH clause we postpone check for tables without database for later stages when tables in WITH will be defined. But we should not try to open such tables as temporary tables because temporary tables always belong to a some database.	6 years ago
Marko Mäkelä	425748f1b5	Cleanup: Replace a redundant statement with an assertion	6 years ago
Marko Mäkelä	292015d486	MDEV-21254 Remove unused keywords from the InnoDB SQL parser The InnoDB internal SQL parser, which is used for updating the InnoDB data dictionary tables (to be removed in MDEV-11655), persistent statistics (to be refactored in MDEV-15020) and fulltext indexes, implements some unused keywords and built-in functions: OUT BINARY BLOB INTEGER FLOAT SUM DISTINCT READ COMPACT BLOCK_SIZE TO_CHAR TO_NUMBER BINARY_TO_NUMBER REPLSTR SYSDATE PRINTF ASSERT RND RND_STR ROW_PRINTF UNSIGNED Also, procedures are never declared with parameters. Only one top-level procedure is declared and invoked at a time, and parameters are being passed via pars_info_t.	6 years ago
Jan Lindström	59e14b9684	MDEV-21189: Dropping partition with 'wsrep_OSU_method=RSU' and 'SESSION sql_log_bin = 0' cases the galera node to hang Found two bugs (1) have_committing_connections was missing mutex unlock on one exit case. As this function is called on a loop it caused mutex lock when we already owned the mutex. This could cause hang. (2) wsrep_RSU_begin did set up error code when partition to be dropped could not be MDL-locked because of concurrent operations but wrong error code was propagated to upper layer causing error to be ignored. This could have also caused the hang.	6 years ago
Alexey Botchkov	fd1979bc9a	MDEV-18463 Don't allow multiple table CONSTRAINTs with the same name. Add necessary checks.	6 years ago
Vladislav Vaintroub	6aa0fa3897	CONC-417 Windows clients using Schannel often encounter error SEC_E_INVALID_TOKEN reenable ssl_8k_key on Windows, which was affected by this bug	6 years ago
Vladislav Vaintroub	6484288cd2	CONC-447 ERROR 2026 (HY000): SSL connection error: Certificate signature check failed Enable CRL checking on Windows. Enable certificate verification testing in client testing.	6 years ago
Elena Stepanova	3cc0e0befb	List of unstable tests for 10.2.30 release	6 years ago
Jan Lindström	c9b9eb3315	MDEV-18497 : CTAS async replication from mariadb master crashes galera nodes (#1410 ) In MariaDB 10.2 master could have been configured so that there is extra annotate events. When we peak next event type for CTAS we need to skip annotate events.	6 years ago
Oleksandr Byelkin	f7d35ffc76	Galera test fix after merge.	6 years ago
Oleksandr Byelkin	ccc5e57730	vew CC v 3.1	6 years ago
Oleksandr Byelkin	425437b290	Merge remote-tracking branch 'connect/10.2' into 10.2	6 years ago
Oleksandr Byelkin	f8b5e147da	Merge branch '10.1' into 10.2	6 years ago
Oleksandr Byelkin	117c8146de	Merge branch '5.5' into 10.1	6 years ago
Eugene Kosov	543f22a2d0	check parameters of io_submit() and LinuxAIOHandler::reserve_slot() Ensure that pointer to a buffer which is used for both reads and writes is properly aligned. I've intentially put permanent check right before io_submit() call instead of the time of setting iocb date. I think that'll make check better. LinuxAIOHandler::resever_slot(): check arguments alignment in debug builds	6 years ago
Jan Lindström	88073dae79	MDEV-21198 : Galera test failure on galera_var_notify_cmd Add proper wsrep sync wait.	6 years ago
Marko Mäkelä	3ff8fb5141	InnoDB: Remove unused get_wkb_of_default_point() The function get_wkb_of_default_point() should never have been added, and the cleanup in commit `56ff6f1b0b` should have removed it. The unnecessary code was added in mysql/mysql-server@0a27b72171c4449f506ad4e93df8c29fead1ed72 and mostly disabled in mysql/mysql-server@8f11af7734509821b654f2c330dff5374c89073c. In MariaDB, the types DATA_POINT and DATA_VAR_POINT are never used. Instead, DATA_GEOMETRY continues to be used since 10.2.2, introduced by mysql/mysql-server@673bad7c7e17701b69e29d0fbc4e2d68c1a7b613 in MySQL 5.7.1.	6 years ago
Anel Husakovic	e3d3bbf598	Using `variables` instead of `values` in mysqld --help documentation would be more accurate	6 years ago
Faustin Lammler	d930422e9e	Fix the line break warning (groff/lintian). The lintian Debian tool is complaining about: 'W: mariadb-test: manpage-has-errors-from-man usr/share/man/man1/mysql-test-run.pl.1.gz 246: warning [p 2, 6.0i, div '3tbd1,1', 0.3i]: can't break line' See: https://salsa.debian.org/faust-guest/mariadb-10.3/-/jobs/431900 The following command permits to catch the problematic lines: $ groff -man -Tascii ./mysql-test-run.pl.1 \| less Closes #1419	6 years ago
Jan Lindström	c6ed37b88a	MDEV-21182: Galera test failure on MW-284 galera_2nodes.cnf did not contain wsrep_on=1 on correct places. Fixed restart options to use correct configuration.	6 years ago
Eugene Kosov	33cf4da183	cleanup: replace exit(1) with abort()	6 years ago
Eugene Kosov	6fe2aae3ce	InnoDB: log unsuccessful calls to pthread_attr_init() and pthread_create() before crash	6 years ago
HF	3fb0fe400c	MENT-510 Failing test(s): perfschema.threads_insert_delayed. orig_test_id should be set properly. Also fixed sporadic test failure.	6 years ago
Anel Husakovic	3cb60ec2c3	Update `stracer` description in `mtr`. `strace-client` is not used	6 years ago
Daniel Black	866e5c250e	MDEV-15503: mtr fix --strace $glob_mysql_test_dir was the wrong directory for strace output as it was for in-tree builds only so failed for: * out of tree builds * --parallel; and * --mem strace output wasn't saved. strace-option never replaced existing arguments (so ammended documentation). strace-client didn't accept an argument as described. Replaced specification of client with this with 'stracer' to be consistent with --debugger option. For consistency with debugger options, --client-strace was added to execute the strace on the mysqltest. Example: Running one test $ ./mtr --strace --client-strace funcs_1.is_table_constraints Logging: ./mtr --strace --client-strace funcs_1.is_table_constraints vardir: /home/anel/mariadb/5.5/mysql-test/var Checking leftover processes... Removing old var directory... - WARNING: Using the 'mysql-test/var' symlink Creating var directory '/home/anel/mariadb/5.5/mysql-test/var'... Checking supported features... MariaDB Version 5.5.67-MariaDB-debug Installing system database... - SSL connections supported - binaries are debug compiled Collecting tests... ============================================================================== TEST RESULT TIME (ms) or COMMENT -------------------------------------------------------------------------- worker[1] Using MTR_BUILD_THREAD 300, with reserved ports 16000..16019 funcs_1.is_table_constraints [ pass ] 1270 -------------------------------------------------------------------------- The servers were restarted 0 times Spent 1.270 of 3 seconds executing testcases Completed: All 1 tests were successful $ find -L . -name \strace -ls 653 56 -rw-r--r-- 1 anel anel 57147 Nov 29 15:08 ./var/log/mysqltest.strace 646 1768 -rw-r--r-- 1 anel anel 1809855 Nov 29 15:08 ./var/log/mysqld.1.strace Example: Running test in parallel $ mysql-test/mtr --strace --client-strace --mem --parallel=3 main.select Logging: /home/dan/software_projects/mariadb-server/mysql-test/mysql-test-run.pl --strace --client-strace --mem --parallel=3 main.select vardir: /home/dan/software_projects/build-mariadb-10.3/mysql-test/var Checking leftover processes... Removing old var directory... Creating var directory '/home/dan/software_projects/build-mariadb-10.3/mysql-test/var'... - symlinking 'var' to '/dev/shm/var_auto_0v2E' Checking supported features... MariaDB Version 5.5.67-MariaDB - SSL connections supported Collecting tests... Installing system database... ============================================================================== TEST WORKER RESULT TIME (ms) or COMMENT -------------------------------------------------------------------------- worker[1] Using MTR_BUILD_THREAD 300, with reserved ports 16000..16019 worker[3] - 'localhost:16040' was not free worker[2] Using MTR_BUILD_THREAD 301, with reserved ports 16020..16039 worker[3] Using MTR_BUILD_THREAD 303, with reserved ports 16060..16079 main.select w1 [ pass ] 7310 -------------------------------------------------------------------------- The servers were restarted 0 times Spent 7.310 of 11 seconds executing testcases Completed: All 1 tests were successful. $ find mysql-test/var/ -name \strace -ls 5213766 1212 -rw-r--r-- 1 dan dan 1237817 May 20 16:47 mysql-test/var/1/log/mysqltest.strace 5214733 13016 -rw-r--r-- 1 dan dan 13328335 May 20 16:47 mysql-test/var/1/log/mysqld.1.strace $ mysql-test/mtr --strace --client-strace --strace-option='-e' --strace-option='trace=openat' --mem --parallel=3 main.select ... $ find mysql-test/var/ -name \*strace -ls 5220790 8 -rw-r--r-- 1 dan dan 6291 May 20 17:02 mysql-test/var/3/log/mysqltest.strace 5224140 308 -rw-r--r-- 1 dan dan 314356 May 20 17:02 mysql-test/var/3/log/mysqld.1.strace $ more mysql-test/var/3/mysqltest.strace 1692 openat(AT_FDCWD, "/home/dan/software_projects/mariadb-server/libmysql/.libs/tls/x86_64/x86_64/libpthread.so.0", O_RDONLY\|O_CLOEXEC) = -1 ENOENT (No such file or directory) 1692 openat(AT_FDCWD, "/home/dan/software_projects/mariadb-server/libmysql/.libs/tls/x86_64/libpthread.so.0", O_RDONLY\|O_CLOEXEC) = -1 ENOE NT (No such file or directory) Closes #600	8 years ago
Vlad Lesin	bd11bd63cc	MDEV-18310: Aria engine: Undo phase failed with "Got error 121 when executing undo undo_key_delete" upon startup on datadir restored from incremental backup aria_log* files were not copied on --prepare --incremental-dir step from incremental to destination backup directory.	6 years ago
Vladislav Vaintroub	32ce5301a9	Update libmariadb	6 years ago
Eugene Kosov	2855edf9ee	try to fix data races in DBUG init_settings.keywords and it's pointee are shared data. Protect them with mutex too.	6 years ago
Alexey Botchkov	bfa6db38cd	MENT-510 Failing test(s): perfschema.threads_insert_delayed. The thread_id of the INSERT DELAYED thread should not be set to 0.	6 years ago
Alexey Botchkov	0e403db2c8	MENT-237 Audit to show INSERT DELAYED for the executing user. Add notifications about the user and connection that actually did the DELAYED insert.	6 years ago
Vicențiu Ciorbaru	6218bf1b41	cracklib-runtime needs a comma after to parse properly	6 years ago
Olivier Bertrand	f0da39be7f	- Fix MDEV-13782 Problem with NOT LIKE queries. modified: storage/connect/ha_connect.cc modified: sql/item_cmpfunc.h - Fix MDEV-21084 Misusage of strncat could cause buffer overflow. modified: storage/connect/reldef.cpp modified: storage/connect/tabcmg.cpp modified: storage/connect/tabjson.cpp modified: storage/connect/tabrest.cpp modified: storage/connect/tabxml.cpp	6 years ago
Vicențiu Ciorbaru	427eedd012	MDEV-13288: Proper fix for cracklib-runtime The required dependencies should be added through the autobake script, to also cover distributions that do not support libcrack2.	6 years ago
Eugene Kosov	49ed1ae320	fix double io_destroy() + cleanup	6 years ago
Marko Mäkelä	a8395853cc	MDEV-21152 Bogus debug assertion btr_pcur_is_after_last_in_tree() in ibuf code As noted in commit `abd45cdc38` a search with PAGE_CUR_GE may land on the supremum record on a leaf page that is not the rightmost leaf page. This could occur when all keys on the current page are smaller than the search key, and the smallest key on the successor page is larger than the search key. Hence, after a failed PAGE_CUR_GE search, assertions btr_pcur_is_after_last_in_tree() are bogus and should be replaced with btr_pcur_is_after_last_on_page().	6 years ago
Vicențiu Ciorbaru	ed2379f983	MDEV-13288: Upstream debian patch	6 years ago
Seth Shelnutt	23664bc7a5	Fix incorrect DBUG_ENTER message for join_read_last	6 years ago
seppo	38839854b7	MDEV-19572 async slave node fails to apply MyISAM only writes (#1418 ) The problem happens when MariaDB master replicates writes for only non InnoDB tables (e.g. writes to MyISAM table(s)). Async slave node, in Galera cluster, can apply these writes successfully, but it will, in the end, write gtid position in mysql.gtid_slave_pos table. mysql.gtid_slave_pos table is InnoDB engine, and this write makes innodb handlerton part of the replicated "transaction". Note that wsrep patch identifies that write to gtid_slave_pos should not be replicated and skips appending wsrep keys for these writes. However, as InnoDB was present in the transaction, and there are replication events (for MyISAM table) in transaction cache, but there are no appended keys, wsrep raises an error, and this makes the söave thread to stop. The fix is simply to not treat it as an error if async slave tries to replicate a write set with binlog events, but no keys. We just skip wsrep replication and return successfully. This commit contains also a mtr test which forces mysql.gtid_slave_pos table isto be of InnoDB engine, and executes MyISAM only write through asyn replication. There is additional fix for declaring IO and background slave threads as non wsrep. These threads should not write anything for wsrep replication, and this is just a safeguard to make sure nothing leaks into cluster from these slave threads.	6 years ago
willhan	3551cd32a8	MDEV-17508 Fix bug for spider when using "not like" fix bug for spider where using "not like" (#890) test case: t1 is a spider engine table; CREATE TABLE `t1` ( `id` int(11) NOT NULL DEFAULT '0', `name` char(64) DEFAULT NULL, PRIMARY KEY (`id`) ) ENGINE=SPIDER query: "select * from t1 where name not like 'x%' " would dispatch "select xxx name name like 'x%' " to remote mysqld, is wrong	7 years ago
Olivier Bertrand	fb91774e4e	These changed were made after pulling 10.2.30 from origin --------------------------------------------------------- - Temporarily fix MDEV-13782 by commenting out LIKE_FUNC in CondFilter modified: storage/connect/ha_connect.cc - Remove use of hack tables modified: storage/connect/connect.cc modified: storage/connect/connect.h modified: storage/connect/ha_connect.cc modified: storage/connect/xtable.h	6 years ago
Hashir Sarwar	d8ace23d26	Fixed some typos in mysql.cc Closes #1403	6 years ago
Olivier Bertrand	b4bfa12b00	Fix compile error (missing declaration) in tabrest.cpp	6 years ago
Olivier Bertrand	420789512f	Fix compile error (missing declaration) in tabrest.cpp	6 years ago
Olivier Bertrand	7a9eca1191	Fix compile error (imcomplete switch) in ha_connect.cc	6 years ago
Olivier Bertrand	3ad054170c	These changed were made after pulling 10.2.30 from origin --------------------------------------------------------- - Temporarily fix MDEV-13782 by commenting out LIKE_FUNC i, CondFilter modified: storage/connect/ha_connect.cc - Make Rest available for MariaDB binary distributed versions. modified: storage/connect/CMakeLists.txt - Remove unused declaration modified: storage/connect/filter.h	6 years ago

1 2 3 4 5 ...

182953 Commits (41e6a154ece1c7d49becac0ccaa72f507686d298) All Branches Search

182953 Commits (41e6a154ece1c7d49becac0ccaa72f507686d298)

All Branches