mariadb

Tree: 4102f1589c

Author	SHA1	Message	Date
Monty	4102f1589c	Aria will now register it's transactions MDEV-22531 Remove maria::implicit_commit() MDEV-22607 Assertion `ha_info->ht() != binlog_hton' failed in MYSQL_BIN_LOG::unlog_xa_prepare From the handler point of view, Aria now looks like a transactional engine. One effect of this is that we don't need to call maria::implicit_commit() anymore. This change also forces the server to call trans_commit_stmt() after doing any read or writes to system tables. This work will also make it easier to later allow users to have system tables in other engines than Aria. To handle the case that Aria doesn't support rollback, a new handlerton flag, HTON_NO_ROLLBACK, was added to engines that has transactions without rollback (for the moment only binlog and Aria). Other things - Moved freeing of MARIA_SHARE to a separate function as the MARIA_SHARE can be still part of a transaction even if the table has closed. - Changed Aria checkpoint to use the new MARIA_SHARE free function. This fixes a possible memory leak when using S3 tables - Changed testing of binlog_hton to instead test for HTON_NO_ROLLBACK - Removed checking of has_transaction_manager() in handler.cc as we can assume that as the transaction was started by the engine, it does support transactions. - Added new class 'start_new_trans' that can be used to start indepdendent sub transactions, for example while reading mysql.proc, using help or status tables etc. - open_system_tables...() and open_proc_table_for_Read() doesn't anymore take a Open_tables_backup list. This is now handled by 'start_new_trans'. - Split thd::has_transactions() to thd::has_transactions() and thd::has_transactions_and_rollback() - Added handlerton code to free cached transactions objects. Needed by InnoDB. squash! `2ed35999f2`	6 years ago
Monty	d1d472646d	Change THD->transaction to a pointer to enable multiple transactions All changes (except one) is of type thd->transaction. -> thd->transaction-> thd->transaction points by default to 'thd->default_transaction' This allows us to 'easily' have multiple active transactions for a THD object, like when reading data from the mysql.proc table	6 years ago
Sergei Golubchik	937dfb74cb	MDEV-22424 Server crashes in handler::check_duplicate_long_entry_key or Assertion `inited == NONE \|\| lookup_handler != this' failed upon DELETE FOR PORTION on table with long unique key even if we're allowed to convert DELETE .. FOR PERIOD OF into an update internally, doesn't think we'll be able to. We always have to prepare for insert.	6 years ago
Monty	e3130d22e1	Fixed some assert crashes related to keyread. - MDEV-22062 Assertion `!table->file->keyread_enabled()' failed in close_thread_table() - MDEV-22077 table->no_keyread .. failed in join_read_first() - MDEV-22237 Assertion `!table->file->keyread_enabled()' failed in handler::ha_reset on DELETE	6 years ago
Sergei Golubchik	fcd84da5f1	MDEV-22218 InnoDB: Failing assertion: node->pcur->rel_pos == BTR_PCUR_ON upon LOAD DATA with NO_BACKSLASH_ESCAPES in SQL_MODE and unique blob in table `inited == NONE` at the initialization time does not always mean that it'll be `NONE` later, at the execution time. Use a more complex caller-specific logic to decide whether to create a cloned lookup handler. Besides LOAD (as in the original bug report) make sure that all prepare_for_insert() invocations are covered by tests. Add tests for CREATE ... SELECT, multi-UPDATE, and multi-DELETE. Don't enable write cache with long uniques.	6 years ago
Sergei Golubchik	0515577d12	cleanup: prepare "update_handler" for WITHOUT OVERLAPS * rename to a generic name * move remaning initializations from query exec to prepare time * simplify/unify key handling in open_table_from_share and delayed * remove dead code * move tests where they belong	6 years ago
Monty	4ef437558a	Improve update handler (long unique keys on blobs) MDEV-21606 Improve update handler (long unique keys on blobs) MDEV-21470 MyISAM and Aria start_bulk_insert doesn't work with long unique MDEV-21606 Bug fix for previous version of this code MDEV-21819 2 Assertion `inited == NONE \|\| update_handler != this' - Move update_handler from TABLE to handler - Move out initialization of update handler from ha_write_row() to prepare_for_insert() - Fixed that INSERT DELAYED works with update handler - Give an error if using long unique with an autoincrement column - Added handler function to check if table has long unique hash indexes - Disable write cache in MyISAM and Aria when using update_handler as if cache is used, the row will not be inserted until end of statement and update_handler would not find conflicting rows. - Removed not used handler argument from check_duplicate_long_entries_update() - Syntax cleanups - Indentation fixes - Don't use single character indentifiers for arguments	6 years ago
Alexander Barkov	a1e330de5a	MDEV-21743 Split up SUPER privilege to smaller privileges	6 years ago
Aleksey Midenkov	cef2b34f25	MDEV-18929 2nd execution of SP does not detect ER_VERS_NOT_VERSIONED Wrong assertion condition. SYSTEM_TIME_ALL indicates that vers_setup_conds() is done. In case FOR SYSTEM_TIME ALL is specified in command the assertion passes but not checks anything.	6 years ago
Aleksey Midenkov	33f55789d3	MDEV-18727 improve DML operation of System Versioning (10.4) UPDATE, DELETE: replace linear search of current/historical records with vers_setup_conds(). Additional DML cases in view.test	6 years ago
Aleksey Midenkov	bf58ec77a1	MDEV-18727 cleanup	6 years ago
Aleksey Midenkov	0076dce2c8	MDEV-18727 improve DML operation of System Versioning MDEV-18957 UPDATE with LIMIT clause is wrong for versioned partitioned tables UPDATE, DELETE: replace linear search of current/historical records with vers_setup_conds(). Additional DML cases in view.test	6 years ago
Sergei Petrunia	68ed3a81f2	MDEV-20854: ANALYZE for statements: not clear where the time is spent Count the "gap" time between table accesses and display it as r_other_time_ms in the "table" element. * The advantage of this approach is that it doesn't add any new my_timer_cycles() calls. * The disadvantage is that the definition of what is done during "other time" is not that clear: it includes checking the WHERE (for this table), constructing index lookup tuple (for the next table) writing to GROUP BY temporary table (as we dont account for that time separately [yet], etc)	6 years ago
Monty	b62101f84b	Fixes for binary logging --read-only mode - Any temporary tables created under read-only mode will never be logged to binary log. Any usage of these tables to update normal tables, even after read-only has been disabled, will use row base logging (as the temporary table will not be on the slave). - Analyze, check and repair table will not be logged in read-only mode. Other things: - Removed not used varaibles in MYSQL_BIN_LOG::flush_and_set_pending_rows_event. - Set table_share->table_creation_was_logged for all normal tables. - THD::binlog_query() now returns -1 if statement was not logged., This is used to update table_share->table_creation_was_logged. - Don't log admin statements in opt_readonly is set. - Table's that doesn't have table_creation_was_logged will set binlog format to row logging. - Removed not needed/wrong setting of table->s->table_creation_was_logged in create_table_from_items()	6 years ago
Rucha Deodhar	837ad9ab97	MDEV-10014 Add RETURNING to INSERT Closes #1384	7 years ago
Sergei Golubchik	57a09a72a3	cleanup st_select_lex_unit::explainable	6 years ago
Sergei Golubchik	721a9df751	cleanup: formatting comments, whitespaces	6 years ago
Sergei Golubchik	a4a025f5d1	cleanup: don't pass wild_num to setup_wild() because internally setup_wild() adjusts select_lex->with_wild directly anyway, so there is no reason to pretend that the number of '*' may be anything else but select_lex->with_wild And don't update select_lex->item_list, because fields can come from anywhere and don't necessarily have to be copied into select_lex.	6 years ago
Oleksandr Byelkin	1ae02f0e0d	MDEV-18553: MDEV-16327 pre-requisits part 2: uniform of LIMIT/OFFSET handling Now both offset and limit are stored and do not chenged during execution (offset is decreased during processing in versions before 10.5). (Big part of this changes made by Monty)	6 years ago
Aleksey Midenkov	f6d0d309fa	MDEV-19814 Assertion `update->n_fields < ulint(table->n_cols + table->n_v_cols)' on DELETE HISTORY Turn off versioned_write for DELETE HISTORY.	7 years ago
Aleksey Midenkov	1a73444d57	Cleanups: DELETE HISTORY [MDEV-19814] * Made make_versioned_() proxies inline; Renamed truncate_history to delete_history Part of: MDEV-19814 Server crash in row_upd_del_mark_clust_rec or Assertion `update->n_fields < ulint(table->n_cols + table->n_v_cols)' failed in upd_node_t::make_versioned_helper	7 years ago
Nisha Gopalakrishnan	2536c0b1eb	BUG#28642318: POINT IN TIME RECOVERY USING MYSQLBINLOG BROKEN WITH TEMPORARY TABLE -> ERRORS Analysis ======== Point in time recovery using mysqlbinlog containing queries operating on temporary tables results in an error. While writing the query log event in the binary log, the thread id used for execution of DROP TABLE and DELETE commands were incorrect. The thread variable 'thread_specific_used' is used to determine whether a specific thread id is to used while executing the statements i.e using 'SET @@session.pseudo_thread_id'. This variable was not set correctly for DROP TABLE query and was never set for DELETE query. The thread id is important for temporary tables since the tables are session specific. DROP TABLE and DELETE queries executed using a wrong thread id resulted in errors while applying the queries generated by mysqlbinlog utility. Fix === Set the 'thread_specific_used' THD variable for DROP TABLE and DELETE queries. ReviewBoard: 21833	7 years ago
Sergei Golubchik	43623f04a9	MDEV-15458 Segfault in heap_scan() upon UPDATE after ADD SYSTEM VERSIONING handler::write_row() should not destroy the state of the running index_search/index_next/... or rnd_init/rnd_next/... scan	7 years ago
Vicențiu Ciorbaru	5543b75550	Update FSF Address * Update wrong zip-code	7 years ago
Nikita Malyavin	7e3e2d060b	MDEV-18859 Server crashes in bitmap_bits_set / pack_row / THD::binlog_write_row upon DELETE .. FOR PORTION with binary logging rpl_write_set is initialized in TABLE::mark_columns_per_binlog_row_image. Since we just call use_all_columns for PORTION OF case, no need in column marking logic here. Instead, initialize table->rpl_write_set in place.	7 years ago
Nikita Malyavin	04055060b6	MDEV-18852 MDEV-18853 fix `period.delete`, `period.update` tests crashes with ``--ps-protocol` The main problem was lack of proper QueryArena handling in `period_setup_conds`. Since mysql_prepare_update/mysql_prepare_delete are called during `PREPARE` statement, period conditions, should be allocated on statement query arena. Another problem is incorrect statement state handling in period_setup_conds, which led to unexpected mysql_update termination. * mysql_update: move period_setup_conds() to mysql_prepare_update to store conditions in statement's mem_root * mtr: add period suite to default list, since --ps-protocol is now fixed Fixes bugs: MDEV-18853 Assertion `0' failed in Protocol::end_statement upon DELETE .. FOR PORTION via prepared statement MDEV-18852 Server crashes in reinit_stmt_before_use upon UPDATE .. FOR PORTION via prepared statement	7 years ago
Marko Mäkelä	482710b20c	Remove an unused variable	7 years ago
Alexander Barkov	0ad598a00b	A cleanup in derived table handling: removing duplicate code from st_select_lex::handle_derived() st_select_lex::handle_derived() and mysql_handle_list_of_derived() had exactly the same implementations. - Adding a new method LEX::handle_list_of_derived() instead - Removing public function mysql_handle_list_of_derived() - Reusing LEX::handle_list_of_derived() in st_select_lex::handle_derived()	7 years ago
Nikita Malyavin	b2bd52290a	MDEV-16974 Application-time periods: UPDATE	7 years ago
Nikita Malyavin	47e28a94d5	MDEV-16973 Application-time periods: DELETE * inject portion of time updates into mysql_delete main loop * triggered case emits delete+insert, no updates * PORTION OF `SYSTEM_TIME` is forbidden * `DELETE HISTORY .. FOR PORTION OF ...` is forbidden as well	7 years ago
Michael Widenius	9990027f87	Fixed compiler warnings from optimized builds	7 years ago
Oleksandr Byelkin	54b2e1c1be	MDEV-16697: Fix difference between 32bit/windows and 64bit systems in allowed select nest level	8 years ago
Eugene Kosov	e43bc02e7b	MDEV-16741 Assertion `m_extra_cache' failed in ha_partition::late_extra_cache multi_delete sets TABLE::no_cache=1 and should set it to 0 when DELETE is done.	8 years ago
Nikita Malyavin	db3be33ec8	MDEV-16783 Assertion `!conds' failed in mysql_delete upon 2nd execution of SP with DELETE HISTORY * remove assertion * do not setup `conds` if it's already cached Fixes #823	8 years ago
Oleksandr Byelkin	de745ecf29	MDEV-11953: support of brackets in UNION/EXCEPT/INTERSECT operations	8 years ago
Sergei Golubchik	c9061d1102	mysys: rename ME_xxx flags to match plugin api	8 years ago
Eugene Kosov	aa5683d12e	MDEV-15380 Index for versioned table gets corrupt after partitioning and DELETE In a test case Update occurs between Search and Delete/Update. This corrupts rowid which Search saves for Delete/Update. Patch prevents this by using of HA_EXTRA_REMEMBER_POS and HA_EXTRA_RESTORE_POS in a partition code. This situation possibly occurs only with system versioning table and partition. MyISAM and Aria engines are affected. fix by midenok Closes #705	8 years ago
Aleksey Midenkov	21eccff625	MDEV-15979 DELETE HISTORY from a table with transaction-precise versioning causes Assertion `table_list->vers_conditions.type == SYSTEM_TIME_BEFORE' failure * Fix versioning.truncate,trx_id to create transaction-based tables * Fix SYSTEM_TIME_BEFORE condition for VERS_TRX_ID	8 years ago
Monty	ef295c31e3	MDEV-11129 CREATE OR REPLACE TABLE t1 AS SELECT spfunc() crashes if spfunc() references t1 Fixed by extending unique_table() with a flag to not allow usage of the replaced table. I also cleaned up find_dup_table() to not use goto next. I also added more comments to the code in find_dup_table()	8 years ago
Varun Gupta	6f4534e622	MDEV-14695: Assertion `n < m_size' failed in Bounds_checked_array<Element_type>::operator In this issue we hit the assert because we are adding addition fields to the field JOIN::all_fields list. This is done because HEAP tables can't index BIT fields so we need to use an additional hidden field for grouping because later it will be converted to a LONG field. Original field will remain of the BIT type and will be returned. This happens when we convert DISTINCT to GROUP BY. The solution is to take into account the number of such hidden fields that would be added to the field JOIN::all_fields list while calculating the size of the ref_pointer_array.	8 years ago
Sergei Golubchik	b1a6d2826a	cleanup: versioning style fixes rename LString/XString classes, remove unused ones	8 years ago
Sergei Golubchik	0f956a0676	cleanup: hide HA_ERR_RECORD_DELETED in ha_rnd_next() it's internal storage engine error, don't let it leak into the upper layer.	8 years ago
Monty	30ebc3ee9e	Add likely/unlikely to speed up execution Added to: - if (error) - Lex - sql_yacc.yy and sql_yacc_ora.yy - In header files to alloc() calls - Added thd argument to thd_net_is_killed()	8 years ago
Sergei Golubchik	a4251d6f18	MDEV-15391 Server crashes in JOIN::fix_all_splittings_in_plan or Assertion `join->best_read < double(1.79...e+308L)' failed vers_setup_conds() used to AND all conditions on row_start/row_end columns and store it either in the WHERE clause or in the ON clause for some table. In some cases this caused ON clause to have conditions for tables that aren't part of that ON's join. Fixed to put a table's condition always in the ON clause of the corresponding table. Removed unnecessary ... `OR row_end IS NULL` clause, it's not needed in the ON clause. Simplified handling on PS and SP.	8 years ago
Sergei Golubchik	794f71cbc4	create a reusable function that tells what FK actions can write and few indentation changes	8 years ago
Sergei Golubchik	17f8e0ecdf	unify error messages a bit	8 years ago
Sergei Golubchik	9f6a7ed2d7	SQL: Truncate history of partitioned table [fixes #399 , closes #403 ] also, don't rotate versioning partitions for DELETE HISTORY originally by: Aleksey Midenkov	8 years ago
Monty	a7e352b54d	Changed database, tablename and alias to be LEX_CSTRING This was done in, among other things: - thd->db and thd->db_length - TABLE_LIST tablename, db, alias and schema_name - Audit plugin database name - lex->db - All db and table names in Alter_table_ctx - st_select_lex db Other things: - Changed a lot of functions to take const LEX_CSTRING* as argument for db, table_name and alias. See init_one_table() as an example. - Changed some function arguments from LEX_CSTRING to const LEX_CSTRING - Changed some lists from LEX_STRING to LEX_CSTRING - threads_mysql.result changed because process list_db wasn't always correctly updated - New append_identifier() function that takes LEX_CSTRING* as arguments - Added new element tmp_buff to Alter_table_ctx to separate temp name handling from temporary space - Ensure we store the length after my_casedn_str() of table/db names - Removed not used version of rename_table_in_stat_tables() - Changed Natural_join_column::table_name and db_name() to never return NULL (used for print) - thd->get_db() now returns db as a printable string (thd->db.str or "")	8 years ago
Sergei Golubchik	826f615fc9	MDEV-14788 System versioning cannot be based on local timestamps, as it is now followup to `be81b00c84` Fix updates and deletes too	8 years ago
Sergei Golubchik	b85efdc3af	rename system_time columns sys_trx_start -> row_start sys_trx_end -> row_end	8 years ago

1 2 3 4 5 ...

882 Commits (4102f1589c23309de968a5bf9511d3228a1b9319)