mariadb

Tree: 3f641968fc

Author	SHA1	Message	Date
Sergey Vojtovich	3f641968fc	BUG#51866 - crash with repair by sort and fulltext keys Repairing MyISAM table with fulltext indexes and low myisam_sort_buffer_size may crash the server. Estimation of number of index entries was done incorrectly, causing further assertion failure or server crash. Docs note: min value for myisam_sort_buffer_size has been changed from 4 to 4096.	16 years ago
Sergey Vojtovich	9fbc44eb09	A follow-up to fix for BUG#47073 - valgrind errs, corruption,failed repair of partition, low myisam_sort_buffer_size Fixed race conditions discovered with the provided test case and stabilized test case.	16 years ago
Sergey Vojtovich	858713edd3	BUG#47073 - valgrind errs, corruption,failed repair of partition, low myisam_sort_buffer_size Repair by sort (default) or parallel repair of a MyISAM table (doesn't matter partitioned or not) as well as bulk inserts and enable indexes some times didn't failover to repair with key cache. The problem was that after unsuccessful attempt, data file was closed. Whereas repair with key cache requires open data file. Fixed by reopening data file. Also fixed a valgrind warning, which may appear during repair by sort or parallel repair with certain myisam_sort_buffer_size number of rows and length of an index entry (very dependent).	16 years ago
Georgi Kodinov	da5d0c90a4	Fixed Sun Studio 8 compilation failures as suggested by Jorgen and reviewed by Svoj over e-mail.	16 years ago
Davi Arnaut	a0e44ec1e8	Fix for a few assorted compiler warnings.	16 years ago
Ramil Kalimullin	0151145310	Fix for bug #37756 : enabling fulltext indexes with myisam_repair_threads > 1 causes crash Problem: parallel repair (myisam_repair_threads > 1) of a myisam table with two or more fulltext keys that use the same parser may lead to a server crash. ALTER TABLE ENABLE KEYS is affected as well. Fix: properly initialize fulltext structures for parallel repair. Note: 1. there's no deterministic test case. 2. now we call parser->init() for each fulltext key (not for each fulltext parser used).	17 years ago
Ramil Kalimullin	5bafde319e	Fix for bug#37537: myisamchk fails with Assertion failure with partitioned table Problem: missed "break" in a switch leads to unexpected assertion failure of 'myisamchk compressed_table'. Fix: add the break.	18 years ago
Mattias Jonsson	07e9a6dc2a	Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that partition is corrupt The main problem was that ALTER TABLE t ANALYZE/CHECK/OPTIMIZE/REPAIR PARTITION took another code path (over mysql_alter_table instead of mysql_admin_table) which differs in two ways: 1) alter table opens the tables in a different way than admin tables do resulting in returning with error before it tried the command 2) alter table does not start to send any diagnostic rows to the client which the lower admin functions continue to use -> resulting in assertion crash The fix: Remapped ALTER TABLE t ANALYZE/CHECK/OPTIMIZE/REPAIR PARTITION to use the same code path as ANALYZE/CHECK/OPTIMIZE/REPAIR TABLE t. Adding check in mysql_admin_table to setup the partition list for which partitions that should be used. Partitioned tables will still not work with REPAIR TABLE/PARTITION USE_FRM, since that requires moving partitions to tables, REPAIR TABLE t USE_FRM, and check that the data still fulfills the partitioning function and then move the table back to being a partition. NOTE: I have removed the following functions from the handler interface: analyze_partitions, check_partitions, optimize_partitions, repair_partitions Since they are not longer needed. THIS ALTERS THE STORAGE ENGINE API	18 years ago
guilhem@gbichot4.local	9e2b31b026	Fix for server bug experienced in Maria (wrong "Truncated incorrect <var_name> value" error even though the value was correct): a C function in my_getopt.c was taking bool* in parameter and was called from C++ sql_plugin.cc, but on some Mac OS X sizeof(bool) is 1 in C and 4 in C++, giving funny mismatches. Fixed, all other occurences of bool in C are removed, future ones are blocked by a "C-bool-catcher" in my_global.h (use my_bool).	18 years ago
istruewing@stella.local	241cd5f969	Bug#4692 - DISABLE/ENABLE KEYS waste a space Fixed absurd compiler warnings of a Suse 10.1 system.	18 years ago
monty@mysql.com/narttu.mysql.fi	7887babe69	Moved a lot of old bug fixes and safe cleanups from Maria 5.1 tree to 5.1 - Reserver namespace and place in frm for TABLE_CHECKSUM and PAGE_CHECKSUM create options - Added syncing of directory when creating .frm files - Portability fixes - Added missing cast that could cause bugs - Code cleanups - Made some bit functions inline - Moved things out of myisam.h to my_handler.h to make them more accessable - Renamed some myisam variables and defines to make them more globaly usable (as they are used outside of MyISAM) - Fixed bugs in error conditions - Use compiler time asserts instead of run time - Fixed indentation HA_EXTRA_PREPARE_FOR_DELETE -> HA_EXTRA_PREPARE_FOR_DROP as the old name was wrong (Added a define for old value to ensure we don't break any old code) Added HA_EXTRA_PREPARE_FOR_RENAME as a signal for rename (before we used a DROP signal which is wrong) - Initialize error messages early to get better errors when mysqld or an engine fails to start - Fix windows bug that query_performance_frequency was not initialized if registry code failed - thread_stack -> my_thread_stack_size	18 years ago
monty@mysql.com/nosik.monty.fi	e53a73e26c	Fixed a lot of compiler warnings and errors detected by Forte C++ on Solaris Faster thr_alarm() Added 'Opened_files' status variable to track calls to my_open() Don't give warnings when running mysql_install_db Added option --source-install to mysql_install_db I had to do the following renames() as used polymorphism didn't work with Forte compiler on 64 bit systems index_read() -> index_read_map() index_read_idx() -> index_read_idx_map() index_read_last() -> index_read_last_map()	19 years ago
monty@mysql.com/narttu.mysql.fi	088e2395f1	WL#3817: Simplify string / memory area types and make things more consistent (first part) The following type conversions was done: - Changed byte to uchar - Changed gptr to uchar* - Change my_string to char * - Change my_size_t to size_t - Change size_s to size_t Removed declaration of byte, gptr, my_string, my_size_t and size_s. Following function parameter changes was done: - All string functions in mysys/strings was changed to use size_t instead of uint for string lengths. - All read()/write() functions changed to use size_t (including vio). - All protocoll functions changed to use size_t instead of uint - Functions that used a pointer to a string length was changed to use size_t* - Changed malloc(), free() and related functions from using gptr to use void * as this requires fewer casts in the code and is more in line with how the standard functions work. - Added extra length argument to dirname_part() to return the length of the created string. - Changed (at least) following functions to take uchar* as argument: - db_dump() - my_net_write() - net_write_command() - net_store_data() - DBUG_DUMP() - decimal2bin() & bin2decimal() - Changed my_compress() and my_uncompress() to use size_t. Changed one argument to my_uncompress() from a pointer to a value as we only return one value (makes function easier to use). - Changed type of 'pack_data' argument to packfrm() to avoid casts. - Changed in readfrm() and writefrom(), ha_discover and handler::discover() the type for argument 'frmdata' to uchar** to avoid casts. - Changed most Field functions to use uchar* instead of char* (reduced a lot of casts). - Changed field->val_xxx(xxx, new_ptr) to take const pointers. Other changes: - Removed a lot of not needed casts - Added a few new cast required by other changes - Added some cast to my_multi_malloc() arguments for safety (as string lengths needs to be uint, not size_t). - Fixed all calls to hash-get-key functions to use size_t. (Needed to be done explicitely as this conflict was often hided by casting the function to hash_get_key). - Changed some buffers to memory regions to uchar to avoid casts. - Changed some string lengths from uint to size_t. - Changed field->ptr to be uchar* instead of char*. This allowed us to get rid of a lot of casts. - Some changes from true -> TRUE, false -> FALSE, unsigned char -> uchar - Include zlib.h in some files as we needed declaration of crc32() - Changed MY_FILE_ERROR to be (size_t) -1. - Changed many variables to hold the result of my_read() / my_write() to be size_t. This was needed to properly detect errors (which are returned as (size_t) -1). - Removed some very old VMS code - Changed packfrm()/unpackfrm() to not be depending on uint size (portability fix) - Removed windows specific code to restore cursor position as this causes slowdown on windows and we should not mix read() and pread() calls anyway as this is not thread safe. Updated function comment to reflect this. Changed function that depended on original behavior of my_pwrite() to itself restore the cursor position (one such case). - Added some missing checking of return value of malloc(). - Changed definition of MOD_PAD_CHAR_TO_FULL_LENGTH to avoid 'long' overflow. - Changed type of table_def::m_size from my_size_t to ulong to reflect that m_size is the number of elements in the array, not a string/memory length. - Moved THD::max_row_length() to table.cc (as it's not depending on THD). Inlined max_row_length_blob() into this function. - More function comments - Fixed some compiler warnings when compiled without partitions. - Removed setting of LEX_STRING() arguments in declaration (portability fix). - Some trivial indentation/variable name changes. - Some trivial code simplifications: - Replaced some calls to alloc_root + memcpy to use strmake_root()/strdup_root(). - Changed some calls from memdup() to strmake() (Safety fix) - Simpler loops in client-simple.c	19 years ago
serg@janus.mylan	68fd66e853	wl#3700 - post-review fixes: s/ulonglong/key_part_map/, comments	19 years ago
serg@janus.mylan	a07fd5fa8f	WL#3700: Handler API change: all index search methods - that is, index_read(), index_read_idx(), index_read_last(), and records_in_range() - instead of 'uint keylen' argument take 'ulonglong keypart_map', a bitmap showing which keyparts are present in the key value. Fallback method is provided for handlers that are lagging behind.	19 years ago
gkodinov/kgeorge@macbook.local	23acc5b630	mi_check.c: added a missing DBUG_RETURN	19 years ago
serg@serg.mylan	c250645c6e	don't try to "estimate" a number of words that a plugin parser can produce	20 years ago
serg@serg.mylan	32711e7b00	Now ftparser does not need to bother about memory management - it can tell MySQL to make a copy of everything (bug#17123)	20 years ago
monty@mysql.com	343644dd5d	Added support for key_block_size for key and table level (WL#602) Added support for key_block_size to MyISAM. Simplify interface to 'new Key' to make it easier to add new key options. mysqld option --new is used to define where key options are printed. (In 5.3 we should move all key options to after key part definition to avoid problem with reserved names) Fixed some compiler warnings and a memory leak in ssl	20 years ago
brian@zim.(none)	cb07d52a7e	This patch cleans up two tests which were a bit fragile from other failing tests. It also removes some variables associated with removed RAID support.	20 years ago
brian@zim.(none)	2a7c71e309	Changes to create storage directory for storage engines.	21 years ago
serg@serg.mylan	0294339b9c	don't check record's checksum in REPAIR	21 years ago
hf@deer.(none)	27eff9f700	Fix for bug #7545 (Undefined symbols if --without-geometry)	21 years ago
monty@mysql.com	3fb088a075	Add 0x before pointers (to help with debugging) Add support for VARCHAR with 1 or 2 length bytes Enable VARCHAR packing in MyISAM files (previous patch didn't pack data properly) Give error if we got problems in temporary tables during a SELECT Don't use new table generated by ALTER TABLE if index generation fails Fixed wrong call by range_end() (Could cause an ASSERT in debug mode)	21 years ago
hf@deer.(none)	e211b26330	Fix for bug #6755 (ALTER TABLE ENABLE KEYS corrupts spatial index)	21 years ago
monty@mysql.com	67ce247965	Add support for up to VARCHAR (size up to 65535) Renamed HA_VAR_LENGTH to HA_VAR_LENGTH_PART Renamed in all files FIELD_TYPE_STRING and FIELD_TYPE_VAR_STRING to MYSQL_TYPE_STRING and MYSQL_TYPE_VAR_STRING to make it easy to catch all possible errors Added support for VARCHAR KEYS to heap Removed support for ISAM Now only long VARCHAR columns are changed to TEXT on demand (not CHAR) Internal temporary files can now use fixed length tables if the used VARCHAR columns are short	21 years ago
monty@mysql.com	e9c3887b58	After merge fixes	21 years ago
serg@serg.mylan	0be3c55594	mi_write: fix for ft2 when found word (in the tree) has different length as the word to insert	21 years ago
serg@serg.mylan	d2bfefc3c1	proper max_records estimation for sort-repair of fulltext indexes	21 years ago
sergefp@mysql.com	6e0ba8e615	Fix for BUG#4785: * myisampack leaves key_file_length value from original table * myisamchk uses this value when calculating key file pointer length	21 years ago
serg@serg.mylan	9b0468bc96	BUG#5327 - mi_sort_index() of 2-level tree	22 years ago
serg@serg.mylan	b60713c033	bug in my_strnncoll_utf8 (and friends) fixed cleanups better, charset-dependent, ft_max_len_for_sort value	22 years ago
monty@mysql.com	5b3c418b48	After merge fixes Note: The following tests fails - fulltext (Sergei has promised to fix) - rpl_charset (Guilhem should fix) - rpl_timezone (Dimitray has promised to fix) Sanja needs to check out the calling of close_thread_tables() in sp_head.cc	22 years ago
monty@mysql.com	fd0153304d	Fixed some byte order bugs with prepared statements on machines with high-byte-first. (Bug #4173 ) Fixed problem with NULL and derived tables (Bug #4097) Cleanup of new pushed code	22 years ago
serg@serg.mylan	9a9bde89ce	make CHECK killable	22 years ago
paul@kite-hub.kitebird.com	2f0ca1ce42	Fix skipp -> skip once and for all. (Note: This affects only comments, not variable names.)	22 years ago
serg@serg.mylan	41f4f0317f	bug in repair_by_sort of fulltext indexes that contained identical (as of mi_compare_text) words with different lengths. bug #3835	22 years ago
serg@serg.mylan	fced5fa188	cleanup of ha_myisam::deactivate_non_unique_index() and Co.	22 years ago
monty@mysql.com	ebc3b3afac	BTREE-indexes in HEAP tables can now be used to optimize ORDER BY Don't read character set files if we are using only the default charset. In most cases the user will not anymore get a warning about missing character set files Compare strings with space extend instead of space strip. Now the following comparisons holds: "a" == "a " and "a\t" < "a". (Bug #3152). Note: Because of the above fix, one has to do a REPAIR on any table that has an ascii character < 32 last in a CHAR/VARCHAR/TEXT columns.	22 years ago
hf@deer.(none)	1eccd27d83	Fix for #3067 Shouldn't be moved to 4.1	22 years ago
hf@deer.(none)	1b78e7dd41	Fix for #3067 (REPAIR TABLE reenables disabled keys)	22 years ago
paul@teton.kitebird.com	f71f714773	Fix typo.	22 years ago
hf@deer.(none)	9edef96561	Fix for #2237 and #2490 (analyze and check for RTree keys) Now checking of the RTree keys works without errors. Worklog entry about appropriate checkup's routine for the RTree added	22 years ago
vva@eagle.mysql.r18.ru	3f50b5204c	fixed bug #2762 "grammar error in myisam/mi_check.c"	22 years ago
serg@serg.mylan	4f845f4c12	two bugs in parallel repair fixed	22 years ago
serg@serg.mylan	f7d4410b57	checking 2nd level of FT index destroyed info->lastkey and CHECK TABLE erroneously treated table as corrupted bug#2190	22 years ago
monty@mysql.com	031390a9a4	Fixes after merge with 4.0 Cleaned up embedded library access and query cache handling Changed min stack size to 128K (to allow longer MyISAM keys) Fixed wrong priority for XOR (should be less than NEG to get -1^1 to work)	22 years ago
monty@mysql.com	56f0abf7bb	Portability fixes (mostly test suite) Make ENGINE= an alias for TYPE= (Compabiltiy with 4.1) Fix when using symlinked data files and realpath() is not working	22 years ago
monty@mysql.com	f995a5f4aa	Fix autoincrement for signed columns (Bug #1366 ) Fixed problem with char > 128 in QUOTE() function. (Bug #1868) Disable creation of symlinks if my_disable_symlink is set Fixed searching of TEXT with end space. (Bug #1651) Fixed caching bug in multi-table-update where same table was used twice. (Bug #1711) Fixed problem with UNIX_TIMESTAMP() for timestamps close to 0. (Bug #1998) Fixed timestamp.test	22 years ago
serg@serg.mylan	fddab846d4	chk_del() should not check key delete-chain make a test for -inf more portable (-Inf)	22 years ago

1 2

57 Commits (3f641968fc91950bf974a8dbfe0cd6d913cab75a)