mariadb

Tree: 3d8d672450

Author	SHA1	Message	Date
Jon Olav Hauglid	d1192eb8ee	Followup to Bug #11752069 (former bug 43152) Assertion `bitmap_is_set_all(&table->s->all_set)' failed in handler::ha_reset This followup fixes the compilation warning 'test_bit' may be used uninitialized in this function introduced by the previous patch.	15 years ago
Jon Olav Hauglid	ba5b97343c	Bug #11752069 (former bug 43152) Assertion `bitmap_is_set_all(&table->s->all_set)' failed in handler::ha_reset This assertion could be triggered if two connections simultaneously executed two bitmap test functions on the same bitmap. For example, the assertion could be triggered if one connection executed UPDATE while a second connection executed SELECT on the same table. Even if bitmap test functions have read-only semantics and have const bitmaps as parameter, several of them modified the internal state of the bitmap. With interleaved execution of two such functions it was possible for one function to modify the state of the same bitmap that the other function had just modified. This lead to an inconsistent state and could trigger the assert. Internally the bitmap uses 32 bit words for storage. Since bitmaps can contain any number of bits, the last word in the bitmap may not be fully used. A 32 bit mask is maintained where a bit is set if the corresponding bit in the last bitmap word is unused. The problem was that several test functions applied this mask to the last word. Sometimes the mask was negated and used to zero out the remainder of the last word and sometimes the mask was used as-is to fill the remainder of the last word with 1's. This meant that if a function first used the negated mask and another function then used the mask as-is (or vice-versa), the first function would then get the wrong result. This patch fixes the problem by changing the implementation of 9 bitmap functions that modified the bitmap state even if the bitmap was declared const. These functions now preserve the internal state of the bitmap. This makes it possible for two connections to concurrently execute two of these functions on the same bitmap without issues. The patch also removes dead testing code from my_bitmap.c. These tests have already been moved to unittest/mysys/bitmap-t.c. Existing test coverage of my_bitmap has been extended. No MTR test case added as this would require adding several sync points to the bitmap functions. The patch has been tested with a non-deterministic test case posted on the bug report.	15 years ago
Davi Arnaut	f6deb00a56	WL#5665: Removal of the autotools-based build system The autotools-based build system has been superseded and is being removed in order to ease the maintenance burden on developers tweaking and maintaining the build system. In order to support tools that need to extract the server version, a new file that (only) contains the server version, called VERSION, is introduced. The file contents are human and machine-readable. The format is: MYSQL_VERSION_MAJOR=5 MYSQL_VERSION_MINOR=5 MYSQL_VERSION_PATCH=8 MYSQL_VERSION_EXTRA=-rc The CMake based version extraction in cmake/mysql_version.cmake is changed to extract the version from this file. The configure to CMake wrapper is retained for backwards compatibility and to support the BUILD/ scripts. Also, a new a makefile target show-dist-name that prints the server version is introduced.	15 years ago
Davi Arnaut	60f30f6909	Bug#45288: pb2 returns a lot of compilation warnings Fix assorted compiler warnings.	15 years ago
Olav Sandstaa	93e7e5f9d9	Fix for Bug#54478 "mysqld crashes during boot when running mtr with --debug option" The crash during boot was caused by a DBUG_PRINT statement in fill_schema_schemata() (in sql_show.cc). This DBUG_PRINT statement contained several instances of %s in the format string and for one of these we gave a NULL pointer as the argument. This caused the call to vsnprintf() to crash when running on Solaris. The fix for this problem is to replace the call to vsnprintf() with my_vsnprintf() which handles that a NULL pointer is passed as argumens for %s. This patch also extends my_vsnprintf() to support %i in the format string.	15 years ago
Alexander Nozdrin	13ec2a1625	Patch for Bug#55854 (MySQL AB should not be AUTHOR, copyright incorrect). Fixing copyright text.	16 years ago
Georgi Kodinov	a843a6873c	Fixed a build error on solaris sparc in the mysql-5.5-wl1054 tree	16 years ago
Alexander Barkov	c7071a7214	Postfix for BUG#45012. Problem: The original patch didn't compile on debug_werror due to wrong format in printf("%d") for size_t variables. Fix: Adding cast to (int).	16 years ago
Alexander Barkov	e497d6e6e1	Bug#45012 my_like_range_cp932 generates invalid string Problem: The functions my_like_range_xxx() returned badly formed maximum strings for Asian character sets, which made problems for storage engines. Fix: - Removed a number my_like_range_xxx() implementations, which were in fact dumplicate code pieces. - Using generic my_like_range_mb() instead. - Setting max_sort_char member properly for Asian character sets - Adding unittest/strings/strings-t.c, to test that my_like_range_xxx() return well-formed min and max strings. Notes: - No additional tests in mysql/t/ available. Old tests cover the affected code well enough.	16 years ago
Davi Arnaut	fb91a92330	WL#5498: Remove dead and unused source code Remove Windows related files which aren't used anymore.	16 years ago
Davi Arnaut	3a22d332c7	Bug#22320: my_atomic-t unit test fails Bug#52261: 64 bit atomic operations do not work on Solaris i386 gcc in debug compilation One of the various problems was that the source operand to CMPXCHG8b was marked as a input/output operand, causing GCC to use the EBX register as the destination register for the CMPXCHG8b instruction. This could lead to crashes as the EBX register is also implicitly used by the instruction, causing the value to be potentially garbaged and a protection fault once the value is used to access a position in memory. Another problem was the lack of proper clobbers for the atomic operations and, also, a discrepancy between the implementations for the Compare and Set operation. The specific problems are described and fixed by Kristian Nielsen patches: Patch: 1 Fix bugs in my_atomic_cas(val,cmp,new) that cmp is accessed after CAS succeds. In the gcc builtin implementation, problem was that cmp was read again after atomic CAS to check if old val == cmp; this fails if CAS is successful and another thread modifies cmp in-between. In the x86-gcc implementation, problem was that *cmp was set also in the case of successful CAS; this means there is a window where it can clobber a value written by another thread after successful CAS. Patch 2: Add a GCC asm "memory" clobber to primitives that imply a memory barrier. This signifies to GCC that any potentially aliased memory must be flushed before the operation, and re-read after the operation, so that read or modification in other threads of such memory values will work as intended. In effect, it makes these primitives work as memory barriers for the compiler as well as the CPU. This is better and more correct than adding "volatile" to variables.	16 years ago
Davi Arnaut	a10ae35328	Bug#34043: Server loops excessively in _checkchunk() when safemalloc is enabled Essentially, the problem is that safemalloc is excruciatingly slow as it checks all allocated blocks for overrun at each memory management primitive, yielding a almost exponential slowdown for the memory management functions (malloc, realloc, free). The overrun check basically consists of verifying some bytes of a block for certain magic keys, which catches some simple forms of overrun. Another minor problem is violation of aliasing rules and that its own internal list of blocks is prone to corruption. Another issue with safemalloc is rather the maintenance cost as the tool has a significant impact on the server code. Given the magnitude of memory debuggers available nowadays, especially those that are provided with the platform malloc implementation, maintenance of a in-house and largely obsolete memory debugger becomes a burden that is not worth the effort due to its slowness and lack of support for detecting more common forms of heap corruption. Since there are third-party tools that can provide the same functionality at a lower or comparable performance cost, the solution is to simply remove safemalloc. Third-party tools can provide the same functionality at a lower or comparable performance cost. The removal of safemalloc also allows a simplification of the malloc wrappers, removing quite a bit of kludge: redefinition of my_malloc, my_free and the removal of the unused second argument of my_free. Since free() always check whether the supplied pointer is null, redudant checks are also removed. Also, this patch adds unit testing for my_malloc and moves my_realloc implementation into the same file as the other memory allocation primitives.	16 years ago
Davi Arnaut	46a3afb331	Bug#22320: my_atomic-t unit test fails The atomic operations implementation on 5.1 has a few problems, which might cause tests to abort randomly. Since no code in 5.1 uses atomic operations, simply remove the code.	16 years ago
Tor Didriksen	e3b4d33187	Backport of Bug#53303 mytap tests should always have a plan() The bug was caused by buffered output. Flushing resolved it. We still recommend to allways call plan(). Also fix some compile warnings (formal parameter different from declaration)	16 years ago
Alexander Nozdrin	091bcacc79	Another incarnation of the patch for Bug#30708 (make relies GNU extentions). The patch was partially backport from 6.0. Original comment: bug#30708: make relies GNU extensions. Now that we no longer use BitKeeper we can safely remove the SCCS handling with no loss of functionality.	16 years ago
Magnus Blåudd	b705b71ee6	Bug#47526 unit.pl fails to execute binaries when using Test::Harness 3.10 - Rewrite unit.pl so it prefers to use TAP::Harness directly. - Also add support for --verbose --noverbose	16 years ago
Sergei Golubchik	ae2768ce9c	WL#4738 streamline/simplify @@variable creation process Bug#16565 mysqld --help --verbose does not order variablesBug#20413 sql_slave_skip_counter is not shown in show variables Bug#20415 Output of mysqld --help --verbose is incomplete Bug#25430 variable not found in SELECT @@global.ft_max_word_len; Bug#32902 plugin variables don't know their names Bug#34599 MySQLD Option and Variable Reference need to be consistent in formatting! Bug#34829 No default value for variable and setting default does not raise error Bug#34834 ? Is accepted as a valid sql mode Bug#34878 Few variables have default value according to documentation but error occurs Bug#34883 ft_boolean_syntax cant be assigned from user variable to global var. Bug#37187 `INFORMATION_SCHEMA`.`GLOBAL_VARIABLES`: inconsistent status Bug#40988 log_output_basic.test succeeded though syntactically false. Bug#41010 enum-style command-line options are not honoured (maria.maria-recover fails) Bug#42103 Setting key_buffer_size to a negative value may lead to very large allocations Bug#44691 Some plugins configured as MYSQL_PLUGIN_MANDATORY in can be disabled Bug#44797 plugins w/o command-line options have no disabling option in --help Bug#46314 string system variables don't support expressions Bug#46470 sys_vars.max_binlog_cache_size_basic_32 is broken Bug#46586 When using the plugin interface the type "set" for options caused a crash. Bug#47212 Crash in DBUG_PRINT in mysqltest.cc when trying to print octal number Bug#48758 mysqltest crashes on sys_vars.collation_server_basic in gcov builds Bug#49417 some complaints about mysqld --help --verbose output Bug#49540 DEFAULT value of binlog_format isn't the default value Bug#49640 ambiguous option '--skip-skip-myisam' (double skip prefix) Bug#49644 init_connect and \0 Bug#49645 init_slave and multi-byte characters Bug#49646 mysql --show-warnings crashes when server dies	16 years ago
Vladislav Vaintroub	b224e24a1e	Remove STATIC from ADD_CONVENIENCE_LIBRARY on 2 places	16 years ago
Marc Alff	6e01be7552	WL#2373 Use cycle counter for timing	16 years ago
Marc Alff	1848b862e1	Port the unit test framework to windows Backport from 6.0.14 to 5.6.0 Original code from Guilhem Bichot	16 years ago
Marc Alff	3ff74fb5fa	WL#3230 concurrent hash Backport from 6.0.14 to 5.6.0 Original code from Sergei Golubchik	16 years ago
Marc Alff	1e46d6a032	WL#2595 kernel-independent atomic operations Backport from 6.0.14 to 5.6.0 Original code from Sergei Golubchik	16 years ago
Vladislav Vaintroub	13cd7170cc	WL#5161 : Cross-platform build with CMake	16 years ago
Sergei Golubchik	afe8b83bb8	unit tests for my_vsnprintf, bug fixes for my_vsnprintf	16 years ago
Mikael Ronstrom	018b63c55c	Bug fixes to my_atomic infrastructure	16 years ago
Mikael Ronstrom	c4ce446f19	Backported my_atomic from 6.0-codebase and added support for 64-bit atomics to enable removal of LOCK_thread_count from every query, removed LOCK_thread_count from use in dispatch_command and close of query which is used in every query, now uses atomic increments/decrements instead	16 years ago
Staale Smedseng	8b9843408d	Bug #43414 Parenthesis (and other) warnings compiling MySQL with gcc 4.3.2 Cleaning up warnings not present in 5.0.	16 years ago
Joerg Bruehe	67bcf54df6	Fix bug#46980 Option "--without-server" still not working in 5.1 The general approach is to make sure that source files which require thread support are only compiled if the build really needs thread support, which means when the server is built or a thread-safe client library. This required several changes: - Make sure the subdirectories "storage/" and "plugin/" are only processed if the server is built, not ifclient-only. - Make the compilation of some modules which inherently require threading depend on thread supportin the build. - Separate the handling of threading in "configure.in" from that of server issues, threading is also needed in a non-server build of a thread-safe client library. Also, "libdbug" must get built even in a client-only build, so "dbug/" must be in the list of client directories. In addition, calls to thread functions in source files which can be built without thread support must use the wrapper functions which handle the non-threaded build. So the modules "client/mysqlimport.c" and "client/mysqlslap.c" must call "my_thread_end()" only via "mysql_thread_end()".	16 years ago
guilhem@gbichot4.local	9e2b31b026	Fix for server bug experienced in Maria (wrong "Truncated incorrect <var_name> value" error even though the value was correct): a C function in my_getopt.c was taking bool* in parameter and was called from C++ sql_plugin.cc, but on some Mac OS X sizeof(bool) is 1 in C and 4 in C++, giving funny mismatches. Fixed, all other occurences of bool in C are removed, future ones are blocked by a "C-bool-catcher" in my_global.h (use my_bool).	18 years ago
serg@janus.mylan	09012c2f5c	my_atomic-t.c: gcc bug workaround	18 years ago
monty@mysql.com/nosik.monty.fi	96f90711a7	Fixes Bug#30127: --debug-info no longer prints memory usage in mysql Fixed compiler warnings, errors and link errors Fixed new bug on Solaris with gethrtime() Added --debug-check option to all mysql clients to print errors and memory leaks Added --debug-info to all clients. This now works as --debug-check but also prints memory and cpu usage	19 years ago
kent@mysql.com/kent-amd64.(none)	870b38b808	Makefile.am: Consistent use of '%::SCCS/s.%' to prevent some 'make' implementations from trying to update files in SCCS directory	19 years ago
serg@janus.mylan	11fbf30e75	remove unnecessary line	19 years ago
kent/mysqldev@mysql.com/production.mysql.com	b7f0778e82	base64-t.c: Calculate and output line count first to be compatible with older versions of Test::Harness	19 years ago
istruewing@chilla.local	a6e4ada737	After merge fix	19 years ago
kent@mysql.com/kent-amd64.(none)	67868597bb	Many files: Removed "MySQL Finland AB & TCX DataKonsult AB" from copyright header Adjusted year(s) in copyright header Added GPL copyright text my_vle.h, rpl_utility.h, my_vle.c, base64-t.c, rpl_utility.cc: Changed copyright header formatting some plugin_example.c, daemon_example.c: Added "Copyright (C) 2006 MySQL AB" to GPL header	19 years ago
kent@mysql.com/kent-amd64.(none)	1e3237fefa	Many files: Changed header to GPL version 2 only	19 years ago
guilhem@gbichot3.local	8f59d9917a	Work around slow my_atomic-t test on hpux11: decrease number of iterations on this platform	19 years ago
monty@mysql.com/nosik.monty.fi	fa81a82e7f	Fixed a LOT of compiler warnings Added missing DBUG_RETURN statements (in mysqldump.c) Added missing enums Fixed a lot of wrong DBUG_PRINT() statements, some of which could cause crashes Removed usage of %lld and %p in printf strings as these are not portable or produces different results on different systems.	19 years ago
mats@romeo.(none)	8723523029	Documentation changes to MyTAP.	19 years ago
joerg@trift2.	72bec39c85	unittest/mytap/tap.c : Do not (try to) set a signal handler action unless a signal is defined on the platform.	19 years ago
mats@romeo.(none)	7b85fb5c13	BUG#19459 (BINLOG RBR command does not lock tables correctly causing crash for, e.g., NDB): Submitting patch to base64_decode() adding extra parameter.	19 years ago
guilhem@gbichot3.local	09c5a83416	WL#3504 "plugin actions for engines' and plugins' unit tests" for push in 5.1 (I will inform Trudy). Storage engines and plugins can now have unit tests to test their components; such test must be an executable C/C++ program which name ends with '-t' and which is obeys the mytap protocol, it must be stored in the storage engine's or plugin's source directory (storage/<engine> or plugin/<plugin>) or any subdirectories of this. The top-level Makefile target "test-unit" will run all unit tests: it will scan the engines' and plugins' directories, recursively, and execute all executable files which name ends with '-t'."	19 years ago
guilhem@gbichot3.local	7e95cda2ac	fixes for the my_atomic-t unit test: - compiler warning - detection of pthread_create failure (you will see this message only if you run with "make test-verbose" in unittest; otherwise unit.pl masks all messages from the test but "ok" ones. - the test fails randomly on some machines (I filed it as BUG#22320), on one host it looks like a crash at exit() which a sleep(2) makes disappear. So I add the sleep(2), which can be removed when BUG#22320 is fixed.	19 years ago
mats@romeo.(none)	d67b341a37	Changes to make unit tests work on OS X and AIX	20 years ago
mkindahl@dl145h.mysql.com	ca1bf4b21e	Various fixes to make MyTAP build on all platforms.	20 years ago
mkindahl@dl145h.mysql.com	0b7dc2689d	Adding missing file	20 years ago
mkindahl@production.mysql.com[mkindahl]	794dba439e	mytap-changes.patch	20 years ago
mats@romeo.(none)	2c21e455d4	Fixing unit test execution script to work with AIX 5.2 and OS X machines. These are using old version of the Test::Harness modules, so I resort to a safer way of running executable files.	20 years ago
lars@mysql.com	78a9adb659	Changed the number of test iterations since this makes test time go from 623 seconds to 11 seconds on AMD64. This is because we have no native atomic implementation on AMD64, so the rwlock-based implementation is used, which is a bit slow. It will be probably be optimized for AMD64 quite soon, but for now this test case will do fewer iterations.	20 years ago

1 2

98 Commits (3d8d67245051f489c3702e35a3201e092da28a88)