mariadb

Tree: 30415ebd52

Author	SHA1	Message	Date
marko	30415ebd52	branches/zip: innodb-index.test: Test duplicate key failures for different indexes.	18 years ago
marko	2505aea758	branches/zip: innodb-index.test: Drop all created tables at the end.	18 years ago
marko	4e44c7332b	branches/zip: innodb-index.test: Work around MySQL bugs and bug fixes.	18 years ago
marko	adbb92becd	branches/zip: Implement a limit for the size of undo log records. innodb-index.test: Add a test with a large number of externally stored columns. Check that there may not be prefix indexes on too many columns. dict_index_too_big_for_undo(): New function: Check if the undo log may overflow. dict_index_add_to_cache(): Return DB_SUCCESS or DB_TOO_BIG_RECORD. Postpone the creation and linking of some data structures, so that when dict_index_too_big_for_undo() holds, it will be easier to clean up. Check the return status in all callers.	18 years ago
marko	71a4f691b2	branches/zip: Fast index creation: Remove the ROW_PREBUILT_OBSOLETE nonsense. Active transactions must not switch table or index definitions on the fly, for several reasons, including the following: * copied indexes do not carry any history or locking information; that is, rollbacks, read views, and record locking would be broken * huge potential for race conditions, inconsistent reads and writes, loss of data, and corruption Instead of trying to track down if the table was changed during a transaction, acquire appropriate locks that protect the creation and dropping of indexes. innodb-index.test: Test the locking of CREATE INDEX and DROP INDEX. Test that consistent reads work across dropped indexes. lock_rec_insert_check_and_lock(): Relax the lock_table_has() assertion. When inserting a record into an index, the table must be at least IX-locked. However, when an index is being created, an IS-lock on the table is sufficient. row_merge_lock_table(): Add the parameter enum lock_mode mode, which must be LOCK_X or LOCK_S. row_merge_drop_table(): Assert that n_mysql_handles_opened == 0. Unconditionally drop the table. ha_innobase::add_index(): Acquire an X or S lock on the table, as appropriate. After acquiring an X lock, assert that n_mysql_handles_opened == 1. Remove the comments about dropping tables in the background. ha_innobase::final_drop_index(): Acquire an X lock on the table. dict_table_t: Remove version_number, to_be_dropped, and prebuilts. ins_node_t: Remove table_version_number. enum lock_mode: Move the definition from lock0lock.h to lock0types.h. ROW_PREBUILT_OBSOLETE, row_update_prebuilt(), row_prebuilt_table_obsolete(): Remove. row_prebuilt_t: Remove the declaration from row0types.h. row_drop_table_for_mysql_no_commit(): Always print a warning if a table was added to the background drop queue.	18 years ago
vasil	857c6501f4	branches/zip: Move test that depends on ucs2 to a separate file that is disabled if ucs2 is not compiled in.	18 years ago
vasil	9d76b5263d	branches/zip: Move common SQL commands to an .inc file.	18 years ago
vasil	62a46de281	branches/zip: Synchronize the utf8 and ucs2 tests.	18 years ago
marko	6c9bfe7825	branches/zip: innodb-index.test: Add FORCE INDEX directives and remove those SELECTs whose ORDER BY cannot possibly make use of an index.	18 years ago
marko	dcde0edf82	branches/zip: innodb-index.result: Adapt the results to a patch from MySQL. Unfortunately, the patch seems to prevent MySQL from utilizing secondary indexes in the ORDER BY clauses. Thus, the test no longer checks if newly created indexes are well-formed. ChangeSet@1.2528.98.1 2007-08-02 12:45:56-07:00 igor@mysql.com Fixed bug#28404. This patch adds cost estimation for the queries with ORDER BY / GROUP BY and LIMIT. If there was a ref/range access to the table whose rows were required to be ordered in the result set the optimizer always employed this access though a scan by a different index that was compatible with the required order could be cheaper to produce the first L rows of the result set. Now for such queries the optimizer makes a choice between the cheapest ref/range accesses not compatible with the given order and index scans compatible with it.	18 years ago
marko	809270166b	branches/zip: innodb-index.test: Add yet another CHECK TABLE and add the column d to two SELECT FROM t1.	18 years ago
marko	f6aec10b49	branches/zip: innodb-index.test: Add more columns and rows, to ensure that row_merge_blocks() will have some work to do when row_merge_block_t is shrunk to 8192 bytes. Currently, this will cause a debug assertion failure, because row_merge_cmp() is considering all columns, not just the unique ones.	18 years ago
marko	fdcf0b1fcd	branches/zip: row_merge_buf_add(): Correct the processing of column prefixes in clustered indexes. innodb-index.test: Add test cases for creating primary keys containing column prefixes.	18 years ago
marko	5de8acee56	branches/zip: ha_innobase::add_index(): Translate DB_TOO_BIG_RECORD via my_error(). Add a test case to innodb-index.test.	18 years ago
marko	62ede4fcd4	branches/zip: innodb-index.test: Make the column b much longer, to hit the 65,535-byte VARCHAR length limit of MySQL.	18 years ago
marko	45b97e559f	branches/zip: Decode table names when displaying error messages in fast index creation. innobase_convert_tablename(): New function, to remove the filename encoding of a database and table name. ha_innobase::add_index(): Invoke innobase_convert_tablename() before calling my_error(). innodb-index.result: Update the error messages.	18 years ago
marko	ffe9a4c52e	branches/zip: ha_innobase:add_index(): Report HA_ERR_TABLE_EXIST when the temporary table cannot be created or renamed. innodb-index.test,result: Add test cases where a temporary table already exists.	18 years ago
marko	71f47ed2e2	branches/zip: innodb-index.test: Add tests for creating or dropping FOREIGN KEY constraints. At the moment, MySQL will rebuild the entire table and indexes when such constraints are added or removed, even though the constraints do not affect the storage format of the data.	19 years ago
marko	885212294d	branches/zip: Preserve FOREIGN KEY constraints when creating a PRIMARY KEY. innodb-index.test: Add some test cases for FOREIGN KEY constraints. row_merge_rename_tables(): New function, adapted from row_rename_table_for_mysql(). ha_innobase::add_index(): Use row_merge_rename_tables().	19 years ago
marko	66f6a5acc8	branches/zip: Fix bugs in the creation or dropping of the clustered index (PRIMARY KEY or UNIQUE INDEX on NOT NULL columns). innodb-index.test: Remove the --replace_regex directives. Replace correct values to the "Duplicate entry" messages. This will cause the test to fail until we somehow return the duplicate key values to MySQL. Add test cases for creating or dropping UNIQUE INDEX or PRIMARY KEY. innobase_copy_index_def(): Allow the function to copy a clustered index definition to a secondary one (UNIQUE INDEX). innobase_create_key_def(): Check the NOT NULL flag from the correct place. Copy the clustered index if it is a UNIQUE INDEX. ha_innobase::prepare_drop_index(): Refuse to drop the clustered index.	19 years ago
marko	4d793ff876	branches/zip: Add changes that accidentally omitted from r1698: innodb-index.test, innodb-index.result: Add a test for creating a PRIMARY KEY on a column that contains a NULL value.	19 years ago
marko	1a8a63d0cd	branches/zip: Reimplement merge sort in fast index creation. The creation of the primary key does not work. We will have to flag externally stored columns and copy the externally stored part from the old table. row_build_index_for_mysql(): Rename to row_merge_build_indexes(). Move from row0mysql.c to row0merge.c. Remove private declarations from row0merge.h. Make many functions static in row0merge.c. cmp_rec_rec_simple(): A new comparison function. dict_index_get_min_size(): New function. OS_FILE_FROM_FD(fd): A macro for converting from int to os_file_t. rec_convert_dtuple_to_rec_comp(): Make the interface lower-level. rec_get_converted_size_comp(): Return also extra_size. UT_SORT_FUNCTION_BODY(): Remove reference to an obsolete test program. row_rec_to_index_entry_low(): New function. row0merge.c: Implement merge sort based on file streams instead of fixed-size blocks. Sort the small blocks as arrays of dfield_t*, because it is faster than invoking rec_get_offsets() for every comparison.	19 years ago
marko	d9c3a96f4f	branches/zip: innodb-index.test: Check the length of the long columns.	19 years ago
marko	aa2a74a67c	branches/zip: Minor cleanup. innobase_create_index_def(): Add parameter new_primary. innobase_copy_index_def(): Simplify the documented algorithm, and try to implement it properly. innodb-index.test: Replace CHECKSUM TABLE with something more stable and useful. The test passes on an older BitKeeper snapshot: ChangeSet@1.2475.18.9, 2007-05-08 11:16:41+02:00, jbruehe@mysql.com +1 -0 Raise version number after cloning 5.1.18-beta But it fails on a newer one where the statement alter table t1 add primary key (a), add key (b(20)); results in fast index creation: ChangeSet@1.2500.1.40, 2007-06-01 20:06:13+04:00, kostja@bodhi.(none) +2 -0 Merge bodhi.(none):/opt/local/work/mysql-5.0-runtime into bodhi.(none):/opt/local/work/mysql-5.1-runtime MERGE: 1.1810.2984.14	19 years ago
marko	fc65b08f53	branches/zip: Merge branches/fast-index-creation -r1413. Fix some bugs. The tests innodb and innodb-index fail, but that might be due to an old MySQL source tree being used.	19 years ago

25 Commits (30415ebd526b931cf6ff88a7daf28ee1a1cd18f4)