mariadb

Tree: 2f88bd2da2

Author	SHA1	Message	Date
Vladislav Vaintroub	edb6e2b951	MDEV-17610 - fix result, for the case when test runs with userstat=on	6 years ago
Alexander Barkov	ef00ac4c86	Part2: MDEV-18156 Assertion `0' failed or `btr_validate_index(index, 0, false)' in row_upd_sec_index_entry or error code 126: Index is corrupted upon DELETE with PAD_CHAR_TO_FULL_LENGTH This patch allows the server to open old tables that have "bad" generated columns (i.e. indexed virtual generated columns, persistent generated columns) that depend on sql_mode, for general things like SELECT, INSERT, DROP, etc. Warning are issued in such cases. Only these commands are now disallowed and return an error: - CREATE TABLE introducing a "bad" generated column - ALTER TABLE introducing a "bad" generated column - CREATE INDEX introdicing a "bad" generated column (i.e. adding an index on a virtual generated column that depends on sql_mode). Note, these commands are allowed: - ALTER TABLE removing a "bad" generate column - ALTER TABLE removing an index from a "bad" virtual generated column - DROP INDEX removing an index from a "bad" virtual generated column but only if the table does not have any "bad" columns as a result.	6 years ago
Alexander Barkov	dc719597ee	MDEV-18156 Assertion `0' failed or `btr_validate_index(index, 0, false)' in row_upd_sec_index_entry or error code 126: Index is corrupted upon DELETE with PAD_CHAR_TO_FULL_LENGTH This change takes into account a column's GENERATED ALWAYS AS expression dependcy on sql_mode's PAD_CHAR_TO_FULL_LENGTH and NO_UNSIGNED_SUBTRACTION flags. Indexed virtual columns as well as persistent generated columns are now not allowed to have such dependencies to avoid inconsistent data or index files on sql_mode changes. So an error is now returned in cases like this: CREATE OR REPLACE TABLE t1 ( a CHAR(5), v VARCHAR(5) AS (a) PERSISTENT -- CHAR->VARCHAR or CHAR->TEXT = ERROR ); Functions RPAD() and RTRIM() can now remove dependency on PAD_CHAR_TO_FULL_LENGTH. So this can be used instead: CREATE OR REPLACE TABLE t1 ( a CHAR(5), v VARCHAR(5) AS (RTRIM(a)) PERSISTENT ); Note, unlike CHAR->VARCHAR and CHAR->TEXT this still works, not RPAD(a) is needed: CREATE OR REPLACE TABLE t1 ( a CHAR(5), v CHAR(5) AS (a) PERSISTENT -- CHAR->CHAR is OK ); More sql_mode flags may affect values of generated columns. They will be addressed separately. See comments in sql_mode.h for implementation details.	6 years ago
Monty	0d66358220	Disabled test in 32bit that uses too much memory or cpu	6 years ago
Oleksandr Byelkin	4f10d0918d	Merge branch '10.3' into 10.4	6 years ago
Ian Gilfillan	3ca68794c0	MDEV-20231: MariaDB 10.4 HELP Tables Changes for 10.4 only, please null-merge to 10.5	6 years ago
Sergei Petrunia	de5f7348bd	Make main.subselect_sj2* tests stable Use EITS statistics to avoid changing query plans	6 years ago
Oleksandr Byelkin	b0ff5a6a73	Merge branch '10.2' into 10.3	6 years ago
Varun Gupta	b1e377997e	Fixed a typo	6 years ago
Varun Gupta	29b13d114e	Followup fix for MDEV-20440	6 years ago
Monty	9cba6c5aa3	Updated mtr files to support different compiled in options This allows one to run the test suite even if any of the following options are changed: - character-set-server - collation-server - join-cache-level - log-basename - max-allowed-packet - optimizer-switch - query-cache-size and query-cache-type - skip-name-resolve - table-definition-cache - table-open-cache - Some innodb options etc Changes: - Don't print out the value of system variables as one can't depend on them to being constants. - Don't set global variables to 'default' as the default may not be the same as the test was started with if there was an additional option file. Instead save original value and reset it at end of test. - Test that depends on the latin1 character set should include default_charset.inc or set the character set to latin1 - Test that depends on the original optimizer switch, should include default_optimizer_switch.inc - Test that depends on the value of a specific system variable should set it in the test (like optimizer_use_condition_selectivity) - Split subselect3.test into subselect3.test and subselect3.inc to make it easier to set and reset system variables. - Added .opt files for test that required specfic options that could be changed by external configuration files. - Fixed result files in rockdsb & tokudb that had not been updated for a while.	6 years ago
Monty	b23b3a5fb6	Fixed some compiler warnings	6 years ago
Monty	b0916141c7	embedded client now writes errors to stderr during init_embedded_server This was done to be able to get any information why the embedded server doesn't start.	6 years ago
Monty	d558981e2c	Remove test that where only applicable for MySQL These was part of an incomplete old merge from MySQL 5.6	6 years ago
Monty	2d85714448	Updated BUILD/SETUP from MariaDB 10.5	6 years ago
Aleksey Midenkov	597b070f82	Compilation fix Caused by: MDEV-18501 Partition pruning doesn't work for historical queries (cleanup)	6 years ago
Sergei Golubchik	df61c58499	MDEV-14383 tokudb_bugs. tests failed in buildbot, lost connection to server don't run tokudb tests under tcmalloc, this is not a supported combination.	6 years ago
Monty	1bbc593eae	Fixed compiler warning that broke builds gcc 7.4.1	6 years ago
Sergei Golubchik	d5a11a1f02	C/C	6 years ago
Aleksey Midenkov	6a490ca0fb	MDEV-18501 Partition pruning doesn't work for historical queries (fix) Pruning fix for SYSTEM_TIME INTERVAL partitioning. Allocating one more element in range_int_array for CURRENT partition is required for RANGE pruning to work correctly (get_partition_id_range_for_endpoint()).	6 years ago
Aleksey Midenkov	c3f35ea55a	MDEV-18501 Partition pruning doesn't work for historical queries (refactoring) SYSTEM_TYPE partitioning: COLUMN properties removed. Partitioning is now pure RANGE based on UNIX_TIMESTAMP(row_end). DECIMAL type is now allowed as RANGE partitioning, we can partition by UNIX_TIMESTAMP() (but not for DATETIME which depends on local timezone of course).	6 years ago
Aleksey Midenkov	a3e49c0d36	MDEV-18501 Partition pruning doesn't work for historical queries (cleanup) Cleanup removes useless allocation.	6 years ago
Marko Mäkelä	db4a27ab73	Merge 10.3 into 10.4	6 years ago
Igor Babaev	d1ef02e959	MDEV-20265 Unknown column in field list This patch corrects the fix of the patch for mdev-19421 that resolved the problem of parsing some embedded join expressions such as t1 join t2 left join t3 on t2.a=t3.a on t1.a=t2.a. Yet the patch contained a bug that prevented proper context analysis of the queries where such expressions were used together with comma separated table references in from clauses.	6 years ago
Vladislav Vaintroub	9dae991a95	MDEV-19200 Do not print "Thread <num> did not exit" message for system/background THDs	6 years ago
Oleksandr Byelkin	14149d6c33	Merge remote-tracking branch 'connect/10.2' into 10.2	6 years ago
Marko Mäkelä	396da1a705	Enable some RocksDB tests that are enabled on 10.2 FIXME: rocksdb.drop_table hangs on shutdown, but is not disabled in 10.2	6 years ago
Marko Mäkelä	a5472b0367	Merge 10.2 into 10.3	6 years ago
Marko Mäkelä	17336f6d30	MDEV-20066 Wrong value on instantly added column after DELETE and UPDATE row_upd_build_difference_binary(): Correctly handle the case where columns (or clustered index fields) have been added since the 'entry' was originally created. In this case, the update vector must replace any missing columns with the default values of the instantly added columns.	6 years ago
Sergei Petrunia	1688a22612	MDEV-18384: rocksdb.index_merge_rocksdb2 test fails Merge the changes to include/index_merge*inc from the upstream. The changes add this command in many places: +if ($engine_type == RocksDB) +{ + set global rocksdb_force_flush_memtable_now=1; +} also add it in one more place to make the test truly stable.	6 years ago
Marko Mäkelä	f42a23178e	MDEV-20425: Fix -Wimplicit-fallthrough With --skip-debug-assert, DBUG_ASSERT(false) will allow execution to continue. Hence, we will need /* fall through */ after them. Some DBUG_ASSERT(0) were replaced by break; when the switch () statement was followed by DBUG_ASSERT(0).	6 years ago
Sergei Petrunia	a379f151b1	MDEV-20109: Optimizer ignores distinct key created for materialized... Adjust the testcase according to the review input	6 years ago
Sergei Petrunia	ef76f81c98	MDEV-20109: Optimizer ignores distinct key created for materialized... (Backported to 10.3, addressed review input) Sj_materialization_picker::check_qep(): fix error in cost/fanout calculations: - for each join prefix, add #prefix_rows / TIME_FOR_COMPARE to the cost, like best_extension_by_limited_search does - Remove the fanout produced by the subquery tables. - Also take into account join condition selectivity optimize_wo_join_buffering() (used by LooseScan and FirstMatch) - also add #prefix_rows / TIME_FOR_COMPARE to the cost of each prefix. - Also take into account join condition selectivity	6 years ago
Teemu Ollakka	9487e0b259	MDEV-19826 10.4 seems to crash with "pool-of-threads" (#1370 ) MariaDB 10.4 was crashing when thread-handling was set to pool-of-threads and wsrep was enabled. There were two apparent reasons for the crash: - Connection handling in threadpool_common.cc was missing calls to control wsrep client state. - Thread specific storage which contains thread variables (THR_KEY_mysys) was not handled appropriately by wsrep patch when pool-of-threads was configured. This patch addresses the above issues in the following way: - Wsrep client state open/close was moved in thd_prepare_connection() and end_connection() to have common handling for one-thread-per-connection and pool-of-threads. - Thread local storage handling in wsrep patch was reworked by introducing set of wsrep_xxx_threadvars() calls which replace calls to THD store_globals()/reset_globals() and deal with thread handling specifics internally. Wsrep-lib was updated to version which relaxes internal concurrency related sanity checks. Rollback code from wsrep_rollback_process() was extracted to separate calls for better readability. Post rollback thread was removed as it was completely unused.	6 years ago
Vladislav Vaintroub	d22f8c459f	MDEV-20432 : add MYSQL_PLUGIN_IMPORT Mroonga does not build on Windows due to log_10_int being used (indirectly) and n ot properly decorated with MYSQL_PLUGIN_IMPORT	6 years ago
Marko Mäkelä	d58437d195	MDEV-20149 innodb.innodb-system-table-view fails with wrong result The test occasionally fails with different table reference count due to purge activity after INSERT operations (MDEV-12288). Wait for purge before accessing dict_table_t::n_ref_count.	6 years ago
Marko Mäkelä	d4246e25e5	After-merge fix Merge a part of commit `25af2a183b`. This was forgotten in the merge commit `e41eb044f1`.	6 years ago
Marko Mäkelä	e50b2bdbcf	MDEV-20425 Implement Boolean debug build option debug_assert Commit `536215e32f` in MariaDB Server 10.3.1 introduced the compiler flag (not cmake option) DBUG_ASSERT_AS_PRINTF that converts DBUG_ASSERT in non-debug builds into printouts. For debug builds, it could be useful to be able to convert DBUG_ASSERT into a warning or error printout, to allow execution to continue. This would allow debug builds to be used for reproducing hard failures that occur with release builds. my_assert: A Boolean flag (set by default), tied to the new option debug_assert that is available on debug builds only. When set, DBUG_ASSERT() will invoke assert(), like it did until now. When unset, DBUG_ASSERT() will invoke fprintf(stderr, ...) with the file name, line number and assertion expression.	6 years ago
Marko Mäkelä	1a3c365953	Merge 10.2 into 10.3	6 years ago
Marko Mäkelä	5e9b34191e	Clean up innodb.innodb-read-view	6 years ago
Marko Mäkelä	2842ae03bc	Remove a bogus comment Changes of PAGE_MAX_TRX_ID must be redo-logged for correctness. That was fixed in the InnoDB Plugin for MySQL 5.1 already.	6 years ago
Marko Mäkelä	5f35e103ee	Merge 10.1 into 10.2	6 years ago
Julius Goryavsky	4ba20e0a14	Improved handling of subdirectories in the xtrabackup-v2 SST scripts (similar to MDEV-18863) for more predictable test results (related to xtrabackup-v2 SST)	6 years ago
Oleksandr Byelkin	9cd6e7ad73	MDEV-16932: ASAN heap-use-after-free in my_charlen_utf8 / my_well_formed_char_length_utf8 on 2nd execution of SP with ALTER trying to add bad CHECK Make automatic name generation during execution (not prepare). Check result of memory allocation operation.	7 years ago
Marko Mäkelä	e41eb044f1	Merge 10.2 into 10.3	6 years ago
Eugene Kosov	d4866c7d0d	fix clang warnings	6 years ago
Marko Mäkelä	947b0b5722	Implement innodb_evict_tables_on_commit_debug Some bugs are detected only after a table definition has been evicted and then reloaded to the InnoDB data dictionary cache. For debug builds, introduce the settable Boolean configuration parameter innodb_evict_tables_on_commit_debug that can be set to request InnoDB to attempt to evict table definitions from the data dictionary cache whenever a transaction is committed. This has been tested on 10.3 and 10.4 with the following: ./mysql-test-run.pl --mysqld=--loose-innodb-evict-tables-on-commit-debug You can also use the following: SET GLOBAL innodb_evict_tables_on_commit_debug=ON; SET GLOBAL innodb_evict_tables_on_commit_debug=OFF; The parameter affects the commit (or rollback or abort) of transactions that have modified persistent InnoDB tables.	6 years ago
Vladislav Vaintroub	5bb8945a3a	Fix compress_qpress result file, broken in `b5615eff0d`	6 years ago
Marko Mäkelä	7aac83580a	MDEV-13626: Add innodb.innodb-read-view	6 years ago
Marko Mäkelä	25af2a183b	MDEV-15326/MDEV-16136 dead code removal Revert part of `fa2a74e08d`. trx_reference(): Remove, and merge the relevant part to the only caller trx_rw_is_active(). If the statements trx = NULL; were ever executed, the function would have dereferenced a NULL pointer and crashed in trx_mutex_exit(trx). Hence, those statements must have been unreachable, and they can be replaced with debug assertions. trx_rw_is_active(): Avoid unnecessary acquisition and release of trx->mutex when do_ref_count=false. lock_trx_release_locks(): Do not reset trx->id=0. Had the statement been necessary, we would have experienced crashes in trx_reference().	6 years ago

1 2 3 4 5 ...

187071 Commits (2f88bd2da26abd30b027308aedc30989c039d518) All Branches Search

187071 Commits (2f88bd2da26abd30b027308aedc30989c039d518)

All Branches