mariadb

Tree: 2a16e7674b

Author	SHA1	Message	Date
Sergey Petrunya	59b2bb9aca	Added back MRR counters. The new names are: Handler_mrr_init, Handler_mrr_key_refills, Handler_mrr_rowid_refills.	14 years ago
Sergey Petrunya	2ae3fca465	Add MRR counters: Handler_mrr_init, Handler_mrr_extra_rowid_sorts, Handler_mrr_extra_key_sorts.	14 years ago
Igor Babaev	2b173bf894	Fixed LP bug #878769 . The method DsMrr_impl::dsmrr_init erroneously tried to get a KEY descriptor for key with number MAX_KEY. This caused valgrind complains.	14 years ago
unknown	255c04aed8	Compiler warning about assigned but not used variables fixed.	14 years ago
Sergey Petrunya	5ebff8ab78	BUG#730133: Wrong result with jkl = 7, BKA, ICP in maria-5.3 + compound index - Mrr_ordered_index_reader::interrupt_read() and resume_read() should save/restore not just index lookup tuple, but entire index tuple. Key parts that are not used for index lookup can be still used in pushed index condition. Failure to save/restore will cause the index condition to be evaluated over the wrong values.	14 years ago
Michael Widenius	ba9a890f0c	New status variables: Rows_tmp_read, Handler_tmp_update and Handler_tmp_write Split status variable Rows_read to Rows_read and Rows_tmp_read so that one can see how much real data is read. Same was done with with Handler_update and Handler_write. Fixed bug in MEMORY tables where some variables was counted twice. Added new internal handler call 'ha_close()' to have one place to gather statistics. Fixed bug where thd->open_options was set to wrong value when doing admin_recreate_table() mysql-test/r/status.result: Updated test results and added new tests mysql-test/r/status_user.result: Udated test results mysql-test/t/status.test: Added new test for temporary table status variables sql/ha_partition.cc: Changed to call ha_close() instead of close() sql/handler.cc: Added internal_tmp_table variable for easy checking of temporary tables. Added new internal handler call 'ha_close()' to have one place to gather statistics. Gather statistics for internal temporary tables. sql/handler.h: Added handler variables internal_tmp_table, rows_tmp_read. Split function update_index_statistics() to two. Added ha_update_tmp_row() for faster tmp table handling with more statistics. sql/item_sum.cc: ha_write_row() -> ha_write_tmp_row() sql/multi_range_read.cc: close() -> ha_close() sql/mysqld.cc: New status variables: Rows_tmp_read, Handler_tmp_update and Handler_tmp_write sql/opt_range.cc: close() -> ha_close() sql/sql_base.cc: close() -> ha_close() sql/sql_class.cc: Added handling of rows_tmp_read sql/sql_class.h: Added new satistics variables. rows_read++ -> update_rows_read() to be able to correctly count reads to internal temp tables. Added handler::ha_update_tmp_row() sql/sql_connect.cc: Added comment sql/sql_expression_cache.cc: ha_write_row() -> ha_write_tmp_row() sql/sql_select.cc: close() -> ha_close() ha_update_row() -> ha_update_tmp_row() sql/sql_show.cc: ha_write_row() -> ha_write_tmp_row() sql/sql_table.cc: Fixed bug where thd->open_options was set to wrong value when doing admin_recreate_table() sql/sql_union.cc: ha_write_row() -> ha_write_tmp_row() sql/sql_update.cc: ha_write_row() -> ha_write_tmp_row() sql/table.cc: close() -> ha_close() storage/heap/ha_heap.cc: Removed double counting of statistic variables. close -> ha_close() to get tmp table statistics. storage/maria/ha_maria.cc: close -> ha_close() to get tmp table statistics.	15 years ago
Sergey Petrunya	9482e387e6	Change optimizer_use_mrr=auto\|disable\|force to be optimizer_switch flags mrr=on\|off and mrr_cost_based=on\|off.	15 years ago
Sergey Petrunya	997445bc8e	Make EXPLAIN better at displaying MRR/BKA: - "Using MRR" is no longer shown with range access. - Instead, both range and BKA accesses will show one of the following: = "Rowid-ordered scan" = "Key-ordered scan" = "Key-ordered Rowid-ordered scan" depending on whether DS-MRR implementation will do scan keys in order, rowids in order, or both. - The patch also introduces a way for other storage engines/MRR implementations to pass information to EXPLAIN output about the properties of employed MRR scans.	15 years ago
Sergey Petrunya	e6bd643c75	MRR interface: change range_info's type from char* to range_id_t typedef. The goals are: - cleaner code - ability to change from using pointers to offsets at some point	15 years ago
Sergey Petrunya	8ef094fe4f	BUG#707925: Wrong result with join_cache_level=6 optimizer_use_mrr = force (incremental, BKA join) - The problem was that Mrr_ordered_index_reader's interrupt_read() and resume_read() would save and restore 1) index tuple 2) the rowid (as bytes returned by handler->position()). Clustered primary key columns were not saved/restored. They are not explicitly present in the index tuple (i.e. table->key_info[secondary_key].key_parts doesn't list them), but they are actually there, in particular table->field[clustered_primary_key_member].part_of_key(secondary_key) == 1. Index condition pushdown code [correctly] uses the latter as inidication that pushed index condition can refer to clustered PK members. The fix was to make interrupt_read()/resume_read() to save/restore clustered primary key members as well, so that we get correct values for them when evaluating pushed index condition. [3rd attempt: remove the debugging aids, fix comments in testcase]	15 years ago
Sergey Petrunya	9faf5452a1	BUG#693747: Assertion multi_range_read.cc:908: int DsMrr_impl::dsmrr_init - Make DsMrr_impl::dsmrr_init() handle the case of 1. 1st MRR scan using DS-MRR strategy (i.e. doing key sorting and rowid sorting) 2. 2nd MRR scan getting a buffer that's too small to fit one key element and one rowid element, and so falling back to default MRR implementation In this case, dsmrr_init() is invoked with {primary_handler, secondary_handler} initialized for DS-MRR scan and have to reset them to be initialized for the default MRR scan. (attempt 2, with simplified testcase)	15 years ago
Vladislav Vaintroub	019256c9fc	Fix numerous warnings introduced in the last pushes on Windows	15 years ago
Michael Widenius	b12e3796dc	Fix for lp:711565 "Index Condition Pushdown can make a thread hold MyISAM locks as well as be unKILLable for long time" - In Maria/MyISAM: Release/re-acquire locks to give queries that wait on them a chance to make progress - In Maria/MyISAM: Change from numeric constants to ICP_RES values. - In Maria: Do check index condition in maria_rprev() (was lost in the merge/backport?) - In Maria/MyISAM/XtraDB: Check if the query was killed, and return immediately if it was. Added new storage engine error: HA_ERR_ABORTED_BY_USER, for handler to signal that it detected a kill of the query and aborted Authors: Sergey Petrunia & Monty include/my_base.h: Added HA_ERR_ABORTED_BY_USER, for handler to signal that it detected a kill of the query and aborted include/my_handler.h: Added comment mysql-test/r/myisam_icp.result: Updated test mysql-test/t/myisam_icp.test: Drop used tables at start of test Added test case that can help with manual testing of killing index condition pushdown query. mysys/my_handler_errors.h: Text for new storage engine error sql/handler.cc: If engine got HA_ERR_ABORTED_BY_USER, send kill message. sql/multi_range_read.cc: Return error code storage/maria/ha_maria.cc: Added ma_killed_in_mariadb() to detect kill. Ensure that file->external_ref points to TABLE object. storage/maria/ma_extra.c: Dummy test-if-killed for standalone storage/maria/ma_key.c: If ma_check_index_cond() fails, set my_errno and info->cur_row.lastpos storage/maria/ma_rkey.c: Release/re-acquire locks to give queries that wait on them a chance to make progress Check if the query was killed, and return immediately if it was storage/maria/ma_rnext.c: Check if the query was killed, and return immediately if it was Added missing fast_ma_writeinfo(info) storage/maria/ma_rnext_same.c: Check if the query was killed, and return immediately if it was Added missing fast_ma_writeinfo(info) storage/maria/ma_rprev.c: Check if the query was killed, and return immediately if it was Added missing fast_ma_writeinfo(info) and ma_check_index_cond() storage/maria/ma_search.c: Give error message if we find a wrong key storage/maria/ma_static.c: Added pointer to test-if-killed function storage/maria/maria_def.h: New prototypes storage/myisam/ha_myisam.cc: Added mi_killed_in_mariadb() Ensure that file->external_ref points to TABLE object. storage/myisam/mi_extra.c: Dummy test-if-killed for standalone storage/myisam/mi_key.c: If ma_check_index_cond() fails, set my_errno and info->lastpos storage/myisam/mi_rkey.c: Ensure that info->lastpos= HA_OFFSET_ERROR in case of error Release/re-acquire locks to give queries that wait on them a chance to make progress Check if the query was killed, and return immediately if it was Reorder code to do less things in case of error. Added missing fast_mi_writeinfo() storage/myisam/mi_rnext.c: Check if the query was killed, and return immediately if it was Simplify old ICP code Added missing fast_ma_writeinfo(info) storage/myisam/mi_rnext_same.c: Check if the query was killed, and return immediately if it was Added missing fast_mi_writeinfo(info) storage/myisam/mi_rprev.c: Check if the query was killed, and return immediately if it was Simplify error handling of ICP Added missing fast_mi_writeinfo(info) storage/myisam/mi_search.c: Give error message if we find a wrong key storage/myisam/mi_static.c: Added pointer to test-if-killed function storage/myisam/myisamdef.h: New prototypes storage/xtradb/handler/ha_innodb.cc: Added DB_SEARCH_ABORTED_BY_USER and ha_innobase::is_thd_killed() Check if the query was killed, and return immediately if it was storage/xtradb/handler/ha_innodb.h: Added prototype storage/xtradb/include/db0err.h: Added DB_SEARCH_ABORTED_BY_USER storage/xtradb/include/row0mysql.h: Added possible ICP errors storage/xtradb/row/row0sel.c: Use ICP errors instead of constants. Detect if killed and return B_SEARCH_ABORTED_BY_USER	15 years ago
Sergey Petrunya	f51a26885f	Fix compile error on Windows: instead of round(X) use floor(X+0.5)	15 years ago
Sergey Petrunya	9d480f6af3	BUG#670417: Diverging results in maria-5.3-mwl128-dsmrr-cpk with join buffer - Fixes for the second fix: take into account case where we don't need to save/restore the scan.	15 years ago
Sergey Petrunya	09a84dc470	BUG#670417: Diverging results in maria-5.3-mwl128-dsmrr-cpk with join buffer Switch from "Disable identical key handling optimization when IndexConditionPushdown is used" approach To an approach where we save/restore index tuple and so can use index condition pushdown.	15 years ago
Sergey Petrunya	81eb82b47d	Fix a compiler warning on sparc32	15 years ago
Sergey Petrunya	80cbf3a1c2	Small code cleanups	15 years ago
Sergey Petrunya	8dc612e6ab	MWL#121-125 DS-MRR improvements - Address Monty's review feedback, portion 3	15 years ago
Sergey Petrunya	3e633eea66	MWL#121-125 DS-MRR improvements - Address Monty's review feedback, portion 2	15 years ago
Sergey Petrunya	802db7a64b	- Fix compiler warning - Better warnings	15 years ago
Sergey Petrunya	eafc4bef33	MWL#121-125 DS-MRR improvements - Address review feedback: change return type of RANGE_SEQ_IF::next()	15 years ago
Sergey Petrunya	14ca046833	Fix crashes on sparc-32 bit: use memcpy when we need to access non-aligned pointers.	15 years ago
Sergey Petrunya	a86599e1e4	BUG#671340: Diverging results in with mrr_sort_keys=ON\|OFF and join_cache_level=5 - Make Mrr_ordered_index_reader() save the rowid across scan interruptions Also - Fix compiler warning for setup_buffer_sizes() - Add commented key_copy/key_restore for better handling of a similar issue with index record being destroyed by scan interruption (which causes incorrect evaluation of pushed index condition later on).	15 years ago
Sergey Petrunya	1c7c67d584	MWL#121-125 DS-MRR improvements - Address Monty's review feedback, part 6: rename "handler *h" variable in all DS-MRR classes to something else.	15 years ago
Sergey Petrunya	44be131cd3	MWL#121-125 DS-MRR improvements - Address Monty's review feedback, part 5	15 years ago
Michael Widenius	ab5e4eefd5	Fixed some compiler warnings found when compiling for windows. Changed rows_read and rows_sent status variables to be longlong (to avoid compiler warnings) sql/item_func.cc: Fixed wrong usage of alias sql/item_subselect.cc: Changed buffer size to ulonglong to be able detect buffers bigger than size_t sql/item_subselect.h: Changed buffer size to ulonglong to be able detect buffers bigger than size_t sql/multi_range_read.cc: Fixed compiler warning by using correct type for function argument sql/mysqld.cc: Changed rows_read and rows_sent status variables to be longlong sql/opt_subselect.h: Fixed compiler warning by using correct type for function argument sql/sql_class.cc: Changed rows_read and rows_sent status variables to be longlong sql/sql_class.h: Changed rows_read and rows_sent status variables to be longlong Changed max_nulls_in_row to uint as this is number of columns in row. This fixed some compiler warnings. sql/sql_select.cc: Added casts to avoid compiler warnings storage/heap/ha_heap.cc: Initilize different types separate storage/oqgraph/ha_oqgraph.cc: Fixed argument to store(longlong) to avoid compiler warnings	15 years ago
Sergey Petrunya	cee6e4565d	Fix trivial error in previous push	15 years ago
Sergey Petrunya	a6d47ab1d3	Fix buildbot failure: keep rowid_buf_elem_size to its original value, otherwise subsequent asserts have the wrong meaning.	15 years ago
Sergey Petrunya	8604dc78e2	Fix trivial error	15 years ago
Sergey Petrunya	40822c8149	Fix buildbot failure	15 years ago
Sergey Petrunya	92442fc598	Merge MWL#121-125 DS-MRR improvements - Address Monty's review feedback, part 4	15 years ago
Sergey Petrunya	fad2ec7499	MWL#121-125 DS-MRR improvements - Address Monty's review feedback, part 3	15 years ago
Sergey Petrunya	a6c1d56e08	MWL#121-125 DS-MRR improvements - Address Monty's review feedback, part 1 - Fix buildbot failure	15 years ago
Sergey Petrunya	2ec43747f5	Merge MWL#121-125 DS-MRR improvements - Address Monty's review feedback, part 1	15 years ago
Sergey Petrunya	3d698ac616	BUG#671361: virtual int Mrr_ordered_index_reader::refill_buffer(): Assertion `!know_key_tuple_params - Make sure we have enough space for both rowids and keys.	15 years ago
Sergey Petrunya	0fb342ba56	BUG#670417: Diverging results in maria-5.3-mwl128-dsmrr-cpk with join buffer, attempt 4 - Disable identical key handling optimization when IndexConditionPushdown is used	15 years ago
Sergey Petrunya	197c99427d	DS-MRR improvements - Code cleanup - Always propagate the error code we got from storage engine all the way up	15 years ago
Sergey Petrunya	c46450de72	Code cleanup	15 years ago
Sergey Petrunya	1654780f2d	Code cleanup	15 years ago
Sergey Petrunya	59db1d7a39	Address problems uncovered by buildbot - Update test results - Handle the case where MRR implementation doesn't get any key tuples at all	15 years ago
Sergey Petrunya	b76a8595c6	Re-initialization reworked	15 years ago
Sergey Petrunya	430f63c271	use DBUG_RETURN with DBUG_ENTER	15 years ago
Sergey Petrunya	d9a8dd22b2	DS-MRR/CPK improvements: correct buffer exhaustion handling	15 years ago
Sergey Petrunya	8e4c627ef8	DS-MRR improvements: - Correct buffer re-allocation	15 years ago
Sergey Petrunya	1e82320d27	DS-MRR improvements - buildbot test failure fixes: don't try to get more records from SimpleIndexReader if we've already got EOF for it.	15 years ago
Sergey Petrunya	a88bd5cf56	DS-MRR improvements: - address the review feedback (class/var renames) - fix wrong test result (bug in buffer refill logic)	15 years ago
Sergey Petrunya	d8efc3b155	DS-MRR improvements: address review feedback for R3 version of the patch	15 years ago
Igor Babaev	79087c9e07	Ported the fix for bug #57024 (a performance issue for outer joins). Employed the same kind of optimization as in the fix for the cases when join buffer is used. The optimization performs early evaluation of the conditions from on expression with table references to only outer tables of an outer join.	15 years ago
Sergey Petrunya	ac8a79b944	Code cleanup	15 years ago

1 2

96 Commits (2a16e7674b9462586ef883e5678b21c87ca5f045)