mariadb

Tree: 23bfacf1cc

Author	SHA1	Message	Date
Alexey Botchkov	9dadfdcde5	MDEV-14024 PCRE2. Related changes in the server code.	6 years ago
Faustin Lammler	2df2238cb8	Lintian complains on spelling error The lintian check complains on spelling error: https://salsa.debian.org/mariadb-team/mariadb-10.3/-/jobs/95739	7 years ago
Monty	d1851b3009	Code cleanups - Replace "class Repeat_count" with function call. There is no reason for this class to exists. More complex and more code than doing a function! In addition the code didn't match what the val() function was doing. Other things: - Fixed compiler failure in print_cached_tables_callback()	6 years ago
Vlad Lesin	6718d3bc32	MDEV-21082: isnan/isinf compilation errors, isfinite warnings on MacOS The fix consists of three commits backported from 10.3: 1) Cleanup isnan() portability checks (cherry picked from commit `7ffd7fe962`) 2) Cleanup isinf() portability checks Original problem reported by Wlad: re-compilation of 10.3 on top of 10.2 build would cache undefined HAVE_ISINF from 10.2, whereas it is expected to be 1 in 10.3. std::isinf() seem to be available on all supported platforms. (cherry picked from commit `bc469a0bdf`) 3) Use std::isfinite in C++ code This is addition to parent revision fixing build failures. (cherry picked from commit `54999f4e75`)	8 years ago
Roman Nozdrin	ad8266a5c2	MDEV-20732 MDB now correctly estimates a length of the FORMAT() result for doubles in scientific notation with a big integer part.	6 years ago
Alexander Barkov	dc719597ee	MDEV-18156 Assertion `0' failed or `btr_validate_index(index, 0, false)' in row_upd_sec_index_entry or error code 126: Index is corrupted upon DELETE with PAD_CHAR_TO_FULL_LENGTH This change takes into account a column's GENERATED ALWAYS AS expression dependcy on sql_mode's PAD_CHAR_TO_FULL_LENGTH and NO_UNSIGNED_SUBTRACTION flags. Indexed virtual columns as well as persistent generated columns are now not allowed to have such dependencies to avoid inconsistent data or index files on sql_mode changes. So an error is now returned in cases like this: CREATE OR REPLACE TABLE t1 ( a CHAR(5), v VARCHAR(5) AS (a) PERSISTENT -- CHAR->VARCHAR or CHAR->TEXT = ERROR ); Functions RPAD() and RTRIM() can now remove dependency on PAD_CHAR_TO_FULL_LENGTH. So this can be used instead: CREATE OR REPLACE TABLE t1 ( a CHAR(5), v VARCHAR(5) AS (RTRIM(a)) PERSISTENT ); Note, unlike CHAR->VARCHAR and CHAR->TEXT this still works, not RPAD(a) is needed: CREATE OR REPLACE TABLE t1 ( a CHAR(5), v CHAR(5) AS (a) PERSISTENT -- CHAR->CHAR is OK ); More sql_mode flags may affect values of generated columns. They will be addressed separately. See comments in sql_mode.h for implementation details.	6 years ago
Alexander Barkov	20c78a6d3e	Fixing `MDEV-20303 SPACE(-1) returns a wrong data type` compilation problem in Windows	6 years ago
Alexander Barkov	43882e764d	MDEV-20303 SPACE(-1) returns a wrong data type	6 years ago
Alexander Barkov	c3d67c17c1	MDEV-20292 REPEAT(x,-1) returns a wrong data type	6 years ago
Eugene Kosov	d36c107a6b	imporve clang build cmake -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_BUILD_TYPE=Debug Maintainer mode makes all warnings errors. This patch fix warnings. Mostly about deprecated `register` keyword. Too much warnings came from Mroonga and I gave up on it.	6 years ago
Alexander Barkov	ab190194cf	MDEV-19686 Add method Type_handler::dyncol_type	7 years ago
Vicențiu Ciorbaru	5543b75550	Update FSF Address * Update wrong zip-code	7 years ago
Alexander Barkov	3b98c65c4e	MDEV-18881 Assertion `0' failed in make_sortkey upon SELECT with GROUP BY after LOAD DATA	7 years ago
Brave Galera Crew	36a2a185fe	Galera4	7 years ago
Alexey Botchkov	c4ab352b67	MDEV-14576 Include full name of object in message about incorrect value for column. The error message modified. Then the TABLE_SHARE::error_table_name() implementation taken from 10.3, to be used as a name of the table in this message.	7 years ago
Alexander Barkov	4447a02cf1	MDEV-16991 Rounding vs truncation for TIME, DATETIME, TIMESTAMP	7 years ago
Alexander Barkov	5646c43159	MDEV-17216 Assertion `!dt->fraction_remainder(decimals())' failed in Field_temporal_with_date::store_TIME_with_warning The problem happened because {{Field_xxx::store(longlong nr, bool unsigned_val)}} erroneously passed {{unsigned_flag}} to the {{usec}} parameter of this constructor: {code:cpp} Datetime(int *warn, longlong sec, ulong usec, date_conv_mode_t flags) {code} 1. Changing Time and Datetime constructors to accept data as Sec6 rather than as longlong/double/my_decimal, so it's not possible to do such mistakes in the future. Additional good effect of these changes: - This reduced some amount of similar code (minus ~35 lines). - The code now does not rely on the fact that "unsigned_flag" is not important inside Datetime(). The constructor always gets all three parts: sign, integer part, fractional part. The simple the better. 2. Fixing Field_xxx::store() to use the new Datetime constructor format. This change actually fixes the problem. 3. Adding "explicit" keyword to all Sec6 constructors, to avoid automatic hidden conversion from double/my_decimal to Sec6, as well as from longlong/ulonglong through double to Sec6. 4. Change#1 caused (as a dependency) changes in a few places with code like this: bool neg= nr < 0 && !unsigned_val; ulonglong value= m_neg ? (ulonglong) -nr : (ulonglong) nr; These fragments relied on a non-standard behavior with the operator "minus" applied to the lowest possible negative signed long long value. This can lead to different results depending on the platform and compilation flags. We have fixed such bugs a few times already. So instead of modifying the old wrong code to a new wrong code, replacing all such fragments to use Longlong_hybrid, which correctly handles this special case with -LONGLONG_MIN in its method abs(). This also reduced the amount of similar code (1 or 2 new lines instead 3 old lines in all 6 such fragments). 5. Removing ErrConvInteger(longlong nr, bool unsigned_flag= false) and adding ErrConvInteger(Longlong_hybrid) instead, to encourage use of safe Longlong_hybrid instead of unsafe pairs nr+neg. 6. Removing unused ErrConvInteger from Item_cache_temporal::get_date()	7 years ago
Michael Widenius	6c97e85673	Remove valgrind warnings from Item_str_concat This warning come from a copy() operation of type: memcpy(ptr, ptr+A, B), which is safe but produces a warning when run with valgrind. To avoid the warning, I added copy_or_move() method which uses memmove() instead of memcpy(). In 10.3 the change in item_strfunc::Item_func_concat() has to be mirroed in Item_func_concat_oracle() to avoid future valgrind warnings.	7 years ago
Alexander Barkov	ad8e02ac45	MDEV-17317 Add THD* parameter into Item::get_date() and stricter data type control to "fuzzydate"	7 years ago
Alexander Barkov	cb7b5fbf1c	MDEV-16910 Add class VDec Adding classes VDec and VDec2_lazy, according to the task description. This patch removes around 250 duplicate code lines.	7 years ago
Oleksandr Byelkin	7749745b7d	Fix of type, to make windows compiler happy.	7 years ago
Alexander Barkov	e2ac4098ed	Simplify caseup() and casedn() in charsets After the MDEV-13118 fix there's no code in the server that wants caseup/casedn to change the argument in place for simple charsets. Let's remove this logic and always return the result in a new string for all charsets, both simple and complex. 1. Removing the optimization that some character sets used in casedn() and caseup(), which allowed (and required) to change the case in-place, overwriting the string passed as the "src" argument. Now all CHARSET_INFO's work in the same way: non of them change the source string in-place, all of them now convert case from the source string to the destination string, leaving the source string untouched. 2. Adding "const" qualifier to the "char src" parameter to caseup() and casedn(). 3. Removing duplicate implementations in ctype-mb.c. Now both caseup() and casedn() implementations for all CJK character sets use internally the same function my_casefold_mb() (the former my_casefold_mb_varlen()). 4. Removing the "unused" attribute from parameters of some my_case{up\|dn}_xxx() implementations, as the affected parameters are now used* in the code. Previously these parameters were used only in DBUG_ASSERT().	7 years ago
Alexander Barkov	ab58493db2	MDEV-13118 Wrong results with LOWER and UPPER and subquery This problem is similar to MDEV-10306. 1. Fixing Item_str_conv::val_str(String *str) to return the result in "str", and to use tmp_value only as a temporary buffer for args[0]->val_str(). The new code version now guarantees that the result is always returned in "str". The trick with copy_if_not_alloced() is not used any more. 2. The change #1 revealed the same problem in SUBSTRING_INDEX(), so some tests with combinations of UPPER()/LOWER() and SUBSTRING_INDEX() started to fail. Fixing Item_func_substr_index::val_str() the same way, to return the result in "str" and use tmp_value as a temporary buffer for args[0]->val_str().	7 years ago
Monty	a9ca819897	Call alloc() instead of realloc() Use alloc() if we don't need original string (avoid copy) Removed not needed test of str_length in sql_string.cc	7 years ago
Oleksandr Byelkin	6b8802e8dd	MDEV-11071: Assertion `thd->transaction.stmt.is_empty()' failed in Locked_tables_list::unlock_locked_table fix_length_and_dec now return result (error/OK)	8 years ago
Sergey Vojtovich	54999f4e75	Use std::isfinite in C++ code This is addition to parent revision fixing build failures.	8 years ago
Sergei Golubchik	e17e798599	cleanup: simplify multi-update's juggling with positions introduce Item_temptable_rowid() that is used to store table->file->position() in the temporary table record	8 years ago
Monty	30ebc3ee9e	Add likely/unlikely to speed up execution Added to: - if (error) - Lex - sql_yacc.yy and sql_yacc_ora.yy - In header files to alloc() calls - Added thd argument to thd_net_is_killed()	8 years ago
Marko Mäkelä	39a4985520	Remove most 'register' use in C++ Modern compilers (such as GCC 8) emit warnings that the 'register' keyword is deprecated and not valid C++17. Let us remove most use of the 'register' keyword. Code in 'extra/' is not touched.	8 years ago
halfspawn	209375fdd0	MDEV-15664 : sql_mode=ORACLE: Make TRIM return NULL instead of empty string	8 years ago
Alexander Barkov	068450a382	MDEV-15689 Fix Item_func_set_collation to pass the collation using CHARSET_INFO instead of Item Main changes: - Changing the constructor to accept a CHARSET_INFO pointer, instead of an Item pointer - Updating the bison grammar accordingly Additional cleanups: - Simplifying Item_func_set_collation::eq() by reusing Item_func::eq() - Removing unused binary_keyword	8 years ago
Alexander Barkov	6aff5fa27a	MDEV-15619 using CONVERT() inside AES_ENCRYPT() in an UPDATE corrupts data	8 years ago
Vladislav Vaintroub	56e7b7eaed	Make possible to use clang on Windows (clang-cl) -DWITH_ASAN can be used as well now, on x64 Fix many clang-cl warnings.	8 years ago
Vladislav Vaintroub	6c279ad6a7	MDEV-15091 : Windows, 64bit: reenable and fix warning C4267 (conversion from 'size_t' to 'type', possible loss of data) Handle string length as size_t, consistently (almost always:)) Change function prototypes to accept size_t, where in the past ulong or uint were used. change local/member variables to size_t when appropriate. This fix excludes rocksdb, spider,spider, sphinx and connect for now.	8 years ago
Monty	f55dc7f733	Change C_STRING_WITH_LEN to STRING_WITH_LEN This preserves const str for constant strings Other things - A few variables where changed from LEX_STRING to LEX_CSTRING - Incident_log_event::Incident_log_event and record_incident where changed to take LEX_CSTRING* as an argument instead of LEX_STRING	8 years ago
Monty	a7e352b54d	Changed database, tablename and alias to be LEX_CSTRING This was done in, among other things: - thd->db and thd->db_length - TABLE_LIST tablename, db, alias and schema_name - Audit plugin database name - lex->db - All db and table names in Alter_table_ctx - st_select_lex db Other things: - Changed a lot of functions to take const LEX_CSTRING* as argument for db, table_name and alias. See init_one_table() as an example. - Changed some function arguments from LEX_CSTRING to const LEX_CSTRING - Changed some lists from LEX_STRING to LEX_CSTRING - threads_mysql.result changed because process list_db wasn't always correctly updated - New append_identifier() function that takes LEX_CSTRING* as arguments - Added new element tmp_buff to Alter_table_ctx to separate temp name handling from temporary space - Ensure we store the length after my_casedn_str() of table/db names - Removed not used version of rename_table_in_stat_tables() - Changed Natural_join_column::table_name and db_name() to never return NULL (used for print) - thd->get_db() now returns db as a printable string (thd->db.str or "")	8 years ago
Alexander Barkov	c4a908cb56	MDEV-13790 UNHEX() of a somewhat complicated CONCAT() returns NULL	8 years ago
Alexander Barkov	02e35ef5f2	MDEV-12681 Wrong VIEW results for CHAR(0xDF USING latin1)	8 years ago
Oleksandr Byelkin	2913f615f0	MDEV-8949: COLUMN_CREATE unicode name breakage Use utf-mb4 if it is possible.	8 years ago
Sergei Golubchik	d76f5774fe	MDEV-13459 Warnings, when compiling with gcc-7.x mostly caused by -Wimplicit-fallthrough	8 years ago
halfspawn	34f36a335b	MDEV-14012 - sql_mode=Oracle: substr(): treat position 0 as position 1	8 years ago
Vladislav Vaintroub	7354dc6773	MDEV-13384 - misc Windows warnings fixed	8 years ago
Sergei Golubchik	80b9ce3593	MDEV-11553 Can't restore a PERSISTENT column that uses DATE_FORMAT() 3-argument form of DATE_FORMAT	8 years ago
Sergei Golubchik	8b1f145c82	cleanup Item_func_format::print() was redundant and other changes	8 years ago
Sreeharsha Ramanavarapu	ad00de4077	Bug #26704451 : INCORRECT BEHAVIOR WITH USE OF CERTAIN CHARSETS AND SHA2 Missed pushing to 5.5.	8 years ago
Sergey Vojtovich	fdc4779235	MDEV-11371 - column compression Storage engine independent support for column compression. TINYBLOB, BLOB, MEDIUMBLOB, LONGBLOB, TINYTEXT, TEXT, MEDIUMTEXT, LONGTEXT, VARCHAR and VARBINARY columns can be compressed. New COMPRESSED column attribute added: COMPRESSED[=<compression_method>] System variables added: column_compression_threshold column_compression_zlib_level column_compression_zlib_strategy column_compression_zlib_wrap Status variables added: Column_compressions Column_decompressions Limitations: - the only supported method currently is zlib - CSV storage engine stores data uncompressed on-disk even if COMPRESSED attribute is present - it is not possible to create indexes over compressed columns.	9 years ago
Michael Widenius	4aaa38d26e	Enusure that my_global.h is included first - Added sql/mariadb.h file that should be included first by files in sql directory, if sql_plugin.h is not used (sql_plugin.h adds SHOW variables that must be done before my_global.h is included) - Removed a lot of include my_global.h from include files - Removed include's of some files that my_global.h automatically includes - Removed duplicated include's of my_sys.h - Replaced include my_config.h with my_global.h	8 years ago
Alexander Barkov	a70809c0fc	MDEV-13555 Assertion `!item->null_value' failed in Type_handler::Item_send_str	8 years ago
halfspawn	c9981fbee2	MDEV-13003 - Oracle compatibility : Replace function	9 years ago
Sergei Golubchik	2fcd8c1252	MDEV-13173 An RLIKE that previously worked on 10.0 now returns "Got error 'pcre_exec: recursion limit of 100 exceeded' from regexp" 1. use Regexp_processor_pcre::set_recursion_limit() to set the recursion limit depending on the current available stack size 2. make pcre stack frame to be estimated no less than 500 bytes. sometimes pcre estimates it too low, even though the manual says 500+16 bytes (it was estimated only 188 for me, actual frame size was 512). 3. do it for embedded too	8 years ago

1 2 3 4 5 ...

1900 Commits (23bfacf1cceb213111556ddb43c55e7c2eeb98e7)