mariadb

Tree: 16fb2963ff

Author	SHA1	Message	Date
Sergei Golubchik	241294b53a	MDEV-6854 Typo in cmake/plugin.cmake	11 years ago
Alexander Barkov	e52b1637e0	MDEV-6950 Bad results with joins comparing DATE/DATETIME and INT/DECIMAL/DOUBLE/ENUM/VARCHAR columns MDEV-6971 Bad results with joins comparing TIME and DOUBLE/DECIMAL columns Disallow using indexes on non-temporal columns to optimize ref access, range access and table elimination when the counterpart's cmp_type is TIME_RESULT, e.g.: SELECT * FROM t1 WHERE indexed_int_column=time_expression; Only index on a temporal column can be used to optimize temporal comparison operations.	11 years ago
Alexander Barkov	807934d083	MDEV-7086 main.ctype_cp932 fails in buildbot on a valgrind build Removing a redundant and wrong condition which could access beyond the pattern string range.	11 years ago
unknown	4d882329a9	MDEV-7116: Dynamic column hangs/segfaults Going to 'create_new_string:' caused double freeing alloc_plan (there and at 'end:').	11 years ago
Kristian Nielsen	e9fc98b583	MDEV-7121: Parallel slave may hang if master crashes in the middle of writing transaction to binlog When a master server restarts, it writes a restart format_description event as the first event in the next binlog file. The parallel slave SQL thread queues a special restart entry for the current worker thread to signal this, so that the worker thread can roll back any prior partial transaction that might have been written to the binlog due to master crashing. This queueing was missing a mysql_cond_signal() to notify the worker thread. This could cause the worker thread to not process the restart entry, and this in turn would cause the SQL thread to hang infinitely waiting for the worker thread to complete processing. Fix by adding the missing wakeup signalling for this case.	11 years ago
Kristian Nielsen	f976050793	MDEV-7079: rpl.rpl_parallel_temptable fails in valgrind builder The test case rpl.rpl_parallel_temptable deliberately crashes the master server as part of the testing. This makes it unsuitable for Valgrind testing. So make sure that it will be skipped when testing with Valgrind.	11 years ago
Kristian Nielsen	7671fd70c0	MDEV-7080: rpl.rpl_gtid_crash fails sporadically in buildbot The real problem here was inconsistent handling of entry->commit_errno in MYSQL_BIN_LOG::write_transaction_or_stmt(). Some return paths were setting it to the value of errno, some where not. And the setting was redundant anyway, as it is set consistently by the caller. Fix by consistently setting it in the caller, and not in each return path in the function. The test failure happened because a DBUG_EXECUTE_IF() used in the test case set an entry->commit_errno that was immediately overwritten in the caller with whatever happened to be the value of errno. This could lead to different error message in the .result file.	11 years ago
Olivier Bertrand	cfa872f6c8	- Commit resolved conflicted files modified: storage/connect/engmsg.h storage/connect/filamtxt.cpp	11 years ago
Olivier Bertrand	b9165cb58d	- Remove gcc warning (no previous declaration of msglang) modified: storage/connect/ha_connect.cc - Define strcasecmp for Linux modified: storage/connect/rcmsg.c - Avoid potential buffer overflow modified: storage/connect/plgdbutl.cpp - Change %d in %lld in VALUE_TOO_BIG message modified: storage/connect/encas.h storage/connect/english.msg storage/connect/frcas.h storage/connect/french.msg storage/connect/frmsg.h	11 years ago
Alexey Botchkov	c9742ceac5	MDEV-6883 ST_WITHIN crashes server if (0,0) is matched to POLYGON((0 0)). Fixed the case when a polygon contains a single-point ring.	11 years ago
Olivier Bertrand	5d8311960a	- Implement the NEWMSG and XMSG methods They are still experimental and should not be used in production. added: storage/connect/encas.h storage/connect/english.msg storage/connect/enids.h storage/connect/frcas.h storage/connect/french.msg storage/connect/frids.h storage/connect/frmsg.h modified: storage/connect/connect.cc storage/connect/engmsg.h storage/connect/filamdbf.cpp storage/connect/global.h storage/connect/ha_connect.cc storage/connect/msgid.h storage/connect/plgdbutl.cpp storage/connect/plugutil.c storage/connect/rcmsg.c storage/connect/resource.h storage/connect/tabfmt.h - Fix global variable not being properly initialized (MDEV-6690, MDEV-7094) modified: storage/connect/ha_connect.cc storage/connect/plugutil.c storage/connect/user_connect.cc storage/connect/xindex.cpp - Implement Rewind for ODBC tables (MDEV-7097) modified: storage/connect/odbconn.cpp storage/connect/odbconn.h storage/connect/tabmysql.cpp storage/connect/tabodbc.cpp - Reset N when reopening MYSQL tables modified: storage/connect/tabmysql.cpp	11 years ago
Rich Prohaska	4555904b16	Merge branch 'master' into releases/tokudb-7.5	11 years ago
Rich Prohaska	3fbe68e6f8	DB-754 build with bundled jemalloc	11 years ago
Jan Lindström	b7d32e053d	MDEV-7083: sys_vars.innodb_sched_priority* tests fail in buildbot on work-amd64-valgrind Fixed issue by finding out first the current used priority for both treads and using that seeing did we really change the priority or not.	11 years ago
Rich Prohaska	a4e20cfd46	Merge branch 'master' into releases/tokudb-7.5	11 years ago
Rich Prohaska	50b928b046	DB-759 test and fix alter table bug with cardinality data	11 years ago
Sergei Golubchik	81d7e2f61c	MDEV-7003 test-alter-table crashes debug build due to double free of plugin correct the buffer boundary check	11 years ago
Sergei Golubchik	6a2c170141	MDEV-6849 ON UPDATE CURRENT_TIMESTAMP doesn't always work reset default fields not for every modified row, but only once, at the beginning, as the set of modified fields doesn't change. exception: INSERT ... ON DUPLICATE KEY UPDATE - the set of fields does change per row and in that case we reset default fields per row.	11 years ago
Sergey Petrunya	50c5339272	MDEV-7068: MRR accessing uninitialised bytes, test case failure main.innodb_mrr Backport to 5.3: - Don't call index_reader->interrupt_read() if the index reader has returned all rows that matched its keys.	11 years ago
Kristian Nielsen	26b1113032	MDEV-6917: Parallel replication: "Commit failed due to failure of an earlier commit on which this one depends", but no prior failure seen This bug was seen when parallel replication experienced a deadlock between transactions T1 and T2, where T2 has reached the commit phase and is waiting for T1 to commit first. In this case, the deadlock is broken by sending a kill to T2; that kill error is then later detected and converted to a deadlock error, which causes T2 to be rolled back and retried. The problem was that the kill caused ha_commit_trans() to errorneously call wakeup_subsequent_commits() on T3, signalling it to abort because T2 failed during commit. This is incorrect, because the error in T2 is only a temporary error, which will be resolved by normal transaction retry. We should not signal error to the next transaction until we have executed the code that handles such temporary errors. So this patch just removes the calls to wakeup_subsequent_commits() from ha_commit_trans(). They are incorrect in this case, and they are not needed in general, as wakeup_subsequent_commits() must in any case be called in finish_event_group() to wakeup any transactions that may have started to wait after ha_commit_trans(). And normally, wakeup will in fact have happened earlier, either from the binlog group commit code, or (in case of no binlogging) after the fast part of InnoDB/XtraDB group commit. The symptom of this bug was that replication would break on some transaction with "Commit failed due to failure of an earlier commit on which this one depends", but with no such failure of an earlier commit visible anywhere.	11 years ago
Kristian Nielsen	3dcd01e5e6	MDEV-7065: Incorrect relay log position in parallel replication after retry of transaction The retry of an event group in parallel replication set the wrong value for the end log position of the event that was retried (qev->future_event_relay_log_pos). It was too large by the size of the event, so it pointed into the middle of the following event. If the retry happened in the very last event of the event group, _and_ the SQL thread was stopped just after successfully retrying that event, then the SQL threads's relay log position would be left incorrect. Restarting the SQL thread could then try to read events from a garbage offset in the relay log, usually leading to an error about not being able to read the event.	11 years ago
Kristian Nielsen	d08b893b39	MDEV-6775: Wrong binlog order in parallel replication: Intermediate commit The code in binlog group commit around wait_for_commit that controls commit order, did the wakeup of subsequent commits early, as soon as a following transaction is put into the group commit queue, but before any such commit has actually taken place. This causes problems with too early wakeup of transactions that need to wait for prior to commit, but do not take part in the binlog group commit for one reason or the other. This patch solves the problem, by moving the wakeup to happen only after the binlog group commit is completed. This requires a new solution to ensure that transactions that arrive later than the leader are still able to participate in group commit. This patch introduces a flag wait_for_commit::commit_started. When this is set, a waiter can queue up itself in the group commit queue. This way, effectively the wait_for_prior_commit() is skipped only for transactions that participate in group commit, so that skipping the wait is safe. Other transactions still wait as needed for correctness.	11 years ago
Kristian Nielsen	eec04fb4f6	MDEV-6680: Performance of domain_parallel replication is disappointing The code that handles free lists of various objects passed to worker threads in parallel replication handles freeing in batches, to avoid taking and releasing LOCK_rpl_thread too often. However, it was possible for freeing to be delayed to the point where one thread could stall the SQL driver thread due to full queue, while other worker threads might be idle. This could significantly degrade possible parallelism and thus performance. Clean up the batch freeing code so that it is more robust and now able to regularly free batches of object, so that normally the queue will not run full unless the SQL driver thread is really far ahead of the worker threads.	11 years ago
Kristian Nielsen	8a3e2f29bb	MDEV-6718: Server crashed in Gtid_log_event::Gtid_log_event with parallel replication The bug occured in parallel replication when re-trying transactions that failed due to deadlock. In this case, the relay log file is re-opened and the events are read out again. This reading requires a format description event of the appropriate version. But the code was using a description event stored in rli, which is not thread-safe. This could lead to various rare races if the format description event was replaced by the SQL driver thread at the exact moment where a worker thread was trying to use it. The fix is to instead make the retry code create and maintain its own format description event. When the relay log file is opened, we first read the format description event from the start of the file, before seeking to the current position. This now uses the same code as when the SQL driver threads starts from a given relay log position. This also makes sure that the correct format description event version will be used in cases where the version of the binlog could change during replication.	11 years ago
Kristian Nielsen	a98a034c5e	MDEV-7102: Incorrect PSI_stage_info message in SHOW PROCESSLIST during parallel replication In parallel replication, threads can do two different waits for a prior transaction. One is for the prior transaction to start commit, the other is for it to complete commit. It turns out that the same PSI_stage_info message was errorneously used in both cases (probably a merge error), causing SHOW PROCESSLIST to be misleading. Fix by using correct, distinct message in each case.	11 years ago
Kristian Nielsen	ecc33da2ca	Fix a confusing error message in the testsuite	11 years ago
Kristian Nielsen	684715a269	MDEV-6775: Wrong binlog order in parallel replication In parallel replication, the wait_for_commit facility is used to ensure that events are written into the binlog in the correct order. This is handled in an optimised way in the binlogging group commit code. However, some statements, for example GRANT, are written directly into the binlog, outside of the group commit code. There was a bug that this direct write does not correctly wait for the prior transactions to have been written first, which allows f.ex. GRANT to be written ahead of earlier transactions. This patch adds the missing wait_for_prior_commit() before writing directly to the binlog. However, the problem is still there, although the race is much less likely to occur now. The problem is that the optimised group commit code does wakeup of following transactions early, before the binlog write is actually done. A woken-up following transaction is then allowed to run ahead and queue up for the group commit, which will ensure that binlog write happens in correct order in the end. However, the code for directly written events currently bypass this mechanism, so they get woken up and written too early. This will be fixed properly in a later patch.	11 years ago
Kristian Nielsen	55791c1a77	Revert incorrect/redundant fix for old BUG#34656 The real bug was that open_tables() returned error in case of thd->killed() without properly calling thd->send_kill_message() to set the correct error. This was fixed some time ago. So remove the, now redundant, extra checks for thd->is_error(), possibly allowing to catch in debug builds more incorrect error handling cases.	11 years ago
Kristian Nielsen	fbc8768ce5	MDEV-7101: SAFE_MUTEX lock order warning when reusing wait_for_commit mutex In SAFE_MUTEX builds, reset the wait_for_commit mutex (destroy and re-initialise), so that SAFE_MUTEX lock order check does not become confused when the mutex is re-used for a different purpose.	11 years ago
Jan Lindström	0f32299437	MDEV-7035: Remove innodb_io_capacity setting depending on setting of innodb_io_capacity_max (a) Changed the behaviour so that if you set innodb_io_capacity to a value > innodb_io_capacity_max that the value is accepted AND that innodb_io_capacity_max = innodb_io_capacity * 2. (b) If someone wants to reduce innodb_io_capacity_max and reduce it below innodb_io_capacity then innodb_io_capacity should be reduced to the same level as innodb_io_capacity_max. In both cases give a warning to user.	11 years ago
Jan Lindström	bff2d46bf7	MDEV-7100: InnoDB error monitor might unnecessary wait log_sys mutex Analysis: InnoDB error monitor is responsible to call every second sync_arr_wake_threads_if_sema_free() to wake up possible hanging threads if they are missed in mutex_signal_object. This is not possible if error monitor itself is on mutex/semaphore wait. We should avoid all unnecessary mutex/semaphore waits on error monitor. Currently error monitor calls function buf_flush_stat_update() that calls log_get_lsn() function and there we will try to get log_sys mutex. Better, solution for error monitor is that in buf_flush_stat_update() we will try to get lsn with mutex_enter_nowait() and if we did not get mutex do not update the stats. Fix: Use log_get_lsn_nowait() function on buf_flush_stat_update() function. If returned lsn is 0, we do not update flush stats. log_get_lsn_nowait() will use mutex_enter_nowait() and if we get mutex we return a correct lsn if not we return 0.	11 years ago
Jan Lindström	84f3f3fa1e	MDEV-7083: sys_vars.innodb_sched_priority* tests fail in buildbot on work-amd64-valgrind. Fixed issue by finding out first the current used priority for both treads and using that seeing did we really change the priority or not.	11 years ago
Rich Prohaska	2494bde757	DB-759 fix tokudb::alter_card to copy ALL of the cardinality data not just the low byte	11 years ago
Rich Prohaska	8a7f07711e	increase test coverage of the cardinality code	11 years ago
Rich Prohaska	ca67239c51	speed up tokudb handler unit tests	11 years ago
Jan Lindström	da52110497	MDEV-7070: rpl.rpl_innodb_bug68220 fails in buildbot	11 years ago
Rich Prohaska	fa92c90393	speed up tokudb handler unit tests	11 years ago
Elena Stepanova	a1dfaa28a1	MDEV-7073 main.information_schema and main.information_schema_all_engines fail in buildbot on a build without perfschema main.information_schema: added a condition to the query to exclude perfschema tables main.information_schema_all_engines: added a call to the include file to check for the presence of perfschema	11 years ago
Elena Stepanova	62bea520f9	MDEV-7072 mroonga/wrapper.version_56_or_later_performance_schema fails in buildbot on a build without perfschema Added a call for the include file to check for the presence of perfschema	11 years ago
Elena Stepanova	570c771bc7	MDEV-7071 Spider tests fail due to an unknown option --skip-performance-schema on a build without perfschema Made the option --loose	11 years ago
Elena Stepanova	aee7e67101	MDEV-7075 perfschema.mks_timer-6258 test not skipped on builds without perfschema Added a call for the include file	11 years ago
Sergey Petrunya	9578a332a2	Fix buildbot failure: make selectivity.test and selectivity_innodb.test work when table names are case-insensitive.	11 years ago
Sergei Golubchik	815667086c	sql_update.cc: always update default fields after compare_record() (it was after in two cases and before in one case)	11 years ago
Rich Prohaska	7b269f8a06	Merge branch 'master' into releases/tokudb-7.5	11 years ago
Rich Prohaska	43c176a779	speed up tokudb handler unit tests	11 years ago
Sergei Golubchik	c4598ce300	MDEV-6862 "#error <my_config.h>" and third-party libraries only enforce the include order if SAFE_MUTEX is defined (that is, in MariaDB source builds in debug mode)	11 years ago
Alexander Barkov	9e8202013a	MDEV-6965 non-captured group \2 in regexp_replace	11 years ago
Olivier Bertrand	9ade2d088d	- FIX ftell error when the line endings do not match the declared or default ending. Also takes care of files having mixed line endings. This is done by never using text mode for streams and handle the line endings in reading and writing. (MDEV-7030) modified: storage/connect/filamtxt.cpp	11 years ago
Rich Prohaska	0e6a4915e1	Merge branch 'master' into releases/tokudb-7.5	11 years ago
Sergei Golubchik	360c49c1b9	MDEV-6179: dynamic columns functions/cast()/convert() doesn't play nice with CREATE/ALTER TABLE When parsing a field declaration, grab type information from LEX before it's overwritten by further rules. Pass type information through the parser stack to the rule that needs it.	11 years ago

1 2 3 4 5 ...

89829 Commits (16fb2963ff497b7c0b6371a3bd3f0345dc625815) All Branches Search

89829 Commits (16fb2963ff497b7c0b6371a3bd3f0345dc625815)

All Branches