mariadb

Tree: 16fadb10b5

Author	SHA1	Message	Date
Georgi Kodinov	16fadb10b5	Bug #52629 : memory leak from sys_var_thd_dbug in binlog.binlog_write_error When re-setting (SET GLOBAL debug='') the GLOBAL debug settings the server was not freeing the data elements from the top (initial) frame before setting them to 0 without freeing the underlying memory. As these are global settings there's a chance that something is there already. Fixed by : 1. making sure the allocated data are cleaned up before re-setting them while parsing a debug string 2. making sure the stuff allocated in the global settings is freed on shutdown.	16 years ago
Luis Soares	8fa9a5861b	automerge: merged bug clone into latest mysql-5.1-bugteam.	16 years ago
Georgi Kodinov	d066fe78e7	merge	16 years ago
Sergey Vojtovich	c37bfe0ae6	Merge fix for BUG39053 to 5.1-bugteam.	16 years ago
Sergey Vojtovich	4aa36ee7b6	BUG#39053 - UNISTALL PLUGIN does not allow the storage engine to cleanup open connections It was possible to UNINSTALL storage engine plugin when binding between THD object and storage engine is still active (e.g. in the middle of transaction). To avoid unclean deactivation (uninstall) of storage engine plugin in the middle of transaction, additional storage engine plugin lock is acquired by thd_set_ha_data(). If ha_data is not null and storage engine plugin was not locked by thd_set_ha_data() in this connection before, storage engine plugin gets locked. If ha_data is null and storage engine plugin was locked by thd_set_ha_data() in this connection before, storage engine plugin lock gets released. If handlerton::close_connection() didn't reset ha_data, server does it immediately after calling handlerton::close_connection(). Note that this is just a framework fix, storage engines must switch to thd_set_ha_data() from thd_ha_data() if they want to see fit. include/mysql/plugin.h: As thd_{get\|set}_ha_data() have some extra logic now, they must be implemented on server side. include/mysql/plugin.h.pp: As thd_{get\|set}_ha_data() have some extra logic now, they must be implemented on server side. sql/handler.cc: Make sure ha_data is reset and ha_data lock is released. sql/handler.h: hton is not supposed to be updated by ha_lock_engine(), make it const. sql/sql_class.cc: As thd_{get\|set}_ha_data() have some extra logic now, they must be implemented on server side. sql/sql_class.h: Added ha_data lock.	16 years ago
unknown	edb8a7b2f8	Merge from mysql-5.1.43sp1-release	16 years ago
Georgi Kodinov	f34a731b6a	Bug #43594 : mysqlhotcopy does not ignore log tables and others in mysql database Added a filter to mysqlhotcopy to filter out the same tables in the 'mysql' database that mysqldump filters out.	16 years ago
Davi Arnaut	97afbf5a27	Backport revision alik@sun.com-20100223131824-comthndat57kx8s5: Add ignore pattern for valgrind messages.	16 years ago
Georgi Kodinov	83dfeb2435	Bug #47095 : Can't open_files_limit really be larger than 65535? Several problems addressed: 1. The maximum value for --open_files_limit on non-windows boxes is now raised to UINT_MAX (the maximum possible without significant changes in the code). The maximum value on windows is kept to be 2048 due to a known limitation (bug 24509). 2. mysqld_safe now supports --open_files_limit=xx in addition to --open-files-limit=xx 3. mysqld_safe always passes through --open[_-]files[_-]limit to the underlying mysqld. It used to pass it through only if it the user running the script has access to the root directory or there was an --user argument specified. 4. Fixed a prototype in my_file.c to match its counterpart in the other #ifdef branch.	16 years ago
Omer BarNir	1008fd89c4	Correction to the disabled.def file in engines/iuds that got overwritten by mistake in previous push	16 years ago
Omer BarNir	9a5d2d63f9	Updates to test files in the 'engines' suite following changes in 5.1.46	16 years ago
unknown	7357c325b9	Raise version number after cloning 5.1.46	16 years ago
Georgi Kodinov	c9cfd2df5f	merge	16 years ago
Georgi Kodinov	e1dbabba15	merge	16 years ago
Sergey Glukhov	ba229d799a	Bug#52120 create view cause Assertion failed: 0, file .\item_subselect.cc, line 817 We should disable const subselect item evaluation because subselect transformation does not happen in view_prepare_mode and thus val_...() methods can not be called. mysql-test/r/ctype_ucs.result: test case mysql-test/r/view.result: test case mysql-test/t/ctype_ucs.test: test case mysql-test/t/view.test: test case sql/item.cc: disabled const subselect item evaluation in view prepare mode. sql/item_subselect.cc: added Item_subselect::safe_charset_converter which prevents const item evaluation in view prepare mode. sql/item_subselect.h: added Item_subselect::safe_charset_converter which prevents const item evaluation in view prepare mode.	16 years ago
Georgi Kodinov	01fb1c8938	merge	16 years ago
Georgi Kodinov	031d698c58	changed the version back	16 years ago
Sergey Glukhov	c1ad5072b8	Bug#52336 Segfault / crash in 5.1 copy_fields (param=0x9872980) at sql_select.cc:15355 The problem is that we can not use make_cond_for_table(). This function relies on used_tables() condition which is not set properly for subqueries. As result subquery is not filtered out. The fix is to use remove_eq_conds() function instead of make_cond_for_table() func. 'remove_eq_conds()' algorithm relies on const_item() value and it allows to handle subqueries in right way. mysql-test/r/having.result: test case mysql-test/t/having.test: test case sql/sql_select.cc: The fix is to use remove_eq_conds() function instead of make_cond_for_table() function.	16 years ago
Gleb Shchepa	e2a546aef4	Bug #40625 : Concat fails on DOUBLE values in a Stored Procedure, while DECIMAL works Selecting of the CONCAT(...<SP variable>...) result into a user variable may return wrong data. Item_func_concat::val_str contains a number of memory allocation-saving tricks. One of them concatenates strings inplace inserting the value of one string at the beginning of the other string. However, this trick didn't care about strings those points to the same data buffer: this is possible when a CONCAT() parameter is a stored procedure variable - Item_sp_variable::val_str() uses the intermediate Item_sp_variable::str_value field, where it may store a reference to an external buffer. The Item_func_concat::val_str function has been modified to take into account val_str functions (such as Item_sp_variable::val_str) that return a pointer to an internal Item member variable that may reference to a buffer provided. mysql-test/r/func_concat.result: Test case for the bug #40625. mysql-test/t/func_concat.test: Test case for the bug #40625. sql/item_strfunc.cc: Bug #40625: Concat fails on DOUBLE values in a Stored Procedure, while DECIMAL works The Item_func_concat::val_str function has been modified to take into account val_str functions (such as Item_sp_variable::val_str) that return a pointer to an internal Item member variable that may reference to a buffer provided.	16 years ago
Anurag Shekhar	ab8ff15cd1	Bug #47904 Incorrect results w/ table subquery, derived SQs, and LEFT JOIN on index 'my_decimal' class has two members which can be used to access the value. The member variable buf (inherited from parent class decimal_t) is set to member variable buffer so that both are pointing to same value. Item_copy_decimal::copy() uses memcpy to clone 'my_decimal'. The member buffer is declared as an array and memcpy results in copying the values of the array, but the inherited member buf, which should be pointing at the begining of the array 'buffer' starts pointing to the begining of buffer in original object (which is being cloned). Further updates on 'my_decimal' updates only the inherited member 'buf' but leaves buffer unchanged. Later when the new object (which now holds a inconsistent value) is cloned again using proper cloning function 'my_decimal2decimal' the buf pointer is fixed resulting in loss of the current value. Using my_decimal2decimal instead of memcpy in Item_copy_decimal::copy() fixed this problem. mysql-test/r/subselect.result: Updated result file after addding test case for bug#47904. mysql-test/t/subselect.test: Added test case for bug#47904. sql/item.cc: Memcopy shouldn't be used to clone my_decimal. Use my_decimal2decimal instead.	16 years ago
Sergey Vojtovich	40de15baa1	Merge fix for BUG40980 to mysql-5.1-bugteam.	16 years ago
Sergey Vojtovich	0dec4ecd07	Merge innodb-zip-ss6900 to mysql-5.1-bugteam.	16 years ago
Sergey Vojtovich	ab1242b9e3	BUG#40980 - Drop table can remove another MyISAM table's data and index files It was possible if DATA/INDEX DIRECTORY is pointing to symlinked MySQL data home directory. Do not allow to drop data/index files implicitly symlinked to data home directory. For such tables remove symlink only. mysql-test/r/symlink.result: A test case for BUG#40980. mysql-test/t/symlink.test: A test case for BUG#40980. storage/myisam/mi_delete_table.c: Do not allow to drop data/index files implicitly symlinked to data home directory. For such tables remove symlink only.	16 years ago
Sergey Vojtovich	377078eaf0	Applying InnoDB snapshot Detailed revision comments: r6900 \| mmakela \| 2010-03-29 13:54:57 +0300 (Mon, 29 Mar 2010) \| 5 lines branches/zip: Merge c6899 from branches/innodb+: Add debug assertions to track down Bug #52360. hash_table_t::magic_n: Add HASH_TABLE_MAGIC_N checks, which were fully absent. ut_hash_ulint(): Assert table_size > 0 before division.	16 years ago
Sergey Vojtovich	ec271fd3c7	Applying InnoDB snapshot Detailed revision comments: r6897 \| mmakela \| 2010-03-29 11:36:19 +0300 (Mon, 29 Mar 2010) \| 3 lines branches/zip: innodb_mutex_show_status(): Fix a condition that was accidentally negated in r6781, making SHOW ENGINE INNODB MUTEX STATUS display only locks with no OS waits.	16 years ago
Sergey Vojtovich	0aa607e414	Applying InnoDB snapshot Detailed revision comments: r6891 \| vdimov \| 2010-03-26 16:19:01 +0200 (Fri, 26 Mar 2010) \| 5 lines Non-functional change: update copyright year to 2010 of the files that have been modified after 2010-01-01 according to svn. for f in $(svn log -v -r{2010-01-01}:HEAD \|grep "^ M " \|cut -b 16- \|sort -u) ; do sed -i "" -E 's/(Copyright $c$ [0-9]{4},) [0-9]{4}, (.*Innobase Oy.+All Rights Reserved)/\1 2010, \2/' $f ; done	16 years ago
Sergey Vojtovich	e76abe0c9c	Applying InnoDB snapshot Detailed revision comments: r6875 \| vdimov \| 2010-03-25 18:18:15 +0200 (Thu, 25 Mar 2010) \| 4 lines branches/zip: Wrap line at 78 column in ChangeLog.	16 years ago
Sergey Vojtovich	cfd2537e26	Applying InnoDB snapshot Detailed revision comments: r6874 \| vdimov \| 2010-03-25 17:17:52 +0200 (Thu, 25 Mar 2010) \| 4 lines branches/zip: Wrap ChangeLog at 78th column	16 years ago
Sergey Vojtovich	3689c1280c	Applying InnoDB snapshot Detailed revision comments: r6873 \| vdimov \| 2010-03-25 17:06:56 +0200 (Thu, 25 Mar 2010) \| 4 lines branches/zip: Use Bug#N instead of Bug #N to be consistent with the rest of the fil.	16 years ago
Sergey Vojtovich	e94b0f2ba2	Applying InnoDB snapshot Detailed revision comments: r6872 \| vdimov \| 2010-03-25 17:03:17 +0200 (Thu, 25 Mar 2010) \| 4 lines branches/zip: Fix ChangeLog - write only the bug title in bugs.mysql.com-related entires.	16 years ago
Sergey Vojtovich	ed034065ef	Applying InnoDB snapshot Detailed revision comments: r6871 \| vdimov \| 2010-03-25 16:39:44 +0200 (Thu, 25 Mar 2010) \| 4 lines branches/zip: Whitespace fixup to be consistent with the rest of the file.	16 years ago
Sergey Vojtovich	2b33751d00	Applying InnoDB snapshot Detailed revision comments: r6868 \| mmakela \| 2010-03-25 13:03:08 +0200 (Thu, 25 Mar 2010) \| 1 line branches/zip: page_validate(): Check the buf[] bounds.	16 years ago
Sergey Vojtovich	242f45fd08	Applying InnoDB snapshot Detailed revision comments: r6864 \| mmakela \| 2010-03-24 14:05:53 +0200 (Wed, 24 Mar 2010) \| 1 line branches/zip: dtype_new_store_for_order_and_null_size(): Add ut_ad() on mtype.	16 years ago
Sergey Vojtovich	743aa8780d	Applying InnoDB snapshot Detailed revision comments: r6861 \| vdimov \| 2010-03-23 19:31:02 +0200 (Tue, 23 Mar 2010) \| 36 lines branches/zip: Merge joerg@mysql.com-20100322150231-vdq0afbqtmbs6phy from BZR, Including univ.i before mysql/plugin.h is needed to avoid this compiler error: o This is how gcc puts it: o > > ccache /usr/local/gcc-4.3.2/bin/gcc -static-libgcc -DHAVE_CONFIG_H -I. -I../../include -I../../include -I../../include -I../../regex -I./include -I../../sql -I. -I../../zlib -g -O3 -march=i686 -DUNIV_LINUX -MT libinnobase_a-trx0i_s.o -MD -MP -MF .deps/libinnobase_a-trx0i_s.Tpo -c -o libinnobase_a-trx0i_s.o `test -f 'trx/trx0i_s.c' \|\| echo './'`trx/trx0i_s.c o > > In file included from ./include/univ.i:114, o > > from trx/trx0i_s.c:36: o > > ../../include/my_pthread.h:628: error: expected ')' before '' token o > > In file included from ../../include/my_pthread.h:732, o > > from ./include/univ.i:114, o > > from trx/trx0i_s.c:36: o > > ../../include/mysql/psi/mysql_thread.h💯 error: expected specifier-qualifier-list before 'pthread_rwlock_t' o > > ../../include/mysql/psi/mysql_thread.h:116: error: expected specifier-qualifier-list before 'pthread_rwlock_t' o > > ../../include/mysql/psi/mysql_thread.h: In function 'inline_mysql_rwlock_init': o > > ../../include/mysql/psi/mysql_thread.h:711: error: 'mysql_rwlock_t' has no member named 'm_psi' o > > ../../include/mysql/psi/mysql_thread.h:716: error: 'mysql_rwlock_t' has no member named 'm_rwlock' o > > .... ((continued)) o o Intel's icc gives slightly clearer messages: o > > icc -static-intel -static-libgcc -DHAVE_CONFIG_H -I. -I../../include -I../../include -I../../include -I../../regex -I./include -I../../sql -I. -I../../zlib -O3 -g -unroll2 -ip -mp -restrict -no-ftz -no-prefetch -DUNIV_LINUX -MT libinnobase_a-trx0i_s.o -MD -MP -MF .deps/libinnobase_a-trx0i_s.Tpo -c -o libinnobase_a-trx0i_s.o `test -f 'trx/trx0i_s.c' \|\| echo './'`trx/trx0i_s.c o > > ../../include/my_pthread.h(628): error: identifier "pthread_rwlock_t" is undefined o > > extern int rw_pr_init(rw_pr_lock_t ); o > > ^ o > > o > > ../../include/mysql/psi/mysql_thread.h(100): error: identifier "pthread_rwlock_t" is undefined o > > rw_lock_t m_rwlock; o > > ^ o > > o > > ../../include/mysql/psi/mysql_thread.h(116): error: identifier "pthread_rwlock_t" is undefined o > > rw_pr_lock_t m_prlock; o > > ^	16 years ago
Sergey Vojtovich	7119e7b78c	Applying InnoDB snapshot Detailed revision comments: r6860 \| jyang \| 2010-03-23 18:20:36 +0200 (Tue, 23 Mar 2010) \| 5 lines branches/zip: This is patch from Inaam that uses red-black tree to speed up insertions into the flush_list and thus the recovery process. The patch has been tested by Nokia.	16 years ago
Sergey Vojtovich	c16f76bed6	Applying InnoDB snapshot Detailed revision comments: r6858 \| mmakela \| 2010-03-23 14:09:24 +0200 (Tue, 23 Mar 2010) \| 1 line branches/zip: innodb_read_ahead_threshold: Add missing space to help string.	16 years ago
Sergey Vojtovich	4da9286ddd	Applying InnoDB snapshot Detailed revision comments: r6857 \| mmakela \| 2010-03-23 14:07:53 +0200 (Tue, 23 Mar 2010) \| 1 line branches/zip: innodb_change_buffering: Correct the documentation.	16 years ago
Sergey Vojtovich	ba580ebcf3	Applying InnoDB snapshot Detailed revision comments: r6853 \| marko \| 2010-03-22 13:35:29 +0200 (Mon, 22 Mar 2010) \| 1 line branches/zip: mutex_own(), rw_lock_own(): Add attribute((warn_unused_result)).	16 years ago
Sergey Vojtovich	b48174e6fe	Applying InnoDB snapshot, fixes BUG#52102. Detailed revision comments: r6840 \| calvin \| 2010-03-19 00:32:23 +0200 (Fri, 19 Mar 2010) \| 6 lines branches/zip: Fix Bug #52102 InnoDB Plugin shows performance drop comparing to builtin InnoDB (Windows only). Disable Windows atomics by default. Approved by: Inaam	16 years ago
Sergey Vojtovich	b5fb2639d8	Applying InnoDB snapshot Detailed revision comments: r6830 \| marko \| 2010-03-18 09:48:18 +0200 (Thu, 18 Mar 2010) \| 3 lines branches/zip: buf_page_peek_if_too_old(): Use 32-bit arithmetics when comparing the age of access_time to buf_LRU_old_threshold_ms. This fixes a bug on 64-bit systems.	16 years ago
Sergey Vojtovich	51af103725	Applying InnoDB snapshot Detailed revision comments: r6828 \| calvin \| 2010-03-17 17:16:38 +0200 (Wed, 17 Mar 2010) \| 7 lines branches/zip: rename IB_HAVE_PAUSE_INSTRUCTION to HAVE_IB_PAUSE_INSTRUCTION in CMakeLists.txt. The rename was done as r5871, but CMakeLists.txt was forgotten. Also, add INNODB_RW_LOCKS_USE_ATOMICS to CMake.	16 years ago
Sergey Vojtovich	9e8ffa495a	Applying InnoDB snapshot Detailed revision comments: r6805 \| inaam \| 2010-03-11 23:15:17 +0200 (Thu, 11 Mar 2010) \| 6 lines branches/zip issue#463 Fixed compiler warning about uninitialized variable. Non-functional change.	16 years ago
Sergey Vojtovich	624f088457	Applying InnoDB snapshot Detailed revision comments: r6801 \| marko \| 2010-03-11 13:34:28 +0200 (Thu, 11 Mar 2010) \| 2 lines branches/zip: mtr_memo_contains(): Relax the assertion of r6800, allowing mtr->state == MTR_COMMITTING.	16 years ago
Sergey Vojtovich	923d34a97f	Applying InnoDB snapshot Detailed revision comments: r6800 \| marko \| 2010-03-11 12:02:57 +0200 (Thu, 11 Mar 2010) \| 1 line branches/zip: Add ut_ad(mtr->state == MTR_ACTIVE) to various places.	16 years ago
Sergey Vojtovich	eb450e18a5	Applying InnoDB snapshot Detailed revision comments: r6799 \| jyang \| 2010-03-11 09:59:42 +0200 (Thu, 11 Mar 2010) \| 5 lines branches/zip: Once change in bug #47621 merges into zip branch, zip only test innodb_bug44571 needs to be updated to reflect the column name change would be successful be done in InnoDB as well.	16 years ago
Sergey Vojtovich	56ce1fc0d1	Applying InnoDB snapshot Detailed revision comments: r6798 \| marko \| 2010-03-11 09:53:01 +0200 (Thu, 11 Mar 2010) \| 14 lines branches/zip: Fix and clarify the latching of some buf_block_t members. buf_block_t::check_index_page_at_flush: Note that this field is not protected by any mutex. Make it a separate field, not a bitfield that could share the machine word with other fields. buf_block_t::lock_hash_val: Note that this field is protected by buf_block_t::lock (or during block creation, by buf_pool_mutex and buf_block_t::mutex). buf_block_get_lock_hash_val(): Assert that block->lock is held by the current thread. Issue #465, rb://267 approved by Inaam Rana	16 years ago
Sergey Vojtovich	2b38090990	Applying InnoDB snapshot Detailed revision comments: r6792 \| marko \| 2010-03-10 13:56:41 +0200 (Wed, 10 Mar 2010) \| 1 line branches/zip: Copy tests from branches/5.1 that were lost in some merge. r6793 \| marko \| 2010-03-10 14:02:19 +0200 (Wed, 10 Mar 2010) \| 60 lines branches/zip: Merge revisions 6669:6788 from branches/5.1: ------------------------------------------------------------------------ r6774 \| calvin \| 2010-03-03 23:56:10 +0200 (Wed, 03 Mar 2010) \| 2 lines Changed paths: M /branches/5.1/trx/trx0sys.c branches/5.1: fix bug#51653: outdated reference to set-variable Non functional change. ------------------------------------------------------------------------ r6780 \| vasil \| 2010-03-08 19:13:20 +0200 (Mon, 08 Mar 2010) \| 4 lines Changed paths: M /branches/5.1/plug.in branches/5.1: Whitespace fixup. ------------------------------------------------------------------------ r6783 \| jyang \| 2010-03-09 17:54:14 +0200 (Tue, 09 Mar 2010) \| 9 lines Changed paths: M /branches/5.1/handler/ha_innodb.cc M /branches/5.1/mysql-test/innodb_bug21704.result A /branches/5.1/mysql-test/innodb_bug47621.result A /branches/5.1/mysql-test/innodb_bug47621.test branches/5.1: Fix bug #47621 "MySQL and InnoDB data dictionaries will become out of sync when renaming columns". MySQL does not provide new column name information to storage engine to update the system table. To avoid column name mismatch, we shall just request a table copy for now. rb://246 approved by Marko. ------------------------------------------------------------------------ r6785 \| vasil \| 2010-03-10 09:04:38 +0200 (Wed, 10 Mar 2010) \| 11 lines Changed paths: M /branches/5.1/mysql-test/innodb_bug38231.test branches/5.1: Add the missing --reap statements in innodb_bug38231.test. Probably MySQL enforced the presence of those recently and the test started failing like: main.innodb_bug38231 [ fail ] Test ended at 2010-03-10 08:48:32 CURRENT_TEST: main.innodb_bug38231 mysqltest: At line 49: Cannot run query on connection between send and reap ------------------------------------------------------------------------ r6788 \| vasil \| 2010-03-10 10:53:21 +0200 (Wed, 10 Mar 2010) \| 8 lines Changed paths: M /branches/5.1/mysql-test/innodb_bug38231.test branches/5.1: In innodb_bug38231.test: replace the fragile sleep 0.2 that depends on timing with a more robust condition which waits for the TRUNCATE and LOCK commands to appear in information_schema.processlist. This could also break if there are other sessions executing the same SQL commands, but there are none during the execution of the mysql test. ------------------------------------------------------------------------	16 years ago
Sergey Vojtovich	96322594b2	Applying InnoDB snapshot Detailed revision comments: r6791 \| marko \| 2010-03-10 13:39:06 +0200 (Wed, 10 Mar 2010) \| 1 line branches/zip: Add ChangeLog entries for r6789, r6790.	16 years ago
Sergey Vojtovich	1fb843587c	Applying InnoDB snapshot, fixes BUG#51356. Detailed revision comments: r6790 \| jyang \| 2010-03-10 13:09:41 +0200 (Wed, 10 Mar 2010) \| 7 lines branches/zip: Fix bug #51356: "many valgrind errors in error messages with concurrent ddl". Null terminate the name string returned from innobase_convert_identifier() call when reporting DB_DUPLICATE_KEY error in create_table_def(). rb://266 approved by Marko	16 years ago
Sergey Vojtovich	5676876884	Applying InnoDB snapshot, fixes BUG#51378. Detailed revision comments: r6789 \| jyang \| 2010-03-10 11:18:18 +0200 (Wed, 10 Mar 2010) \| 10 lines branches/zip: If a unique index is on a column prefix, such unique index cannot be upgrade to primary index even if there is no primary index already defined. Also fix possible corruption when initialize "ref_length" value in case there is a mismatch between MySQL and InnoDB primary key. Fix bug #51378: "Init 'ref_length' to correct value, in case an out of bound MySQL primary_key". rb://262 approved by Marko.	16 years ago

1 2 3 4 5 ...

59538 Commits (16fadb10b5d2a9328b5caa85963a3d851b35cef4) All Branches Search

59538 Commits (16fadb10b5d2a9328b5caa85963a3d851b35cef4)

All Branches