mariadb

Tree: 152f3c5e28

Author	SHA1	Message	Date
Alexey Botchkov	152f3c5e28	PostGIS-style 'same point' handling.	15 years ago
Alexey Botchkov	90c4df7a4a	Fix for bug #804266 Memory corruption/valgrind warning/crash in move_hole() with ST_UNION. Second smaller hole in the polygon got link to the bigger one as it's the outer ring. Fixed by specifying the outer ring explicitly. per-file comments: mysql-test/r/gis-precise.result Fix for bug #804266 Memory corruption/valgrind warning/crash in move_hole() with ST_UNION. test result updated. mysql-test/t/gis-precise.test Fix for bug #804266 Memory corruption/valgrind warning/crash in move_hole() with ST_UNION. test case added. sql/gcalc_tools.cc Fix for bug #804266 Memory corruption/valgrind warning/crash in move_hole() with ST_UNION. specify the outer ring explicitly in the get_polygon_result parameter. sql/gcalc_tools.h Fix for bug #804266 Memory corruption/valgrind warning/crash in move_hole() with ST_UNION. add the outer ring as a parameter to the get_polygon_result.	15 years ago
Alexey Botchkov	e7c9f52fd9	Fix for bug #801217 Assertion `t1->result_range' in Gcalc_operation_reducer::end_couple. We cannot cut a line from a polygon. So if the polygon fits the condition, and the intersection of a line and the polygon doesn't, we just skip the line. That rule wasn't applied if the line start was inside the polygon, which leaded to the assertion. per-file comments: mysql-test/r/gis-precise.result Fix for bug #801217 Assertion `t1->result_range' in Gcalc_operation_reducer::end_couple. test result updated. mysql-test/t/gis-precise.test Fix for bug #801217 Assertion `t1->result_range' in Gcalc_operation_reducer::end_couple. test case added. sql/gcalc_tools.cc Fix for bug #801217 Assertion `t1->result_range' in Gcalc_operation_reducer::end_couple. Don't mark the line as a border if it's inside a polygon that fits the result condition.	15 years ago
Alexey Botchkov	67e937095c	Fix for bug #804259 Second assertion in Gis_geometry_collection::init_from_opresult. A polygon has no right to have holes that are actually points. So just skip them when we collect the result of an operation. per-file comments: mysql-test/r/gis-precise.result Fix for bug #804259 Second assertion in Gis_geometry_collection::init_from_opresult. test result updated. mysql-test/t/gis-precise.test Fix for bug #804259 Second assertion in Gis_geometry_collection::init_from_opresult. test case added. sql/gcalc_tools.cc Fix for bug #804259 Second assertion in Gis_geometry_collection::init_from_opresult. Skip the point in the result if it's the hole inside a polygon.	15 years ago
Alexey Botchkov	e182ae27cd	Fix for bug #805860 Second assertion Assertion `n > 0 && n < SINUSES_CALCULATED2+1' in get_n_sincos. Just typo-style mistake. Should be '\|\|' instead of '&&'. per-file comments: mysql-test/r/gis-precise.result Fix for bug #805860 Second assertion Assertion `n > 0 && n < SINUSES_CALCULATED2+1' in get_n_sincos. test result updated. mysql-test/t/gis-precise.test Fix for bug #805860 Second assertion Assertion `n > 0 && n < SINUSES_CALCULATED2+1' in get_n_sincos. test case added. sql/item_geofunc.cc Fix for bug #805860 Second assertion Assertion `n > 0 && n < SINUSES_CALCULATED2+1' in get_n_sincos. condition fixed.	15 years ago
Alexey Botchkov	13f6e1119f	Fix for bug #804324 Assertion 0 in Gcalc_scan_iterator::pop_suitable_intersection There were actually two bugs. One was when the line that intersects itself the intersection point treated as it doesn't belong to the line. Second when edges partly coincide, wrong result produced when we try to find their intersection. per-file comments: mysql-test/r/gis-precise.result Fix for bug #804324 Assertion 0 in Gcalc_scan_iterator::pop_suitable_intersection test result updated. mysql-test/t/gis-precise.test Fix for bug #804324 Assertion 0 in Gcalc_scan_iterator::pop_suitable_intersection test case added. sql/gcalc_slicescan.cc Fix for bug #804324 Assertion 0 in Gcalc_scan_iterator::pop_suitable_intersection skip the intersection if it just line that intersects itself. sql/gcalc_tools.cc Fix for bug #804324 Assertion 0 in Gcalc_scan_iterator::pop_suitable_intersection if edges coincide, just pick the first coinciding poing as an intersection.	15 years ago
Alexey Botchkov	f3b850a7b5	bug #804305 Crash in wkb_get_double with ST_INTERSECTION. That crash happened with the complicated topology of the result. If we found a hole in a polygon whose outside border was already found, we need to paste the hole right after it and respectively shift polygons after it. Also we need to update poly_position fields in these polygons. That last thing wasn't properly done that led to the crash. To fix that we keep the list of the found polygons and update the poly_positions that are bigger or equal to where we placed the next hole. per-file comments: mysql-test/r/gis-precise.result bug #804305 Crash in wkb_get_double with ST_INTERSECTION. test result updated. mysql-test/t/gis-precise.test bug #804305 Crash in wkb_get_double with ST_INTERSECTION. test result added. sql/gcalc_tools.cc bug #804305 Crash in wkb_get_double with ST_INTERSECTION. keep the list of the found polygons and update their poly_position fields respectively. sql/gcalc_tools.h bug #804305 Crash in wkb_get_double with ST_INTERSECTION. Gcalc_result_receiver::move_hole interface changed.	15 years ago
Alexey Botchkov	7f55ea1211	fix for bug #801212 Assertion with ST_INTERSECTION on NULL values The ::val_str() method has to return NULL if it calculated the null_value, not just set the related flag. per-file comments: mysql-test/r/gis-precise.result fix for bug #801212 Assertion with ST_INTERSECTION on NULL values test result updated. mysql-test/t/gis-precise.test fix for bug #801212 Assertion with ST_INTERSECTION on NULL values test case added. sql/item_geofunc.cc fix for bug #801212 Assertion with ST_INTERSECTION on NULL values return NULL from the val_str if we get the null_value.	15 years ago
Alexey Botchkov	0e6c889c83	bug #801199 Infinite recursion in Gcalc_function::count_internal with ST_BUFFER over MULTIPOINT Collections were treated mistakenly, so the counter for the final UNION operation received the wrong value. As a fix we implement Item_func_buffer::Transporter::start_collection() method, where we set the proper operation and the operand counter. start_poly() and start_line() were also modified to function correctly for the polygon as a part of a collection. per-file comments: mysql-test/r/gis-precise.result bug #801199 Infinite recursion in Gcalc_function::count_internal with ST_BUFFER over MULTIPOINT test result updated. mysql-test/t/gis-precise.test bug #801199 Infinite recursion in Gcalc_function::count_internal with ST_BUFFER over MULTIPOINT test case added. sql/item_geofunc.cc bug #801199 Infinite recursion in Gcalc_function::count_internal with ST_BUFFER over MULTIPOINT start_collection() implemented. sql/item_geofunc.h bug #801199 Infinite recursion in Gcalc_function::count_internal with ST_BUFFER over MULTIPOINT Item_func_buffer::Transporter::start_collection() defined.	15 years ago
Alexey Botchkov	a9a6597d59	fix for bug #201189 ST_BUFFER asserts if radius = 0. Internal caclucations can't handle zero distance properly. As the ST_BUFFER(geom, 0) is in fact NOOP, we'll just return the 'geom' as the result here. per-file comments: mysql-test/r/gis-precise.result fix for bug #201189 ST_BUFFER asserts if radius = 0. test result updated. mysql-test/t/gis-precise.test fix for bug #201189 ST_BUFFER asserts if radius = 0. test case added. sql/item_geofunc.cc fix for bug #201189 ST_BUFFER asserts if radius = 0. return the first argument as the result of the ST_BUFFER, if the distance is 0 there.	15 years ago
Alexey Botchkov	4f49cdf8d3	fix for bug #801243 Assertion `(0)' failed in Gis_geometry_collection::init_from_opresult on ST_UNION If the result contains a polygon with a hole, consequitive shapes weren't calculated properly, as the hole appeared as shape in the result, but actually it's a single shape with the surrounding polygon. It's more natural to use the size of the result as a border instead of the number of resulting shapes. per-file comments: mysql-test/r/gis-precise.result fix for bug #801243 Assertion `(0)' failed in Gis_geometry_collection::init_from_opresult on ST_UNION test result updated. mysql-test/t/gis-precise.test fix for bug #801243 Assertion `(0)' failed in Gis_geometry_collection::init_from_opresult on ST_UNION test case added. sql/spatial.cc fix for bug #801243 Assertion `(0)' failed in Gis_geometry_collection::init_from_opresult on ST_UNION check the data lenght instead of number of shapes. sql/spatial.h fix for bug #801243 Assertion `(0)' failed in Gis_geometry_collection::init_from_opresult on ST_UNION check the data lenght instead of number of shapes.	15 years ago
Sergey Petrunya	bce51cebcb	BUG#778406: Crash in hp_movelink with Aria engine and subqueries -In do_sj_dups_weedout(), set nulls_ptr to point to NULL bytes (and not to length bytes) of the DuplicateWeedout column.	15 years ago
Sergei Golubchik	54d0ec5732	fix for cast of negative numbers to datetime	15 years ago
Sergey Petrunya	b8fdbf8874	Remove redundant code that is a result of a wrong merge. (Changeset sp1r-igor@olga.mysql.com-20070526173301-38848 moved this loop from one place to another, then the merge of sp1r-gshchepa/uchum@gleb.loc-20070527192244-26330 have kept both copies).	15 years ago
Sergey Petrunya	0f22ba3cfe	In make_join_select(): - move attempt to evaluate join->exec_const_cond() out of the "Extract constant part of each ON expression" loop (it got there by mistake when merging).	15 years ago
Sergei Golubchik	49874ff827	more buildbot fixes	15 years ago
Sergei Golubchik	f1a5c49c4e	various fixes for buildbot failures	15 years ago
Sergey Petrunya	9c11646fcd	[No BUG#] end_tab_idx==-1 passed as parameter to JOIN::get_partial_cost_and_fanout() - Handle the case when the subquery's join is degenerate and so has zero tables.	15 years ago
Sergei Golubchik	10fedf675a	change test_if_equality_guarantees_uniqueness() from an ad hoc set of limitations to a correct rule	15 years ago
Michael Widenius	13f55aac67	A bit better fix for tmp-table problem Fixed reference to not initialized memory detected by valgrind sql/sql_select.cc: A bit better fix for tmp-table problem: Use only dynamic_record format for group by and distinct. storage/maria/ma_create.c: DYNAMIC_RECORD format doesn't pack VARCHAR fields. This change fixes a non-fatal uninitialized memory copy.	15 years ago
Igor Babaev	ab411f8f1c	Fixed LP bug #794909 . The function generate_derived_keys did not take into account the fact that the last element in the array of keyuses could be just a barrier element. In some cases it could lead to a crash of the server. Also fixed a couple of other bugs in generate_derived_keys: the inner loop in the body of if this function did not change the cycle variables properly.	15 years ago
Michael Widenius	97e834e151	Use dynamic row format when creating temporary tables without sumary fields. The reason for this is that BLOCK_RECORD format is not good when there is a lot of duplicated keys as it first writes the data (to get the row position) and then writes the key (and thus checks for duplicates).	15 years ago
Sergei Golubchik	fdfeb4bea3	small optimization in Field_time_hires. Fix Field_time_hires::reset()	15 years ago
Sergei Golubchik	c3f665dc66	bugfixes: microsecond(TIME) alter table datetime<->datetime(6) max(TIME), mix(TIME) mysql-test/t/func_if.test: fix the test case of avoid overflow sql/field.cc: don't use make_date() and make_time() sql/field.h: correct eq_def() for temporal fields sql/item.cc: move datetime caching from Item_cache_int to Item_cache_temporal sql/item.h: move datetime caching from Item_cache_int to Item_cache_temporal sql/item_func.cc: use existing helper methods, don't duplicate sql/item_sum.cc: argument cache must use argument's cmp_type, not result_type. sql/item_timefunc.cc: use existing methods, don't tuplicate. remove unused function. fix micorseconds() to support TIME argument sql/mysql_priv.h: dead code sql/time.cc: dead code	15 years ago
Michael Widenius	3600e6b81c	Fixed problem that global status variables 'bytes_recieved' and 'binlog_bytes_written' where not correctly updated	15 years ago
Michael Widenius	60bd2133d7	Fixed compile failure when we don't use system zlib Fixed crash when setting query_cache_type to 0. client/Makefile.am: Added zlib include (needed by checksum.c) sql/set_var.cc: Updated call to disable_query_cache() sql/sql_cache.cc: Don't give warning if we start mysqld with --query_cache_type=0 --query_cache-size=0 Fixed crash when setting query_cache_type to 0 (we shouldn't call query_cache.disable_query_cache() when there is no current_thd) sql/sql_cache.h: Added THD to disable_query_cache()	15 years ago
Igor Babaev	7f345153f9	Fixed LP bug #794038 . INSERT/UPDATE/DELETE statement that used a temptable view v1 could lead to a crash if v1 was defined as a select from a mergeable view v2 that selected rows from a temptable view v3. When INSERT/UPDATE/DELETE uses a view that is not updatable then field translation for the view should be created before the prepare phase.	15 years ago
Michael Widenius	8d7f810894	Upgraded to latest handlersocket code. This fixed LP:766870 "Assertion `next_insert_id == 0' failed with handlersocket" sql/handler.cc: Added DBUG_ code	15 years ago
Michael Widenius	2740edcf56	Fixed that mysqld --no-defaults --help --verbose doesn't give a lot of irrelevant error messages. sql/mysql_priv.h: Make opt_help global sql/mysqld.cc: Don't give (double) warnings about lower case file systems if --help is given. Don't give warning about non existing data directory if --help is given. sql/sql_plugin.cc: Give a better warning if --help is used and plugin table doesn't exists	15 years ago
Michael Widenius	370f79e389	Fixed strict alias problem by replacing = with memcpy()	15 years ago
Igor Babaev	059aff15cd	Fixed LP bug #784441 . The code that added semi-join transformations missed checking the state of the fixed flag for the items built with the and_items function before calls of the fix_fields method. This could lead to an abort failure when the first argument of and_items() happened to be NULL.	15 years ago
Igor Babaev	db0c340601	Fixed LP bug #793436 . When looking for the execution plan of a derived table to be materialized JOIN::optimize finds out that all joined tables of the derived table contain not more than one row then the derived table should be maretialized at the optimization stage. Added a test case for the bug. Adjusted results in other test cases.	15 years ago
Sergei Golubchik	4d128777dd	revert a suggested "optimization" that introduced a bug compilation error in mysys/my_getsystime.c fixed some redundant code removed sec_to_time, time_to_sec, from_unixtime, unix_timestamp, @@timestamp now use decimal, not double for numbers with a fractional part. purge_master_logs_before_date() fixed many bugs in corner cases fixed mysys/my_getsystime.c: compilation failure fixed sql/sql_parse.cc: don't cut corners. it backfires.	15 years ago
Michael Widenius	7e04f7c8fb	Fixed that SHOW COLUMNS for a virtual persistent column shows 'PERSISTENT' instead of 'VIRTUAL' Strict mode now gives error if one tries to update a virtual column. mysql-test/suite/vcol/r/vcol_column_def_options_innodb.result: Updated test results mysql-test/suite/vcol/r/vcol_column_def_options_myisam.result: Updated test results mysql-test/suite/vcol/r/vcol_keys_innodb.result: Updated test results mysql-test/suite/vcol/r/vcol_keys_myisam.result: Updated test results mysql-test/suite/vcol/r/vcol_misc.result: Added new test for 'show columns' and error handling when trying to update a virtual column. mysql-test/suite/vcol/t/vcol_misc.test: Added new test for 'show columns' and error handling when trying to update a virtual column. sql/sql_base.cc: Strict mode now gives error if one tries to update a virtual column. sql/sql_show.cc: Show PERSISTENT instead of VIRTUAL for persistent columns.	15 years ago
Michael Widenius	6ae42b75b8	Fixed lock sorting and lock check issues with thr_lock that caused warnings when running test suite. Safety check that could cause core dump when doing create table with virtual column. mysql-test/mysql-test-run.pl: Show also warnings from thr_lock (which starts with just Warning, not Warning:) mysql-test/r/lock.result: Added test that showed not relevant warning when using table locks. mysql-test/t/lock.test: Added test that showed not relevant warning when using table locks. mysys/thr_lock.c: Fixed sorting of locks. (Old sort code didn't handle case where TL_WRITE_CONCURRENT_INSERT must be sorted before TL_WRITE) Added more information to check_locks warning output. Fixed wrong testing of multiple different write locks for same table. sql/item_cmpfunc.cc: Safety check that could cause core dump when doing create table with virtual column.	15 years ago
Igor Babaev	3bf08e549a	Added two new flags for the optimizer switch: 'derived_merge': - if the flag is off then all derived tables are materialized - if the flag is on then mergeable derived tables are merged 'derived_with_keys': - if the flag is off then no keys are created for derived tables - if the flag is on then for any derived table a key to access the derived table may be created. Now by default both flags are on. Later the default values for the flags will be off to comply with the current behaviour of mysql-5.1. Uncommented previously commented out test case from parts.partition_repair_myisam after having added an explicit requirement to materialize the derived table used in the test case.	15 years ago
Igor Babaev	35c35858f8	Fixed bugs causing failures fot the funcs_1 test suite. Uncommented the failing test cases. Commented out the failing test case from parts.partition_repair_myisam.test. The test case has to be changed to bear the same semantics as before mwl106.	15 years ago
Sergey Petrunya	f0f2ec3086	Buildbot fixes: - make sp.test work both with and without query_cache (attempt 2) - fix compile warning in make_sort_key(), as directed by SergeiG	15 years ago
Vladislav Vaintroub	668d79e87c	Fixed compiler warning in central header file mysql_priv.h.	15 years ago
Sergey Petrunya	9482e387e6	Change optimizer_use_mrr=auto\|disable\|force to be optimizer_switch flags mrr=on\|off and mrr_cost_based=on\|off.	15 years ago
Sergey Petrunya	ebb130b189	BUG#787299: Valgrind complains on a join query with two IN subqueries - Don't attempt to construct FirstMatch access method if we've just figured three lines above that it can't be used (because join prefix doesn't have the needed tables), and so have set pos->first_firstmatch_table= MAX_TABLES Attempts to analyze join->positions[MAX_TABLES] caused valgrind warnings	15 years ago
Oleksandr Byelkin	dd3b27834c	Fix of privilege problem in views and PS sql/sql_base.cc: Column for views should be looked in views (not in underlying table) sql/sql_parse.cc: if we reread grants for single table we should read both database and tables grants for views (not only database grants).	15 years ago
Igor Babaev	8bf69ab7bf	Corrected the previous patch concerning elimination of SQL_SELECT::original_cond. Corrected the code from the patch for LP bug 702322.	15 years ago
unknown	55d26463ad	Fixed typo (exlude -> exclude).	15 years ago
unknown	cd6fc3876b	Fixed valgrind problem in expression cache (double opening the table). sql/sql_expression_cache.cc: The call should not open the temporary table. It will be done later after its index creation.	15 years ago
Sergey Petrunya	0cf912c23f	- Remove compiler warning - Remove garbage comments	15 years ago
Igor Babaev	5dc9a53d19	Eliminated the member original_cond from the class SQL_SELECT introduced at the latest merge 5.1->5.2->5.3. It is basically not needed since if SQL_SELECT::pre_idx_push_select_cond is not NULL then SQL_SELECT::original_cond would point to the same condition as SQL_SELECT::pre_idx_push_select_cond. Otherwise SQL_SELECT::original_cond would be equal to SQL_SELECT::cond.	15 years ago
Sergey Petrunya	037e16583e	Remove garbage comments	15 years ago
Sergey Petrunya	4efe046352	Update pbxt suite test results	15 years ago
Igor Babaev	8ce2e1bcbe	Fixed the abort failure of a test case from vcol.vcol_misc. The fix blocks execution of any constant sub-expressions of the defining expressions for virtual columns when context analysis if these expressions is performed. Fixed a compiler warning.	15 years ago

1 2 3 4 5 ...

27990 Commits (152f3c5e28fe2ae3fd950f15bb3de7064500ced5)