mariadb

Tree: 13cd7170cc

Author	SHA1	Message	Date
Ignacio Galarza	2b85c64d65	Bug#29125 Windows Server X64: so many compiler warnings - Remove bothersome warning messages. This change focuses on the warnings that are covered by the ignore file: support-files/compiler_warnings.supp. - Strings are guaranteed to be max uint in length	17 years ago
cmiller@zippy.cornsilk.net	867ae4ccc4	Correct bad merge, and remove version numbers from test case.	19 years ago
monty@mysql.com/nosik.monty.fi	b16289a5e0	Slow query log to file now displays queries with microsecond precission --long-query-time is now given in seconds with microseconds as decimals --min_examined_row_limit added for slow query log long_query_time user variable is now double with 6 decimals Added functions to get time in microseconds Added faster time() functions for system that has gethrtime() (Solaris) We now do less time() calls. Added field->in_read_set() and field->in_write_set() for easier field manipulation by handlers set_var.cc and my_getopt() can now handle DOUBLE variables. All time() calls changed to my_time() my_time() now does retry's if time() call fails. Added debug function for stopping in mysql_admin_table() when tables are locked Some trivial function and struct variable renames to avoid merge errors. Fixed compiler warnings Initialization of some time variables on windows moved to my_init()	19 years ago
monty@mysql.com/narttu.mysql.fi	088e2395f1	WL#3817: Simplify string / memory area types and make things more consistent (first part) The following type conversions was done: - Changed byte to uchar - Changed gptr to uchar* - Change my_string to char * - Change my_size_t to size_t - Change size_s to size_t Removed declaration of byte, gptr, my_string, my_size_t and size_s. Following function parameter changes was done: - All string functions in mysys/strings was changed to use size_t instead of uint for string lengths. - All read()/write() functions changed to use size_t (including vio). - All protocoll functions changed to use size_t instead of uint - Functions that used a pointer to a string length was changed to use size_t* - Changed malloc(), free() and related functions from using gptr to use void * as this requires fewer casts in the code and is more in line with how the standard functions work. - Added extra length argument to dirname_part() to return the length of the created string. - Changed (at least) following functions to take uchar* as argument: - db_dump() - my_net_write() - net_write_command() - net_store_data() - DBUG_DUMP() - decimal2bin() & bin2decimal() - Changed my_compress() and my_uncompress() to use size_t. Changed one argument to my_uncompress() from a pointer to a value as we only return one value (makes function easier to use). - Changed type of 'pack_data' argument to packfrm() to avoid casts. - Changed in readfrm() and writefrom(), ha_discover and handler::discover() the type for argument 'frmdata' to uchar** to avoid casts. - Changed most Field functions to use uchar* instead of char* (reduced a lot of casts). - Changed field->val_xxx(xxx, new_ptr) to take const pointers. Other changes: - Removed a lot of not needed casts - Added a few new cast required by other changes - Added some cast to my_multi_malloc() arguments for safety (as string lengths needs to be uint, not size_t). - Fixed all calls to hash-get-key functions to use size_t. (Needed to be done explicitely as this conflict was often hided by casting the function to hash_get_key). - Changed some buffers to memory regions to uchar to avoid casts. - Changed some string lengths from uint to size_t. - Changed field->ptr to be uchar* instead of char*. This allowed us to get rid of a lot of casts. - Some changes from true -> TRUE, false -> FALSE, unsigned char -> uchar - Include zlib.h in some files as we needed declaration of crc32() - Changed MY_FILE_ERROR to be (size_t) -1. - Changed many variables to hold the result of my_read() / my_write() to be size_t. This was needed to properly detect errors (which are returned as (size_t) -1). - Removed some very old VMS code - Changed packfrm()/unpackfrm() to not be depending on uint size (portability fix) - Removed windows specific code to restore cursor position as this causes slowdown on windows and we should not mix read() and pread() calls anyway as this is not thread safe. Updated function comment to reflect this. Changed function that depended on original behavior of my_pwrite() to itself restore the cursor position (one such case). - Added some missing checking of return value of malloc(). - Changed definition of MOD_PAD_CHAR_TO_FULL_LENGTH to avoid 'long' overflow. - Changed type of table_def::m_size from my_size_t to ulong to reflect that m_size is the number of elements in the array, not a string/memory length. - Moved THD::max_row_length() to table.cc (as it's not depending on THD). Inlined max_row_length_blob() into this function. - More function comments - Fixed some compiler warnings when compiled without partitions. - Removed setting of LEX_STRING() arguments in declaration (portability fix). - Some trivial indentation/variable name changes. - Some trivial code simplifications: - Replaced some calls to alloc_root + memcpy to use strmake_root()/strdup_root(). - Changed some calls from memdup() to strmake() (Safety fix) - Simpler loops in client-simple.c	19 years ago
cmiller@zippy.cornsilk.net	d81f116534	Contributed patch from Jorge Bernal Ordovás. CLA#42 Bug#27894: mysqlbinlog formats timestamp wrong in comment Date stamps lack zero padding, and so are meaningless. Implement minimum-width zero padding for the percent-escape sequences used in the logging code.	19 years ago
gbichot@dl145h.mysql.com	ba2452f092	Fix for BUG#25628: "mysqlbinlog crashes while processing binary logs". mysqlbinlog prints all row-based events of a single statement as a single "BINLOG" statement containing the concatenation of those events. Big (i.e. >64k) concatenations of row-based events (e.g. Write_rows_log_event) caused mysqlbinlog's IO_CACHE to overflow to a temporary file but the IO_CACHE had not been inited with open_cached_file(), so it tried to create a temporary file in an uninitialized directory (thus failing to create, then to write; some OS errors were printed, and it finally segfaulted). After fixing this, it appeared that mysqlbinlog was printing only a piece of big concatenations of row-based events (it printed at most the size of the IO_CACHE's buffer i.e. 64k); that caused data loss at restore. We fix and test that. Last, mysqlbinlog's printouts looked a bit strange with the informative header (#-prefixed) of groupped Rows_log_event all on one line, so we insert \n. After that, a small bug in the --hexdump code appeared (only if the string to hex-print had its length a multiple of 16), we fix it.	19 years ago
kent@mysql.com/kent-amd64.(none)	226a5c833f	Many files: Changed header to GPL version 2 only	19 years ago
monty@mysql.com/narttu.mysql.fi	88dd873de0	Fixed compiler warnings detected by option -Wshadow and -Wunused: - Removed not used variables and functions - Added #ifdef around code that is not used - Renamed variables and functions to avoid conflicts - Removed some not used arguments Fixed some class/struct warnings in ndb Added define IS_LONGDATA() to simplify code in libmysql.c I did run gcov on the changes and added 'purecov' comments on almost all lines that was not just variable name changes	19 years ago
mats@romeo.(none)	0b6ff112b2	Fix to make it build on all platforms. Replacing C++ code with C code in a C file.	19 years ago
mats@romeo.(none)	e762328b54	BUG#19459 (BINLOG RBR command does not lock tables correctly causing crash for, e.g., NDB): Before, mysqlbinlog printed table map events as a separate statement, so when executing the event, the opened table was subsequently closed when the statement ended. Instead, the row-based events that make up a statement are now printed as one BINLOG statement, which means that the table maps and the following *_rows_log_event events are executed fully before the statement ends. Changing implementation of BINLOG statement to be able to read the emitted format, which now consists of several chunks of BASE64-encoded data.	19 years ago
mats@romeo.(none)	d1b9686245	BUG#19459 (BINLOG RBR command does not lock tables correctly causing crash for, e.g., NDB): Adding new function my_b_copy_to_file() to copy an IO_CACHE to a file.	19 years ago
cmiller@zippy.(none)	85ffd9640e	SECURITY FIX Bug#17667: An attacker has the opportunity to bypass query logging. This adds a new, local-only printf format specifier to our *printf functions that allows us to print known-size buffers that must not be interpreted as NUL-terminated "strings." It uses this format-specifier to print to the log, thus fixing this problem.	20 years ago
serg@serg.mylan	14f94dc0ca	many warnings (practically safe but annoying) corrected	20 years ago
konstantin@mysql.com	f08bbd1f12	assert.h needed for my_dbug.h now is included in my_dbug.h, where it for some reason wasn't included before. A lot of files cleaned up from #include <assert.h>	22 years ago
paul@kite-hub.kitebird.com	2f0ca1ce42	Fix skipp -> skip once and for all. (Note: This affects only comments, not variable names.)	22 years ago
guilhem@gbichot2	66a32e8925	This will be pushed only after I fix the testsuite. This is the main commit for Worklog tasks: * A more dynamic binlog format which allows small changes (1064) * Log session variables in Query_log_event (1063) Below 5.0 means 5.0.0. MySQL 5.0 is able to replicate FOREIGN_KEY_CHECKS, UNIQUE_KEY_CHECKS (for speed), SQL_AUTO_IS_NULL, SQL_MODE. Not charsets (WL#1062), not some vars (I can only think of SQL_SELECT_LIMIT, which deserves a special treatment). Note that this works for queries, except LOAD DATA INFILE (for this it would have to wait for Dmitri's push of WL#874, which in turns waits for the present push, so... the deadlock must be broken!). Note that when Dmitri pushes WL#874 in 5.0.1, 5.0.0 won't be able to replicate a LOAD DATA INFILE from 5.0.1. Apart from that, the new binlog format is designed so that it can tolerate a little variation in the events (so that a 5.0.0 slave could replicate a 5.0.1 master, except for LOAD DATA INFILE unfortunately); that is, when I later add replication of charsets it should break nothing. And when I later add a UID to every event, it should break nothing. The main change brought by this patch is a new type of event, Format_description_log_event, which describes some lengthes in other event types. This event is needed for the master/slave/mysqlbinlog to understand a 5.0 log. Thanks to this event, we can later add more bytes to the header of every event without breaking compatibility. Inside Query_log_event, we have some additional dynamic format, as every Query_log_event can have a different number of status variables, stored as pairs (code, value); that's how SQL_MODE and session variables and catalog are stored. Like this, we can later add count of affected rows, charsets... and we can have options --don't-log-count-affected-rows if we want. MySQL 5.0 is able to run on 4.x relay logs, 4.x binlogs. Upgrading a 4.x master to 5.0 is ok (no need to delete binlogs), upgrading a 4.x slave to 5.0 is ok (no need to delete relay logs); so both can be "hot" upgrades. Upgrading a 3.23 master to 5.0 requires as much as upgrading it to 4.0. 3.23 and 4.x can't be slaves of 5.0. So downgrading from 5.0 to 4.x may be complicated. Log_event::log_pos is now the position of the end of the event, which is more useful than the position of the beginning. We take care about compatibility with <5.0 (in which log_pos is the beginning). I added a short test for replication of SQL_MODE and some other variables. TODO: - after committing this, merge the latest 5.0 into it - fix all tests - update the manual with upgrade notes.	22 years ago
root@home.(none)	5c6c54c09a	system_charset_info has been moved to /sql directory and isn't used in libraries any longer	23 years ago
monty@hundin.mysql.fi	03b0179af9	Use our version of RWLOCKS on UNIXWARE 7 More DBUG info for replication Better error messages from replication Fixed bug in replication code when connecting to 'localhost' (time was not released properly) Block ALARM signal on Linux for signal handler thread (Fixes problem with running mysqld with --debug) Removed warning when setting an AUTO_INCREMENT field to NULL	24 years ago
monty@mashka.mysql.fi	2c4fa340cc	Lots of code fixes to the replication code (especially the binary logging and index log file handling) Fixed bugs in my last changeset that made MySQL hard to compile. Added mutex around some data that could cause table cache corruptions when using OPTIMIZE TABLE / REPAIR TABLE or automatic repair of MyISAM tables. Added mutex around some data in the slave start/stop code that could cause THD linked list corruptions Extended my_chsize() to allow one to specify a filler character. Extend vio_blocking to return the old state (This made some usage of this function much simpler) Added testing for some functions that they caller have got the required mutexes before calling the function. Use setrlimit() to ensure that we can write core file if one specifies --core-file. Added --slave-compressed-protocol Made 2 the minimum length for ft_min_word_len Added variables foreign_key_checks & unique_checks. Less logging from replication code (if not started with --log-warnings) Changed that SHOW INNODB STATUS requre the SUPER privilege More DBUG statements and a lot of new code comments	24 years ago
monty@mashka.mysql.fi	2aecdd1a91	Big code cleanup/review before 4.0.2 release. (All commit emails since 4.0.1 checked) This had to be done now, before the 4.1 tree changes to much, to make it easy to propagate bug fixes to the 4.1 tree.	24 years ago
sasha@mysql.sashanet.com	14603a3620	relay_log_space_limit DBUG_ macro cleanup buffer boundary cleanup This changeset, although not fully tested, works for me better than anything I've had so far, including what is in the repository. I will push it unless something crashes while I am writing this :-)	24 years ago
bar@gw.udmsearch.izhnet.ru	b37ce8e769	New ctype functions/macros to support many charsets at a time	24 years ago
sasha@mysql.sashanet.com	b9637dae05	fixed wrong DBUG_ASSERT() in IO_CACHE fixed apparent typo in opt_sum.cc I will push this Changeset although it fails select test - failing select is better than the code that does not compile.	24 years ago
sasha@mysql.sashanet.com	cef13d5b8e	temporary commit to pull Monty's changes	24 years ago
sasha@mysql.sashanet.com	7275dcef35	misc replication bugfixes including some needed modifications in IO_CACHE likely() and unlikely() branch prediction compiler hint macros clean-up of comments	24 years ago
sasha@mysql.sashanet.com	56129ce634	Here comes a nasty patch, although I am not ready to push it yet. I will first pull, merge,test, and get it to work. The main change is the new replication code - now we have two slave threads SQL thread and I/O thread. I have also re-written a lot of the code to prepare for multi-master implementation. I also documented IO_CACHE quite extensively and to some extend, THD class.	24 years ago
monty@hundin.mysql.fi	b658662ae4	Update copyright Fixed memory leak on shutdown (Affects the embedded version & MyODBC)	24 years ago
monty@hundin.mysql.fi	76ed6c26fc	Fix of testcases after merge. Small improvement to write caching.	24 years ago
monty@hundin.mysql.fi	4d5d1ae2ef	Added read log caching and fixed a possible bug in write cacheing. This should cause fewer seeks when using replication.	24 years ago
monty@hundin.mysql.fi	5fedd2dda7	Fix for IO_CACHE. Portability fixes.	24 years ago
monty@bitch.mysql.fi	d0ccff5090	New improved IO_CACHE	24 years ago
monty@hundin.mysql.fi	e4bdf26066	Small safety fix	24 years ago
sasha@mysql.sashanet.com	a56c72a214	fixed memory leak in replication fixed bugs in new IO_CACHE code so that the old calls work fixed shutdown bug clean-up of mysql-test-run	24 years ago
monty@hundin.mysql.fi	55a6911bb1	Portability fixes.	24 years ago
monty@donna.mysql.com	6d0e529042	Fixed bug when having many binary log files Fixed bug when deleting keys with possible NULL values many changes to mysqltest	25 years ago
monty@donna.mysql.com	10693572ed	Fixed delete in tables with hidden primary key Remove not used BDB logs on shutdown Don't give warnings for repair on slaves Fixed transaction log files	25 years ago
monty@donna.mysql.com	7617d198a4	Lots of fixes for BDB tables Change DROP TABLE to first drop the data, then the .frm file	25 years ago
sasha@mysql.sashanet.com	a9ef0b4bf1	slave master.info FILE -> IO_CACHE send_file() is more stack-friendly - changed large static buffer to alloc_root() fixed my_b_seek() to work with WRITE_CACHE test case to make sure the slave starts correctly after being stopped truncated words file so the replication tests will take less time	25 years ago
sasha@mysql.sashanet.com	d528126359	fixed bugs in IO_CACHE and Load_event constructor. The code now passes replication test suite	25 years ago
monty@narttu.mysql.fi	22415489f2	Fixes for bugs in the usage of IO_CACHE	25 years ago
monty@donna.mysql.com	a9097ca323	changed to use IO_CACHE instead of FILE	25 years ago

48 Commits (13cd7170ccadbc596146175c0674956f49aed830)