mariadb

Tree: 0ddf32c840

Author	SHA1	Message	Date
sjaakola	0ddf32c840	refs: MW-322 * generating fake trx id for CTAS, requires trx_sys mutex protection to be safe for concurrent CTAS processors	9 years ago
Marko Mäkelä	4325041df6	MDEV-13057 innodb_read_only=1 should avoid creating buf_flush_page_cleaner_thread When the server is started in innodb_read_only mode, there cannot be any writes to persistent InnoDB/XtraDB files. Just like the creation of buf_flush_page_cleaner_thread is skipped in this case, also the creation of the XtraDB-specific buf_flush_lru_manager_thread should be skipped.	9 years ago
Marko Mäkelä	417434f12d	MDEV-13039 innodb_fast_shutdown=0 may fail to purge all undo log When a slow shutdown is performed soon after spawning some work for background threads that can create or commit transactions, it is possible that new transactions are started or committed after the purge has finished. This is violating the specification of innodb_fast_shutdown=0, namely that the purge must be completed. (None of the history of the recent transactions would be purged.) Also, it is possible that the purge threads would exit in slow shutdown while there exist active transactions, such as recovered incomplete transactions that are being rolled back. Thus, the slow shutdown could fail to purge some undo log that becomes purgeable after the transaction commit or rollback. srv_undo_sources: A flag that indicates if undo log can be generated or the persistent, whether by background threads or by user SQL. Even when this flag is clear, active transactions that already exist in the system may be committed or rolled back. innodb_shutdown(): Renamed from innobase_shutdown_for_mysql(). Do not return an error code; the operation never fails. Clear the srv_undo_sources flag, and also ensure that the background DROP TABLE queue is empty. srv_purge_should_exit(): Do not allow the purge to exit if srv_undo_sources are active or the background DROP TABLE queue is not empty, or in slow shutdown, if any active transactions exist (and are being rolled back). srv_purge_coordinator_thread(): Remove some previous workarounds for this bug. innobase_start_or_create_for_mysql(): Set buf_page_cleaner_is_active and srv_dict_stats_thread_active directly. Set srv_undo_sources before starting the purge subsystem, to prevent immediate shutdown of the purge. Create dict_stats_thread and fts_optimize_thread immediately after setting srv_undo_sources, so that shutdown can use this flag to determine if these subsystems were started. dict_stats_shutdown(): Shut down dict_stats_thread. Backported from 10.2. srv_shutdown_table_bg_threads(): Remove (unused).	9 years ago
Sergei Golubchik	7c03edf2fe	MDEV-6262 analyze the coverity report on mariadb uploaded 10.0, analyzed everything with the Impact=High (and a couple of Medium)	9 years ago
Vicențiu Ciorbaru	3c7af6c490	Fix xtradb handler compilation post merge	9 years ago
Marko Mäkelä	54bb04f7ef	Fix some __attribute__((nonnull)) misuse This fixes warnings that were emitted when running InnoDB test suites on a debug server that was compiled with GCC 7.1.0 using the flags -O3 -fsanitize=undefined. thd_requested_durability(): XtraDB can call this with trx->mysql_thd=NULL. Remove the function in InnoDB, because it is not used there. calc_row_difference(): Do not call memcmp(o_ptr, NULL, 0). innobase_index_name_is_reserved(): This can be called with key_info=NULL, num_of_keys=0. innobase_dropping_foreign(), innobase_check_foreigns_low(), innobase_check_foreigns(): This can be called with drop_fk=NULL, n_drop_fk=0. rec_convert_dtuple_to_rec_comp(): Do not invoke memcpy(end, NULL, 0).	9 years ago
Marko Mäkelä	9f89b94ba6	MDEV-12358 Work around what looks like a bug in GCC 7.1.0 The parameter thr of the function btr_cur_optimistic_insert() is not declared as nonnull, but GCC 7.1.0 with -O3 is wrongly optimizing away the first part of the condition UNIV_UNLIKELY(thr && thr_get_trx(thr)->fake_changes) when the function is being called by row_merge_insert_index_tuples() with thr==NULL. The fake_changes is an XtraDB addition. This GCC bug only appears to have an impact on XtraDB, not InnoDB. We work around the problem by not attempting to dereference thr when both BTR_NO_LOCKING_FLAG and BTR_NO_UNDO_LOG_FLAG are set in the flags. Probably BTR_NO_LOCKING_FLAG alone should suffice. btr_cur_optimistic_insert(), btr_cur_pessimistic_insert(), btr_cur_pessimistic_update(): Correct comments that disagree with usage and with nonnull attributes. No other parameter than thr can actually be NULL. row_ins_duplicate_error_in_clust(): Remove an unused parameter. innobase_is_fake_change(): Unused function; remove. ibuf_insert_low(), row_log_table_apply(), row_log_apply(), row_undo_mod_clust_low(): Because we will be passing BTR_NO_LOCKING_FLAG \| BTR_NO_UNDO_LOG_FLAG in the flags, the trx->fake_changes flag will be treated as false, which is the right thing to do at these low-level operations (change buffer merge, ALTER TABLE…LOCK=NONE, or ROLLBACK). This might be fixing actual XtraDB bugs. Other callers that pass these two flags are also passing thr=NULL, implying fake_changes=false. (Some callers in ROLLBACK are passing BTR_NO_LOCKING_FLAG and a nonnull thr. In these callers, fake_changes better be false, to avoid corruption.)	9 years ago
Marko Mäkelä	4754f88cff	Never pass NULL to innobase_get_stmt()	9 years ago
Marko Mäkelä	7972da8aa1	Silence bogus GCC 7 warnings -Wimplicit-fallthrough Do not silence uncertain cases, or fix any bugs. The only functional change should be that ha_federated::extra() is not calling DBUG_PRINT to report an unhandled case for HA_EXTRA_PREPARE_FOR_DROP.	9 years ago
Marko Mäkelä	b8187fd005	MDEV-12071 storage/xtradb/handler/ha_innodb.cc: Cannot assign const_iterator to iterator	9 years ago
Vicențiu Ciorbaru	360a4a0372	5.6.36-82.0	9 years ago
Sergei Golubchik	71b4503242	MDEV-9998 Fix issues caught by Clang's -Wpointer-bool-conversion warning remove useless checks and a couple of others	9 years ago
Vicențiu Ciorbaru	8d69ce7b82	5.6.35-80.0	9 years ago
Marko Mäkelä	f162704570	Rewrite the innodb.log_file_size test with DBUG_EXECUTE_IF. Remove the debug parameter innodb_force_recovery_crash that was introduced into MySQL 5.6 by me in WL#6494 which allowed InnoDB to resize the redo log on startup. Let innodb.log_file_size actually start up the server, but ensure that the InnoDB storage engine refuses to start up in each of the scenarios.	9 years ago
Marko Mäkelä	732672c304	MDEV-11233 CREATE FULLTEXT INDEX with a token longer than 127 bytes crashes server This bug is the result of merging the Oracle MySQL follow-up fix BUG#22963169 MYSQL CRASHES ON CREATE FULLTEXT INDEX without merging the base bug fix: Bug#79475 Insert a token of 84 4-bytes chars into fts index causes server crash. Unlike the above mentioned fixes in MySQL, our fix will not change the storage format of fulltext indexes in InnoDB or XtraDB when a character encoding with mbmaxlen=2 or mbmaxlen=3 and the length of a word is between 128 and 84mbmaxlen bytes. The Oracle fix would allocate 2 length bytes for these cases. Compatibility with other MySQL and MariaDB releases is ensured by persisting the used maximum length in the SYS_COLUMNS table in the InnoDB data dictionary. This fix also removes some unnecessary strcmp() calls when checking for the legacy default collation my_charset_latin1 (my_charset_latin1.name=="latin1_swedish_ci"). fts_create_one_index_table(): Store the actual length in bytes. This metadata will be written to the SYS_COLUMNS table. fts_zip_initialize(): Initialize only the first byte of the buffer. Actually the code should not even care about this first byte, because the length is set as 0. FTX_MAX_WORD_LEN: Define as HA_FT_MAXCHARLEN 4 aka 336 bytes, not as 254 bytes. row_merge_create_fts_sort_index(): Set the actual maximum length of the column in bytes, similar to fts_create_one_index_table(). row_merge_fts_doc_tokenize(): Remove the redundant parameter word_dtype. Use the actual maximum length of the column. Calculate the extra_size in the same way as row_merge_buf_encode() does.	9 years ago
Nirbhay Choubey	5fc1ba604e	Fix for post-merge build failure.	9 years ago
Marko Mäkelä	80d5d1452a	MDEV-11694 InnoDB tries to create unused table SYS_ZIP_DICT MariaDB Server 10.0.28 and 10.1.19 merged code from Percona XtraDB that introduced support for compressed columns. Much but not all of this code was disabled by placing #ifdef HAVE_PERCONA_COMPRESSED_COLUMNS around it. Among the unused but not disabled code is code to access some new system tables related to compressed columns. The creation of these system tables SYS_ZIP_DICT and SYS_ZIP_DICT_COLS would cause a crash in --innodb-read-only mode when upgrading from an earlier version to 10.0.28 or 10.1.19. Let us remove all the dead code related to compressed columns. Users who already upgraded to 10.0.28 and 10.1.19 will have the two above mentioned empty tables in their InnoDB system tablespace. Subsequent versions of MariaDB Server will completely ignore those tables.	9 years ago
Sergei Golubchik	7436c3d6ab	5.6.34-79.1	9 years ago
Jan Lindström	03ddc19ab2	MDEV-6424: MariaDB server crashes with assertion failure in file ha_innodb.c line 11652 This is not a fix, this is instrumentation to find out is MySQL frm dictionary and InnoDB data dictionary really out-of-sync when this assertion is fired, or is there some other reason (bug).	9 years ago
Jan Lindström	923a7f8675	MDEV-11188: rpl.rpl_parallel_partition fails with valgrind warnings in buildbot and outside	9 years ago
Sergei Golubchik	d7dc03a267	5.6.33-79.0	9 years ago
Sergei Golubchik	eac8d95ffc	compilation warning after xtradb merge	9 years ago
Sergei Golubchik	6010a27c87	5.5.52-38.3	9 years ago
Sergei Golubchik	93ab3093cb	5.6.32-78.1	9 years ago
Sergei Golubchik	64752acf72	5.6.31-77.0	9 years ago
Jan Lindström	26de9061e8	Merge following commit from 5.5: commit `ef92aaf9ec` Author: Jan Lindström <jan.lindstrom@mariadb.com> Date: Wed Jun 22 22:37:28 2016 +0300 MDEV-10083: Orphan ibd file when playing with foreign keys Analysis: row_drop_table_for_mysql did not allow dropping referenced table even in case when actual creating of the referenced table was not successfull if foreign_key_checks=1. Fix: Allow dropping referenced table even if foreign_key_checks=1 if actual table create returned error.	10 years ago
Jan Lindström	ef92aaf9ec	MDEV-10083: Orphan ibd file when playing with foreign keys Analysis: row_drop_table_for_mysql did not allow dropping referenced table even in case when actual creating of the referenced table was not successfull if foreign_key_checks=1. Fix: Allow dropping referenced table even if foreign_key_checks=1 if actual table create returned error.	10 years ago
Sergei Golubchik	b42664e85e	5.6.30-76.3	10 years ago
Sergei Golubchik	f54dcf1e87	5.5.49-37.9	10 years ago
Jan Lindström	0f252702b1	MDEV-7139: Sporadic failure in innodb.innodb_corrupt_bit on P8 Use direct persistent index corruption set on InnoDB dictionary for this test. Do not allow creating new indexes if one of the existing indexes is already marked as corrupted.	10 years ago
Sergei Golubchik	5b8ac23030	5.6.29-76.2	10 years ago
Jan Lindström	628bc576b3	MDEV-9918: [ERROR] mysqld got signal 11 during ALTER TABLE `name` COLUMN ADD Problem was that in-place online alter table was used on a table that had mismatch between MySQL frm file and InnoDB data dictionary. Fixed so that traditional "Copy" method is used if the MySQL frm and InnoDB data dictionary is not consistent.	10 years ago
Sergei Golubchik	c9e56d5ca9	5.5.48-37.8	10 years ago
Jan Lindström	8103526b38	MDEV-9667: Server hangs after select count(distinct name) from t2 where a=8366 and b>=5 and b<=5; In row_search_for_mysql function on XtraDB there was a old logic where null bytes were inited. This caused server to think that key value is null and continue on incorrect path.	10 years ago
Nirbhay Choubey	2cdcde93c5	Merge sync point from previous commit to XtraDB.	10 years ago
Sergei Golubchik	d520d35380	Revert "MDEV-8696: Adding indexes on empty table is slow with large innodb_sort_buffer_size." This reverts commit `13884cf206`. Fixed in 5.6 (merged in the next commit)	10 years ago
Sergei Golubchik	d76eba6a6b	5.6.28-76.1	10 years ago
Jan Lindström	a70b8961f4	MDEV-9424: Server crashes when slave works with partitioned tables copied from Windows to Linux Add check to avoid NULL-pointer access and added warning if share->ib_table is not what expected.	10 years ago
Sergei Golubchik	3cfd36bbe2	5.5.47-37.7	10 years ago
Jan Lindström	33ac501b6a	Use C++ linkage.	10 years ago
Jan Lindström	1d00d5c626	Fix function visibility as it is used on row0mysql.c in Windows.	10 years ago
Jan Lindström	a3d843d949	Fix function visibility as it is used on row0mysql.c in Windows.	10 years ago
Jan Lindström	080da551ea	MDEV-8869: Potential lock_sys->mutex deadlock In wsrep BF we have already took lock_sys and trx mutex either on wsrep_abort_transaction() or before wsrep_kill_victim(). In replication we could own lock_sys mutex taken in lock_deadlock_check_and_resolve().	10 years ago
Jan Lindström	b63bf7368b	MDEV-8923: port innodb_buffer_pool_dump_pct from MySQL Backport pull request #125 from grooverdan/MDEV-8923_innodb_buffer_pool_dump_pct to 10.0 WL#6504 InnoDB buffer pool dump/load enchantments This patch consists of two parts: 1. Dump only the hottest N% of the buffer pool(s) 2. Prevent hogging the server duing BP load From MySQL - commit `b409342c43` Add testcases for innodb_buffer_pool_dump_pct_basic. Part of the code authored by Daniel Black	10 years ago
Jan Lindström	99404c3437	MDEV-9276: MySQL Bug #78754 : FK definitions missing from SHOW CREATE TABLE in "innodb_read_only" mode	10 years ago
Nirbhay Choubey	18173ddfc4	MDEV-9162 : MariaDB Galera Cluster memory leak on async slave node As galera node (slave) received query log events from an async replication master, it partially wrote the updates made to replication state table (mysql.gtid_slave_pos) to galera transaction writeset post TOI. As a result, the transaction handle, thus created within galera, was never freed/purged as the corresponding trx did not commit. Thus, it kept piling up for every query log event and was only reclaimed upon server shutdown when the transaction map object got destructed. Fixed by making sure that updates in replication slave state table are not written to galera transaction writeset and thus, not replicated to other nodes.	10 years ago
Jan Lindström	4437f51682	MDEV-8869: Potential lock_sys->mutex deadlock In wsrep brute force (BF) we have already took lock_sys and trx mutex either on wsrep_abort_transaction() or before wsrep_kill_victim().	10 years ago
Sergei Golubchik	1e270d504d	5.6.27-76.0	10 years ago
Sergei Golubchik	d67aacb4fb	fix xtradb compilation on windows	10 years ago
Sergei Golubchik	9457139e59	5.5.46-37.6	10 years ago

1 2 3 4 5 ...

473 Commits (0ddf32c840b8b30957104d2a5b59d4edd9dcc297)