mariadb

Tree: 0a12fa2922

Author	SHA1	Message	Date
Sergey Petrunya	56a23357ae	BUG#803457: Wrong result with semijoin + view + outer join in maria-5.3-subqueries-mwl90 (This is not a real fix for this bug, even though it makes it to no longer repeat) - Semi-join subquery predicates, i.e. ... WHERE outer_expr IN (SELECT ...) may have null-rejecting properties, may allow to convert outer joins into inner. - When convert_subq_to_sj() injected IN-equality into parent's WHERE/ON clause, it didn't call $new_cond->top_level_item(), which would cause null-rejecting properties to be lost. - Fixed, now the mentioned outer-to-inner conversion will really take place.	15 years ago
Sergey Petrunya	85571ea76c	Disable LooseScan and FirstMatch when outer joins are present.	15 years ago
Sergey Petrunya	62cc4df4d3	Alternate version of MySQL's fix for BUG#49453. The cause of the crash is sj_nest->sj_subq_pred->unit->first_select()->item_list contains "stale" items for the second execution. By "stale" I mean that they have item->fixed==FALSE, and they are Item_field object instead of Item_direct_view_ref. The solution is to use sj_nest->sj_subq_pred->unit->first_select()->ref_pointer_array. Surprisingly, that array contains items that are ok. Oracle team has introduced and is using NESTED_JOIN::sj_inner_exprs, but we go without that and always copy the ref_pointer_array.	15 years ago
Sergey Petrunya	0ce603ab5e	[No BUG#] Fixes for problems discovered when running mysql-trunk's subquery testsuite	15 years ago
Sergey Petrunya	05d54b121c	BUG#803365: Crash in pull_out_semijoin_tables with outer join + semijoin + derived tables in maria-5.3 with WL#106 - Don't perform table pullout out of semi-join nests that have nested outer joins.	15 years ago
Sergey Petrunya	e2eafc3bd1	Fix buildbot failures: - JOIN::prepare would have set JOIN::table_count to incorrect value (bad merge of MWL 106) - optimize_keyuse() would use table-bit as table number (the change in optimize_keyuse is also the reason for query plan changes. Not expected to have much effect because only handles cases of no index statistics) - st_select_lex::register_dependency_item() ignored the fact that some of the selects on the dependency paths could have been merged to their parents (because they were mergeable VIEWs) - Undo the incorrect fix in Item_subselect::recalc_used_tables(): do not call fix_after_pullout() for Item_subselect::Ref_to_outside members.	15 years ago
Sergey Petrunya	ff960f439e	Remove garbage comment	15 years ago
Sergey Petrunya	4493197125	Followup to previous commit: - Update test results - Fix a problem with PS: = convert_subq_to_sj() should not save where to prep_where or on_expr to prep_on_expr. = After an unmerged subquery predicate has been pulled, it should call fix_after_pullout() for outer_refs.	15 years ago
unknown	78fa331eaa	Fixed bug lp:800679 Analysis: The failed assert ensured that the choice of subquery strategy is performed only for queries with at least one table. If there is a LIMIT 0 clause all tables are removed, and the subquery is neither optimized, nor executed during actual optimization. However, if the query is EXPLAIN-ed, the EXPLAIN execution path doesn't remove the query tables if there is a LIMIT 0 clause. As a result, the subquery optimization code is called, which violates the ASSERT condition. Solution: Transform the assert into a condition, and if the outer query has no tables assume that there will be at most one subquery execution. There is potentially a better solution by reengineering the EXPLAIN/optimize code, so that subquery optimization is not done if not needed. Such a solution would be a lot bigger and more complex than a bug fix.	15 years ago
Sergey Petrunya	04326c5220	Test: enable semi-join processing for cases of semi-joins and outer joins, except for the case when the subquery is in the ON clause.	15 years ago
Sergey Petrunya	4480642624	Added TODO comments	15 years ago
Sergey Petrunya	6adddca80e	Make semi-joins work with outer joins part #1 : - Make make_outerjoin_info() correctly process semi-join nests - Make make_join_select() attach conditions to the right places.	15 years ago
unknown	a02682abcc	MWL#89 - Added regression test with queries over the WORLD database. - Discovered and fixed several bugs in the related cost calculation functionality both in the semijoin and non-semijon subquery code. - Added DBUG printing of the cost variables used to decide between IN-EXISTS and MATERIALIZATION.	15 years ago
Sergey Petrunya	bce51cebcb	BUG#778406: Crash in hp_movelink with Aria engine and subqueries -In do_sj_dups_weedout(), set nulls_ptr to point to NULL bytes (and not to length bytes) of the DuplicateWeedout column.	15 years ago
Igor Babaev	059aff15cd	Fixed LP bug #784441 . The code that added semi-join transformations missed checking the state of the fixed flag for the items built with the and_items function before calls of the fix_fields method. This could lead to an abort failure when the first argument of and_items() happened to be NULL.	15 years ago
Sergey Petrunya	ebb130b189	BUG#787299: Valgrind complains on a join query with two IN subqueries - Don't attempt to construct FirstMatch access method if we've just figured three lines above that it can't be used (because join prefix doesn't have the needed tables), and so have set pos->first_firstmatch_table= MAX_TABLES Attempts to analyze join->positions[MAX_TABLES] caused valgrind warnings	15 years ago
Sergey Petrunya	0cf912c23f	- Remove compiler warning - Remove garbage comments	15 years ago
Sergey Petrunya	ded7342daa	- Update test results (trivial) - Code cleanup: remove garbage comments	15 years ago
Sergey Petrunya	77c4c4d8ea	post-merge fixes: get MWL#90 code to work with MWL#89's way of processing prepared statements: - conversion subquery_predicate -> TABLE_LIST is once per-statement - However, the code must take into account that materialized temptable is dropped and re-created on each execution (the tricky part is that at start of n-th EXECUTE we have TABLE_LIST object but not its TABLE object) - IN-equality is injected into WHERE on every execution.	15 years ago
Sergey Petrunya	aa551f1b9e	Post-merge fixes part#2	15 years ago
unknown	742dfc92a2	MWL#89: Address review feedback (by Sergey Petrunia) mysql-test/r/subselect4.result: Moved test case for LP BUG#718593 into the correct test file subselect_mat_cost_bugs.test. mysql-test/t/subselect4.test: Moved test case for LP BUG#718593 into the correct test file subselect_mat_cost_bugs.test.	15 years ago
Sergey Petrunya	d1138283b9	BUG#784723: Wrong result with semijoin + nested subqueries in maria-5.3 - in advance_sj_state(), remember join->cur_dups_producing_tables in pos->prefix_dups_producing_tables before we modify it, so that restore_prev_sj_state() restores cur_dups_producing_tables in all cases. - Updated test results in subselect_sj2[_jcl6].result (the original EXPLAIN was invalid there)	15 years ago
unknown	56c0e19ed0	MWL#89 Addressing Sergey's review comments - Part 1. Address the 'trivial' part of Sergey's review of MWL#89.	15 years ago
unknown	18d08eeacc	Post review fixes of MWL#148 (moving max/min optimization in optimize phase). sql/item_subselect.cc: Cleanup. Comments added. sql/item_subselect.h: Cleanup. sql/mysql_priv.h: Comments added. sql/opt_subselect.cc: The function renamed and turned to method. Comments added. sql/opt_subselect.h: The function turned to method of JOIN. sql/sql_select.cc: Comment added. The function turned to method. sql/sql_select.h: The function turned to method.	15 years ago
Sergey Petrunya	f34b421839	Code cleanup, added comments.	15 years ago
Sergey Petrunya	76fd8c1c2f	Change "disable semi-joins in presense of outer joins" check to actually check for outer joins (and not for any "t1 SOME_JOIN t2 ON cond" syntax).	15 years ago
Sergey Petrunya	524e6aad73	MWL#90: Non-merged semi-joins - Take into account that grouping or aggregates decrease join output cardinality. (First code, can't make use of index statistics yet)	15 years ago
Oleksandr Byelkin	7b797fe66d	Moving max/min optimization from prepare to optimization phase. MWL#148 mysql-test/r/explain.result: fixed results (new item) mysql-test/r/subselect.result: fixed results (new item) mysql-test/r/subselect_no_mat.result: fixed results (new item) mysql-test/r/subselect_no_opts.result: fixed results (new item) mysql-test/r/subselect_no_semijoin.result: Fixed results (new item) mysql-test/suite/pbxt/r/subselect.result: Fixed results (new item) mysql-test/t/explain.test: Fixed results (correct behaviour) sql/item_cmpfunc.cc: Pass through for max/min sql/item_subselect.cc: moving max/min sql/item_subselect.h: moving max/min sql/mysql_priv.h: new uncacheble flags added sql/opt_subselect.cc: maxmin moved. sql/opt_subselect.h: New function for maxmin. sql/sql_class.h: debug code sql/sql_lex.cc: Fixed flags. Limit setting fixed. sql/sql_lex.h: 2 new flags. sql/sql_select.cc: Prepare divided on 2 function to be able recollect some info after transformation. sql/sql_select.h: Prepare divided on 2 functions.	15 years ago
Igor Babaev	8d9dd21d85	Fixed LP bugs #717577 , #724942 . Both these two bugs happened due to the following problem. When a view column is referenced in the query an Item_direct_view_ref object is created that is refers to the Item_field for the column. All references to the same view column refer to the same Item_field. Different references can belong to different AND/OR levels and, as a result, can be included in different Item_equal object. These Item_equal objects may include different constant objects. If these constant objects are substituted for the Item_field created for a view column we have a conflict situation when the second substitution annuls the first substitution. This leads to wrong result sets returned by the query. Bug #724942 demonstrates such an erroneous behaviour. Test case of the bug #717577 produces wrong result sets because best equal fields of the multiple equalities built for different OR levels of the WHERE condition differs. The subsitution for the best equal field in the second OR branch overwrites the the substitution made for the first branch. To avoid such conflicts we have to substitute for the references to the view columns rather than for the underlying field items. To make such substitutions possible we have to include into multiple equalities references to view columns rather than field items created for such columns. This patch modifies the Item_equal class to include references to view columns into multiple equality objects. It also performs a clean up of the class methods and adds more comments. The methods of the Item_direct_view_ref class that assist substitutions for references to view columns has been also added by this patch.	15 years ago
Sergey Petrunya	acc161d363	BUG#752992: Wrong results for a subquery with 'semijoin=on' - Let advance_sj_state() save the value of JOIN::cur_dups_producing_tables in POSITION::prefix_dups_producing_tables, and restore_sj_state() restore it.	15 years ago
Sergey Petrunya	81c6f73ff2	MWL#90: Address review feedback part #19 : More comments	15 years ago
Sergey Petrunya	151207134b	MWL#90: Address review feedback part #18	15 years ago
Sergey Petrunya	dc937fb53b	MWL#90: Address review feedback part #16	15 years ago
Sergey Petrunya	4e5199912b	Rename JOIN::top_jtrange_tables to top_join_tab_count	15 years ago
Sergey Petrunya	5de770f317	MWL#90: Address review feedback part #14	15 years ago
Sergey Petrunya	432a058723	- Fix valgrind failure introduced in previous push	15 years ago
Sergey Petrunya	39fe368d68	MWL#90: Address review feedback part #7	15 years ago
Sergey Petrunya	b77e3dc9f4	MWL#90: Address review feedback part #5	15 years ago
Sergey Petrunya	809a805251	MWL#90: Address review feedback part #4	15 years ago
unknown	0737fb479f	MWL#89 Added comment.	15 years ago
unknown	96efe1cab3	Fix for LP BUG#714808 and LP BUG#719280. The patch also adjusts several instable test results to order the result. Analysis: The function prev_record_reads() may skip (jump over) some query plan nodes where record_count < 1. At the same time, even though get_partial_join_cost() uses all first N plan nodes after the last constant table, it may produce a smaller record_count than prev_record_reads(), because the record count for some plan nodes may be < 1, and these nodes may not participate in prev_record_reads. Solution: The current solution is to treat the result of get_partial_join_cost() as the upper bound for the total number of unique lookup keys.	15 years ago
unknown	6a66bf3182	MWL#89 Fixed LP BUG#714808 Assertion `outer_lookup_keys <= outer_record_count' Analysis: The function best_access_path() computes the number or records as follows: ... if (rec < MATCHING_ROWS_IN_OTHER_TABLE) rec= MATCHING_ROWS_IN_OTHER_TABLE; // Fix for small tables ... if (table->quick_keys.is_set(key)) records= (double) table->quick_rows[key]; else { /* quick_range couldn't use key! */ records= (double) s->records/rec; } Above MATCHING_ROWS_IN_OTHER_TABLE == 10, and s->records == 1, thus we get an estimated 0.1 records. As a result JOIN::get_partial_join_cost() for the outer query computes outer_record_count == 0.1 records, which is meaningless in this context. Solution: Round row count estimates that are < 1 to 1.	15 years ago
unknown	648e604615	MWL#89 Adjusted test cases in accordance with the implementation.	15 years ago
unknown	fd6a079993	MWL#89 - fixed incorrect query plans that resulted from emptying the keyuse array with the access methods of the non-modified query plan. - fixed compiler warning.	15 years ago
Igor Babaev	0f46efcba6	Post-review fixes for the patch that added the code allowing to use hash join over equi-join conditions without supporting indexes.	15 years ago
Sergei Golubchik	418df96d51	use bulk insert and repair by sort for unique keys in Aria and MyISAM in create_internal_tmp_table_from_heap() (safe, as duplicates are impossible). This gives a HUGE speed boost! sql/opt_subselect.cc: Fixed problem with wrong recinfo in create_duplicate_weedout_tmp_tabl() Tagged the table with 'no_rows' so that when we create the table on disk, we only store the index data. This gave us a major speedup! sql/sql_select.cc: create_tmp_table_from_heap() now uses bulk_insert + repair_by_sort when creating Aria/MyISAM tables from HEAP tables. This gives a HUGE speed boost! storage/maria/ha_maria.cc: Extended bulk_insert() to recreate UNIQUE keys for internal temporary tables storage/maria/ma_open.c: Initialize m_info->lock.type properly for temporarly tables (needed for start_bulk_insert()) storage/maria/ma_write.c: Don't check uniques that are disabled storage/myisam/ha_myisam.cc: Extended bulk_insert() to recreate UNIQUE keys for internal temporary tables.	15 years ago
Sergei Golubchik	6554977fe5	Added ha_write_tmp_row() for slightly faster write_row for internal temp tables. This will also enable us in the future to collect statistics for writes to internal tmp tables. sql/handler.h: Added ha_write_tmp_row() sql/opt_subselect.cc: ha_write_row -> ha_write_tmp_row sql/sql_class.h: Added ha_write_tmp_row() sql/sql_select.cc: ha_write_row -> ha_write_tmp_row	15 years ago
Sergei Golubchik	563da78d57	Removed some old comments. mysys/my_handler.c: Fixed typo	15 years ago
Sergey Petrunya	770548442f	Bug#46692 Crash occurring on queries with nested FROM subqueries using materialization - Backport testcases - We have a different fix because we've fixed part of the problem as part of fix for LPBUG#602574.	15 years ago
Igor Babaev	af800fd92f	The patch adds the code that allows to use equi-join conditions for hash join in the cases when there are no suitable indexes for these conditions.	15 years ago

1 2 3

128 Commits (0a12fa292221ed9cf1c58e924682a8d49c6059b8)