mariadb

Tree: 059b9356a1

Author	SHA1	Message	Date
unknown	c558b3e068	Fix Valgrind errors seen in buildbot. Fix mysql-test-run.pl to not terminate early when warnings in error logs are detected during server shutdown. Instead, give a nice summary report at the end of the failures. Fix code to make 100% sure no failures will go undetected. Revert earlier wrong change. Fix race with port allocation semaphore file permissions. Adjust testsuite to copy with new PBXT engine now in the tree. The PBXT engine causes an extra table to appear in the INFORMATION_SCHEMA. This causes different output for a few test cases. dbug/dbug.c: If DbugParse() is called multiple times, the stack->keywords for the top stack frame could be overwritten without being freed, causing a memory leak reported by Valgrind. include/my_global.h: Add useful macro for different values when Valgrind (HAVE_purify) and not. mysql-test/extra/rpl_tests/rpl_auto_increment.test: Omit pbxt variables from show variables output. mysql-test/include/have_pbxt.inc: Add facility to disable test if PBXT engine is not available. mysql-test/lib/mtr_report.pm: Give a nice summary report at the end of tests of any warnings seen in logs during server shutdowns. mysql-test/lib/mtr_unique.pm: Move chmod 777 to greatly reduce the risk of leaving the port semaphore file unaccessible bu other users. mysql-test/mysql-test-run.pl: Don't abort in case of warnings detected, instead give a nice summary report. Fix code to make 100% sure no failures will go undetected. Revert earlier wrong change when master disconnects early. mysql-test/r/information_schema.result: Omit PBXT INFORMATION_SCHEMA table from output. Move part of test to information_schema_all_engines. mysql-test/r/information_schema_all_engines.result: New file for information_schema tests that depend on which engines are available. mysql-test/r/information_schema_db.result: Move part of test to information_schema_all_engines. mysql-test/r/innodb-autoinc.result: Omit pbxt variables from show variables output. mysql-test/r/mysqlshow.result: Move part of test to information_schema_all_engines. mysql-test/suite/rpl/r/rpl_auto_increment.result: Omit pbxt variables from show variables output. mysql-test/t/information_schema.test: Omit PBXT INFORMATION_SCHEMA table from output. Move part of test to information_schema_all_engines. mysql-test/t/information_schema_all_engines.test: New file for information_schema tests that depend on which engines are available. mysql-test/t/information_schema_db.test: Move part of test to information_schema_all_engines. mysql-test/t/innodb-autoinc.test: Omit pbxt variables from show variables output. mysql-test/t/mysqlshow.test: Move part of test to information_schema_all_engines. mysql-test/valgrind.supp: Add variant suppression (different system library versions). Add suppression for problem with inet_ntoa(). sql/mysqld.cc: Fix missing DBUG_RETURN. Fix uninitialised thd->connect_utime, likely introduced by pool_of_threads. sql/set_var.cc: Fix one-byte buffer overflow in several places. Fix unsafe use of String::c_ptr() of stack-allocated String buffer. sql/sql_select.cc: Silence valgrind warning due to GCC bug. sql/sql_string.h: Document potential problem with String::c_ptr() and String() constructor with caller-supplied buffer. storage/archive/azio.c: Silence Valgrind false warning for libz.	17 years ago
unknown	30f4155023	Remove redundant code, probably bad automerge	17 years ago
unknown	8193c32743	BUG#43418: MTR2: does not notice a memory leak occuring at shutdown of mysqld w/ --valgrind - Fixed by implementing parsing of error log messages generated outside of test case runs (eg. during server shutdown). Also make mysql-test-run.pl not delete the error log after server restart, which looses information about which warnings were found. Finally, make multi_update2 a --big test. mysql-test/lib/My/Test.pm: Fix home-brewed (and broken) serialization in My::Test to use the standard Storable serializer. mysql-test/mysql-test-run.pl: - Stop mysqld servers gracefully rather than kill -9 when warnings are being checked. - After stopping mysqld servers, do an additional parse of the error log to check for any warnings generated during shutdown. - Fix error log parsing to be careful not to skip parsing part of the file, by keeping track of previous file position rather than relying on mark_log markers. - Workers report warnings during shutdown to the master process with a new packet 'WARNINGS' which includes a list of names of test that might have caused the problem (could be any test run since last server start). - Fail entire test suite if warnings are found. - When we remove the server data dir before server restart, preserve the error log (don't delete it between restarts), as it may contain valuable information even for test cases which don't show direct failures. mysql-test/t/multi_update2.test: Make test --big, as it takes a _long_ time to run and only tests a single bug.	17 years ago
unknown	ce956c8f2d	Add testing of extra port for pool-of-threads. The additional test uses up all threads in the pool with SELECT SLEEP(), and tests that this makes normal connections block, but connections on the extra port still work. Also test connection limit on extra port with and without pool-of-threads enabled. Add --connect-timeout option to mysqltest program. Add facility for --extra-port option to ConfigFactory. Fix regexp typo in ConfigFactory.pm	17 years ago
Bjorn Munch	d3f4c75e55	Bug #42535 MTR2 output format for skipped tests should be identical to MTR 1 Changed [ skip ] to [ skipped ] and removed optional .	17 years ago
Luis Soares	0030ff1457	BUG#42485: Pushbuild2 and some build tools do not work together with MTR2 It seems that the length of the thick line printed by mtr when printing the suite name differs from mtr1 and mtr2, affecting the mtr filtering by PB2. This patch addresses it by restoring the thick line length to 78 (original length) instead of 60 (the one in mtr2).	17 years ago
Satya B	4a657eee92	An addition to BUG#39886 - Table full for MEMORY table is not written into error log After the earlier fix, mtr tests reports "table full" messages as warnings. This is expected, this patch fixes the mtr testframework to ignore the error message. mysql-test/lib/mtr_report.pl: fixed mtr_report_stats to ignore the Table Full error messages generated by the testcases main.almost_full, main.myisam_data_pointer_size_func	17 years ago
Magnus Svensson	ad94278ba0	WL#4198 mtr.pl v2 - Improve error message for "found warnings in server log file"	17 years ago
Magnus Svensson	b3e1ca1f2c	WL#4189 mtr.pl v2 - Add a "skip-ssl=1" to [mysqltest] section so that mysqltest will not run with ssl turned on by default but stil be able to turn it on when requested - This avoids that check_warnings and check_testcase connects to the server woth SSL turned on	17 years ago
Magnus Svensson	66bf048dd3	mtr.pl v2 - extend debug prints for "permission denied"	17 years ago
Magnus Svensson	bbdd0576ee	WL#4189 mtr.pl v2 - Clear test variables "comment" and "logfile" to make sure thay aren't already set from previous run of same test - Print warning if test result already set and set it anyway	17 years ago
Magnus Svensson	0cb63777a7	WL#4189 mtr.pl v2 - fix typo	17 years ago
Magnus Svensson	0226941c09	mtr.pl v2 - Add debug prints for analyzing mkdir "Permission denied" failure	17 years ago
Magnus Svensson	c2a4f3901b	Bug#35735 mysql-test-run.pl creates tmpdir for socket path longer than 70 - Additional patch with improved protection by putting it all inside an "eval" - Calling 'hostpath' on a truncated socket may also croak. - Remove the need to create any directory parts of "path" inside the function.	17 years ago
Magnus Svensson	9c76ec9323	Bug#39972 mysql-test-run.pl: Confusing error message under special conditions - Fix problem with for example ./mtr --timer, caused by new version of "Getopt::Long" - Evaluating the "$opt" variable as a string, returns the name of the parameter to be modified instead of "Getopt::Long::Callback" which is the class name	17 years ago
Bjorn Munch	089663f9a7	Bug #40399 Please make mtr print stack trace after every failure SIGABRT is sent to relevant processes after a timeout client/mysqltest.cc: Fixed signal handlers to mysqltest actually dumps core mysql-test/lib/My/CoreDump.pm: Added support for dbx mysql-test/lib/My/SafeProcess.pm: Added dump_core to force process to dump core mysql-test/lib/My/SafeProcess/safe_process.cc: Traps SIGABRT and sends this on to child mysql-test/mysql-test-run.pl: When test times out, force core dumps on mysqltest and servers	17 years ago
Sven Sandberg	75017750c3	BUG#41959: mtr: error message when mkpath() fails and the file exists but is not directory Problem: when mtr tries to create a directory, and the target exists but is a file instead of directory, it tries several times to create the directory again before it fails. Fix: make it check if the target exists and is a non-directory. mysql-test/lib/My/File/Path.pm: mkpath() now stops with appropriate error message if the target exists but is a non-directory.	17 years ago
Magnus Svensson	949b2f1c0c	Bug#41480 Tests that do LOAD DATA INFILE fail when run locally mysql-test/lib/My/File/Path.pm: Extend 'copytree' to take an optional "umask" parameter that will be used while copying the files mysql-test/mysql-test-run.pl: Pass umask 0022 to copytree so that the copied files will be created world readable and the mysqld can LOAD DATA INFILE them	17 years ago
Timothy Smith	19fed02ce9	Apply InnoDB snapshot innodb-5.1-ss2858, part 4. Fixes Bug #39438: Testcase for Bug#39436 crashes on 5.1 in fil_space_get_latch Detailed revision comments: r2719 \| vasil \| 2008-10-03 18:17:28 +0300 (Fri, 03 Oct 2008) \| 49 lines branches/5.1: Fix Bug#39438 Testcase for Bug#39436 crashes on 5.1 in fil_space_get_latch In ha_innobase::info() - do not try to get the free space for a tablespace which has been discarded with ALTER TABLE ... DISCARD TABLESPACE or if the .ibd file is missing for some other reason. ibd_file_missing and tablespace_discarded are manipulated only in row_discard_tablespace_for_mysql() and in row_import_tablespace_for_mysql() and the manipulation is protected/surrounded by row_mysql_lock_data_dictionary()/row_mysql_unlock_data_dictionary() thus we do the same in ha_innobase::info() when checking the values of those members to avoid race conditions. I have tested the code-path with UNIV_DEBUG and UNIV_SYNC_DEBUG. rb://20 Reviewed by: Inaam, Calvin Approved by: Heikki	17 years ago
Andrei Elkin	fab8d1b460	Bug #40129 no-threads fails on pushbuild in 6.0-rpl, ps_stm_threadpool The test reacted on the way how mtr orders arguments for the server that are gathered from different source. It appeared that the opt-file options were parsed before those that supplied to mtr via its command line. In effect, the opt-file preferences got overriden by the command line and some tests, like no-threads, were caught by surprise: a test expects an option value that had been "hardcoded" into its opt-file but gets another one. This server options ordering problem exists on in the new rpl trees mtr. In option of the author of this patch, the opt-file shall be considered as having the highest preference weight. The opt-file is merely a part of the header of a test, namely a part that can not be technically deployed along the test file. It's unnatural for the test writer to provide both the opt file value and a guard that guarantees the value will be set on in the run time. It's logical to provide either one: the option and its value or the guard. Fixed with relocating parse of the opt file to be the last among sources of the sever's options. A side effect: fixing a small problem of resetting the suite options at time the opt file starts parsing. A side effect: main.log_bin_trust_function_creators_func is disabled to be re-enabled with the fixes for bug#41003 will be merged from the main trees. mysql-test/lib/mtr_cases.pm: Relocating parse of the opt file to be the last. This ensure the opt file is the last provider for the server options so that the opt-file options have the highest preference; fixing a separate issue of incorrect resetting the suite options for the server; mysql-test/t/disabled.def: log_bin_trust_function_creators_func is disabled. Todo: to-reable when fixes for bug#41003 will be merged from the main trees.	17 years ago
Bjorn Munch	d2e0e3ce35	Bug #40924 please print timestamp when mtr fails Added text "Test ended at <time>" after failure reports	17 years ago
Guilhem Bichot	1889e8b075	Under Windows one can get \ instead of / in file names in error messages (fix for pushbuild warning) mysql-test/lib/mtr_report.pl: Under Windows one can get \ instead of / in file names in error messages	17 years ago
Serge Kozlov	3e0fb46142	Bug#39861: 1. mysqltest.cc - added flush to log file after each executed command in a testcase. 2. mtr shows 20 last lines from test case log file if timeout reached. 3. Optimizing the code by Magnus review. 4. It is partially fix bug#40150	17 years ago
Magnus Svensson	06fdd29404	Bug#40742 MTR_VERSION=1 perl mysql-test-run.pl --start-and-exit rpl_alter does not work mysql-test/lib/v1/mtr_cases.pl: The combinations file in suite uses my.cnf file syntax - thus the options in the combinations file should not have -- prefixed. Add -- to the option while reading it from file.	17 years ago
Magnus Svensson	950d5d2760	Bug#40715 mtr fails when running the same test case in parallel threads mysql-test/lib/My/Test.pm: Use a more unique key to identify which test has been serialized	17 years ago
Magnus Svensson	b454d067cb	WL#4189 Add full backward compatibility to mysql-test-run.pl - Add copy of mtr v1 and make it possible to run it using MTR_VERSION=1	17 years ago
Build Team	e85fe79430	Added "Sun Microsystems, Inc." to copyright headers on files modified since Oct 1st	17 years ago
Sven Sandberg	906fc6bb95	BUG#38817: please make mtr analyze crashes better Post-push fixes making it work on pushbuild's valgrind host, and clarifying the output. mysql-test/lib/My/CoreDump.pm: - Improved parsing of mtr output so that it works on pushbuild's "valgrind" host. - Added stack trace for the thread that coredumped, to make output more readable when there are many threads. - Added explanation of what the output consists of. - Added early removal of temp file.	17 years ago
Magnus Svensson	770ef5c307	WL#4189 Set parallel to 1 if running under vmware on windows	17 years ago
Magnus Svensson	6a10718848	WL#4189 Add retry logic to mkpath to avoid temporary permission denied problems	17 years ago
Magnus Svensson	9ffab58506	WL#41890 After review fixes, remove unecessary if's	17 years ago
Magnus Svensson	7dca45f8b2	Merge	17 years ago
Magnus Svensson	2d2387927a	BUG#38559 Annoying cygwin problem fixed by resolving pid->winpid before kill instead of just after fork	17 years ago
Magnus Svensson	fc6a7def0b	WL#4189 NO need to retry OpenEvent if the process does not exist anymore	17 years ago
Magnus Svensson	e75daedf17	WL4189 Active state perl fixes	17 years ago
Magnus Svensson	160e13cb4c	WL#4189 Only kill process that hasn't yet finished at end of mtr.pl. Improve debug printout	17 years ago
Magnus Svensson	01a3ac7596	WL4189 Add Handles.pm and use it from My::File::Path to show open handles. Rewrite rmtree to use File::Find so we can get better debug printouts when something fails	17 years ago
Magnus Svensson	c61516c381	Improve gdb coredump	17 years ago
Andrei Elkin	64accb36bf	Bug #36968 rpl_temporary_errors.test produces warning in pushbuild backporting a part of the bug patch to 5.1.29 tree which uses an older version of mtr. mysql-test/lib/mtr_report.pl: refining a suppression rule.	17 years ago
Magnus Svensson	853880910c	Memoize functions that converts between different paths, a given input string will always return the same output. This save a lot of calls to cygpath for example	17 years ago
Magnus Svensson	670a46aa0a	Print 'cygpath -m' command if it fails	17 years ago
Magnus Svensson	a50eed3a27	Bug #37312 Make tests binlog_row_innodb_stat and binlog_stm_innodb_stat more robust mysql-test/lib/mtr_cases.pl: forward port the algorithm to check if a binlog format is supported mysql-test/mysql-test-run.pl: Don't use dynamic setting of binlog format - does not work	17 years ago
Magnus Svensson	a925ec107f	Use --batch when invoking gdb, to make sure it will exit in case of an error in the command files.	17 years ago
Magnus Svensson	231984dd5d	Versional testing support	17 years ago
Magnus Svensson	862f105151	Make sure the direcory where the test socket is to be created exists	17 years ago
Magnus Svensson	af23ec8579	WL#4189 Wrap the check for socket path length in eval	17 years ago
Magnus Svensson	0456e23984	WL#4350 Fix --record and no .result file	17 years ago
Magnus Svensson	258c88471f	Bug#38817 please make mtr analyze crashes better	17 years ago
Magnus Svensson	7ef8929ba4	Bug#35482 mysql-test-run have_innodb does not detect external server has Innodb support	17 years ago
Magnus Svensson	c11e919980	WL#4350 Options in my.cnf style config file should not start with --	17 years ago

1 2 3 4 5 ...

728 Commits (059b9356a19118a48fbad31be81c4859e15d3bc8)