From 96b8909062c0b4df654f11057905b1e31398f88f Mon Sep 17 00:00:00 2001 From: Sergei Golubchik Date: Fri, 6 Jul 2018 04:03:43 +0200 Subject: [PATCH] MDEV-16662 CMake warnings: CMP0022 --- CMakeLists.txt | 6 ++---- cmake/libutils.cmake | 3 +-- sql/CMakeLists.txt | 3 +-- 3 files changed, 4 insertions(+), 8 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 5d95bb568cf..94e38658697 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -14,12 +14,10 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA -CMAKE_MINIMUM_REQUIRED(VERSION 2.8.3) +CMAKE_MINIMUM_REQUIRED(VERSION 2.8.7) -# explicitly set the policy to OLD -# (cannot use NEW, not everyone is on cmake-2.8.12 yet) IF(POLICY CMP0022) - CMAKE_POLICY(SET CMP0022 OLD) + CMAKE_POLICY(SET CMP0022 NEW) ENDIF() # We use the LOCATION target property (CMP0026) diff --git a/cmake/libutils.cmake b/cmake/libutils.cmake index a31fe0d4510..621f6ecb535 100644 --- a/cmake/libutils.cmake +++ b/cmake/libutils.cmake @@ -269,7 +269,7 @@ MACRO(MERGE_LIBRARIES) IF (ARG_SOVERSION) SET_TARGET_PROPERTIES(${TARGET} PROPERTIES SOVERSION ${ARG_VERSION}) ENDIF() - TARGET_LINK_LIBRARIES(${TARGET} ${LIBS}) + TARGET_LINK_LIBRARIES(${TARGET} LINK_PRIVATE ${LIBS}) IF(ARG_OUTPUT_NAME) SET_TARGET_PROPERTIES(${TARGET} PROPERTIES OUTPUT_NAME "${ARG_OUTPUT_NAME}") ENDIF() @@ -282,7 +282,6 @@ MACRO(MERGE_LIBRARIES) ENDIF() MYSQL_INSTALL_TARGETS(${TARGET} DESTINATION "${INSTALL_LIBDIR}" ${COMP}) ENDIF() - SET_TARGET_PROPERTIES(${TARGET} PROPERTIES LINK_INTERFACE_LIBRARIES "") IF(ARG_SHARED AND LINK_FLAG_NO_UNDEFINED) # Do not allow undefined symbols in shared libraries GET_TARGET_PROPERTY(TARGET_LINK_FLAGS ${TARGET} LINK_FLAGS) diff --git a/sql/CMakeLists.txt b/sql/CMakeLists.txt index 0037ff23153..c736b0e82aa 100644 --- a/sql/CMakeLists.txt +++ b/sql/CMakeLists.txt @@ -307,8 +307,7 @@ TARGET_LINK_LIBRARIES(mysqld sql) # Provide plugins with minimal set of libraries SET(INTERFACE_LIBS ${LIBRT}) IF(INTERFACE_LIBS) - SET_TARGET_PROPERTIES(mysqld PROPERTIES LINK_INTERFACE_LIBRARIES - "${INTERFACE_LIBS}") + TARGET_LINK_LIBRARIES(mysqld LINK_PUBLIC ${INTERFACE_LIBS}) ENDIF() # On Solaris, some extra effort is required in order to get dtrace probes