Browse Source

MariaRocks port: Make SQL layer allow errors in start_consistent_snapshot().

rocksdb.cons_snapshot_read_committed test used to crash.
This happened, because
- MyRocks produces an error when one attempts to do a START TRANSACTION
  WITH CONSISTENT SNAPSHOT with @@tx_isolation=REPEATABLE_READ
- MariaDB's SQL layer didn't assume that errors are possible inside
  hton->start_constistent_snapshot() call.
pull/355/head
Sergei Petrunia 9 years ago
parent
commit
4faa9da81c
  1. 4
      sql/sql_parse.cc

4
sql/sql_parse.cc

@ -5428,7 +5428,9 @@ end_with_restore_list:
(longlong) thd->thread_id); (longlong) thd->thread_id);
goto error; goto error;
} }
my_ok(thd);
/* MyRocks: hton->start_consistent_snapshot call may fail with an error */
if (!thd->is_error())
my_ok(thd);
break; break;
case SQLCOM_COMMIT: case SQLCOM_COMMIT:
{ {

Loading…
Cancel
Save