kicad

17233 Commits

14 Branches

135 Tags

2.3 GiB

Tree: eb3d32f967

Commit Graph

Author	SHA1	Message	Date
John Beard	0415c89c5b	Fix broken GetReferencePrefix function This function was incorrectly processing refdeses like "U1000". Change the algorithm to a simpler STL-compatible one and update the tests. Fixes: lp:1813669 * https://bugs.launchpad.net/kicad/+bug/1813669	7 years ago
John Beard	88f9f6f072	Break out ref-des-centric functions to own header This breaks the following functions out to a general-purposed refdes utils header: * MODULE::GetReferencePrefix() * kicad_string.h RefDesStringCompare() This acheives: * Slimming of MODULE interface * Placement of refdes code in common rather than pcbnew ** Testing of this code in qa_common * Tighter and smaller includes for code that only needed refdes functions Note: there are failing tests commited (as expected failures). These are the cause of lp:1813669 and will be fixed as a follow-up commit.	7 years ago

Author

SHA1

Message

Date

John Beard

0415c89c5b

Fix broken GetReferencePrefix function

This function was incorrectly processing refdeses like "U1000".

Change the algorithm to a simpler STL-compatible one and
update the tests.

Fixes: lp:1813669
* https://bugs.launchpad.net/kicad/+bug/1813669

7 years ago

John Beard

88f9f6f072

Break out ref-des-centric functions to own header

This breaks the following functions out to a general-purposed refdes utils
header:

* MODULE::GetReferencePrefix()
* kicad_string.h RefDesStringCompare()

This acheives:

* Slimming of MODULE interface
* Placement of refdes code in common rather than pcbnew
** Testing of this code in qa_common
* Tighter and smaller includes for code that only needed refdes functions

Note: there are failing tests commited (as expected failures). These
are the cause of lp:1813669 and will be fixed as a follow-up commit.

7 years ago

2 Commits (eb3d32f96731c5048a4007ec2054819e960fa114)