e61144d45a
Finish with EDA_ANGLE.
4 years ago
3011ae1d51
PNS: Do not allow smart pads when in 90-degree mode
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10386
(cherry picked from commit cf4d46b24d
4 years ago
0e9cfd0af2
Add missing initialization values to variables
Flagged by Coverity.
4 years ago
57af990066
router: fix layer switch issue when starting a track on via without fixed segments
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/9915
4 years ago
2ae3a83b54
router: fix use-after-free crash in single trace shove routing when m_endItem's owning NODE is erased by the springback algorithm.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/9994
4 years ago
63560ecd7b
Remove RM_Smart state from router tool
It was never fully implemented and there was no way to switch into this
route mode.
4 years ago
a746d31038
PNS: Fix loop removal outside shove mode
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9680
4 years ago
c40e921cb3
router: remeber to make a shove lockpoint when placing a lone via
Note to self: works around a possible bug in CommitPlacement()/RewindToLastLockedNode()
fixes: https://gitlab.com/kicad/code/kicad/-/issues/9695
4 years ago
8ec3ce99ae
PNS: Update shover when autocompleting on item
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9598
4 years ago
59807d8d26
A better solution to discarding pending shove operations
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9553
4 years ago
64f77b3596
PNS: Add support for 90-degree corner modes
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6902
4 years ago
faba2b06c2
Lock track width after placing segment
We don't want to allow the full track width to change after placing a
segment when we are in follow-segment mode. This would require either
ripping up and re-solving the existing track or allowing potential DRC
errors.
Fixes https://gitlab.com/kicad/code/kicad/issues/9395
4 years ago
35e90d0cf4
Allow changing router mode while routing
Keeps shove active even when not using to allow switching modes during
routing.
Fixes https://gitlab.com/kicad/code/kicad/issues/9342
4 years ago
7f1247a23c
Update track width when changed
Tracks starting from pads should change in response to the track width
changing despite having the "follow existing track" width selected.
4 years ago
a03b6f6fc9
router: use tail start point when saving the FIXED_TAIL
fixes: https://gitlab.com/kicad/code/kicad/-/issues/8771
4 years ago
78e5e98ea0
Pass VECTOR2I objects by reference instead of on the stack.
4 years ago
e61b1f03b8
PNS: Discard duplicate tracks in FixRoute
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8737
4 years ago
00f1b609c4
PNS: Don't run fanout cleanup when manually forced
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8724
4 years ago
65c7958293
Coverity issue fixes.
Issues #331869 , #331875 , #332203 , #332159 , #332171 , #332180 , and #332648 .
4 years ago
c3051ba48a
Refactor SHAPE_LINE_CHAIN to allow two shapes per point
m_shapes now has two possible indices. The first one is populated if
the point is associated with an arc and the second index is populated
if the point is shared between two arcs.
5 years ago
740b028180
pns_line_placer: do not constraint the 45deg of current segment in free angle mode.
Fixes #8691
https://gitlab.com/kicad/code/kicad/issues/8691
4 years ago
a7eb611744
Fix leftover vias in shove mode
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8597
4 years ago
75ce97e260
Fix the last cause of duplicate segments when completing a route
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6863
4 years ago
49c5130123
PNS: Implement final cleanup pass for redundant colinear segs
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6863
4 years ago
3c6b98a0d5
PNS: preserve auto-detected track width when changing via sizes
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8046
4 years ago
6cb8154ec0
PNS: Remove code that broke width changes during placement
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8334
4 years ago
6789dac20b
PNS: Keep most recent good placement around for a rainy day
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8562
4 years ago
d32b9c1c25
Use debug group for line placer debug
4 years ago
ab04e24f9a
router: rhMarkObstacles should return a correct error status
Long story short: a few days ago I fixed error handling in routeStep(), so it actually started to recognize the wrong error status returned
by rhMarkObstacles() and think that the trace is always incorrect.
fixes: https://gitlab.com/kicad/code/kicad/-/issues/8557
4 years ago
cf2bb5692a
Remove the wxLog calls from math/util.h for now
This was leaking windows headers and partial wx headers to 1084 compilation units......
This also means math/util.h is leaking to 1084 compilation units which seems a bit high too.
4 years ago
614787caae
router: clear head line geometry if current head routing failed + small improvement to follow-mouse optimization.
Also added a lot of verbosity for the pns-log-viewer tool.
Fixes: 8511
4 years ago
fcb89b99a3
router: walkaround algo should not copy the previous via position when the current iteration via placement fails.
fixes: 7827
4 years ago
bd59da3642
PNS: Local min distance has a minimum points requirement
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8510
4 years ago
ebd957b08e
router: rework router's debugging infrastructure to be more compatibile with the 'qa/pns/pns-log-viewer' tool.
The log viewer tool lets you inspect all the intermediate stages of the routing algorithms. This patch:
- Adds source location tracking of the debug calls (need to use the PNS_DBG macro, sorry)
- Moves some wxLogTrace calls to DEBUG_DECORATOR::Message() so that messages can be displayed alongside the corresponding geometric shapes
4 years ago
132eb53a40
router: clean some debug clutter
4 years ago
e66bbfd1ec
router: improve the feel of the walkaround algorithm
Makes walkaround more 'huggy' - the trace being routed sticks to obstacles
instead of jumping around in uncontrollable way.
4 years ago
8c4361bbc6
router: adapt to new SHAPE_LINE_CHAIN::INTERSECTIONS structure
4 years ago
dd828bd964
PNS: Bring back original Highlight Collisions behavior
From discussion with Tom, Jeff, and Wayne, it appears as though
we all agreed that Highlight Collisions should behave like it
did in 5.1, which is to say, always just highlight collisions,
never prevent them. The Allow DRC Violations checkbox just
controls whether or not you can fix/commit the head line if it
has violations; you are not prevented from moving the head
line to violating positions in any case.
Right now, there does not seem to be much demand for a separate
"Stop at First Obstacle" mode since Walkaround basically does that
but better, but we agreed that if there is demand for it in the
future, it should be implemented as a new router mode rather than
a behavior of Highlight Collisions mode controlled by the Allow
DRC Violations checkbox.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7828
5 years ago
dc0cf3b802
Clean up a confusing API.
AllowDRCViolations is kept in any mode as a *setting*, but only
controls router behaviour when the mode is mark obstacles.
Fixes https://gitlab.com/kicad/code/kicad/issues/7795
5 years ago
df99ee39d9
PNS: new through vias should span all copper layers
Fixes https://gitlab.com/kicad/code/kicad/issues/7576
5 years ago
79a9d69ff5
Coverity fixes for issues 314755, 316287, 324536, 324539, and 324539.
5 years ago
d269778cd4
PNS: disable smart pads in walkaround if posture is forced
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7710
5 years ago
f84836f51e
router: factor out POSTURE_SOLVER to more generic MOUSE_TRAIL_TRACER class
5 years ago
330d717c69
Fix typo
5 years ago
111fa99f9f
PNS: Use last-segment posture optimization always
Also when auto-posture is enabled, don't flutter
until area threshold has been met.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6935
5 years ago
0234b7278a
PNS: Make DIRECTION_45 North be up everywhere
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6935
5 years ago
8619086cf2
PNS: re-enable optimization of colinear segs in lines with arcs
5 years ago
8901e71fc8
PNS: Fix loop removal, make walkaround less broken for arcs
5 years ago
d24b034cbc
Cleanup (and a minor performance improvement).
5 years ago
eba7cb222c
PNS: Fix initial posture guess for pads
5 years ago
Jeff Young
Jon Evans
Ian McInerney
Tomasz Wlostowski
Johannes Pfister
Seth Hillbrand
Wayne Stambaugh
Roberto Fernandez Bautista
jean-pierre charras
Marek Roszko
david-beinder