Seth Hillbrand
96297b50a1
Remove padstack offset value
We encode the pad locations for the package in the pin, so we don't need
an additional offset from the pin location
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16767
2 years ago
Jeff Young
3fde08f711
Attempt to escape from MacOS menubar crashbug.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16738
2 years ago
jean-pierre charras
89f8c5d918
PCB_SELECTION_TOOL::selectPoint() Remove items disabled by the selection filter
before using any other filter. This avoid to select an item from the candidate
list that cannot be selected and eliminate another candidate.
Fixes #16755
https://gitlab.com/kicad/code/kicad/-/issues/16755
2 years ago
Jeff Young
fb8f05fb34
Correctly report body style in symbol checker.
Also fixes a bug where off-grid pin locations were truncated.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16770
2 years ago
Jeff Young
cc9f8f5b83
Fix a straggler from rename.
2 years ago
Seth Hillbrand
3cf8b718f3
Don't truncate if not needed
2 years ago
Seth Hillbrand
bcad0761a4
Fix compile error
2 years ago
Jeff Young
ae735d3eb4
Renaming: replace convert with body-style.
No functional changes.
2 years ago
Jeff Young
c5bd62434b
Zero out number of non-numberable pads in ImportSettingsFrom().
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16769
2 years ago
Jeff Young
053a0aade7
Formatting & commenting.
2 years ago
Wayne Stambaugh
8975f26c26
Coding policy fixes.
2 years ago
Jon Evans
c39bec4c08
SCH_FIELD.Visible can be unmasked
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16760
2 years ago
Jeff Young
cc058a7927
Exit pad edit mode before closing footprint editor.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16766
2 years ago
Jeff Young
f4e123f57e
!m_isBoardEditor != m_isFootprintEditor.
(There's also python, cli, etc.)
2 years ago
Jeff Young
e99f758447
Revert b8a2b3b2bf.
2 years ago
Marek Roszko
991703ceee
Add missing default init
2 years ago
jean-pierre charras
12357cfba6
symbol checker: do not forget to display error messages about pins not on grid.
Fixes #16759
https://gitlab.com/kicad/code/kicad/-/issues/16759
2 years ago
jean-pierre charras
74e02d7701
Eeschema, open CvPcb: ensure the netlist sent to CvPcb is up to date.
Fixes #16762
https://gitlab.com/kicad/code/kicad/-/issues/16762
2 years ago
Marek Roszko
7f5433f0f2
Realize why we sch parity wasnt included in cli drc
Need to add schematic loading...to the pcbnew jobs handler
2 years ago
Marek Roszko
465ccaef90
Add missing schematic parity drc test to cli
2 years ago
Marek Roszko
a282762686
Fix pcb drc in cli due to awkward !m_isBoardEditor logic with more awkward logic
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16744
2 years ago
Seth Hillbrand
ec82a1b4e2
Fix duplicate pin check string
MessageTextFromValue returns text not floating point
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16758
2 years ago
Marek Roszko
c2989132ac
DeselectRow as we delete rows to avoid asserts
2 years ago
Marek Roszko
5d44e090dc
Fix shadowed var
2 years ago
Seth Hillbrand
bba0a8d038
Protect schematic undo list actions
The undo/redo lists can have non-SCH_ITEM elements such as worksheet
items. When re-doing connectivity, we only need the schematic items, so
we pass on these
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16752
2 years ago
Jeff Young
b8a2b3b2bf
Take a stab at fixing #16752 .
2 years ago
Wayne Stambaugh
4d6bbc8caa
Fix symbol annotation when pasting nested hierarchical sheets.
2 years ago
Seth Hillbrand
9e9dfb38d1
IPC2581: Correct flipped pad handling
Board footprints have pads already flipped, so we don't need to adjust
layers when outputting
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16659
2 years ago
Alex Shvartzkop
6a69396070
Allow column auto-sizing in RC trees.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16727
2 years ago
jean-pierre charras
2e760483b0
HIERARCHY_PANE: Update tree labels when editing a sheet name or number
Fixes #16650
https://gitlab.com/kicad/code/kicad/-/issues/16650
2 years ago
Jeff Young
a2b204572d
Don't assert when a sim returns no results.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16749
2 years ago
Jeff Young
70bca8bc4e
Provide popups for inductor references.
Also fixes a long-standing bug deleting the last field of
a symbol in the Symbol Editor.
2 years ago
Jeff Young
340d1b7fad
Guard against nullptr access.
2 years ago
Jeff Young
b3f94ad46a
Cleanup before exit.
Possibly KICAD-5TE.
2 years ago
Jeff Young
d3bc59e0e7
SelectBlock() will assert for invalid selection modes.
KICAD-63D.
2 years ago
Jon Evans
a377fa4201
Add some missing deep comparisions for BOARD_STACKUP
2 years ago
Marek Roszko
fec57459f3
Use correct arg types in altium arc import error message
Fixes KICAD-6Q1
2 years ago
Jon Evans
bfbf000f60
Add some safety around event-driven menubar recreation
Maybe addresses sentry KICAD-PC
2 years ago
Jon Evans
3ef16221fe
Make sure default board thickness exists
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16733
2 years ago
Marek Roszko
c816280c6d
Move the current selection before deleting the row to avoid asserts
Fixes sentry KICAD-63D
2 years ago
Marek Roszko
5321c1c481
Create the import directory if it doesn't exist
Fixes sentry KICAD-6BC
2 years ago
Marek Roszko
b8bbbcf410
Fix assert in SYMBOL_VIEWER_FRAME::onSelectNextSymbol due to bad current selection check
Fixes sentry KICAD-6KE
2 years ago
Marek Roszko
8f57a9bcf0
Fix spacemouse version check by pawning it off on wxWidgets
Version is a value not a key name. Also the registry returns things in wchars soooo lets just pawn off the encoding mess on wxWidgets
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16730
2 years ago
Jon Evans
5d7eac7677
Allow for empty LIB_PART in certain symbol functions
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16731
2 years ago
Alex Shvartzkop
13f8fd77ac
wx 3.3 compatibility.
2 years ago
Jeff Young
b8b4ea1a45
Comments.
2 years ago
Ian McInerney
d04b21c6d6
Ensure parameter typeinfo matches the actual object's typeinfo
AppleClang seems to generate different typeinfo for forward declarations
of classes than the actual class object, so the any_cast for the pointer
parameter fails due to the types not matching (even when they look the
same when printed in the error).
Instead, we must always ensure we use the actual object when defining
the parameter type when placing the object into the event.
2 years ago
Jeff Young
a5ee614ae8
Comments.
2 years ago
Jeff Young
65c75072ef
Convert between refs and KIIDs in Footprint Properties.
Also fixes DIALOG_TEXT_PROPERTIES, which did it correctly
for multi-line texts, but not for single-line texts.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16721
2 years ago
Jeff Young
89850824d5
Naming & comments.
2 years ago