Seth Hillbrand
0b2d4d4879
Revise Copyright statement to align with TLF
Recommendation is to avoid using the year nomenclature as this
information is already encoded in the git repo. Avoids needing to
repeatly update.
Also updates AUTHORS.txt from current repo with contributor names
11 months ago
jean-pierre charras
edd7f5e229
BOARD_COMMIT::Revert(): protect against null pointer.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/19011
1 year ago
jean-pierre charras
b2be5798cd
Fix a typo probably due to a paste command.
1 year ago
Jeff Young
94f995c49e
Reduce dependency on dynamic_cast.
(Especially where it is no-worky on MacOS.)
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17245
1 year ago
jean-pierre charras
4ce9648d34
Fix a few minor Coverity and compil warnings.
1 year ago
Tomasz Wlostowski
a4936964e2
pcbnew: fix rebase issue in BOARD_COMMIT
2 years ago
Tomasz Wlostowski
048bbcb02b
BOARD_COMMIT: allow to make PCB-editor specific commits outside the actual pcbnew
Useful for testing pcbnew's tools without building the actual pcbnew.
2 years ago
jean-pierre charras
8d53090581
Pcbnew: fix 2 issues after removing a track, especially ending on a teardrop
- Message panel display not always correctly updated (shows an old data)
- Incorrect updated ratsnest is some cases when removing a track ending on
a teardrop.
1 year ago
Jeff Young
b8819b4636
Another reduction in asserts.
1 year ago
Seth Hillbrand
cc850d0da0
Split out LSEQ/LSET from LAYER_ID
Separate the layer grouping classes for easier modification
1 year ago
JamesJCode
36c33e1ad4
Call board listeners after updating connectivity
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18277
(for v9)
1 year ago
Jeff Young
9fb07d886e
PCB_GENERATOR_Ts are PCB_GROUP_Ts too.
Also, an item must already be in a commit to add it to a group.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17595
1 year ago
JamesJ
951065390e
Add composite update callback to BOARD_LISTENER
Required for net inspector otherwise composite operations (such
as undo / redo, and length tuning) can result in multiple add /
remove events firing which results in inconsistent length state.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17527
(for 9.0)
2 years ago
Jeff Young
4ed2a0674a
Minor cleanup.
2 years ago
Seth Hillbrand
6a8d2a7eb3
Store group id rather than group
We only need the group storage id for lookup. Storing the KIID instead
of a copy of the group avoids unneeded overhead
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17175
(cherry picked from commit 7d1adff071 )
2 years ago
Jeff Young
e445249720
ADDED: PCB tables.
2 years ago
Jeff Young
995c4af51d
Deleted items must have their ownership changed to undo/redo.
2 years ago
Jeff Young
eacebe63f1
We do undo on individual footprint children now.
Adding a commit record for the parent means we replace the
parent first on undo and then if a child was added we can't
find it to remove it.
2 years ago
Jeff Young
07cefa7883
More active tracking of undo/redo items.
2 years ago
Jeff Young
f4e123f57e
!m_isBoardEditor != m_isFootprintEditor.
(There's also python, cli, etc.)
2 years ago
Marek Roszko
a282762686
Fix pcb drc in cli due to awkward !m_isBoardEditor logic with more awkward logic
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16744
2 years ago
Jeff Young
9d88a9f60a
Fix typo causing OnItemsChanged() to get called too often.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16657
2 years ago
Jon Evans
d50e0811fb
Fix QA build
2 years ago
Jon Evans
a46d409ec6
Make sure grouping commits follow board editor path
2 years ago
Jeff Young
d6b39c672e
Footprint editor items always get added to footprint.
Also fixes an unrelated crash when assuming the current
editor is the board editor.
2 years ago
Jeff Young
e55ec85e19
Remove added items from group on revert.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16562
2 years ago
Jeff Young
1f627a3a75
Fix two unrelated bugs in ungroup.
1) Don't double-remove the members from the group.
2) Don't auto-recurse BOARD_COMMIT::Stage for non-modify
changes.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16419
2 years ago
Jeff Young
08a00633b1
Make sure child items get edit flags cleared in commit.
In the footprint editor, in particular, we often just
add the parent footprint to the commit rather than the
actual modified item(s).
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16389
2 years ago
Jeff Young
1b0cc82c56
Move a couple of stragglers to BOARD_COMMIT.
2 years ago
Jeff Young
b29a56530c
Remove undo-of-ungroup hack.
The hack assumed that the parent group would be the first
deleted item of type group in the undo list. While this
will be true when undoing a user ungroup command, it will
not be when undoing an ungroup side-effect, such as when a
member of a group is deleted during UpdateFromPCB.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16384
2 years ago
Jeff Young
9fb06f95a0
Fix msys2 build.
2 years ago
Jeff Young
ea3c87f243
Move group/ungroup to COMMIT infrastructure.
2 years ago
Jeff Young
ca8cb5a206
Fix typo.
We want recursion into descendants here. Alternatively we could
change the caller to RunOnDescendents(), but it seemed cleaner to
omit the scoping of the Stage() call....
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16077
2 years ago
Jeff Young
cc721c4907
Improve encapsulation of group internals.
(It's still leaking into BOARD_COMMIT and some other places, but at
least it no longer leaks into all the edit tools.)
Also fixes some bugs when moving/copying/pasting multiple selections
containing length-tuning patterns.
2 years ago
Jeff Young
791aa64950
Functionally it's a "reference image".
The implementation happens to be a "bitmap".
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15932
2 years ago
Jeff Young
504652b972
Regularize RunOnChildren() at the BOARD_ITEM level.
BOARD_ITEM sub-classes which don't have children simply don't
overrid it.
2 years ago
Alex Shvartzkop
be72e07e61
Introduce PCB_GENERATOR.
2 years ago
Jeff Young
2d762acc7d
Remove accidentally-checked-in debugging code.
2 years ago
Jeff Young
69a1b30b8a
Implement undo/redo around Pad Edit Mode changes.
2 years ago
Mike Williams
3cd25f0045
PCB: add ratsnest to search pane
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/15338
2 years ago
Jeff Young
b986391a04
Remove stale teardrops before rebuilding connectivity.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15398
2 years ago
Marek Roszko
812143ac69
ADDED: Run PCB DRC via cli
2 years ago
Jeff Young
e2aa3aae8a
Don't delete items out from under undo lists.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15253
2 years ago
Jeff Young
a09a5cb641
More undo cleanup.
The symbol editor has few enough items that it will still be performant
if we always send a selected-item-modifed event. (As it turns out we
were doing that anyway as the check for child-modified flags didn't
also check for selected.)
2 years ago
Jeff Young
1218f61d0a
Implement undo/redo for footprint children.
Our special-cases to handle the fact that we didn't do this had far
outgrown the code necessary to actually handle it.
2 years ago
Jeff Young
c3222b0652
Clear edit flags on footprint children in footprint editor.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15199
2 years ago
Jeff Young
d02e94805a
Store original boardItem (before promoting ent.m_item to parent footprint).
2 years ago
Jeff Young
cf8294b5c2
Remove a bunch of blind (and a few redundant) static_casts.
2 years ago
Jeff Young
67c9d3932b
Another attempt to fix qa error.
2 years ago
Jeff Young
9ff33e5ec6
Remove BOARD_COMMIT( TOOL_MANAGER ).
It initializes both m_isFootprintEditor and m_isBoardEditor to false,
causing all sorts of trouble.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15072
2 years ago