e427099cff
Disable flaky ngspice tests
These need to be re-done in a way that is more
tolerant of the inherent instability/noise in
the simulated circuits (or more ideally, changed
to test a particular thing that can be more
well-defined rather than just simulating a circuit
and seeing if the numbers come out a certain way)
2 years ago
1e6986d2f5
Don't report starved thermals when connected only to isolated islands.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16866
2 years ago
86368abba2
pns_debug_tool: Add Emacs as IDE option for Wayne, maybe?
2 years ago
366d8ecb73
pns_debug_tool: Add combobox to select IDE (CLion / VS Code)
2 years ago
7cc663ad77
Schematic parity checking for CLI DRC.
2 years ago
3a95bd1bd1
pns_debug_tool: Add option to go to definition in vs code
Todo: add a way to add other IDEs and select them via GUI or
advanced config
2 years ago
7276486756
Finish fixing SHAPE_LINE_CHAIN::Slice
2 years ago
79aba50c23
Finish fixing SHAPE_LINE_CHAIN::NextShape and add tests
2 years ago
70f14277d1
PNS Debug/regresions: Fix some memory leaks
2 years ago
effed5dfdf
Fix SHAPE_LINE_CHAIN::Remove and SHAPE_LINE_CHAIN::RemoveShape
2 years ago
673e23c2e6
Fix and simplify SHAPE_LINE_CHAIN::Append( SHAPE_ARC ) + QA tests
2 years ago
34942290a2
SHAPE_LINE_CHAIN: Fix SetClosed() logic
SetClosed should unwrap the chain when there are coincident points at the
start.
2 years ago
7593863245
SHAPE_LINE_CHAIN: Fix and simplify ShapeCount()
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15754
2 years ago
c72ba189cf
Fix SHAPE_LINE_CHAIN::Slice following NextShape() changes
2 years ago
e9fbb36538
SHAPE_LINE_CHAIN: Fix and simplify NextShape() + remove PrevShape()
NextShape() function was too complex (trying to go back and forwards).
We only used PrevShape() in one place, so removed that usage.
Added QA tests
2 years ago
079478f989
EDA_ANGLE: use constexpr for constant angles
Remove all statics in the class and instead use constexpr to
ensure correct ordering
2 years ago
ae735d3eb4
Renaming: replace convert with body-style.
No functional changes.
2 years ago
1981997ee2
Dump the ERC report as part of the erc failure
2 years ago
37c185f437
Remove overly-complex snapping layer for moving objects.
We now have a hotkey to select Active Layer vs All Layers,
which gives the user more control.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16683
2 years ago
e04cd8743c
Separate out Pad_Shape so auto-complete can work.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16566
2 years ago
27c253780d
Separate out Pad_Shape so auto-complete can work.
2 years ago
a523c58530
Add a m_forceMarkObstaclesMode warning when violating DRC.
Also adds a modifier combination to commit anyway.
2 years ago
104aa1abe4
Change prettifier QA to not depend on file format changes
Instead of writing out and reading back in using the plugin,
just test the formatter itself.
Also add support for testing full boards.
2 years ago
58b7eda47a
QA test( test_prettifier) update golden files and fix a warning message.
2 years ago
751c88ef20
Use 'uuid' (not 'id') in the s-expr PCB groups/generator format
Add some regression tests to check loading of groups and generators
from various versions of the s-expr PCB format.
2 years ago
ea0673e7a0
Do not merge buses of distinct types
Previously, this code would merge a vector bus
with a group bus containing the vector as a member.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16439
2 years ago
2ecf1ac23f
Change regression test for #13162 to be less complex
We are really only testing that `Rload1` works,
and the original testcase is unstable on some platforms.
2 years ago
f2702b223c
Introduce base IO_MGR class and unify RELEASER objects
The IO_RELEASER is a thin-wrapper around a std::unique_ptr, but done
this way to allow easier addition of a custom deleter in the future if
something needs to call back into the IO_MGR.
2 years ago
9a890cdba9
Kick the wildcards and file exts into a static class, export it from kicommon
2 years ago
9799a7ddcc
Fix broken build due to missing rename
2 years ago
e6632bb983
Rename PCB IO classes/files
2 years ago
85f62c1fde
Rename all schematic IO plugins
2 years ago
d8b47d18d3
Initial rename of file plugin infrastructure components to IO
2 years ago
5c334c147b
Make some types auto-reference to prevent copies
2 years ago
a4b38fbb80
Coverity warning fixes.
2 years ago
eb3fd10af8
Fix obscured object selection issue in board and footprint editors.
This selection improvement feature is hidden behind the advanced
configuration key "PcbSelectionVisibilityRatio". It is turned off (1.0)
by default. Value values are from 0.0 to less that 1.0. From testing,
using a value between 0.1 and 0.3 produces the best results.
This fix uses normal alpha blending described in the link below. The
current design only uses the alpha of the object's color. It could be
improved by doing a full color alpha blending but using the color alpha
alone seems to result in satisfactory results.
https://en.wikipedia.org/wiki/Alpha_compositing
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16126
2 years ago
d8b1e3fcb3
test_prettifier: Better warning message for commit 8e647c24
2 years ago
8e647c24b4
QA test, prettifier: Update golden files to the latest version.
Add also a warning when a golden file is too old and creates comparison error.
2 years ago
e41f5efb03
Use modern bool style for footprint locking (locked yes)
Add some simple tests for specific footprint load/save checks
(including round-trip stability)
2 years ago
481fa1f959
Allow PCB reference image locking and UUID to be saved
Add some unit tests for reference image saving/loading.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/16334
2 years ago
b9a5e04ad0
Workaround to fix a QA not working test on platforms is Python older than 3.9
A Pcbnew Python test in QA cli (to test SVG outputs) fails in old Python
because it uses a function only existing in Python 3.9 and newer.
So skip this test for older Python version
2 years ago
11be5d6f1d
Improve error handling when reading test board data
2 years ago
078ba510b4
Remove empty QA layer test file stub from build list.
2 years ago
5fa274ead0
Add board layer view stack up sequence from front layer to back layer.
The old bottom to top layer stack up sequence from back to front layer was
only used for plotting so it was renamed appropriately. This will be used
for future board object select disambiguation improvements.
2 years ago
1adf96d879
Update gold failure count.
2 years ago
931cec862e
Non-plated slots are effectively edges.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16267
2 years ago
e0a34efcb7
Use a more self-documenting API for router preview item flags.
Also fixes a bug where rule areas were drawn with solid fills.
2 years ago
096bcff160
Try to fix a QA not working test on W10/msys2.
Probably due to a not closed file when trying to delete it.
2 years ago
343828c552
Fix invalid string compare in IBIS parser
strcmp returns 0 if strings are the same but compareIbisWord returns
True (1).
Adds an IBIS simulation QA test case to catch this in the future
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16223
(cherry picked from commit ef8b6bf9e1
2 years ago
56b7f91361
Format the std::filesystem path directly
2 years ago
Jon Evans
Jeff Young
Roberto Fernandez Bautista
Marek Roszko
jean-pierre charras
John Beard
Ian McInerney
Wayne Stambaugh
Seth Hillbrand