9805aca5a0
Handle backslash-escaped quotes in libeval.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15786
2 years ago
3a40b59cd3
Ensure lazy evaluation of DRC rules works on all compilers.
2 years ago
ecb2fcd559
Don't trip over null strings.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14989
2 years ago
cb53a18ee3
Bug fixes for handling boolean flags in DRC rules.
2 years ago
4e99812145
Coverity fixes and code cleaning.
3 years ago
4665823089
Turn on and fix MSVC compliance mode issues
We want /permissive- to enable debug performance improvements in MSVC 17.5+.
This flag is also default under C++20 so we'll have to deal with these compile issues anyway at some point in the future.
In particular, MSVC becomes pedantic about ternary types.
See https://learn.microsoft.com/en-us/cpp/build/reference/permissive-standards-conformance?view=msvc-170#ambiguous-conditional-operator-arguments
MSFT cites https://cplusplus.github.io/CWG/issues/1805.html
3 years ago
8260f0ee13
Add support for unitless values to PCB_EXPR_EVALUATOR.
Fixes https://gitlab.com/kicad/code/kicad/issues/13016
3 years ago
62863d6c5b
Ensure that we clear deleted values
When throwing on an invalid value, we may end up freeing the same tree
twice. This is generally not an issue but we need to mark the freed
memory as null to avoid a double free
Fixes https://gitlab.com/kicad/code/kicad/issues/12981
3 years ago
5e7c4b734c
Small optimizations in DRC and SHAPE_POLY_SET.
3 years ago
3d5913c825
Remove convert_to_biu.h, merge contents to base_units.h
3 years ago
cf1565a16a
Bug fixes for layer expression processing.
1) Push a VAR onto the stack, not a resolved value
2) Don't collapse a PCB_LAYER_VALUE to a VALUE during processing
3) Make sure we run overloaded operators from the correct side
Fixes https://gitlab.com/kicad/code/kicad/issues/12437
3 years ago
b00178adb3
Nuke base_units from orbit
3 years ago
6cec58cf75
Add field access to custom DRC rules.
ADDED getField() method to custom DRC rules.
4 years ago
1a252b4f96
Add a compile error for ill-defined rules, and more performance.
Also adds const-safety to GetBoard().
4 years ago
6aaf4413b3
Fix kicad_string.h / string.cpp mismatch.
They don't define a KiCad string class, so the header file name was
somewhat misleading. But the fact that they didn't match definitely
made coding more difficult.
4 years ago
6c3ba1c20b
Coverity issue fixes.
Issues #332032 , #332086 , #332157 , and #332171 .
4 years ago
65c7958293
Coverity issue fixes.
Issues #331869 , #331875 , #332203 , #332159 , #332171 , #332180 , and #332648 .
4 years ago
cf2bb5692a
Remove the wxLog calls from math/util.h for now
This was leaking windows headers and partial wx headers to 1084 compilation units......
This also means math/util.h is leaking to 1084 compilation units which seems a bit high too.
4 years ago
4a77a4080d
Fix Coverity warning.
4 years ago
e93e9fa3e5
Add rudimentary type checking to rule eval with reporter.
Also cleaned up existing error reporting to not expend CPU cycles
when there was no reporter.
Fixes https://gitlab.com/kicad/code/kicad/issues/8438
4 years ago
b1fa02bcc8
Push a non-existent ref's value as 0. (Don't just crash.)
Fixes https://gitlab.com/kicad/code/kicad/issues/7971
5 years ago
5c17ff0595
Libeval: don't try to dereference invalid STRUCT_REF parent
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7764
5 years ago
1ce1e493d6
A rule zone is not really a BOARD_CONNECTED_ITEM.
Or at least it shouldn't always be treated as one.
Fixes https://gitlab.com/kicad/code/kicad/issues/6382
5 years ago
31e626f279
Cleanup creation of all our smart pointers
5 years ago
948036372e
Ban unitless numbers in DRC rules.
Fixes https://gitlab.com/kicad/code/kicad/issues/6029
5 years ago
a1c75748a0
Remove GetChars(), a wxWidgets 2.9 compatibility hack
5 years ago
ebd5dc81cc
Fix some more cases of malformed syntax crashing the compiler.
Fixes https://gitlab.com/kicad/code/kicad/issues/6016
5 years ago
f7d3dddd6d
Fix format argument assertion in libeval_compiler
5 years ago
39995341d9
Compile fixes
Fix compile error
Fix string format to use %ld instead to work on clang in CADSTAR Archive importers
Add virtual destructor to CONNECTION in CADSTAR_ARCHIVE_PARSER
5 years ago
78fc0349a9
libeval_compiler: free tree in destructor, warning fixes
5 years ago
d2ed27b500
libeval_compiler: fix string comparison
5 years ago
0c885c9c31
libeval_compiler: == operator now does wildcard string comparison
5 years ago
5023d9a780
libeval_compiler: initial support for multiple (>1) function/method arguments
5 years ago
0763a8962c
Implement boolean not processing in expression language.
Also adds some more error catching to be more robust in the face
of malformed customer rules.
Fixes https://gitlab.com/kicad/code/kicad/issues/5694
5 years ago
80acf944a0
Don't assert when compiling rules; generate a user-visible error.
Fixes https://gitlab.com/kicad/code/kicad/issues/5694
5 years ago
712215fe12
libeval_compiler: fix crash when preflighting method calls with 0 arguments
5 years ago
466cbe2f00
libeval_compiler: fixhandling of method calls with empty argument list (e.g. 'A.method()' )
5 years ago
a35698f08a
Don't fire non-well-formed rules. (But don't assert either.)
Fixes https://gitlab.com/kicad/code/kicad/issues/5443
5 years ago
050bbcdb4f
Fix error reporting from function pre-flighting.
5 years ago
d7f26cfdf2
Fix test failures.
5 years ago
b42395ec8d
Attempt to fix locale issue with decimal separator in rules.
5 years ago
ec5040aff5
Fix missing 'else' and EOF processing, both of which cause crashes.
5 years ago
edda024285
Fix up some Coverity and CLion warnings.
5 years ago
ab17f4b7b5
libeval_compiler: thou shalt not use strlen() on wxStrings. Works under Linux, doesn't work on OSX/MSVC...
5 years ago
519bc80394
Replace error reporting in DRC rule compiler.
5 years ago
0b17dbd123
Fix nesting issues in the DRC rule expression code generator.
We were executing function calls multiple times because we were
processing them at a depth the traversal algorithm wasn't expecting.
5 years ago
518a659185
Post-rebase fixes
5 years ago
4abe71d2ef
libeval_compiler: implemented unary +/- operators
5 years ago
c88c8102e5
libeval_compiler: fixed segfault for "(number)" expressions.
5 years ago
a5a06e3c89
libeval_compiler: general clean up of the Lemon grammar + some smart pointers + killed all memory leaks. WIP!
5 years ago
Jeff Young
Wayne Stambaugh
Marek Roszko
Seth Hillbrand
Alex
Jon Evans
Ian McInerney
Roberto Fernandez Bautista
Tomasz Wlostowski