6f8a0a4eed
pcbnew: Fix launching of action plugins from an action menu
The action menu handler was capturing too many menuitem events.
Only context menuitem highlight events and some popup menu events need to be captured
Any id < 0 (like automatically assigned menuitem id) is no longer captured.
Fixes: lp:1831669
https://bugs.launchpad.net/kicad/+bug/1831669
6 years ago
6936effaa7
Implement undo for Page Settings in PlEditor, Eeschema and PCBNew.
Fixes: lp:1820059
* https://bugs.launchpad.net/kicad/+bug/1820059
6 years ago
32f25cf8b4
ACTION_MENU::appendCopy: Fix an issue on Windows with Check-able menu-items.
The source bitmap was copied to the new created item.
However, for Checkable menu-items, when setting a bitmap, our standard check bitmap is also added.
This is unwanted when the source bitmap is the wxNullBitmap (bitmap sizes are different)
7 years ago
83e08c9277
Fix crash in Eeschema when clicking on a menubar item.
It happens if an other frame (libedit) was opened, a menubar clicked, an this frame was closed.
7 years ago
0047f88f82
Mark unfold bus menu as clean so it doesn't get generated a second time.
Fixes: lp:1829878
* https://bugs.launchpad.net/kicad/+bug/1829878
7 years ago
06b22594ca
libedit: Prevent null dereference in popup
Lack of tool manager can happen when the popup is not connected to the
main tool.
Fixes: lp:1829825
* https://bugs.launchpad.net/kicad/+bug/1829825
7 years ago
aee1fe45f4
Fix a few issues related to Bitmaps in menus.
- fix missing icons.
- remove duplicate (and incorrect) code to set these icons in wxMenuItems
7 years ago
62a5302bc4
Fix issues created by commit cbb0d74bd5.
This commit redirected too many menuitem IDs to the tool manager.
Only some context menu items have to be redirected, not all inside ACTION_EVENT events.
This hack is not perfect. It needs a better handling of ACTION_EVENT handling.
7 years ago
cbb0d74bd5
Ensure all custom event ids are processed by ACTION_MENU
Fixes: lp:1829759
* https://bugs.launchpad.net/kicad/+bug/1829759
7 years ago
f53c42fac9
Fix another instance of wxGTK not liking menu icons
7 years ago
f21faceb74
A hack to work around wxWidgets failure to capture WX_MENU_OPEN events
See the comments. It's not pretty, but it works.
Fixes: lp:1829640
* https://bugs.launchpad.net/kicad/+bug/1829640
Fixes: lp:1829307
* https://bugs.launchpad.net/kicad/+bug/1829307
Fixes: lp:1594029
* https://bugs.launchpad.net/kicad/+bug/1594029
7 years ago
7d9a0b06e0
Push help menu down into EDA_BASE_FRAME.
7 years ago
69afa27a5f
Implement ACTION_TOOLBAR and update some of the menus to ACTION_MENU.
This gives us better separation of MVC in line with the design of
the modern toolset. It also reduces a whole bunch of duplicated
data.
7 years ago
f9e4ee1fc9
CONTEXT_MENU -> ACTION_MENU. (Now used for menu-bar menus too.)
7 years ago
ef5c69167a
Start moving some LibEdit and SchEdit menubar menus to actions.
Also includes a bunch of bug fixes that got intermingled.
Fixes: lp:1828826
* https://bugs.launchpad.net/kicad/+bug/1828826
Fixes: lp:1828826
* https://bugs.launchpad.net/kicad/+bug/1828826
Fixes: lp:1828793
* https://bugs.launchpad.net/kicad/+bug/1828793
7 years ago
6e695aac25
Move bus unfold and symbol unit selection to modern toolkit.
7 years ago
9f21d32563
Fix a compatibility issue with wxWidgets 3.1.2 (MSW specific)
7 years ago
cd5b1c2885
set_wxMenuIcon: prevent null pointer dereference
7 years ago
122d7ed3b3
Improve document file handling.
Fixes: lp:1779512
* https://bugs.launchpad.net/kicad/+bug/1779512
7 years ago
5f3ee1e7ce
More g_UserUnit erradication.
(cherry picked from commit 3f08780)
7 years ago
7841f8a466
Unified preferences dialog framework.
(cherry picked from commit 8ee3e77)
8 years ago
8b94606fb5
Promote selection up context menu hierarchy.
This is so that tools checking for a selected item won't think
the menu has been cancelled if the selection was in a submenu.
Fixes: lp:1758372
* https://bugs.launchpad.net/kicad/+bug/1758372
8 years ago
c18b638c17
Cosmetic enhancement in GAL: disambiguationMenu: add icons in menuitems, like in Legacy mode.
8 years ago
788972554b
minor fix
8 years ago
eb2340bc23
Show/Hide icons in menus (according to Icons option) in GAL, like in Legacy mode.
Cosmetic enhancement in Gerbview context menu.
8 years ago
d7bf44eee0
Removed a few more headers from base_struct.h
9 years ago
ca91c27852
Adjust pad sub-menu enablements
The apply settings and push settings options now take account of the
validity of the global pad settings when deciding whether to show or
not.
Global pad push now requires a source pad and doesn't push from the
global pad setting when there is no selection.
The whole submenu is hidden when there are no enabled items.
Fixes: lp:1664016
* https://bugs.launchpad.net/kicad/+bug/1664016
9 years ago
283ba553ba
Change wxItemMenu GetLabel (deprecated) to GetItemLabelText
GetLabel can compile or not, depending on the compatibility level used to build wxWidgets.
9 years ago
1bcbbb41cd
Fixed double menu entries in context menus
9 years ago
060e163511
Fixed invoking TOOL_ACTIONs in submenus
Fixes: lp:1663101
* https://bugs.launchpad.net/kicad/+bug/1663101
9 years ago
8f82f04153
Copy menu title in CONTEXT_MENU::copyFrom()
9 years ago
1102eb0d0d
Store menu titles in CONTEXT_MENU
Previously a title had to be provided when a submenu was added,
but this led to storing the same title in many places.
9 years ago
fc7be1a497
Removed redundant CONTEXT_MENU::m_parent field.
9 years ago
682da70a86
Fixed the issue of creating and event handling in context menus (GAL).
When creating a copy of CONTEXT_MENU, always a CONTEXT_MENU instance was
constructed, whereas an inherited type should be used. Solved with
CONTEXT_MENU::create() that has to be overridden in inheriting classes.
Event & update handlers are now virtual functions, instead of setting
the handlers with Set{Event,Update}Handler().
9 years ago
fde12ebd25
Replace boost::function and boost::bind with their std:: counterparts
9 years ago
a09d6431e4
Coverity report fix: handle an exception potentially thrown by CONTEXT_MENU::runOnSubmenus.
10 years ago
9c2bcb2f3c
Fixed crash on right click on zone with GAL mode.
10 years ago
29cbaa206e
Fixed updating of Zoom & Grid context menus.
10 years ago
094c286024
Fixed issues reported by Coverity.
10 years ago
e9921d8eea
Fixed an assert when footprint viewer was closed before the pcbnew window.
10 years ago
d6bc33bd42
Removed a few more memory leaks and fixed crash on exit.
10 years ago
4661e39e08
Fixed displayed modifiers for hotkeys in context menus (GAL).
10 years ago
a988ebaabd
Zone merging (GAL).
10 years ago
da75c52665
Hot keys settings are synchronized between GAL & legacy
11 years ago
e37b07a6fc
Explicit destruction of menu entries in CONTEXT_MENU.
11 years ago
06b978b829
Refactored CONTEXT_MENU, added handler for updating.
11 years ago
4be876a13a
Expandable CONTEXT_MENUs (GAL). Minor CONTEXT_MENU
11 years ago
b1cd83c197
Icons in GAL context menus.
11 years ago
6083f3b011
Internationalization of GAL dialogs & menus.
11 years ago
74e83e924a
Pcbnew: Fix Bug #1420074 (Crash when a footprint is added to the board (or edited) from the footprint editor, if a new pad was added, because the net info of the new pad is broken in this case)
11 years ago
jean-pierre charras
Jeff Young
Seth Hillbrand
Jon Evans
Maciej Suminski
John Beard
Maciej Suminski
Michael Steinberg
Tomasz Wlostowski