jean-pierre charras
31be74b8b3
Fix a few Coverity warnings
3 years ago
jean-pierre charras
07f79208b9
Minor fixes: Coverity and compil minor warnings.
3 years ago
Jeff Young
8b1318c92f
Update associated data structures after changing trace colour.
Also removes likely benign but never-the-less useless grid even processing
during rebuilding of the grids.
Fixes https://gitlab.com/kicad/code/kicad/issues/13956
3 years ago
Jeff Young
d5e50b70bb
Display a generic "Value" column label when there are no cursors.
3 years ago
Jeff Young
f50d114b27
Push gain & phase for .probe statements in AC analysis.
Fixes https://gitlab.com/kicad/code/kicad/issues/13941
3 years ago
Jeff Young
95232edd0d
Do a better job of looking for .probe commands in directives.
Fixes https://gitlab.com/kicad/code/kicad/issues/13941
3 years ago
Jeff Young
d8a4f9821e
Smarten regex to accept ':' in signal names.
(In fact, just accept anything up to the closing paren.)
Fixes https://gitlab.com/kicad/code/kicad/issues/13942
3 years ago
Jeff Young
9ce18dffdd
Better startup experience for simulator.
Pre-load signals list (and plot panel if there is an schText simulation
command).
Also fixes a bug where the workbook was getting dirtied on open because
the events would fire after the dirty flag had been cleared.
3 years ago
Jeff Young
74eb587291
Better sorting within sections (voltage, current, power).
Fixes https://gitlab.com/kicad/code/kicad/issues/13846
3 years ago
Jeff Young
1e756dbdd8
Save cursor positions in sim workbook.
3 years ago
Jeff Young
83dd06e5d1
Allow opening of workbook when simulation frame is opened.
This involved splitting creation of traces from setting of trace
data.
Also renamed SIM_WORKBOOK to SIM_NOTEBOOK. This class is a subclass
of wxAiuNotebook and represents the collection of simulation plot tabs.
It is NOT the same thing as a simulation workbook, which contains other
stuff such as measurements, plotted signals, colours, etc.
This also removes a bunch of "friend" declarations.
3 years ago
Jeff Young
78746b77c6
Save trace colors and cursor value formatting in sim workbook.
3 years ago
Jeff Young
84c72b087c
Simplify (and fix) logic for starting new simulations.
Fixes https://gitlab.com/kicad/code/kicad/issues/13853
3 years ago
Jeff Young
9d3a3d705d
ADDED simulation measurements.
3 years ago
Jeff Young
e5176ff4d6
ADDED power dissipation plotting and cursors.
Also fixes a bug so that voltages, currents and power dissipations are
only probed if the flag is set -- this keeps ngspice from throwing an
error if you probe something twice (for instance, if you have .probe
commands in text and turn off the auto-probing).
3 years ago
Jeff Young
bc108023b3
ADDED operating point overlay for SCH_EDIT_FRAME.
Fixes https://gitlab.com/kicad/code/kicad/issues/11253
3 years ago
Jeff Young
2a5bb71fbd
ADDED operating point text variables for labels and symbols.
ADDED formatting for cursors and operationg points
Also fixes a bunch of bugs to make the new cursors work with .ac sims.
Fixes https://gitlab.com/kicad/code/kicad/issues/11253
Fixes https://gitlab.com/kicad/code/kicad/issues/6965
3 years ago
Jeff Young
b3ffbd6258
Don't include unconnected nets in signals list.
Fixes https://gitlab.com/kicad/code/kicad/issues/4961
3 years ago
Jeff Young
f0bd25b397
ADDED use-settable simulation trace colors.
Fixes https://gitlab.com/kicad/code/kicad/issues/2536
3 years ago
Jeff Young
09822c7f18
ADDED direct access to signals & cursors.
ADDED differential cursors.
Fixes https://gitlab.com/kicad/code/kicad/issues/4447
Fixes https://gitlab.com/kicad/code/kicad/issues/6221
3 years ago
Jeff Young
6bc89ee180
Don't disable run when there's no command: just ask for a command.
3 years ago
Jeff Young
a1a1a49729
On-the-fly language updates for simulator window.
Fixes https://gitlab.com/kicad/code/kicad/issues/13357
3 years ago
Jeff Young
b000d68def
Move simulator to tool framework.
3 years ago
Jeff Young
123467c8dd
Don't throw up debug message when signal is deleted.
Fixes https://gitlab.com/kicad/code/kicad/issues/13711
3 years ago
Jeff Young
4e50c5313d
More safety for array access.
Fixes https://gitlab.com/kicad/code/kicad/issues/13583
3 years ago
Seth Hillbrand
4d7ddf619a
Remove unused var and cleanup
3 years ago
Wayne Stambaugh
ee3e285393
Correctly parent simulator netlist error dialogs.
3 years ago
Jeff Young
0e778f17db
Add context menu for simulation cursors.
Fixes https://gitlab.com/kicad/code/kicad/issues/13580
3 years ago
Stefan Brüns
1df81b10e6
Explicitly convert std::string to wxString
In wxWidgets STL builds the compiler has multiple, ambigous choices
for converting - both arguments to std::string first, or just the
first to wxString.
Fixes #13432 .
3 years ago
Jeff Young
098d2b30a2
Support for simulation options in workbook and simulation command dlg.
Fixes https://gitlab.com/kicad/code/kicad/issues/13524
Fixes https://gitlab.com/kicad/code/kicad/issues/13523
Fixes https://gitlab.com/kicad/code/kicad/issues/13431
3 years ago
Jeff Young
7fbad183db
Gracefully handle Quit when simulator window is open.
3 years ago
Jeff Young
4391fc7a7a
Don't be annoying about refusing to create traces when there's no data.
3 years ago
Jeff Young
ef6001bfe6
Use consistent terminology: opposite of Add is Remove.
Note: violating string freeze because this change should ease translation,
not make it harder.
3 years ago
Jeff Young
e11d39b0f2
If magnitude or phase is specified, don't add both.
Fixes https://gitlab.com/kicad/code/kicad/issues/13202
3 years ago
Jeff Young
80f3abe082
Event safety.
Sentry crash probably happens when an update title event fires either
too early or too late to have a simulator or simulator settings.
Sentry issue https://sentry.io/organizations/kicad/issues/3669444623/events/fce0179f7d5e4ff3a7dbb0d90a0570b4/
3 years ago
Jeff Young
bf1c4e7bcd
Allow translation of simulation error messages.
3 years ago
Jeff Young
6f44468385
Fix more lifetime issues in simulator tuning.
Fixes https://gitlab.com/kicad/code/kicad/issues/13257
3 years ago
Jeff Young
8069e5d5d6
Fix sim bug running a command the first time when no command in doc.
Fixes https://gitlab.com/kicad/code/kicad/issues/11366
3 years ago
Jeff Young
bfd3b40672
Bug fixes for tuning.
1) Don't save SCH_ITEM pointers in long-lived structures. Use KIIDs
instead.
2) Use the correct sheet for the referenced item, not the current sheet.
3 years ago
Jeff Young
77998d7c51
Better fix for not selecting all of netlist.
3 years ago
Jeff Young
13d9b061ee
Don't select all of netlist when showing it in simulator.
3 years ago
Jeff Young
50ccc4e6da
Fix issue converting legacy SPICE models.
1) if a legacy model references a library then we need to see if said
libraray exists and read model from it if so
2) legacy node ordering is by index, not pin name
3) we can't auto-generate a pin map when we don't know the pin names,
so don't try
3 years ago
Jeff Young
419fe236ad
Fix logic error in parsing sim command, and DC source types in dialog.
Fixes https://gitlab.com/kicad/code/kicad/issues/9064
3 years ago
Jeff Young
9c129ed03f
More dialog adjustments for wx 3.2. Also renames files to match dialog.
3 years ago
Jeff Young
56aae7a147
Reduce compiler warnings.
3 years ago
Jeff Young
3581a9773f
Move simulator settings disposal earlier so it happens before parent.
Fixes https://gitlab.com/kicad/code/kicad/issues/12370
3 years ago
Jeff Young
bb6544914e
Bring simulator file menu commands more in line with rest of Kicad.
3 years ago
Jon Evans
5251ea6f27
Prevent crash on exit due to simulator settings being double freed
3 years ago
Jeff Young
4872dd7238
Don't put empty lines in the workbook.
Fixes https://gitlab.com/kicad/code/kicad/issues/12299
3 years ago
Jeff Young
f8e0a272c0
Remove a bunch of 'auto'.
3 years ago