f606679164
Proper numeric sorting for intersheet refs.
Also expunges the horrifically named std::remove and std::remove_if
(neither of which remove anything).
4 years ago
6aaf4413b3
Fix kicad_string.h / string.cpp mismatch.
They don't define a KiCad string class, so the header file name was
somewhat misleading. But the fact that they didn't match definitely
made coding more difficult.
4 years ago
3aab37bd2a
Fix determinism issue when comparing a local and hierarchical label
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8406
5 years ago
bcdec0dea7
Move '~' pin name processing to LIB_PIN and SCH_PIN.
This will also allow us to do variable processing in the future if
desired.
5 years ago
fbc135e69f
Rename SCH_COMPONENT to SCH_SYMBOL.
5 years ago
4df3cb912d
Remove another leaky wx/log.h header
5 years ago
9effeb1fcb
Don't crash if an invalid bus connection is made
Certain situations can trigger the stale cleanup being run
on a bus that doesn't actually contain the stated member.
In this case we should just keep calm and carry on -- who knows
what netlist will be generated, but we shouldn't crash.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8530
5 years ago
55c1d814f9
Fix hierarchical propagation for designs with unmatched hier ports
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8397
5 years ago
2e3860de6f
Naming conventions.
5 years ago
2b86b34124
Eeschema: split out SCH_SHEET_PIN declarations into separate header.
5 years ago
1786ae8773
Eeschema: use symbol nomenclature for object file naming.
5 years ago
d951ac5bfe
Fix logic issue with sheet pin ERC
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7592
5 years ago
212c67c365
Fix bus<>net conflict ERC not checking local labels
5 years ago
07e1ae1b56
Fix logic of global label ERC check
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7392
5 years ago
dbd749c07a
ERC warn if hierarchical labels have no matching sheet pin
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7511
5 years ago
7015f4cf75
Use full names for bus membership ERC checking
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7522
5 years ago
73ea0fc15e
Always upgrade to a stronger driver even if the path is longer
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7492
5 years ago
8e9b457887
Make sure sheet pin connections get reset every time
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7499
5 years ago
0ba0160da9
Add a PT_NIC pin electrical type and a netlist token for SCH_NO_CONNECT.
ADDED a new pin electrical type "free" for internally unconnected pins.
CHANGED the "unconnected" pin electrical type is now represented by
"no_connect" in files and netlists. (The legacy syntax is also accepted
in files.)
5 years ago
274fc60fe9
Formatting.
5 years ago
6cd4fcf30c
Don't pick a name with a longer path to override with
Only triggered on some platforms because of compiler-dependent
unordered_set iteration
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7169
5 years ago
95ca5a0233
Don't record null drivers.
Fixes https://gitlab.com/kicad/code/kicad/issues/7155
5 years ago
f3a6d2655e
Improvements to ERC and bus parsing.
1) Add some nullptr safety to ERC.
2) Allow unconnected flagging on bus/wire entries.
3) Allow commas in bus group definitions.
Fixes https://gitlab.com/kicad/code/kicad/issues/7155
5 years ago
02681fcf0e
Move no-connect processing to connection graph
This way the net names can be inspected in eeschema and cross-probing works.
Testcases updated for the name changes
CHANGED: all unconnected pins are now included in the netlist with no_connect_ prefixes
5 years ago
9b69c1e198
Fix a bone-headed cause of non-determinism
5 years ago
654e9a77db
Connectivity: defer and parallelize item updates
Good for ~15% performance improvement in large designs
5 years ago
6fb1ed2824
Make sure hierarchical overrides are deterministic
Without alphabetic sorting here, we are at the mercy of
the r-tree and multithreading.
5 years ago
b90e72ed07
Don't simplify hierarchical nets based on weak drivers
This behavior provided shorter net names, but was confusing if
the user gives an explicit strong driver in the subsheet but not
one in the parent sheet.
Testcases updated for net name changes; connectivity is the same
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4201
5 years ago
24ff66f5a2
ERC: flag unconnected sheet pins
Fixes https://gitlab.com/kicad/code/kicad/-/issues/1780
5 years ago
693e40b5b0
Exclude buses from dangling label checks
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7017
5 years ago
ede500f117
Don't create multiple markers for the same issue
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7016
5 years ago
5ceadbda3b
Don't show redundant ERC markers from subsheets
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7016
5 years ago
c3d46c1cb5
Add ncPins to the list of no_connect_ nets.
This allows the info to be acted upon in PCBNew (for instance, clearance
rules).
Fixes https://gitlab.com/kicad/code/kicad/issues/6991
5 years ago
487aa37d2e
Connectivity: don't rename things multiple times in subsheets
Depending on what order the subgraphs are processed in, it's
possible to hit a case where the parent sheet renames a bus
member before the bus neighbor renaming logic runs. In this
case, we don't want to apply the bus neighbor logic as it will
break connectivity to the parent sheet if that bus was not
also renamed (for example, if the hier ports only make net
connections and not bus connections)
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6887
5 years ago
e33a331095
Don't ERC check absorbed subgraphs
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6861
5 years ago
3d852372ca
Handle nested unescaping (for buses in particular).
Also adds a few missing unescape() calls when showing netnames to the
user.
Fixes https://gitlab.com/kicad/code/kicad/issues/6400
5 years ago
7b9c21e290
Not connected pins should not get connected
This prevents splitting wires/busses on the NC pin end. It also keeps
NC pins out of the netlist.
Fixes https://gitlab.com/kicad/code/kicad/issues/6777
5 years ago
6544dca056
Ensure driver connections are always properly initialized
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6694
5 years ago
ad281f7538
Remove duplicated TestDanglingEnds routines.
Also adds a changedItemHandler so that the single remaining version
can update the view.
Fixes https://gitlab.com/kicad/code/kicad/issues/6581
5 years ago
c85ef8eb69
Make updating netnames in backannotate more discrete.
Trying to be too smart was producing unexpected results.
Fixes https://gitlab.com/kicad/code/kicad/issues/6480
5 years ago
9c7c05c161
Mostly formatting cleanup but a few type-casting cleanups too.
5 years ago
44850e9409
Fix nullptr crash.
5 years ago
c94001839b
Minor performance improvements to connection graph.
5 years ago
94a358c592
fix 2 compil issues
5 years ago
6654c03041
Embarking on the next adventure: component -> symbol.
5 years ago
79dd6e6476
Eeschema, ERC: fix missing call to subgraph->ResolveDrivers() when test driver
conflicts (more than one name for a net) is disabled.
This missing call was creating issues in tests that need a full connection
calculation, especially ercCheckFloatingWires()
5 years ago
7c505da368
Make sure ERC tests honour the severity settings.
(And in particular, IGNORE.)
Fixes https://gitlab.com/kicad/code/kicad/issues/6178
5 years ago
31d502735c
Better messages for bus entry conflict ERC
5 years ago
2edd246f36
Use explicit message for multiple drivers ERC
Fixes https://gitlab.com/kicad/code/kicad/-/issues/3980
5 years ago
ee08a3488f
Fix missing driver conflict ERC
5 years ago
Jeff Young
Jon Evans
Wayne Stambaugh
Marek Roszko
Seth Hillbrand
jean-pierre charras