1ce1e493d6
A rule zone is not really a BOARD_CONNECTED_ITEM.
Or at least it shouldn't always be treated as one.
Fixes https://gitlab.com/kicad/code/kicad/issues/6382
5 years ago
31e626f279
Cleanup creation of all our smart pointers
5 years ago
948036372e
Ban unitless numbers in DRC rules.
Fixes https://gitlab.com/kicad/code/kicad/issues/6029
5 years ago
a1c75748a0
Remove GetChars(), a wxWidgets 2.9 compatibility hack
5 years ago
ebd5dc81cc
Fix some more cases of malformed syntax crashing the compiler.
Fixes https://gitlab.com/kicad/code/kicad/issues/6016
5 years ago
f7d3dddd6d
Fix format argument assertion in libeval_compiler
5 years ago
39995341d9
Compile fixes
Fix compile error
Fix string format to use %ld instead to work on clang in CADSTAR Archive importers
Add virtual destructor to CONNECTION in CADSTAR_ARCHIVE_PARSER
5 years ago
78fc0349a9
libeval_compiler: free tree in destructor, warning fixes
5 years ago
d2ed27b500
libeval_compiler: fix string comparison
5 years ago
0c885c9c31
libeval_compiler: == operator now does wildcard string comparison
5 years ago
5023d9a780
libeval_compiler: initial support for multiple (>1) function/method arguments
5 years ago
0763a8962c
Implement boolean not processing in expression language.
Also adds some more error catching to be more robust in the face
of malformed customer rules.
Fixes https://gitlab.com/kicad/code/kicad/issues/5694
5 years ago
80acf944a0
Don't assert when compiling rules; generate a user-visible error.
Fixes https://gitlab.com/kicad/code/kicad/issues/5694
5 years ago
712215fe12
libeval_compiler: fix crash when preflighting method calls with 0 arguments
5 years ago
466cbe2f00
libeval_compiler: fixhandling of method calls with empty argument list (e.g. 'A.method()' )
5 years ago
a35698f08a
Don't fire non-well-formed rules. (But don't assert either.)
Fixes https://gitlab.com/kicad/code/kicad/issues/5443
5 years ago
050bbcdb4f
Fix error reporting from function pre-flighting.
5 years ago
d7f26cfdf2
Fix test failures.
5 years ago
b42395ec8d
Attempt to fix locale issue with decimal separator in rules.
5 years ago
ec5040aff5
Fix missing 'else' and EOF processing, both of which cause crashes.
5 years ago
edda024285
Fix up some Coverity and CLion warnings.
5 years ago
ab17f4b7b5
libeval_compiler: thou shalt not use strlen() on wxStrings. Works under Linux, doesn't work on OSX/MSVC...
5 years ago
519bc80394
Replace error reporting in DRC rule compiler.
5 years ago
0b17dbd123
Fix nesting issues in the DRC rule expression code generator.
We were executing function calls multiple times because we were
processing them at a depth the traversal algorithm wasn't expecting.
5 years ago
518a659185
Post-rebase fixes
5 years ago
4abe71d2ef
libeval_compiler: implemented unary +/- operators
5 years ago
c88c8102e5
libeval_compiler: fixed segfault for "(number)" expressions.
5 years ago
a5a06e3c89
libeval_compiler: general clean up of the Lemon grammar + some smart pointers + killed all memory leaks. WIP!
5 years ago
29a01e5515
libeval_compiler: wxString()-ification WIP
5 years ago
17d3e36bd6
Fix crash bug when condition expression is empty.
5 years ago
0a1d8c1aaa
Move lemon parser generation into build directory
This moves the generated files out of the source tree and into
the build directory. They are now regenerated each time they are
needed, based on the timestamp of the generated file compared to
the timestamp of the lemon file.
To do this, we also bundle lemon into the thirdparty directory
and build it for ourselves since it is a very tiny program and
not all platforms seem to distribute it in a consistent manner.
Fixes https://gitlab.com/kicad/code/kicad/issues/5013
5 years ago
7e63376266
Fix typo in DRC rule error reporting that causes crash.
5 years ago
268dec5c19
Cleanup some build and Coverity warnings
5 years ago
577c1be391
Report all DRC rule errors, not just the first.
5 years ago
fe4695719d
libeval_compiler: post-rebase fixes
5 years ago
3c80b98d1c
libeval_compiler: CONTEXT runs the UCODE now (thread-safe solution), fixed some memory leaks
5 years ago
abe6ccf97e
common: re-enable libeval_compiler and DRC proto test (fixed missing file issues)
5 years ago
2ea5528cd0
Start compiling identifiers.
We'll need this if we support the "L == foobar" syntax, and besides
it should really be up to the parser client whether or not they use
identifiers with no function call or property reference.
It also allows us to generate error messages for unknown identifers.
5 years ago
8a010bc23e
Null safety for expression variables.
5 years ago
552dde8976
Fix return value going out of scope.
(From Coverity report.)
5 years ago
bf445c1a95
Performance enhancements.
1) cache pad polygon outlines
huge improvement in connectivity performance and a decent
improvement in DRC performance
2) don't pre-allocate CONTEXT stack
significant improvement in DRC rule performance
2) don't keep re-encoding strings
decent improvement in DRC rule performance
5 years ago
6529e339a9
Don't store context in the uCode. (It's not thread-safe.)
Although it does give some pretty funny results when filling zones.
5 years ago
f2812773d4
Better handling of undefined values in Rule expressions.
This is particularly important to keep the user from having to
enter overly verbose statements such as:
A.Type == 'via' && A.Via_Type == 'buried'
when:
A.Via_Type == 'buried'
is perfectly clear.
5 years ago
84085df82a
Fix tokenizer to allow '_' in tokens.
5 years ago
637571e0be
Assume mm if units not given in DRC rules.
This keeps us from internalizing them as nm which appear to have
no effect (at least visually).
5 years ago
150c781f27
Fixup formatting and coding style.
5 years ago
a6b6084a60
Add preflighting for DRC rule function calls.
5 years ago
095937563b
Hook libeval compiler up to rule parser
- convert expression string tokens to single-quote-delimited
- fix bug where netclass assignments weren't getting updated after
board setup dialog
- move property manager rebuild to lazy evaluation
- improve performance with wider use of const&
- retire DRC_SELECTOR stuff
- use wxString for GUI stuff (particularly translated stuff)
- fix EqualTo() to return false instead of asserting when op types
don't match
- fix buffer overruns with fixed-size string buffers
- make expression function calls case-insensitive
- integrate expression errors into rule parser
- produce more and better error messages
- keep BOARD_ITEM ptrs const as long as possible
- fix a couple of uninitialized variables
5 years ago
6d8fb94d86
Fix a few Coverity warnings.
5 years ago
a253c53fe7
Fix buffer overflow in dumpNode
The formatted string buffer doesn't need to be used, so we bypass it
with string concat
5 years ago
Jeff Young
Ian McInerney
Marek Roszko
Jon Evans
Roberto Fernandez Bautista
Tomasz Wlostowski
jean-pierre charras
Seth Hillbrand