Browse Source

Fix is-same logic in updateFootprintParameters.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/19988
revert-0c36e162
Jeff Young 7 months ago
parent
commit
f9b19bbb5b
  1. 13
      pcbnew/netlist_reader/board_netlist_updater.cpp

13
pcbnew/netlist_reader/board_netlist_updater.cpp

@ -481,9 +481,18 @@ bool BOARD_NETLIST_UPDATER::updateFootprintParameters( FOOTPRINT* aPcbFootprint,
// in the order they are stored in the symbol.
bool same = true;
for( std::pair<wxString, wxString> field : compFields )
for( const auto& [name, value] : compFields )
{
if( fpFieldsAsMap.count( field.first ) == 0 || fpFieldsAsMap[field.first] != field.second )
if( fpFieldsAsMap.count( name ) == 0 || fpFieldsAsMap[name] != value )
{
same = false;
break;
}
}
for( const auto& [name, value] : fpFieldsAsMap )
{
if( compFields.count( name ) == 0 )
{
same = false;
break;

Loading…
Cancel
Save