From ec5f7b35a9ed521b44dbb834745c70447e1b7aff Mon Sep 17 00:00:00 2001
From: Jeff Young <jeff@rokeby.ie>
Date: Tue, 12 May 2020 19:48:36 +0100
Subject: [PATCH] Attempt to fix crash with RMB on un-selected graphic line.

Fixes https://gitlab.com/kicad/code/kicad/issues/4414
---
 eeschema/tools/sch_edit_tool.cpp | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/eeschema/tools/sch_edit_tool.cpp b/eeschema/tools/sch_edit_tool.cpp
index 96ebf1e661..64e463693f 100644
--- a/eeschema/tools/sch_edit_tool.cpp
+++ b/eeschema/tools/sch_edit_tool.cpp
@@ -199,9 +199,9 @@ bool SCH_EDIT_TOOL::Init()
                                    && aSel.AreAllItemsIdentical() ) )
                     return false;
 
-                EDA_ITEM* item = static_cast<EDA_ITEM*>( aSel.Front() );
+                EDA_ITEM* firstItem = static_cast<EDA_ITEM*>( aSel.Front() );
 
-                switch( item->Type() )
+                switch( firstItem->Type() )
                 {
                 case SCH_COMPONENT_T:
                 case SCH_SHEET_T:
@@ -215,12 +215,15 @@ bool SCH_EDIT_TOOL::Init()
                     return aSel.GetSize() == 1;
 
                 case SCH_LINE_T:
-                    return std::all_of( aSel.GetItems().begin(), aSel.GetItems().end(),
-                                        [&]( EDA_ITEM* selItem )
-                                        {
-                                            SCH_LINE* line = dynamic_cast<SCH_LINE*>( selItem );
-                                            return line && line->IsGraphicLine();
-                                        } );
+                    for( EDA_ITEM* item : aSel.GetItems() )
+                    {
+                        SCH_LINE* line = dynamic_cast<SCH_LINE*>( item );
+
+                        if( !line || !line->IsGraphicLine() )
+                            return false;
+                    }
+
+                    return true;
 
                 default:
                     return false;