performance efficiencies

eeschema/symbol_tree_model_adapter.cpp

@@ -121,7 +121,7 @@ bool SYMBOL_TREE_MODEL_ADAPTER::AddLibraries( const std::vector<wxString>& aNick
         PROJECT_FILE&    project = aFrame->Prj().GetProjectFile();
 
         auto addFunc =
-                [&]( const wxString& aLibName, std::vector<LIB_SYMBOL*> aSymbolList,
+                [&]( const wxString& aLibName, const std::vector<LIB_SYMBOL*>& aSymbolList,
                      const wxString& aDescription )
                 {
                     std::vector<LIB_TREE_ITEM*> treeItems( aSymbolList.begin(), aSymbolList.end() );

pcbnew/router/pns_itemset.cpp

@@ -61,7 +61,7 @@ ITEM_SET& ITEM_SET::FilterLayers( int aStart, int aEnd, bool aInvert )
             newItems.push_back( item );
     }
 
-    m_items = newItems;
+    m_items = std::move( newItems );
 
     return *this;
 }
@@ -77,7 +77,7 @@ ITEM_SET& ITEM_SET::FilterKinds( int aKindMask, bool aInvert )
             newItems.push_back( item );
     }
 
-    m_items = newItems;
+    m_items = std::move( newItems );
 
     return *this;
 }
@@ -93,7 +93,7 @@ ITEM_SET& ITEM_SET::FilterMarker( int aMarker, bool aInvert )
             newItems.push_back( item );
     }
 
-    m_items = newItems;
+    m_items = std::move( newItems );
 
     return *this;
 }
@@ -109,7 +109,7 @@ ITEM_SET& ITEM_SET::FilterNet( NET_HANDLE aNet, bool aInvert )
             newItems.push_back( item );
     }
 
-    m_items = newItems;
+    m_items = std::move( newItems );
 
     return *this;
 }
@@ -125,7 +125,7 @@ ITEM_SET& ITEM_SET::ExcludeItem( const ITEM* aItem )
             newItems.push_back( item );
     }
 
-    m_items = newItems;
+    m_items = std::move( newItems );
 
     return *this;
 }