sch_symbol.h doesn't need sch_lib_table.h

It doesn't even use the forward-declared
SYMBOL_LIB_TABLE.

Including this pulls in the whole richio system,
and sch_symbol.h is a very-included header.

Quite a few things do use SYMBOL_LIB_TABLE, but nowhere
near as many as use SYMBOL.

eeschema/dialogs/dialog_schematic_setup.cpp

@@ -33,6 +33,7 @@
 #include <panel_embedded_files.h>
 #include <project/project_file.h>
 #include <project/net_settings.h>
+#include <sch_io/sch_io.h>
 #include <settings/settings_manager.h>
 #include <widgets/wx_progress_reporters.h>
 #include "dialog_schematic_setup.h"

eeschema/dialogs/dialog_sheet_properties.cpp

@@ -22,7 +22,8 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
  */
 
-#include <dialog_sheet_properties.h>
+#include "dialog_sheet_properties.h"
+
 #include <kiface_base.h>
 #include <wx/string.h>
 #include <wx/log.h>
@@ -37,6 +38,7 @@
 #include <kiplatform/ui.h>
 #include <sch_commit.h>
 #include <sch_edit_frame.h>
+#include <sch_io/sch_io.h>
 #include <sch_sheet.h>
 #include <schematic.h>
 #include <bitmaps.h>

eeschema/eeschema_helpers.cpp

@@ -21,16 +21,20 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
  */
 
-#include <eeschema_helpers.h>
+#include "eeschema_helpers.h"
+
+#include <connection_graph.h>
+#include <locale_io.h>
+#include <schematic.h>
 #include <sch_edit_frame.h>
+#include <sch_label.h>
+#include <sch_io/sch_io.h>
+#include <sch_io/sch_io_mgr.h>
 #include <settings/settings_manager.h>
 #include <wildcards_and_files_ext.h>
-#include <schematic.h>
-#include <sch_io/sch_io_mgr.h>
-#include <locale_io.h>
+
 #include <wx/app.h>
-#include <sch_label.h>
-#include <connection_graph.h>
+
 
 SCH_EDIT_FRAME*   EESCHEMA_HELPERS::s_SchEditFrame = nullptr;
 SETTINGS_MANAGER* EESCHEMA_HELPERS::s_SettingsManager = nullptr;

eeschema/erc/erc.cpp

@@ -48,6 +48,7 @@
 #include <sch_textbox.h>
 #include <sch_line.h>
 #include <schematic.h>
+#include <symbol_lib_table.h>
 #include <drawing_sheet/ds_draw_item.h>
 #include <drawing_sheet/ds_proxy_view_item.h>
 #include <wx/ffile.h>

eeschema/sch_io/altium/sch_io_altium.cpp

@@ -50,6 +50,7 @@
 #include <sch_sheet.h>
 #include <sch_sheet_pin.h>
 #include <sch_textbox.h>
+#include <symbol_lib_table.h>
 
 #include <bezier_curves.h>
 #include <compoundfilereader.h>

eeschema/sch_io/cadstar/sch_io_cadstar_archive.cpp

@@ -30,6 +30,7 @@
 #include <sch_sheet.h>
 #include <schematic.h>
 #include <sch_io/kicad_sexpr/sch_io_kicad_sexpr.h>
+#include <symbol_lib_table.h>
 #include <wildcards_and_files_ext.h>
 #include <wx_filename.h>
 #include <wx/dir.h>

eeschema/sch_io/easyedapro/sch_io_easyedapro.cpp

@@ -29,6 +29,7 @@
 #include <schematic.h>
 #include <sch_sheet.h>
 #include <sch_screen.h>
+#include <symbol_lib_table.h>
 #include <kiplatform/environment.h>
 
 #include <fstream>

eeschema/sch_io/kicad_legacy/sch_io_kicad_legacy.cpp

@@ -61,6 +61,7 @@
 #include <sch_screen.h>
 #include <schematic.h>
 #include <symbol_library.h>
+#include <symbol_lib_table.h>
 #include <eeschema_id.h>       // for MAX_UNIT_COUNT_PER_PACKAGE definition
 #include <tool/selection.h>
 #include <wildcards_and_files_ext.h>

eeschema/sch_io/ltspice/sch_io_ltspice.cpp

@@ -27,6 +27,7 @@
 #include <schematic.h>
 #include <sch_sheet.h>
 #include <sch_screen.h>
+#include <symbol_lib_table.h>
 #include <kiplatform/environment.h>
 
 /**

eeschema/sch_symbol.h

@@ -46,7 +46,6 @@
 #include <sch_field.h>
 #include <sch_pin.h>
 #include <sch_sheet_path.h>    // SCH_SYMBOL_INSTANCE
-#include <symbol_lib_table.h>
 #include <transform.h>
 
 struct PICKED_SYMBOL;
@@ -60,7 +59,6 @@ class SYMBOL_LIBS;
 class EE_COLLECTOR;
 class SCH_SCREEN;
 class SCH_COMMIT;
-class SYMBOL_LIB_TABLE;
 
 
 /// A container for several SCH_FIELD items

eeschema/symbol_editor/lib_symbol_library_manager.cpp

@@ -20,6 +20,7 @@
 #include <lib_logger.h>
 #include <lib_symbol_library_manager.h>
 #include <symbol_edit_frame.h>
+#include <symbol_lib_table.h>
 
 
 LIB_SYMBOL_LIBRARY_MANAGER::LIB_SYMBOL_LIBRARY_MANAGER( SYMBOL_EDIT_FRAME& aFrame ) :

eeschema/symbol_library_manager.cpp

@@ -23,10 +23,12 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
  */
 
-#include <symbol_library_manager.h>
+#include "symbol_library_manager.h"
+
 #include <symbol_library.h>
 #include <dialogs/html_message_box.h>
 #include <symbol_edit_frame.h>
+#include <symbol_lib_table.h>
 #include <env_paths.h>
 #include <pgm_base.h>
 #include <project_sch.h>

eeschema/symbol_tree_model_adapter.cpp

@@ -19,6 +19,8 @@
  * with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
+#include "symbol_tree_model_adapter.h"
+
 #include <wx/log.h>
 #include <wx/tokenzr.h>
 #include <wx/window.h>
@@ -31,7 +33,7 @@
 #include <sch_base_frame.h>
 #include <locale_io.h>
 #include <symbol_async_loader.h>
-#include <symbol_tree_model_adapter.h>
+#include <symbol_lib_table.h>
 #include <string_utils.h>
 
 bool SYMBOL_TREE_MODEL_ADAPTER::m_show_progress = true;

eeschema/tools/ee_inspection_tool.cpp

@@ -22,6 +22,8 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
  */
 
+#include "tools/ee_inspection_tool.h"
+
 #include <sch_symbol.h>
 #include <id.h>
 #include <kiway.h>
@@ -32,13 +34,13 @@
 #include <tool/conditional_menu.h>
 #include <tool/selection_conditions.h>
 #include <tools/ee_actions.h>
-#include <tools/ee_inspection_tool.h>
 #include <tools/ee_selection_tool.h>
 #include <tools/ee_selection.h>
 #include <sim/simulator_frame.h>
 #include <sch_edit_frame.h>
 #include <symbol_edit_frame.h>
 #include <symbol_viewer_frame.h>
+#include <symbol_lib_table.h>
 #include <eda_doc.h>
 #include <sch_marker.h>
 #include <project.h>

eeschema/tools/sch_editor_control.cpp

@@ -22,7 +22,8 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
  */
 
-#include <symbol_library.h>
+#include "tools/sch_editor_control.h"
+
 #include <confirm.h>
 #include <connection_graph.h>
 #include <dialogs/dialog_symbol_fields_table.h>
@@ -55,6 +56,8 @@
 #include <sch_sheet_pin.h>
 #include <sch_commit.h>
 #include <sim/simulator_frame.h>
+#include <symbol_lib_table.h>
+#include <symbol_library.h>
 #include <symbol_library_manager.h>
 #include <symbol_viewer_frame.h>
 #include <tool/picker_tool.h>
@@ -62,7 +65,6 @@
 #include <tools/ee_actions.h>
 #include <tools/ee_selection.h>
 #include <tools/ee_selection_tool.h>
-#include <tools/sch_editor_control.h>
 #include <drawing_sheet/ds_proxy_undo_item.h>
 #include <eda_list_dialog.h>
 #include <view/view_controls.h>

eeschema/tools/symbol_editor_control.cpp

@@ -22,6 +22,8 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
  */
 
+#include "tools/symbol_editor_control.h"
+
 #include <advanced_config.h>
 #include <kiway.h>
 #include <pgm_base.h>
@@ -29,11 +31,11 @@
 #include <tool/tool_manager.h>
 #include <tool/library_editor_control.h>
 #include <tools/ee_actions.h>
-#include <tools/symbol_editor_control.h>
 #include <lib_symbol_library_manager.h>
 #include <symbol_editor/symbol_editor_settings.h>
 #include <symbol_viewer_frame.h>
 #include <symbol_tree_model_adapter.h>
+#include <symbol_lib_table.h>
 #include <wildcards_and_files_ext.h>
 #include <bitmaps/bitmap_types.h>
 #include <confirm.h>

eeschema/widgets/panel_symbol_chooser.cpp

@@ -22,9 +22,9 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
  */
 
+#include "panel_symbol_chooser.h"
+
 #include <pgm_base.h>
-#include <symbol_library.h>         // For SYMBOL_LIBRARY_FILTER
-#include <panel_symbol_chooser.h>
 #include <kiface_base.h>
 #include <sch_base_frame.h>
 #include <project_sch.h>
@@ -36,6 +36,8 @@
 #include <project/project_file.h>
 #include <eeschema_settings.h>
 #include <symbol_editor_settings.h>
+#include <symbol_library.h>         // For SYMBOL_LIBRARY_FILTER
+#include <symbol_lib_table.h>
 #include <wx/button.h>
 #include <wx/clipbrd.h>
 #include <wx/panel.h>

eeschema/widgets/panel_symbol_chooser.h

@@ -33,6 +33,7 @@ class wxPanel;
 class wxTimer;
 class wxSplitterWindow;
 
+class SYMBOL_LIBRARY_FILTER;
 class SYMBOL_PREVIEW_WIDGET;
 class FOOTPRINT_PREVIEW_WIDGET;
 class FOOTPRINT_SELECT_WIDGET;