Mirrors
/
kicad
mirror of https://github.com/KiCad/kicad-source-mirror
3
0
Fork 0
Code Releases Activity
Browse Source

Pcbnew: Activate pad fabrication property in pad properties dialog. 

It was previously an option of advanced config since 6 months.
It is now not optional.
pull/16/head
jean-pierre charras 5 years ago
parent
5ef50ab27a
commit
c254b331f3
7 changed files with 9 additions and 25 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Split View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 4
      common/advanced_config.cpp
  2. 5
      include/advanced_config.h
  3. 7
      pcbnew/dialogs/dialog_pad_properties.cpp
  4. 2
      pcbnew/dialogs/dialog_pad_properties_base.cpp
  5. 2
      pcbnew/dialogs/dialog_pad_properties_base.fbp
  6. 10
      pcbnew/kicad_plugin.cpp
  7. 4
      pcbnew/pcb_parser.cpp

4
common/advanced_config.cpp
View File

@ -162,7 +162,6 @@ ADVANCED_CFG::ADVANCED_CFG()
// Init defaults - this is done in case the config doesn't exist,
// then the values will remain as set here.
m_EnableUsePadProperty = false;
m_realTimeConnectivity = true;
m_coroutineStackSize = AC_STACK::default_stack;
m_ShowRouterDebugGraphics = false;
@ -199,9 +198,6 @@ void ADVANCED_CFG::loadSettings( wxConfigBase& aCfg )
{
std::vector<PARAM_CFG*> configParams;
configParams.push_back( new PARAM_CFG_BOOL( true, AC_KEYS::UsePadProperty,
&m_EnableUsePadProperty, false ) );
configParams.push_back( new PARAM_CFG_BOOL( true, AC_KEYS::RealtimeConnectivity,
&m_realTimeConnectivity, false ) );

5
include/advanced_config.h
View File

@ -68,11 +68,6 @@ public:
*/
static const ADVANCED_CFG& GetCfg();
/**
* Enable pad property handling in pcbnew.
*/
bool m_EnableUsePadProperty;
/**
* Do real-time connectivity
*/

7
pcbnew/dialogs/dialog_pad_properties.cpp
View File

@ -142,13 +142,6 @@ DIALOG_PAD_PROPERTIES::DIALOG_PAD_PROPERTIES( PCB_BASE_FRAME* aParent, D_PAD* aP
m_board = m_parent->GetBoard();
// Disable the pad property if not allowed in advanced config
if( !ADVANCED_CFG::GetCfg().m_EnableUsePadProperty )
{
m_staticTextFabProperty->Show( false );
m_choiceFabProperty->Show( false );
}
m_PadNetSelector->SetBoard( m_board );
m_PadNetSelector->SetNetInfo( &m_board->GetNetInfo() );

2
pcbnew/dialogs/dialog_pad_properties_base.cpp
View File

@ -556,7 +556,7 @@ DIALOG_PAD_PROPERTIES_BASE::DIALOG_PAD_PROPERTIES_BASE( wxWindow* parent, wxWind
m_staticTextFabProperty = new wxStaticText( m_panelGeneral, wxID_ANY, _("Fabrication Property:"), wxDefaultPosition, wxDefaultSize, 0 );
m_staticTextFabProperty->Wrap( -1 );
m_staticTextFabProperty->SetToolTip( _("Optional property to specify a special purpose or constraint in fabrication files:\nBGA attribute is for pads in BGA footprints\nFiducial local is a fiducial for the parent footprint\nFiducial global is a fiducial for the whole board\nTest pad is useful to specify test points in Gerber files\nHeatsink pad specify a thermal pad\nCastellated specify castellated through hole pads on a board edge\nThis property is specified in Gerber X2 files.") );
m_staticTextFabProperty->SetToolTip( _("Optional property to specify a special purpose or constraint in fabrication files:\nBGA attribute is for pads in BGA footprints\nFiducial local is a fiducial for the parent footprint\nFiducial global is a fiducial for the whole board\nTest Point pad is useful to specify test points in Gerber files\nHeatsink pad specify a thermal pad\nCastellated specify castellated through hole pads on a board edge\nThese properties are specified in Gerber X2 files.") );
m_middleBoxSizer->Add( m_staticTextFabProperty, 0, wxTOP|wxRIGHT|wxLEFT, 5 );

2
pcbnew/dialogs/dialog_pad_properties_base.fbp
View File

@ -6754,7 +6754,7 @@
<property name="style"></property>
<property name="subclass">; ; forward_declare</property>
<property name="toolbar_pane">0</property>
<property name="tooltip">Optional property to specify a special purpose or constraint in fabrication files:&#x0A;BGA attribute is for pads in BGA footprints&#x0A;Fiducial local is a fiducial for the parent footprint&#x0A;Fiducial global is a fiducial for the whole board&#x0A;Test pad is useful to specify test points in Gerber files&#x0A;Heatsink pad specify a thermal pad&#x0A;Castellated specify castellated through hole pads on a board edge&#x0A;This property is specified in Gerber X2 files.</property>
<property name="tooltip">Optional property to specify a special purpose or constraint in fabrication files:&#x0A;BGA attribute is for pads in BGA footprints&#x0A;Fiducial local is a fiducial for the parent footprint&#x0A;Fiducial global is a fiducial for the whole board&#x0A;Test Point pad is useful to specify test points in Gerber files&#x0A;Heatsink pad specify a thermal pad&#x0A;Castellated specify castellated through hole pads on a board edge&#x0A;These properties are specified in Gerber X2 files.</property>
<property name="window_extra_style"></property>
<property name="window_name"></property>
<property name="window_style"></property>

10
pcbnew/kicad_plugin.cpp
View File

@ -51,8 +51,6 @@
#include <convert_basic_shapes_to_polygon.h> // for enum RECT_CHAMFER_POSITIONS definition
#include <kiface_i.h>
#include <advanced_config.h> // for pad pin function and pad property feature management
using namespace PCB_KEYS_T;
@ -1181,7 +1179,7 @@ void PCB_IO::format( D_PAD* aPad, int aNestLevel ) const
switch( aPad->GetProperty() )
{
case PAD_PROP_NONE: break;
case PAD_PROP_NONE: break; // could be also "none"
case PAD_PROP_BGA: property = "pad_prop_bga"; break;
case PAD_PROP_FIDUCIAL_GLBL: property = "pad_prop_fiducial_glob"; break;
case PAD_PROP_FIDUCIAL_LOCAL: property = "pad_prop_fiducial_loc"; break;
@ -1230,11 +1228,9 @@ void PCB_IO::format( D_PAD* aPad, int aNestLevel ) const
m_out->Print( 0, ")" );
}
if( property && ADVANCED_CFG::GetCfg().m_EnableUsePadProperty )
{
// Add pad property, if exists.
// Add pad property, if exists.
if( property )
m_out->Print( 0, " (property %s)", property );
}
formatLayers( aPad->GetLayerSet() );

4
pcbnew/pcb_parser.cpp
View File

@ -3370,6 +3370,10 @@ D_PAD* PCB_PARSER::parseD_PAD( MODULE* aParent )
pad->SetProperty( PAD_PROP_HEATSINK );
break;
case T_none:
pad->SetProperty( PAD_PROP_NONE );
break;
case T_RIGHT:
break;

Write Preview
Loading…
Cancel
Save