Remove aIsCli which never ended being used

common/jobs/job.cpp

@@ -21,9 +21,8 @@
 #include <jobs/job.h>
 #include <wx/filename.h>
 
-JOB::JOB( const std::string& aType, bool aOutputIsDirectory, bool aIsCli ) :
+JOB::JOB( const std::string& aType, bool aOutputIsDirectory ) :
         m_type( aType ),
-        m_isCli( aIsCli ),
         m_varOverrides(),
         m_tempOutputDirectory(),
         m_outputPath(),

common/jobs/job.h

@@ -78,12 +78,11 @@ struct KICOMMON_API JOB_OUTPUT
 class KICOMMON_API JOB
 {
 public:
-    JOB( const std::string& aType, bool aOutputIsDirectory, bool aIsCli );
+    JOB( const std::string& aType, bool aOutputIsDirectory );
 
     virtual ~JOB();
 
     const std::string& GetType() const { return m_type; };
-    bool IsCli() const { return m_isCli; };
 
     const std::map<wxString, wxString>& GetVarOverrides() const { return m_varOverrides; }
 
@@ -125,7 +124,6 @@ public:
 
 protected:
     std::string m_type;
-    bool m_isCli;
     std::map<wxString, wxString> m_varOverrides;
 
     wxString m_tempOutputDirectory;

common/jobs/job_export_pcb_3d.cpp

@@ -74,8 +74,8 @@ wxString EXPORTER_STEP_PARAMS::GetFormatName() const
 }
 
 
-JOB_EXPORT_PCB_3D::JOB_EXPORT_PCB_3D( bool aIsCli ) :
-    JOB( "3d", false, aIsCli ),
+JOB_EXPORT_PCB_3D::JOB_EXPORT_PCB_3D() :
+    JOB( "3d", false ),
     m_hasUserOrigin( false ),
     m_filename(),
     m_format( JOB_EXPORT_PCB_3D::FORMAT::UNKNOWN ),

common/jobs/job_export_pcb_3d.h

@@ -101,7 +101,7 @@ public:
 class KICOMMON_API JOB_EXPORT_PCB_3D : public JOB
 {
 public:
-    JOB_EXPORT_PCB_3D( bool aIsCli );
+    JOB_EXPORT_PCB_3D();
     wxString GetDescription() override;
 
     enum class FORMAT

common/jobs/job_export_pcb_drill.cpp

@@ -57,8 +57,8 @@ NLOHMANN_JSON_SERIALIZE_ENUM( JOB_EXPORT_PCB_DRILL::MAP_FORMAT,
                                       { JOB_EXPORT_PCB_DRILL::MAP_FORMAT::SVG, "svg" },
                               } )
 
-JOB_EXPORT_PCB_DRILL::JOB_EXPORT_PCB_DRILL( bool aIsCli ) :
-    JOB( "drill", true, aIsCli ),
+JOB_EXPORT_PCB_DRILL::JOB_EXPORT_PCB_DRILL() :
+    JOB( "drill", true ),
     m_filename(),
     m_excellonMirrorY( false ),
     m_excellonMinimalHeader( false ),

common/jobs/job_export_pcb_drill.h

@@ -29,7 +29,7 @@
 class KICOMMON_API JOB_EXPORT_PCB_DRILL : public JOB
 {
 public:
-    JOB_EXPORT_PCB_DRILL( bool aIsCli );
+    JOB_EXPORT_PCB_DRILL();
 
     wxString GetDescription() override;
 

common/jobs/job_export_pcb_dxf.cpp

@@ -28,8 +28,8 @@ NLOHMANN_JSON_SERIALIZE_ENUM( JOB_EXPORT_PCB_DXF::DXF_UNITS,
                                       { JOB_EXPORT_PCB_DXF::DXF_UNITS::MILLIMETERS, "mm" },
                               } )
 
-JOB_EXPORT_PCB_DXF::JOB_EXPORT_PCB_DXF( bool aIsCli ) :
-    JOB_EXPORT_PCB_PLOT( JOB_EXPORT_PCB_PLOT::PLOT_FORMAT::DXF, "dxf", false, aIsCli ),
+JOB_EXPORT_PCB_DXF::JOB_EXPORT_PCB_DXF() :
+    JOB_EXPORT_PCB_PLOT( JOB_EXPORT_PCB_PLOT::PLOT_FORMAT::DXF, "dxf", false ),
     m_plotGraphicItemsUsingContours( true ),
     m_useDrillOrigin( false ),
     m_dxfUnits( DXF_UNITS::INCHES )

common/jobs/job_export_pcb_dxf.h

@@ -31,7 +31,7 @@
 class KICOMMON_API JOB_EXPORT_PCB_DXF : public JOB_EXPORT_PCB_PLOT
 {
 public:
-    JOB_EXPORT_PCB_DXF( bool aIsCli );
+    JOB_EXPORT_PCB_DXF();
     wxString GetDescription() override;
 
     enum class DXF_UNITS

common/jobs/job_export_pcb_gencad.cpp

@@ -21,8 +21,8 @@
 #include <jobs/job_export_pcb_gencad.h>
 
 
-JOB_EXPORT_PCB_GENCAD::JOB_EXPORT_PCB_GENCAD( bool aIsCli ) :
-    JOB( "gencad", false, aIsCli ),
+JOB_EXPORT_PCB_GENCAD::JOB_EXPORT_PCB_GENCAD() :
+    JOB( "gencad", false ),
     m_flipBottomPads( false ),
     m_useIndividualShapes( false ),
     m_storeOriginCoords( false ),

common/jobs/job_export_pcb_gencad.h

@@ -30,7 +30,7 @@
 class KICOMMON_API JOB_EXPORT_PCB_GENCAD : public JOB
 {
 public:
-    JOB_EXPORT_PCB_GENCAD( bool aIsCli );
+    JOB_EXPORT_PCB_GENCAD();
     wxString m_filename;
 
     bool m_flipBottomPads;

common/jobs/job_export_pcb_gerber.cpp

@@ -23,8 +23,8 @@
 #include <i18n_utility.h>
 
 
-JOB_EXPORT_PCB_GERBER::JOB_EXPORT_PCB_GERBER( const std::string& aType, bool aIsCli ) :
-    JOB_EXPORT_PCB_PLOT( JOB_EXPORT_PCB_PLOT::PLOT_FORMAT::GERBER, aType, false, aIsCli ),
+JOB_EXPORT_PCB_GERBER::JOB_EXPORT_PCB_GERBER( const std::string& aType ) :
+    JOB_EXPORT_PCB_PLOT( JOB_EXPORT_PCB_PLOT::PLOT_FORMAT::GERBER, aType, false ),
     m_subtractSolderMaskFromSilk( false ),
     m_includeNetlistAttributes( true ),
     m_useX2Format( true ),
@@ -71,8 +71,8 @@ JOB_EXPORT_PCB_GERBER::JOB_EXPORT_PCB_GERBER( const std::string& aType, bool aIs
 }
 
 
-JOB_EXPORT_PCB_GERBER::JOB_EXPORT_PCB_GERBER( bool aIsCli ) :
-    JOB_EXPORT_PCB_GERBER( "gerber", aIsCli )
+JOB_EXPORT_PCB_GERBER::JOB_EXPORT_PCB_GERBER() :
+    JOB_EXPORT_PCB_GERBER( "gerber" )
 {
 }
 

common/jobs/job_export_pcb_gerber.h

@@ -30,8 +30,8 @@
 class KICOMMON_API JOB_EXPORT_PCB_GERBER : public JOB_EXPORT_PCB_PLOT
 {
 public:
-    JOB_EXPORT_PCB_GERBER( const std::string& aType, bool aIsCli );
-    JOB_EXPORT_PCB_GERBER( bool aIsCli );
+    JOB_EXPORT_PCB_GERBER( const std::string& aType );
+    JOB_EXPORT_PCB_GERBER();
     wxString GetDescription() override;
 
     bool m_subtractSolderMaskFromSilk;

common/jobs/job_export_pcb_gerbers.cpp

@@ -23,8 +23,8 @@
 #include <jobs/job_registry.h>
 #include <i18n_utility.h>
 
-JOB_EXPORT_PCB_GERBERS::JOB_EXPORT_PCB_GERBERS( bool aIsCli ) :
-        JOB_EXPORT_PCB_GERBER( "gerbers", aIsCli ),
+JOB_EXPORT_PCB_GERBERS::JOB_EXPORT_PCB_GERBERS() :
+        JOB_EXPORT_PCB_GERBER( "gerbers" ),
         m_layersIncludeOnAll(),
         m_layersIncludeOnAllSet( false ),
         m_useBoardPlotParams( false )

common/jobs/job_export_pcb_gerbers.h

@@ -31,7 +31,7 @@
 class KICOMMON_API JOB_EXPORT_PCB_GERBERS : public JOB_EXPORT_PCB_GERBER
 {
 public:
-    JOB_EXPORT_PCB_GERBERS( bool aIsCli );
+    JOB_EXPORT_PCB_GERBERS();
     wxString GetDescription() override;
 
     LSET m_layersIncludeOnAll;

common/jobs/job_export_pcb_ipc2581.cpp

@@ -35,8 +35,8 @@ NLOHMANN_JSON_SERIALIZE_ENUM( JOB_EXPORT_PCB_IPC2581::IPC2581_VERSION,
                                       { JOB_EXPORT_PCB_IPC2581::IPC2581_VERSION::C, "C" },
                               } )
 
-JOB_EXPORT_PCB_IPC2581::JOB_EXPORT_PCB_IPC2581( bool aIsCli ) :
-    JOB( "ipc2581", false, aIsCli ),
+JOB_EXPORT_PCB_IPC2581::JOB_EXPORT_PCB_IPC2581() :
+    JOB( "ipc2581", false ),
     m_filename(),
     m_drawingSheet(),
     m_units( IPC2581_UNITS::MILLIMETERS ),

common/jobs/job_export_pcb_ipc2581.h

@@ -28,7 +28,7 @@
 class KICOMMON_API JOB_EXPORT_PCB_IPC2581 : public JOB
 {
 public:
-    JOB_EXPORT_PCB_IPC2581( bool aIsCli );
+    JOB_EXPORT_PCB_IPC2581();
     wxString GetDescription() override;
 
     void SetDefaultOutputPath( const wxString& aReferenceName );

common/jobs/job_export_pcb_pdf.cpp

@@ -23,8 +23,8 @@
 #include <i18n_utility.h>
 
 
-JOB_EXPORT_PCB_PDF::JOB_EXPORT_PCB_PDF( bool aIsCli ) :
-        JOB_EXPORT_PCB_PLOT( JOB_EXPORT_PCB_PLOT::PLOT_FORMAT::PDF, "pdf", false, aIsCli )
+JOB_EXPORT_PCB_PDF::JOB_EXPORT_PCB_PDF() :
+        JOB_EXPORT_PCB_PLOT( JOB_EXPORT_PCB_PLOT::PLOT_FORMAT::PDF, "pdf", false )
 {
     m_plotDrawingSheet = false;
 

common/jobs/job_export_pcb_pdf.h

@@ -31,7 +31,7 @@
 class KICOMMON_API JOB_EXPORT_PCB_PDF : public JOB_EXPORT_PCB_PLOT
 {
 public:
-    JOB_EXPORT_PCB_PDF( bool aIsCli );
+    JOB_EXPORT_PCB_PDF();
     wxString GetDescription() override;
 };
 

common/jobs/job_export_pcb_plot.cpp

@@ -3,9 +3,8 @@
 #include <jobs/job_export_pcb_plot.h>
 
 JOB_EXPORT_PCB_PLOT::JOB_EXPORT_PCB_PLOT( PLOT_FORMAT aFormat, const std::string& aType,
-                                          bool aOutputIsDirectory,
-                                          bool aIsCli )
-	: JOB( aType, aOutputIsDirectory, aIsCli ),
+                                          bool aOutputIsDirectory )
+	: JOB( aType, aOutputIsDirectory ),
     m_plotFormat( aFormat ),
 	m_filename(),
 	m_colorTheme(),

common/jobs/job_export_pcb_plot.h

@@ -40,7 +40,7 @@ public:
         SVG
     };
 
-    JOB_EXPORT_PCB_PLOT( PLOT_FORMAT aFormat, const std::string& aType, bool aOutputIsDirectory, bool aIsCli );
+    JOB_EXPORT_PCB_PLOT( PLOT_FORMAT aFormat, const std::string& aType, bool aOutputIsDirectory );
 
     PLOT_FORMAT m_plotFormat;
 

common/jobs/job_export_pcb_pos.cpp

@@ -43,8 +43,8 @@ NLOHMANN_JSON_SERIALIZE_ENUM( JOB_EXPORT_PCB_POS::UNITS,
                                       { JOB_EXPORT_PCB_POS::UNITS::MILLIMETERS, "mm" },
                               } )
 
-JOB_EXPORT_PCB_POS::JOB_EXPORT_PCB_POS( bool aIsCli ) :
-    JOB( "pos", false, aIsCli ),
+JOB_EXPORT_PCB_POS::JOB_EXPORT_PCB_POS() :
+    JOB( "pos", false ),
     m_filename(),
     m_useDrillPlaceFileOrigin( true ),
     m_smdOnly( false ),

common/jobs/job_export_pcb_pos.h

@@ -29,7 +29,7 @@
 class KICOMMON_API JOB_EXPORT_PCB_POS : public JOB
 {
 public:
-    JOB_EXPORT_PCB_POS( bool aIsCli );
+    JOB_EXPORT_PCB_POS();
     wxString GetDescription() override;
 
     void SetDefaultOutputPath( const wxString& aReferenceName );

common/jobs/job_export_pcb_svg.cpp

@@ -23,8 +23,8 @@
 #include <i18n_utility.h>
 
 
-JOB_EXPORT_PCB_SVG::JOB_EXPORT_PCB_SVG( bool aIsCli ) :
-    JOB_EXPORT_PCB_PLOT( JOB_EXPORT_PCB_PLOT::PLOT_FORMAT::SVG, "svg", false, aIsCli ),
+JOB_EXPORT_PCB_SVG::JOB_EXPORT_PCB_SVG() :
+    JOB_EXPORT_PCB_PLOT( JOB_EXPORT_PCB_PLOT::PLOT_FORMAT::SVG, "svg", false ),
     m_pageSizeMode( 0 )
 {
     m_plotDrawingSheet = true;

common/jobs/job_export_pcb_svg.h

@@ -31,7 +31,7 @@
 class KICOMMON_API JOB_EXPORT_PCB_SVG : public JOB_EXPORT_PCB_PLOT
 {
 public:
-    JOB_EXPORT_PCB_SVG( bool aIsCli );
+    JOB_EXPORT_PCB_SVG();
     wxString GetDescription() override;
 
     int m_pageSizeMode;

common/jobs/job_export_sch_bom.cpp

@@ -23,8 +23,8 @@
 #include <i18n_utility.h>
 
 
-JOB_EXPORT_SCH_BOM::JOB_EXPORT_SCH_BOM( bool aIsCli ) :
-    JOB( "bom", false, aIsCli ),
+JOB_EXPORT_SCH_BOM::JOB_EXPORT_SCH_BOM() :
+    JOB( "bom", false),
     m_filename(),
 
     m_fieldDelimiter(),

common/jobs/job_export_sch_bom.h

@@ -29,7 +29,7 @@
 class KICOMMON_API JOB_EXPORT_SCH_BOM : public JOB
 {
 public:
-    JOB_EXPORT_SCH_BOM( bool aIsCli );
+    JOB_EXPORT_SCH_BOM();
     wxString GetDescription() override;
 
     // Basic options

common/jobs/job_export_sch_netlist.cpp

@@ -35,8 +35,8 @@ NLOHMANN_JSON_SERIALIZE_ENUM( JOB_EXPORT_SCH_NETLIST::FORMAT,
                                       { JOB_EXPORT_SCH_NETLIST::FORMAT::SPICEMODEL, "spicemodel" },
                               } )
 
-JOB_EXPORT_SCH_NETLIST::JOB_EXPORT_SCH_NETLIST( bool aIsCli ) :
-    JOB( "netlist", false, aIsCli ),
+JOB_EXPORT_SCH_NETLIST::JOB_EXPORT_SCH_NETLIST() :
+    JOB( "netlist", false ),
     m_filename(),
     format( FORMAT::KICADSEXPR ),
     m_spiceSaveAllVoltages( false ),

common/jobs/job_export_sch_netlist.h

@@ -28,7 +28,7 @@
 class KICOMMON_API JOB_EXPORT_SCH_NETLIST : public JOB
 {
 public:
-    JOB_EXPORT_SCH_NETLIST( bool aIsCli );
+    JOB_EXPORT_SCH_NETLIST();
     wxString GetDescription() override;
 
     wxString m_filename;

common/jobs/job_export_sch_plot.cpp

@@ -63,8 +63,8 @@ NLOHMANN_JSON_SERIALIZE_ENUM( SCH_PLOT_FORMAT,
                                       { SCH_PLOT_FORMAT::DXF, "dxf" },
                               } )
 
-JOB_EXPORT_SCH_PLOT::JOB_EXPORT_SCH_PLOT( bool aIsCli ) :
-        JOB( "plot", false, aIsCli ),
+JOB_EXPORT_SCH_PLOT::JOB_EXPORT_SCH_PLOT() :
+        JOB( "plot", false ),
         m_plotFormat( SCH_PLOT_FORMAT::PDF ),
         m_filename(),
         m_drawingSheet(),
@@ -122,36 +122,36 @@ wxString JOB_EXPORT_SCH_PLOT::GetDescription()
 }
 
 
-JOB_EXPORT_SCH_PLOT_PDF::JOB_EXPORT_SCH_PLOT_PDF( bool aIsCli ) :
-		JOB_EXPORT_SCH_PLOT( aIsCli )
+JOB_EXPORT_SCH_PLOT_PDF::JOB_EXPORT_SCH_PLOT_PDF() :
+		JOB_EXPORT_SCH_PLOT()
 {
     m_plotFormat = SCH_PLOT_FORMAT::PDF;
 }
 
 
-JOB_EXPORT_SCH_PLOT_DXF ::JOB_EXPORT_SCH_PLOT_DXF ( bool aIsCli ) :
-		JOB_EXPORT_SCH_PLOT( aIsCli )
+JOB_EXPORT_SCH_PLOT_DXF ::JOB_EXPORT_SCH_PLOT_DXF () :
+		JOB_EXPORT_SCH_PLOT()
 {
 	m_plotFormat = SCH_PLOT_FORMAT::DXF;
 }
 
 
-JOB_EXPORT_SCH_PLOT_SVG::JOB_EXPORT_SCH_PLOT_SVG( bool aIsCli ) :
-		JOB_EXPORT_SCH_PLOT( aIsCli )
+JOB_EXPORT_SCH_PLOT_SVG::JOB_EXPORT_SCH_PLOT_SVG() :
+		JOB_EXPORT_SCH_PLOT()
 {
 	m_plotFormat = SCH_PLOT_FORMAT::SVG;
 }
 
 
-JOB_EXPORT_SCH_PLOT_PS::JOB_EXPORT_SCH_PLOT_PS( bool aIsCli ) :
-		JOB_EXPORT_SCH_PLOT( aIsCli )
+JOB_EXPORT_SCH_PLOT_PS::JOB_EXPORT_SCH_PLOT_PS() :
+		JOB_EXPORT_SCH_PLOT()
 {
 	m_plotFormat = SCH_PLOT_FORMAT::POST;
 }
 
 
-JOB_EXPORT_SCH_PLOT_HPGL::JOB_EXPORT_SCH_PLOT_HPGL( bool aIsCli ) :
-		JOB_EXPORT_SCH_PLOT( aIsCli )
+JOB_EXPORT_SCH_PLOT_HPGL::JOB_EXPORT_SCH_PLOT_HPGL() :
+		JOB_EXPORT_SCH_PLOT()
 {
 	m_plotFormat = SCH_PLOT_FORMAT::HPGL;
 }

common/jobs/job_export_sch_plot.h

@@ -75,7 +75,7 @@ enum class SCH_PLOT_FORMAT
 class KICOMMON_API JOB_EXPORT_SCH_PLOT : public JOB
 {
 public:
-    JOB_EXPORT_SCH_PLOT( bool aIsCli );
+    JOB_EXPORT_SCH_PLOT();
     wxString GetDescription() override;
 
     SCH_PLOT_FORMAT       m_plotFormat;
@@ -106,35 +106,35 @@ public:
 class KICOMMON_API JOB_EXPORT_SCH_PLOT_PDF : public JOB_EXPORT_SCH_PLOT
 {
 public:
-    JOB_EXPORT_SCH_PLOT_PDF( bool aIsCli );
+    JOB_EXPORT_SCH_PLOT_PDF();
 };
 
 
 class KICOMMON_API JOB_EXPORT_SCH_PLOT_DXF : public JOB_EXPORT_SCH_PLOT
 {
 public:
-    JOB_EXPORT_SCH_PLOT_DXF( bool aIsCli );
+    JOB_EXPORT_SCH_PLOT_DXF();
 };
 
 
 class KICOMMON_API JOB_EXPORT_SCH_PLOT_SVG : public JOB_EXPORT_SCH_PLOT
 {
 public:
-    JOB_EXPORT_SCH_PLOT_SVG( bool aIsCli );
+    JOB_EXPORT_SCH_PLOT_SVG();
 };
 
 
 class KICOMMON_API JOB_EXPORT_SCH_PLOT_PS : public JOB_EXPORT_SCH_PLOT
 {
 public:
-    JOB_EXPORT_SCH_PLOT_PS( bool aIsCli );
+    JOB_EXPORT_SCH_PLOT_PS();
 };
 
 
 class KICOMMON_API JOB_EXPORT_SCH_PLOT_HPGL : public JOB_EXPORT_SCH_PLOT
 {
 public:
-    JOB_EXPORT_SCH_PLOT_HPGL( bool aIsCli );
+    JOB_EXPORT_SCH_PLOT_HPGL();
 };
 
 #endif

common/jobs/job_export_sch_pythonbom.cpp

@@ -23,8 +23,8 @@
 #include <i18n_utility.h>
 
 
-JOB_EXPORT_SCH_PYTHONBOM::JOB_EXPORT_SCH_PYTHONBOM( bool aIsCli ) :
-        JOB( "pythonbom", false, aIsCli ),
+JOB_EXPORT_SCH_PYTHONBOM::JOB_EXPORT_SCH_PYTHONBOM() :
+        JOB( "pythonbom", false ),
         m_filename()
 {
 }

common/jobs/job_export_sch_pythonbom.h

@@ -28,7 +28,7 @@
 class KICOMMON_API JOB_EXPORT_SCH_PYTHONBOM : public JOB
 {
 public:
-    JOB_EXPORT_SCH_PYTHONBOM( bool aIsCli );
+    JOB_EXPORT_SCH_PYTHONBOM();
     wxString GetDescription() override;
 
     wxString m_filename;

common/jobs/job_fp_export_svg.cpp

@@ -21,8 +21,8 @@
 #include <jobs/job_fp_export_svg.h>
 
 
-JOB_FP_EXPORT_SVG::JOB_FP_EXPORT_SVG( bool aIsCli ) :
-    JOB( "fpsvg", true, aIsCli ),
+JOB_FP_EXPORT_SVG::JOB_FP_EXPORT_SVG() :
+    JOB( "fpsvg", true ),
     m_libraryPath(),
     m_footprint(),
     m_blackAndWhite( false ),

common/jobs/job_fp_export_svg.h

@@ -30,7 +30,7 @@
 class KICOMMON_API JOB_FP_EXPORT_SVG : public JOB
 {
 public:
-    JOB_FP_EXPORT_SVG( bool aIsCli );
+    JOB_FP_EXPORT_SVG();
 
     wxString m_libraryPath;
     wxString m_footprint;

common/jobs/job_fp_upgrade.cpp

@@ -21,8 +21,8 @@
 #include <jobs/job_fp_upgrade.h>
 
 
-JOB_FP_UPGRADE::JOB_FP_UPGRADE( bool aIsCli ) :
-        JOB( "fpupgrade", true, aIsCli ),
+JOB_FP_UPGRADE::JOB_FP_UPGRADE() :
+        JOB( "fpupgrade", true ),
         m_libraryPath(),
         m_force( false )
 {

common/jobs/job_fp_upgrade.h

@@ -28,7 +28,7 @@
 class KICOMMON_API JOB_FP_UPGRADE : public JOB
 {
 public:
-    JOB_FP_UPGRADE( bool aIsCli );
+    JOB_FP_UPGRADE();
 
     wxString m_libraryPath;
     wxString m_outputLibraryPath;

common/jobs/job_pcb_drc.cpp

@@ -35,8 +35,8 @@ NLOHMANN_JSON_SERIALIZE_ENUM( JOB_PCB_DRC::OUTPUT_FORMAT,
                                       { JOB_PCB_DRC::OUTPUT_FORMAT::JSON, "json" },
                               } )
 
-JOB_PCB_DRC::JOB_PCB_DRC( bool aIsCli ) :
-    JOB( "drc", false, aIsCli ),
+JOB_PCB_DRC::JOB_PCB_DRC() :
+    JOB( "drc", false ),
     m_filename(),
     m_reportAllTrackErrors( false ),
     m_units( JOB_PCB_DRC::UNITS::MILLIMETERS ),

common/jobs/job_pcb_drc.h

@@ -30,7 +30,7 @@
 class KICOMMON_API JOB_PCB_DRC : public JOB
 {
 public:
-    JOB_PCB_DRC( bool aIsCli );
+    JOB_PCB_DRC();
     wxString GetDescription() override;
 
     wxString m_filename;

common/jobs/job_pcb_render.cpp

@@ -22,7 +22,7 @@
 #include <jobs/job_pcb_render.h>
 
 
-JOB_PCB_RENDER::JOB_PCB_RENDER( bool aIsCli ) :
-        JOB( "render", false, aIsCli ), m_filename()
+JOB_PCB_RENDER::JOB_PCB_RENDER() :
+        JOB( "render", false ), m_filename()
 {
 }

common/jobs/job_pcb_render.h

@@ -31,7 +31,7 @@
 class KICOMMON_API JOB_PCB_RENDER : public JOB
 {
 public:
-    JOB_PCB_RENDER( bool aIsCli );
+    JOB_PCB_RENDER();
 
     wxString m_filename;
     wxString m_outputFile;

common/jobs/job_registry.h

@@ -64,7 +64,7 @@ private:
 #define REGISTER_JOB( job_name, title, face, T ) bool job_name##_entry = JOB_REGISTRY::Add( #job_name, \
                                                             { face, []()                               \
                                                             {                                          \
-                                                                return new T( true );                  \
+                                                                return new T();                        \
                                                             },                                         \
                                                             title } )
 // newline required to appease warning for REGISTER_JOB macro

common/jobs/job_sch_erc.cpp

@@ -35,8 +35,8 @@ NLOHMANN_JSON_SERIALIZE_ENUM( JOB_SCH_ERC::OUTPUT_FORMAT,
                                       { JOB_SCH_ERC::OUTPUT_FORMAT::JSON, "json" },
                               } )
 
-JOB_SCH_ERC::JOB_SCH_ERC( bool aIsCli ) :
-    JOB( "erc", false, aIsCli ),
+JOB_SCH_ERC::JOB_SCH_ERC() :
+    JOB( "erc", false ),
     m_filename(),
     m_units( JOB_SCH_ERC::UNITS::MILLIMETERS ),
     m_severity( RPT_SEVERITY_ERROR | RPT_SEVERITY_WARNING ),

common/jobs/job_sch_erc.h

@@ -30,7 +30,7 @@
 class KICOMMON_API JOB_SCH_ERC : public JOB
 {
 public:
-    JOB_SCH_ERC( bool aIsCli );
+    JOB_SCH_ERC();
     wxString GetDescription() override;
 
     wxString m_filename;

common/jobs/job_special_execute.cpp

@@ -22,8 +22,8 @@
 #include <jobs/job_registry.h>
 #include <i18n_utility.h>
 
-JOB_SPECIAL_EXECUTE::JOB_SPECIAL_EXECUTE( bool aIsCli ) :
-        JOB( "special_execute", false, aIsCli ),
+JOB_SPECIAL_EXECUTE::JOB_SPECIAL_EXECUTE() :
+        JOB( "special_execute", false ),
         m_command(),
         m_ignoreExitcode( false ),
         m_recordOutput( true )

common/jobs/job_special_execute.h

@@ -27,7 +27,7 @@
 class KICOMMON_API JOB_SPECIAL_EXECUTE : public JOB
 {
 public:
-    JOB_SPECIAL_EXECUTE( bool aIsCli );
+    JOB_SPECIAL_EXECUTE();
 
     wxString GetDescription() override;
 

common/jobs/job_sym_export_svg.cpp

@@ -21,8 +21,8 @@
 #include <jobs/job_sym_export_svg.h>
 
 
-JOB_SYM_EXPORT_SVG::JOB_SYM_EXPORT_SVG( bool aIsCli ) :
-    JOB( "symsvg", true, aIsCli ),
+JOB_SYM_EXPORT_SVG::JOB_SYM_EXPORT_SVG() :
+    JOB( "symsvg", true),
     m_libraryPath(),
     m_symbol(),
     m_blackAndWhite( false ),

common/jobs/job_sym_export_svg.h

@@ -28,7 +28,7 @@
 class KICOMMON_API JOB_SYM_EXPORT_SVG : public JOB
 {
 public:
-    JOB_SYM_EXPORT_SVG( bool aIsCli );
+    JOB_SYM_EXPORT_SVG();
 
     wxString m_libraryPath;
     wxString m_symbol;

common/jobs/job_sym_upgrade.cpp

@@ -21,8 +21,8 @@
 #include <jobs/job_sym_upgrade.h>
 
 
-JOB_SYM_UPGRADE::JOB_SYM_UPGRADE( bool aIsCli ) :
-    JOB( "symupgrade", false, aIsCli ),
+JOB_SYM_UPGRADE::JOB_SYM_UPGRADE() :
+    JOB( "symupgrade", false ),
     m_libraryPath(),
     m_outputLibraryPath(),
     m_force( false )

common/jobs/job_sym_upgrade.h

@@ -28,7 +28,7 @@
 class KICOMMON_API JOB_SYM_UPGRADE : public JOB
 {
 public:
-    JOB_SYM_UPGRADE( bool aIsCli );
+    JOB_SYM_UPGRADE();
 
     wxString m_libraryPath;
     wxString m_outputLibraryPath;

kicad/cli/command_fp_export_svg.cpp

@@ -78,7 +78,7 @@ int CLI::FP_EXPORT_SVG_COMMAND::doPerform( KIWAY& aKiway )
     if( baseExit != EXIT_CODES::OK )
         return baseExit;
 
-    std::unique_ptr<JOB_FP_EXPORT_SVG> svgJob = std::make_unique<JOB_FP_EXPORT_SVG>( true );
+    std::unique_ptr<JOB_FP_EXPORT_SVG> svgJob = std::make_unique<JOB_FP_EXPORT_SVG>();
 
     svgJob->m_libraryPath = m_argInput;
     svgJob->m_outputDirectory = m_argOutput;

kicad/cli/command_fp_upgrade.cpp

@@ -44,7 +44,7 @@ CLI::FP_UPGRADE_COMMAND::FP_UPGRADE_COMMAND() : PCB_EXPORT_BASE_COMMAND( "upgrad
 
 int CLI::FP_UPGRADE_COMMAND::doPerform( KIWAY& aKiway )
 {
-    std::unique_ptr<JOB_FP_UPGRADE> fpJob = std::make_unique<JOB_FP_UPGRADE>( true );
+    std::unique_ptr<JOB_FP_UPGRADE> fpJob = std::make_unique<JOB_FP_UPGRADE>();
 
     fpJob->m_libraryPath = m_argInput;
     fpJob->m_outputLibraryPath = m_argOutput;

kicad/cli/command_pcb_drc.cpp

@@ -93,7 +93,7 @@ CLI::PCB_DRC_COMMAND::PCB_DRC_COMMAND() : COMMAND( "drc" )
 
 int CLI::PCB_DRC_COMMAND::doPerform( KIWAY& aKiway )
 {
-    std::unique_ptr<JOB_PCB_DRC> drcJob( new JOB_PCB_DRC( true ) );
+    std::unique_ptr<JOB_PCB_DRC> drcJob( new JOB_PCB_DRC() );
 
     drcJob->m_outputFile = m_argOutput;
     drcJob->m_filename = m_argInput;

kicad/cli/command_pcb_export_3d.cpp

@@ -201,7 +201,7 @@ CLI::PCB_EXPORT_3D_COMMAND::PCB_EXPORT_3D_COMMAND( const std::string&        aNa
 
 int CLI::PCB_EXPORT_3D_COMMAND::doPerform( KIWAY& aKiway )
 {
-    std::unique_ptr<JOB_EXPORT_PCB_3D> step( new JOB_EXPORT_PCB_3D( true ) );
+    std::unique_ptr<JOB_EXPORT_PCB_3D> step( new JOB_EXPORT_PCB_3D() );
     EXPORTER_STEP_PARAMS& params = step->m_3dparams;
 
     if( m_format != JOB_EXPORT_PCB_3D::FORMAT::UNKNOWN

kicad/cli/command_pcb_export_drill.cpp

@@ -103,7 +103,7 @@ CLI::PCB_EXPORT_DRILL_COMMAND::PCB_EXPORT_DRILL_COMMAND() : PCB_EXPORT_BASE_COMM
 
 int CLI::PCB_EXPORT_DRILL_COMMAND::doPerform( KIWAY& aKiway )
 {
-    std::unique_ptr<JOB_EXPORT_PCB_DRILL> drillJob( new JOB_EXPORT_PCB_DRILL( true ) );
+    std::unique_ptr<JOB_EXPORT_PCB_DRILL> drillJob( new JOB_EXPORT_PCB_DRILL() );
 
     drillJob->m_filename = m_argInput;
     drillJob->SetOutputPath( m_argOutput );

kicad/cli/command_pcb_export_dxf.cpp

@@ -76,7 +76,7 @@ int CLI::PCB_EXPORT_DXF_COMMAND::doPerform( KIWAY& aKiway )
     if( baseExit != EXIT_CODES::OK )
         return baseExit;
 
-    std::unique_ptr<JOB_EXPORT_PCB_DXF> dxfJob( new JOB_EXPORT_PCB_DXF( true ) );
+    std::unique_ptr<JOB_EXPORT_PCB_DXF> dxfJob( new JOB_EXPORT_PCB_DXF() );
 
     dxfJob->m_filename = m_argInput;
     dxfJob->SetOutputPath( m_argOutput );

kicad/cli/command_pcb_export_gencad.cpp

@@ -75,7 +75,7 @@ int CLI::PCB_EXPORT_GENCAD_COMMAND::doPerform( KIWAY& aKiway )
     if( baseExit != EXIT_CODES::OK )
         return baseExit;
 
-    std::unique_ptr<JOB_EXPORT_PCB_GENCAD> gencadJob( new JOB_EXPORT_PCB_GENCAD( true ) );
+    std::unique_ptr<JOB_EXPORT_PCB_GENCAD> gencadJob( new JOB_EXPORT_PCB_GENCAD() );
 
     gencadJob->m_filename = m_argInput;
     gencadJob->SetVarOverrides( m_argDefineVars );

kicad/cli/command_pcb_export_gerber.cpp

@@ -132,7 +132,7 @@ int CLI::PCB_EXPORT_GERBER_COMMAND::doPerform( KIWAY& aKiway )
     if( exitCode != EXIT_CODES::OK )
         return exitCode;
 
-    std::unique_ptr<JOB_EXPORT_PCB_GERBER> gerberJob( new JOB_EXPORT_PCB_GERBER( true ) );
+    std::unique_ptr<JOB_EXPORT_PCB_GERBER> gerberJob( new JOB_EXPORT_PCB_GERBER() );
 
     exitCode = populateJob( gerberJob.get() );
 

kicad/cli/command_pcb_export_gerbers.cpp

@@ -65,7 +65,7 @@ int CLI::PCB_EXPORT_GERBERS_COMMAND::doPerform( KIWAY& aKiway )
     if( exitCode != EXIT_CODES::OK )
         return exitCode;
 
-    std::unique_ptr<JOB_EXPORT_PCB_GERBERS> gerberJob( new JOB_EXPORT_PCB_GERBERS( true ) );
+    std::unique_ptr<JOB_EXPORT_PCB_GERBERS> gerberJob( new JOB_EXPORT_PCB_GERBERS() );
 
     exitCode = populateJob( gerberJob.get() );
 

kicad/cli/command_pcb_export_ipc2581.cpp

@@ -107,7 +107,7 @@ int CLI::PCB_EXPORT_IPC2581_COMMAND::doPerform( KIWAY& aKiway )
     if( exitCode != EXIT_CODES::OK )
         return exitCode;
 
-    std::unique_ptr<JOB_EXPORT_PCB_IPC2581> ipc2581Job( new JOB_EXPORT_PCB_IPC2581( true ) );
+    std::unique_ptr<JOB_EXPORT_PCB_IPC2581> ipc2581Job( new JOB_EXPORT_PCB_IPC2581() );
 
     ipc2581Job->m_filename = m_argInput;
     ipc2581Job->SetOutputPath( m_argOutput );

kicad/cli/command_pcb_export_pdf.cpp

@@ -96,7 +96,7 @@ int CLI::PCB_EXPORT_PDF_COMMAND::doPerform( KIWAY& aKiway )
     if( baseExit != EXIT_CODES::OK )
         return baseExit;
 
-    std::unique_ptr<JOB_EXPORT_PCB_PDF> pdfJob( new JOB_EXPORT_PCB_PDF( true ) );
+    std::unique_ptr<JOB_EXPORT_PCB_PDF> pdfJob( new JOB_EXPORT_PCB_PDF() );
 
     pdfJob->m_filename = m_argInput;
     pdfJob->SetOutputPath( m_argOutput );

kicad/cli/command_pcb_export_pos.cpp

@@ -96,7 +96,7 @@ int CLI::PCB_EXPORT_POS_COMMAND::doPerform( KIWAY& aKiway )
     if( baseExit != EXIT_CODES::OK )
         return baseExit;
 
-    std::unique_ptr<JOB_EXPORT_PCB_POS> aPosJob( new JOB_EXPORT_PCB_POS( true ) );
+    std::unique_ptr<JOB_EXPORT_PCB_POS> aPosJob( new JOB_EXPORT_PCB_POS() );
 
     aPosJob->m_filename = m_argInput;
     aPosJob->SetOutputPath( m_argOutput );

kicad/cli/command_pcb_export_svg.cpp

@@ -100,7 +100,7 @@ int CLI::PCB_EXPORT_SVG_COMMAND::doPerform( KIWAY& aKiway )
     if( baseExit != EXIT_CODES::OK )
         return baseExit;
 
-    std::unique_ptr<JOB_EXPORT_PCB_SVG> svgJob( new JOB_EXPORT_PCB_SVG( true ) );
+    std::unique_ptr<JOB_EXPORT_PCB_SVG> svgJob( new JOB_EXPORT_PCB_SVG() );
 
     svgJob->m_mirror = m_argParser.get<bool>( ARG_MIRROR );
     svgJob->m_blackAndWhite = m_argParser.get<bool>( ARG_BLACKANDWHITE );

kicad/cli/command_pcb_render.cpp

@@ -241,7 +241,7 @@ CLI::PCB_RENDER_COMMAND::PCB_RENDER_COMMAND() : COMMAND( "render" )
 
 int CLI::PCB_RENDER_COMMAND::doPerform( KIWAY& aKiway )
 {
-    std::unique_ptr<JOB_PCB_RENDER> renderJob( new JOB_PCB_RENDER( true ) );
+    std::unique_ptr<JOB_PCB_RENDER> renderJob( new JOB_PCB_RENDER() );
 
     renderJob->m_outputFile = m_argOutput;
     renderJob->m_filename = m_argInput;

kicad/cli/command_sch_erc.cpp

@@ -83,7 +83,7 @@ CLI::SCH_ERC_COMMAND::SCH_ERC_COMMAND() : COMMAND( "erc" )
 
 int CLI::SCH_ERC_COMMAND::doPerform( KIWAY& aKiway )
 {
-    std::unique_ptr<JOB_SCH_ERC> ercJob( new JOB_SCH_ERC( true ) );
+    std::unique_ptr<JOB_SCH_ERC> ercJob( new JOB_SCH_ERC() );
 
     ercJob->m_outputFile = m_argOutput;
     ercJob->m_filename = m_argInput;

kicad/cli/command_sch_export_bom.cpp

@@ -130,7 +130,7 @@ std::vector<wxString> CLI::SCH_EXPORT_BOM_COMMAND::convertStringList( const wxSt
 
 int CLI::SCH_EXPORT_BOM_COMMAND::doPerform( KIWAY& aKiway )
 {
-    std::unique_ptr<JOB_EXPORT_SCH_BOM> bomJob = std::make_unique<JOB_EXPORT_SCH_BOM>( true );
+    std::unique_ptr<JOB_EXPORT_SCH_BOM> bomJob = std::make_unique<JOB_EXPORT_SCH_BOM>();
 
     // Basic options
     bomJob->m_filename = m_argInput;

kicad/cli/command_sch_export_netlist.cpp

@@ -46,7 +46,7 @@ CLI::SCH_EXPORT_NETLIST_COMMAND::SCH_EXPORT_NETLIST_COMMAND() : COMMAND( "netlis
 int CLI::SCH_EXPORT_NETLIST_COMMAND::doPerform( KIWAY& aKiway )
 {
     std::unique_ptr<JOB_EXPORT_SCH_NETLIST> netJob =
-            std::make_unique<JOB_EXPORT_SCH_NETLIST>( true );
+            std::make_unique<JOB_EXPORT_SCH_NETLIST>();
 
     netJob->m_filename = m_argInput;
     netJob->SetOutputPath( m_argOutput );

kicad/cli/command_sch_export_plot.cpp

@@ -143,7 +143,7 @@ int CLI::SCH_EXPORT_PLOT_COMMAND::doPerform( KIWAY& aKiway )
     }
 
     std::unique_ptr<JOB_EXPORT_SCH_PLOT> plotJob =
-            std::make_unique<JOB_EXPORT_SCH_PLOT>( true );
+            std::make_unique<JOB_EXPORT_SCH_PLOT>();
     plotJob->m_filename = filename;
     plotJob->m_plotFormat = m_plotFormat;
     plotJob->m_plotPages = pages;

kicad/cli/command_sch_export_pythonbom.cpp

@@ -41,7 +41,7 @@ CLI::SCH_EXPORT_PYTHONBOM_COMMAND::SCH_EXPORT_PYTHONBOM_COMMAND() :
 int CLI::SCH_EXPORT_PYTHONBOM_COMMAND::doPerform( KIWAY& aKiway )
 {
     std::unique_ptr<JOB_EXPORT_SCH_PYTHONBOM> bomJob =
-            std::make_unique<JOB_EXPORT_SCH_PYTHONBOM>( true );
+            std::make_unique<JOB_EXPORT_SCH_PYTHONBOM>();
 
     bomJob->m_filename = m_argInput;
     bomJob->SetOutputPath( m_argOutput );

kicad/cli/command_sym_export_svg.cpp

@@ -70,7 +70,7 @@ CLI::SYM_EXPORT_SVG_COMMAND::SYM_EXPORT_SVG_COMMAND() : COMMAND( "svg" )
 
 int CLI::SYM_EXPORT_SVG_COMMAND::doPerform( KIWAY& aKiway )
 {
-    std::unique_ptr<JOB_SYM_EXPORT_SVG> svgJob = std::make_unique<JOB_SYM_EXPORT_SVG>( true );
+    std::unique_ptr<JOB_SYM_EXPORT_SVG> svgJob = std::make_unique<JOB_SYM_EXPORT_SVG>();
 
     svgJob->m_libraryPath = m_argInput;
     svgJob->m_outputDirectory = m_argOutput;

kicad/cli/command_sym_upgrade.cpp

@@ -48,7 +48,7 @@ CLI::SYM_UPGRADE_COMMAND::SYM_UPGRADE_COMMAND() : COMMAND( "upgrade" )
 
 int CLI::SYM_UPGRADE_COMMAND::doPerform( KIWAY& aKiway )
 {
-    std::unique_ptr<JOB_SYM_UPGRADE> symJob = std::make_unique<JOB_SYM_UPGRADE>( true );
+    std::unique_ptr<JOB_SYM_UPGRADE> symJob = std::make_unique<JOB_SYM_UPGRADE>();
 
     symJob->m_libraryPath = m_argInput;
     symJob->m_outputLibraryPath = m_argOutput;

pcbnew/pcbnew_jobs_handler.cpp

@@ -621,13 +621,10 @@ int PCBNEW_JOBS_HANDLER::JobExportSvg( JOB* aJob )
     brd->GetProject()->ApplyTextVars( aJob->GetVarOverrides() );
     brd->SynchronizeProperties();
 
-    if( aJob->IsCli() )
-    {
-        if( EXPORT_SVG::Plot( brd, svgPlotOptions ) )
-            m_reporter->Report( _( "Successfully created svg file" ) + wxS( "\n" ), RPT_SEVERITY_INFO );
-        else
-            m_reporter->Report( _( "Error creating svg file" ) + wxS( "\n" ), RPT_SEVERITY_ERROR );
-    }
+    if( EXPORT_SVG::Plot( brd, svgPlotOptions ) )
+        m_reporter->Report( _( "Successfully created svg file" ) + wxS( "\n" ), RPT_SEVERITY_INFO );
+    else
+        m_reporter->Report( _( "Error creating svg file" ) + wxS( "\n" ), RPT_SEVERITY_ERROR );
 
     return CLI::EXIT_CODES::OK;
 }
@@ -970,14 +967,12 @@ int PCBNEW_JOBS_HANDLER::JobExportGencad( JOB* aJob )
         wxString msg;
         msg.Printf( _( "Failed to create file '%s'.\n" ), aGencadJob->GetFullOutputPath() );
 
-        if( aJob->IsCli() )
-            m_reporter->Report( msg, RPT_SEVERITY_ERROR );
+        m_reporter->Report( msg, RPT_SEVERITY_ERROR );
 
         return CLI::EXIT_CODES::ERR_UNKNOWN;
     }
 
-    if( aJob->IsCli() )
-        m_reporter->Report( _( "Successfully created genCAD file\n" ), RPT_SEVERITY_INFO );
+    m_reporter->Report( _( "Successfully created genCAD file\n" ), RPT_SEVERITY_INFO );
 
     return CLI::EXIT_CODES::OK;
 }
@@ -1325,9 +1320,7 @@ int PCBNEW_JOBS_HANDLER::JobExportFpUpgrade( JOB* aJob )
             return CLI::EXIT_CODES::ERR_INVALID_INPUT_FILE;
         }
 
-
-        if( aJob->IsCli() )
-            m_reporter->Report( _( "Loading footprint library\n" ), RPT_SEVERITY_INFO );
+        m_reporter->Report( _( "Loading footprint library\n" ), RPT_SEVERITY_INFO );
 
         PCB_IO_KICAD_SEXPR pcb_io( CTL_FOR_LIBRARY );
         FP_CACHE           fpLib( &pcb_io, upgradeJob->m_libraryPath );
@@ -1398,8 +1391,7 @@ int PCBNEW_JOBS_HANDLER::JobExportFpSvg( JOB* aJob )
     if( svgJob == nullptr )
         return CLI::EXIT_CODES::ERR_UNKNOWN;
 
-    if( aJob->IsCli() )
-        m_reporter->Report( _( "Loading footprint library\n" ), RPT_SEVERITY_INFO );
+    m_reporter->Report( _( "Loading footprint library\n" ), RPT_SEVERITY_INFO );
 
     PCB_IO_KICAD_SEXPR pcb_io( CTL_FOR_LIBRARY );
     FP_CACHE   fpLib( &pcb_io, svgJob->m_libraryPath );