Fix Coverity warnings

gerbview/class_am_param.cpp

@@ -124,6 +124,7 @@ double AM_PARAM::GetValue( const D_CODE* aDcode ) const
             case PUSHVALUE: // a value is on the stack:
                 curr_value = item.GetValue();
                 ops.push_back( AM_PARAM_EVAL( curr_value ) );
+                break;
 
             default:
                 wxLogDebug( "AM_PARAM::GetValue(): unexpected type\n" );

gerbview/files.cpp

@@ -508,7 +508,9 @@ bool GERBVIEW_FRAME::unarchiveFiles( const wxString& aFullFileName, REPORTER* aR
         else
         {
             GERBER_FILE_IMAGE* gerber_image = GetGbrImage( layer );
-            gerber_image->m_FileName = fname;
+
+            if( gerber_image )
+                gerber_image->m_FileName = fname;
 
             layer = getNextAvailableLayer( layer );
             setActiveLayer( layer, false );

include/bezier_curves.h

@@ -39,6 +39,7 @@ public:
         m_ctrlPts.emplace_back( x1, y1 );
         m_ctrlPts.emplace_back( x2, y2 );
         m_ctrlPts.emplace_back( x3, y3 );
+        m_output = nullptr;
     }
 
     BEZIER_POLY( int x1, int y1, int x2, int y2, int x3, int y3, int x4, int y4 )
@@ -47,11 +48,13 @@ public:
         m_ctrlPts.emplace_back( x2, y2 );
         m_ctrlPts.emplace_back( x3, y3 );
         m_ctrlPts.emplace_back( x4, y4 );
+        m_output = nullptr;
     }
 
     BEZIER_POLY( const std::vector<wxPoint>& aControlPoints )
         : m_ctrlPts( aControlPoints )
     {
+        m_output = nullptr;
     }
 
     /**

pcbnew/dialogs/dialog_pad_properties.cpp

@@ -1054,7 +1054,9 @@ bool DIALOG_PAD_PROPERTIES::TransferDataFromWindow()
         m_currentPad->SetShape( PAD_SHAPE_RECT );
     }
 
-    footprint->CalculateBoundingBox();
+    if( footprint )
+        footprint->CalculateBoundingBox();
+
     m_parent->SetMsgPanel( m_currentPad );
 
     // redraw the area where the pad was

pcbnew/exporters/gendrill_file_writer_base.h

@@ -160,6 +160,7 @@ protected:
         m_mapFileFmt = PLOT_FORMAT_PDF;
         m_pageInfo = NULL;
         m_merge_PTH_NPTH = false;
+        m_zeroFormat = DECIMAL_FORMAT;
     }
 
 public:

pcbnew/tools/microwave_tool.cpp

@@ -171,6 +171,12 @@ MICROWAVE_TOOL_INFO getMicrowaveItemCreator( PCB_EDIT_FRAME& frame, int aParam )
             return std::unique_ptr<MODULE>( frame.Create_MuWavePolygonShape() );
         };
         break;
+
+    default:
+        // Avoid uninitilized value:
+        info.toolId = 0;
+        // info.name is already set to empty string
+        break;
     };
 
     return info;
@@ -195,18 +201,19 @@ int MICROWAVE_TOOL::addMicrowaveFootprint( const TOOL_EVENT& aEvent )
 
     frame.SetToolID( info.toolId, wxCURSOR_PENCIL, info.name );
 
-    ITEM_CREATOR moduleCreator = [this, &info] ( const TOOL_EVENT& aAddingEvent ) {
-            auto module = info.creatorFunc();
+    ITEM_CREATOR moduleCreator = [this, &info] ( const TOOL_EVENT& aAddingEvent )
+    {
+        auto module = info.creatorFunc();
 
-            // Module has been added in the legacy backend,
-            // so we have to remove it before committing the change
-            // @todo LEGACY
-            if( module )
-            {
-                board()->Remove( module.get() );
-            }
+        // Module has been added in the legacy backend,
+        // so we have to remove it before committing the change
+        // @todo LEGACY
+        if( module )
+        {
+            board()->Remove( module.get() );
+        }
 
-            return module;
+        return module;
     };
 
     doInteractiveItemPlacement( moduleCreator,  _( "Place microwave feature" ) );