Browse Source

Fix a few Coverity issues.

newinvert
Wayne Stambaugh 3 years ago
parent
commit
b05de51a8d
  1. 8
      include/eda_text.h
  2. 16
      include/font/text_attributes.h
  3. 6
      include/gal/color4d.h

8
include/eda_text.h

@ -423,12 +423,8 @@ struct std::hash<EDA_TEXT>
{
std::size_t operator()( const EDA_TEXT& aText ) const
{
std::size_t seed;
hash_combine( seed, aText.GetText(), aText.GetAttributes(), aText.GetTextPos().x,
aText.GetTextPos().y );
return seed;
return hash_val( aText.GetText(), aText.GetAttributes(), aText.GetTextPos().x,
aText.GetTextPos().y );
}
};

16
include/font/text_attributes.h

@ -97,16 +97,12 @@ struct std::hash<TEXT_ATTRIBUTES>
{
std::size_t operator()( const TEXT_ATTRIBUTES& aAttributes ) const
{
std::size_t seed;
hash_combine( seed, aAttributes.m_Font, aAttributes.m_Halign, aAttributes.m_Valign,
aAttributes.m_Angle.AsDegrees(), aAttributes.m_LineSpacing,
aAttributes.m_StrokeWidth, aAttributes.m_Italic, aAttributes.m_Bold,
aAttributes.m_Underlined, aAttributes.m_Color, aAttributes.m_Visible,
aAttributes.m_Mirrored, aAttributes.m_Multiline, aAttributes.m_Size.x,
aAttributes.m_Size.y );
return seed;
return hash_val( aAttributes.m_Font, aAttributes.m_Halign, aAttributes.m_Valign,
aAttributes.m_Angle.AsDegrees(), aAttributes.m_LineSpacing,
aAttributes.m_StrokeWidth, aAttributes.m_Italic, aAttributes.m_Bold,
aAttributes.m_Underlined, aAttributes.m_Color, aAttributes.m_Visible,
aAttributes.m_Mirrored, aAttributes.m_Multiline, aAttributes.m_Size.x,
aAttributes.m_Size.y );
}
};

6
include/gal/color4d.h

@ -441,11 +441,7 @@ struct std::hash<KIGFX::COLOR4D>
{
std::size_t operator()( const KIGFX::COLOR4D& aColor ) const
{
std::size_t seed;
hash_combine( seed, aColor.r, aColor.b, aColor.g, aColor.a );
return seed;
return hash_val( aColor.r, aColor.b, aColor.g, aColor.a );
}
};

Loading…
Cancel
Save