Browse Source

Don't set m_IsPreviewer to force 3D models.

It has unintended side-effects (such as showing
user drawings and user comments layers).

Fixes https://gitlab.com/kicad/code/kicad/-/issues/21428

(cherry picked from commit b2ecaf1ddc)
9.0
Jeff Young 3 months ago
parent
commit
ac270d16eb
  1. 13
      pcbnew/pcbnew_jobs_handler.cpp

13
pcbnew/pcbnew_jobs_handler.cpp

@ -577,9 +577,6 @@ int PCBNEW_JOBS_HANDLER::JobExportRender( JOB* aJob )
boardAdapter.SetBoard( brd );
boardAdapter.m_IsBoardView = false;
if( aRenderJob->m_appearancePreset.empty() )
boardAdapter.m_IsPreviewer = true; // Force display 3D models, regardless of 3D viewer options
SETTINGS_MANAGER& mgr = Pgm().GetSettingsManager();
EDA_3D_VIEWER_SETTINGS cfg;
@ -590,6 +587,16 @@ int PCBNEW_JOBS_HANDLER::JobExportRender( JOB* aJob )
cfg.m_LayerPresets = userCfg->m_LayerPresets;
}
if( aRenderJob->m_appearancePreset.empty() )
{
// Force display 3D models
cfg.m_Render.show_footprints_not_in_posfile = true;
cfg.m_Render.show_footprints_dnp = true;
cfg.m_Render.show_footprints_insert = true;
cfg.m_Render.show_footprints_normal = true;
cfg.m_Render.show_footprints_virtual = true;
}
if( aRenderJob->m_quality == JOB_PCB_RENDER::QUALITY::BASIC )
{
// Silkscreen is pixelated without antialiasing

Loading…
Cancel
Save