Browse Source

Fix a compil warning.

Fix also an incorrect comment.
newinvert
jean-pierre charras 2 years ago
parent
commit
a7b1448ccd
  1. 2
      3d-viewer/3d_canvas/board_adapter.h
  2. 4
      3d-viewer/3d_canvas/create_3Dgraphic_brd_items.cpp
  3. 2
      pcbnew/pcb_track.cpp

2
3d-viewer/3d_canvas/board_adapter.h

@ -351,7 +351,7 @@ private:
void createPadWithMargin( const PAD *aPad, CONTAINER_2D_BASE* aDstContainer,
PCB_LAYER_ID aLayer, const VECTOR2I& aMargin ) const;
OBJECT_2D* createPadWithHole( const PAD* aPad, CONTAINER_2D_BASE* aDstContainer,
void createPadWithHole( const PAD* aPad, CONTAINER_2D_BASE* aDstContainer,
int aInflateValue );
void addPads( const FOOTPRINT* aFootprint, CONTAINER_2D_BASE* aDstContainer,

4
3d-viewer/3d_canvas/create_3Dgraphic_brd_items.cpp

@ -467,13 +467,13 @@ void BOARD_ADAPTER::createPadWithMargin( const PAD* aPad, CONTAINER_2D_BASE* aCo
}
OBJECT_2D* BOARD_ADAPTER::createPadWithHole( const PAD* aPad, CONTAINER_2D_BASE* aDstContainer,
void BOARD_ADAPTER::createPadWithHole( const PAD* aPad, CONTAINER_2D_BASE* aDstContainer,
int aInflateValue )
{
if( !aPad->HasHole() )
{
wxLogTrace( m_logTrace, wxT( "BOARD_ADAPTER::createPadWithHole - found an invalid pad" ) );
return nullptr;
return;
}
std::shared_ptr<SHAPE_SEGMENT> slot = aPad->GetEffectiveHoleShape();

2
pcbnew/pcb_track.cpp

@ -1177,7 +1177,7 @@ bool PCB_ARC::IsDegenerated( int aThreshold ) const
// cannot be safely computed if the distance between mid and end points
// is too small (a few internal units)
// len of both segments must be >= aThreshold to be not Degenerated arc
// len of both segments must be < aThreshold to be a very small degenerated arc
return ( GetMid() - GetStart() ).EuclideanNorm() < aThreshold
&& ( GetMid() - GetEnd() ).EuclideanNorm() < aThreshold;
}

Loading…
Cancel
Save