Fix a few (minor) compil and Coverity warnings.

common/pg_properties.cpp

@@ -169,7 +169,7 @@ bool PGPROPERTY_DISTANCE::StringToDistance( wxVariant& aVariant, const wxString&
 
 
     // Conversion to internal units
-    long newValueIU;
+    long newValueIU = 0;
 
     switch( unit )
     {

eeschema/cross-probing.cpp

@@ -618,7 +618,7 @@ findItemsFromSyncSelection( const SCHEMATIC& aSchematic, const std::string aSync
     }
 
     // Init sync maps from the sync string
-    for( int i = 0; i < syncArray.size(); i++ )
+    for( size_t i = 0; i < syncArray.size(); i++ )
     {
         wxString syncEntry = syncArray[i];
 

eeschema/dialogs/panel_setup_buses.cpp

@@ -28,6 +28,7 @@
 PANEL_SETUP_BUSES::PANEL_SETUP_BUSES( wxWindow* aWindow, SCH_EDIT_FRAME* aFrame ) :
         PANEL_SETUP_BUSES_BASE( aWindow ),
         m_frame( aFrame ),
+        m_lastAlias( 0 ),
         m_errorGrid( nullptr ),
         m_errorRow( -1 )
 {

eeschema/eeschema_config.cpp

@@ -139,10 +139,14 @@ void SCH_EDIT_FRAME::LoadSettings( APP_SETTINGS_BASE* aCfg )
     SCH_BASE_FRAME::LoadSettings( eeconfig() );
 
     SCH_SEARCH_DATA* searchData = dynamic_cast<SCH_SEARCH_DATA*>( m_findReplaceData.get() );
-    searchData->replaceReferences = eeconfig()->m_FindReplaceExtra.replace_references;
-    searchData->searchAllFields = eeconfig()->m_FindReplaceExtra.search_all_fields;
-    searchData->searchAllPins = eeconfig()->m_FindReplaceExtra.search_all_pins;
-    searchData->searchCurrentSheetOnly = eeconfig()->m_FindReplaceExtra.search_current_sheet_only;
+
+    if( searchData )
+    {
+        searchData->replaceReferences = eeconfig()->m_FindReplaceExtra.replace_references;
+        searchData->searchAllFields = eeconfig()->m_FindReplaceExtra.search_all_fields;
+        searchData->searchAllPins = eeconfig()->m_FindReplaceExtra.search_all_pins;
+        searchData->searchCurrentSheetOnly = eeconfig()->m_FindReplaceExtra.search_current_sheet_only;
+    }
 
     GetRenderSettings()->m_ShowPinsElectricalType = false;
 }
@@ -164,11 +168,15 @@ void SCH_EDIT_FRAME::SaveSettings( APP_SETTINGS_BASE* aCfg )
         // hierarchy panel
 
         SCH_SEARCH_DATA* searchData = dynamic_cast<SCH_SEARCH_DATA*>( m_findReplaceData.get() );
-        eeconfig()->m_FindReplaceExtra.replace_references = searchData->replaceReferences;
-        eeconfig()->m_FindReplaceExtra.search_all_fields = searchData->searchAllFields;
-        eeconfig()->m_FindReplaceExtra.search_all_pins = searchData->searchAllPins;
-        eeconfig()->m_FindReplaceExtra.search_current_sheet_only =
-                searchData->searchCurrentSheetOnly;
+
+        if( searchData )
+        {
+            eeconfig()->m_FindReplaceExtra.replace_references = searchData->replaceReferences;
+            eeconfig()->m_FindReplaceExtra.search_all_fields = searchData->searchAllFields;
+            eeconfig()->m_FindReplaceExtra.search_all_pins = searchData->searchAllPins;
+            eeconfig()->m_FindReplaceExtra.search_current_sheet_only =
+                    searchData->searchCurrentSheetOnly;
+        }
     }
 }
 

pcbnew/pcb_painter.cpp

@@ -401,7 +401,8 @@ PCB_PAINTER::PCB_PAINTER( GAL* aGal, FRAME_T aFrameType ) :
     PAINTER( aGal ),
     m_frameType( aFrameType ),
     m_maxError( ARC_HIGH_DEF ),
-    m_holePlatingThickness( 0 )
+    m_holePlatingThickness( 0 ),
+    m_lockedShadowMargin( 0 )
 {
 }