From 9c0727f28e7a6a4653b6f8aa66ce6af2f91e144d Mon Sep 17 00:00:00 2001 From: Seth Hillbrand Date: Tue, 16 Sep 2025 18:15:48 -0700 Subject: [PATCH] We need to clamp the index to max - 1 What did we think this was? Pascal? Fixes https://gitlab.com/kicad/code/kicad/issues/21750 --- pcbnew/board_design_settings.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pcbnew/board_design_settings.cpp b/pcbnew/board_design_settings.cpp index e1f8f704ef..8abd13758f 100644 --- a/pcbnew/board_design_settings.cpp +++ b/pcbnew/board_design_settings.cpp @@ -1347,7 +1347,7 @@ int BOARD_DESIGN_SETTINGS::GetSmallestClearanceValue() const void BOARD_DESIGN_SETTINGS::SetViaSizeIndex( int aIndex ) { - m_viaSizeIndex = std::min( aIndex, (int) m_ViasDimensionsList.size() ); + m_viaSizeIndex = std::min( aIndex, (int) m_ViasDimensionsList.size() - 1 ); m_useCustomTrackVia = false; } @@ -1380,7 +1380,7 @@ int BOARD_DESIGN_SETTINGS::GetCurrentViaDrill() const void BOARD_DESIGN_SETTINGS::SetTrackWidthIndex( int aIndex ) { - m_trackWidthIndex = std::min( aIndex, (int) m_TrackWidthList.size() ); + m_trackWidthIndex = std::min( aIndex, (int) m_TrackWidthList.size() - 1 ); m_useCustomTrackVia = false; }