pcbnew: Don't limit editing of the polygons

45 deg contraints are not saved per polygon, so don't limit per polygon.
The constraint is only enforced during creation.

Fixes: lp:1847722
* https://bugs.launchpad.net/kicad/+bug/1847722

Fixes: lp:1846029
* https://bugs.launchpad.net/kicad/+bug/1846029

include/tool/edit_points.h

@@ -510,17 +510,6 @@ public:
         return m_lines.size();
     }
 
-    void SetAllowPoints( bool aAllow = true )
-    {
-        m_allowPoints = aAllow;
-    }
-
-    bool GetAllowPoints() const
-    {
-        return m_allowPoints;
-    }
-
-
     ///> @copydoc VIEW_ITEM::ViewBBox()
     virtual const BOX2I ViewBBox() const override;
 

pcbnew/tools/point_editor.cpp

@@ -187,7 +187,6 @@ public:
             {
                 auto zone = static_cast<const ZONE_CONTAINER*>( aItem );
                 buildForPolyOutline( points, zone->Outline(), aGal );
-                points->SetAllowPoints( !zone->GetHV45() );
                 break;
             }
 
@@ -356,8 +355,7 @@ int POINT_EDITOR::OnSelectionChange( const TOOL_EVENT& aEvent )
                                                              snapLayers, { item } ) );
 
             // The alternative constraint limits to 45°
-            bool enableAltConstraint =
-                    ( !!evt->Modifier( MD_CTRL ) || !m_editPoints->GetAllowPoints() );
+            bool enableAltConstraint = !!evt->Modifier( MD_CTRL );
 
             if( enableAltConstraint != (bool) m_altConstraint )  // alternative constraint
                 setAltConstraint( enableAltConstraint );