Code cleanup: Fixing assignment operators

common/tool/tool_manager.cpp

@@ -109,7 +109,7 @@ struct TOOL_MANAGER::TOOL_STATE
     /// VIEW_CONTROLS settings to preserve settings when the tools are switched
     KIGFX::VC_SETTINGS vcSettings;
 
-    void operator=( const TOOL_STATE& aState )
+    TOOL_STATE& operator=( const TOOL_STATE& aState )
     {
         theTool = aState.theTool;
         idle = aState.idle;

pcbnew/router/pns_itemset.h

@@ -110,7 +110,7 @@ public:
 
     ~ITEM_SET();
 
-    const ITEM_SET& operator=( const ITEM_SET& aOther )
+    ITEM_SET& operator=( const ITEM_SET& aOther )
     {
         m_items = aOther.m_items;
         return *this;

pcbnew/router/pns_layerset.h

@@ -58,7 +58,7 @@ public:
 
     ~LAYER_RANGE() {};
 
-    const LAYER_RANGE& operator=( const LAYER_RANGE& aB )
+    LAYER_RANGE& operator=( const LAYER_RANGE& aB )
     {
         m_start = aB.m_start;
         m_end = aB.m_end;

pcbnew/router/pns_line.cpp

@@ -55,7 +55,7 @@ LINE::~LINE()
 }
 
 
-const LINE& LINE::operator=( const LINE& aOther )
+LINE& LINE::operator=( const LINE& aOther )
 {
     m_line = aOther.m_line;
     m_width = aOther.m_width;

pcbnew/router/pns_line.h

@@ -99,7 +99,7 @@ public:
     /// @copydoc ITEM::Clone()
     virtual LINE* Clone() const override;
 
-    const LINE& operator=( const LINE& aOther );
+    LINE& operator=( const LINE& aOther );
 
     ///> Assigns a shape to the line (a polyline/line chain)
     void SetShape( const SHAPE_LINE_CHAIN& aLine )