Fix some Coverity uninitialized scalar variable issues.

common/eda_text.cpp

@@ -91,7 +91,8 @@ GR_TEXT_V_ALIGN_T EDA_TEXT::MapVertJustify( int aVertJustify )
 
 EDA_TEXT::EDA_TEXT( const wxString& text ) :
         m_text( text ),
-        m_bounding_box_cache_valid( false )
+        m_bounding_box_cache_valid( false ),
+        m_bounding_box_cache_line( -1 )
 {
     int sz = Mils2iu( DEFAULT_SIZE_TEXT );
     SetTextSize( wxSize( sz, sz ) );

libs/kimath/include/geometry/shape_line_chain.h

@@ -111,6 +111,15 @@ public:
         ///< used by the refining code (e.g. hull handling stuff in the P&S) to reject false
         ///< intersection points.
         bool valid;
+
+        INTERSECTION() :
+            index_our( -1 ),
+            index_their( -1 ),
+            is_corner_our( false ),
+            is_corner_their( false ),
+            valid( false )
+        {
+        }
     };
 
 

pcbnew/plugins/cadstar/cadstar_pcb_archive_parser.h

@@ -2,7 +2,7 @@
  * This program source code file is part of KiCad, a free EDA CAD application.
  *
  * Copyright (C) 2020 Roberto Fernandez Bautista <roberto.fer.bau@gmail.com>
- * Copyright (C) 2020-2021 KiCad Developers, see AUTHORS.txt for contributors.
+ * Copyright (C) 2020-2022 KiCad Developers, see AUTHORS.txt for contributors.
  *
  * This program is free software: you can redistribute it and/or modify it
  * under the terms of the GNU General Public License as published by the
@@ -598,9 +598,9 @@ public:
             };
 
             STYLE ArrowStyle;  ///< Subnode="ARROWSTYLE"
-            long  UpperAngle;  ///< token="ARROWANGLEA"
-            long  LowerAngle;  ///< token="ARROWANGLEB"
-            long  ArrowLength; ///< The length of the angled lines that make up the arrow head
+            long  UpperAngle = 0;  ///< token="ARROWANGLEA"
+            long  LowerAngle = 0;  ///< token="ARROWANGLEB"
+            long  ArrowLength = 0; ///< The length of the angled lines that make up the arrow head
 
             void Parse( XNODE* aNode, PARSER_CONTEXT* aContext ) override;
         };

pcbnew/router/pns_via.h

@@ -2,7 +2,7 @@
  * KiRouter - a push-and-(sometimes-)shove PCB router
  *
  * Copyright (C) 2013-2014 CERN
- * Copyright (C) 2016-2020 KiCad Developers, see AUTHORS.txt for contributors.
+ * Copyright (C) 2016-2022 KiCad Developers, see AUTHORS.txt for contributors.
  * Author: Tomasz Wlostowski <tomasz.wlostowski@cern.ch>
  *
  * This program is free software: you can redistribute it and/or modify it
@@ -42,7 +42,7 @@ struct VIA_HANDLE
     bool        valid = false;
     VECTOR2I    pos;
     LAYER_RANGE layers;
-    int         net;
+    int         net = -1;
 };
 
 class VIA : public ITEM

pcbnew/tools/pcb_selection_tool.cpp

@@ -1875,6 +1875,8 @@ void PCB_SELECTION_TOOL::FindItem( BOARD_ITEM* aItem )
                     //Let's refocus because there is an algortihm to avoid dialogs in there.
                     m_frame->FocusOnLocation( aItem->GetCenter() );
                 }
+
+                delete screenRect;
             }
         }
         // Inform other potentially interested tools