From 74fc5cde02b2d8923f267083a37f1679beeefce3 Mon Sep 17 00:00:00 2001 From: Jeff Young Date: Sun, 1 Jun 2025 10:26:13 +0100 Subject: [PATCH] Don't save symbol library when importing Altium schematic. The user can always export the symbol library from the schematic if they want it. This also improves performance by more than 100X in the test case for #20299. Fixes https://gitlab.com/kicad/code/kicad/-/issues/15468 --- eeschema/sch_io/altium/sch_io_altium.cpp | 7 ------- 1 file changed, 7 deletions(-) diff --git a/eeschema/sch_io/altium/sch_io_altium.cpp b/eeschema/sch_io/altium/sch_io_altium.cpp index 1c593539b2..5c1a436341 100644 --- a/eeschema/sch_io/altium/sch_io_altium.cpp +++ b/eeschema/sch_io/altium/sch_io_altium.cpp @@ -1071,9 +1071,6 @@ void SCH_IO_ALTIUM::ParseFileHeader( const ALTIUM_COMPOUND_FILE& aAltiumSchFile fixupSymbolPinNameNumbers( symbol.second ); fixupSymbolPinNameNumbers( libSymbolIt->second ); - m_pi->SaveSymbol( getLibFileName().GetFullPath(), - new LIB_SYMBOL( *( libSymbolIt->second ) ), m_properties.get() ); - symbol.second->SetLibSymbol( libSymbolIt->second ); } @@ -1181,9 +1178,6 @@ void SCH_IO_ALTIUM::ParseASCIISchematic( const wxString& aFileName ) fixupSymbolPinNameNumbers( symbol.second ); fixupSymbolPinNameNumbers( libSymbolIt->second ); - m_pi->SaveSymbol( getLibFileName().GetFullPath(), - new LIB_SYMBOL( *( libSymbolIt->second ) ), m_properties.get() ); - symbol.second->SetLibSymbol( libSymbolIt->second ); } @@ -3685,7 +3679,6 @@ void SCH_IO_ALTIUM::ParsePowerPort( const std::map& aPropert libSymbol->GetValueField().SetPosition( valueFieldPos ); // this has to be done after parsing the LIB_SYMBOL! - m_pi->SaveSymbol( getLibFileName().GetFullPath(), libSymbol, m_properties.get() ); m_powerSymbols.insert( { symName, libSymbol } ); }