Don't leak output file path between projects.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/17846

(cherry picked from commit 0e9b547f94)

pcbnew/dialogs/dialog_gen_footprint_position.cpp

@@ -178,10 +178,7 @@ void DIALOG_GEN_FOOTPRINT_POSITION::initDialog()
     m_units = cfg->m_PlaceFile.units == 0 ? EDA_UNITS::INCHES : EDA_UNITS::MILLIMETRES;
 
     // Output directory
-    if( !projectFile.m_PcbLastPath[ LAST_PATH_POS_FILES ].IsEmpty() )
-        m_outputDirectoryName->SetValue( projectFile.m_PcbLastPath[ LAST_PATH_POS_FILES ] );
-    else
-        m_outputDirectoryName->SetValue( cfg->m_PlaceFile.output_directory );
+    m_outputDirectoryName->SetValue( projectFile.m_PcbLastPath[ LAST_PATH_POS_FILES ] );
 
     // Update Options
     m_radioBoxUnits->SetSelection( cfg->m_PlaceFile.units );

pcbnew/pcbnew_settings.cpp

@@ -485,8 +485,12 @@ PCBNEW_SETTINGS::PCBNEW_SETTINGS()
     m_params.emplace_back( new PARAM<bool>( "netlist.associate_by_ref_sch",
             &m_NetlistDialog.associate_by_ref_sch, false ) );
 
-    m_params.emplace_back( new PARAM<wxString>( "place_file.output_directory",
-            &m_PlaceFile.output_directory, wxEmptyString ) );
+    /*
+     * place_file.output_directory is only used at run-time; actual data is in project file
+     *
+     * m_params.emplace_back( new PARAM<wxString>( "place_file.output_directory",
+     *                        &m_PlaceFile.output_directory, wxEmptyString ) );
+     */
 
     m_params.emplace_back( new PARAM<int>( "place_file.units",
             &m_PlaceFile.units, 1 ) );

pcbnew/pcbnew_settings.h

@@ -267,7 +267,7 @@ public:
 
     struct DIALOG_PLACE_FILE
     {
-        wxString output_directory;  // legacy; now in project settings
+        wxString output_directory;  // only used at run-time; actual data in project settings
         int      units;
         int      file_options;
         int      file_format;