From 5993b3301047924b761f33e088cd234b6f3adae7 Mon Sep 17 00:00:00 2001 From: Maciej Suminski Date: Wed, 5 Sep 2018 11:18:48 +0200 Subject: [PATCH] Relax selection discard rules for footprints with area larger than the viewport Normally working at a zoom level when a footprint is not fully displayed indicates that the user modifies other components. Selection Tool used to discard footprints that had area larger than the viewport area, but it may make sense to select them if there are no other candidates. Fixes: lp:1789578 * https://bugs.launchpad.net/kicad/+bug/1789578 --- pcbnew/tools/selection_tool.cpp | 8 -------- 1 file changed, 8 deletions(-) diff --git a/pcbnew/tools/selection_tool.cpp b/pcbnew/tools/selection_tool.cpp index 49c65fde37..317661f07a 100644 --- a/pcbnew/tools/selection_tool.cpp +++ b/pcbnew/tools/selection_tool.cpp @@ -1620,14 +1620,6 @@ bool SELECTION_TOOL::selectable( const BOARD_ITEM* aItem ) const if( m_editModules ) return false; - float viewArea = getView()->GetViewport().GetArea(); - float modArea = aItem->GetBoundingBox().GetArea(); - - // Do not select modules that are larger the view area - // (most likely footprints representing shield connectors) - if( viewArea > 0.0 && modArea > viewArea ) - return false; - // Allow selection of footprints if at least one draw layer is on and // the appropriate LAYER_MOD is on