Remove redundant change to padstack mode

pcbnew/dialogs/dialog_pad_properties.cpp

@@ -415,16 +415,8 @@ void DIALOG_PAD_PROPERTIES::prepareCanvas()
 
 void DIALOG_PAD_PROPERTIES::OnPadstackModeChanged( wxCommandEvent& aEvent )
 {
-    switch( m_cbPadstackMode->GetSelection() )
-    {
-    default:
-    case 0: m_previewPad->Padstack().SetMode( PADSTACK::MODE::NORMAL );           break;
-    case 1: m_previewPad->Padstack().SetMode( PADSTACK::MODE::FRONT_INNER_BACK ); break;
-    case 2: m_previewPad->Padstack().SetMode( PADSTACK::MODE::CUSTOM );           break;
-    }
-
-    afterPadstackModeChanged();
     transferDataToPad( m_previewPad );
+    afterPadstackModeChanged();
     redraw();
 }
 
@@ -1581,6 +1573,8 @@ bool DIALOG_PAD_PROPERTIES::TransferDataFromWindow()
     if( !transferDataToPad( m_masterPad ) )
         return false;
 
+    m_padPreviewGAL->StopDrawing();
+
     PAD_TOOL* padTool = m_parent->GetToolManager()->GetTool<PAD_TOOL>();
     padTool->SetLastPadNumber( m_masterPad->GetNumber() );
 

pcbnew/pad.cpp

@@ -1599,7 +1599,7 @@ EDA_ITEM* PAD::Clone() const
     {
         for( std::shared_ptr<PCB_SHAPE>& primitive : cloned->m_padStack.Primitives( aLayer ) )
         {
-            primitive->SetParent(cloned);
+            primitive->SetParent( cloned );
         }
     } );