Remove kicad_string.h from eda_text.h

eeschema/connection_graph.cpp

@@ -39,6 +39,7 @@
 #include <schematic.h>
 #include <connection_graph.h>
 #include <widgets/ui_common.h>
+#include <kicad_string.h>
 
 #include <advanced_config.h> // for realtime connectivity switch
 

eeschema/dialogs/dialog_edit_sheet_pin.cpp

@@ -27,6 +27,7 @@
 #include <sch_validators.h>
 #include <dialog_edit_sheet_pin.h>
 #include <html_messagebox.h>
+#include <kicad_string.h>
 
 
 static wxString sheetPinTypes[] =

eeschema/dialogs/dialog_erc.cpp

@@ -48,6 +48,7 @@
 #include <wx/ffile.h>
 #include <erc_item.h>
 #include <eeschema_settings.h>
+#include <kicad_string.h>
 
 DIALOG_ERC::DIALOG_ERC( SCH_EDIT_FRAME* parent ) :
         DIALOG_ERC_BASE( parent, ID_DIALOG_ERC ),  // parent looks for this ID explicitly

eeschema/dialogs/dialog_lib_edit_pin_table.cpp

@@ -33,6 +33,7 @@
 #include <widgets/wx_grid.h>
 #include <pgm_base.h>
 #include <settings/settings_manager.h>
+#include <kicad_string.h>
 
 class PIN_TABLE_DATA_MODEL : public wxGridTableBase
 {

eeschema/sch_connection.cpp

@@ -27,6 +27,7 @@
 #include <sch_screen.h>
 #include <project/net_settings.h>
 #include <advanced_config.h>
+#include <kicad_string.h>
 
 #include <sch_connection.h>
 

eeschema/sch_edit_frame.cpp

@@ -33,6 +33,7 @@
 #include <hierarch.h>
 #include <html_messagebox.h>
 #include <invoke_sch_dialog.h>
+#include <kicad_string.h>
 #include <kiface_i.h>
 #include <kiplatform/app.h>
 #include <kiway.h>

eeschema/sch_plugins/cadstar/cadstar_sch_archive_loader.cpp

@@ -29,6 +29,7 @@
 #include <lib_arc.h>
 #include <lib_polyline.h>
 #include <lib_text.h>
+#include <kicad_string.h>
 #include <sch_bus_entry.h>
 #include <sch_edit_frame.h> //COMPONENT_ORIENTATION_T
 #include <sch_io_mgr.h>
@@ -87,14 +88,14 @@ void CADSTAR_SCH_ARCHIVE_LOADER::Load( ::SCHEMATIC* aSchematic, ::SCH_SHEET* aRo
     loadFigures();
     loadTexts();
     loadDocumentationSymbols();
-    
+
     if( Schematic.VariantHierarchy.Variants.size() > 0 )
     {
         wxLogWarning(
                 _( "The CADSTAR design contains variants which has no KiCad equivalent. All "
                    "components have been loaded on top of each other. " ) );
     }
-        
+
     if( Schematic.Groups.size() > 0 )
     {
         wxLogWarning(
@@ -1050,11 +1051,11 @@ CADSTAR_SCH_ARCHIVE_LOADER::POINT CADSTAR_SCH_ARCHIVE_LOADER::getLocationOfNetEl
         const NET_SCH& aNet, const NETELEMENT_ID& aNetElementID )
 {
     // clang-format off
-    auto logUnknownNetElementError = 
+    auto logUnknownNetElementError =
         [&]()
         {
-            wxLogError( wxString::Format( _( 
-                "Net %s references unknown net element %s. The net was "                                         
+            wxLogError( wxString::Format( _(
+                "Net %s references unknown net element %s. The net was "
                 "not properly loaded and may require manual fixing." ),
                     getNetName( aNet ), aNetElementID ) );
 

eeschema/sch_plugins/kicad/sch_sexpr_plugin.cpp

@@ -58,6 +58,7 @@
 #include <sch_plugins/kicad/sch_sexpr_parser.h>
 #include <symbol_lib_table.h>  // for PropPowerSymsOnly definintion.
 #include <ee_selection.h>
+#include <kicad_string.h>
 
 
 using namespace TSCHEMATIC_T;

eeschema/tools/backannotate.cpp

@@ -32,6 +32,7 @@
 #include <sch_edit_frame.h>
 #include <sch_sheet_path.h>
 #include <schematic.h>
+#include <kicad_string.h>
 #include <kiface_i.h>
 #include <wildcards_and_files_ext.h>
 

eeschema/tools/sch_edit_tool.cpp

@@ -34,6 +34,7 @@
 #include <confirm.h>
 #include <eda_item.h>
 #include <reporter.h>
+#include <kicad_string.h>
 #include <sch_item.h>
 #include <sch_component.h>
 #include <sch_sheet.h>

gerbview/tools/gerbview_control.cpp

@@ -25,6 +25,7 @@
 #include <gerber_file_image_list.h>
 #include <gerbview_painter.h>
 #include <gerbview_frame.h>
+#include <kicad_string.h>
 #include <excellon_image.h>
 #include <menus_helpers.h>
 #include <tool/tool_manager.h>

gerbview/tools/gerbview_selection_tool.cpp

@@ -26,6 +26,7 @@ using namespace std::placeholders;
 #include <bitmaps.h>
 #include <gerber_collectors.h>
 #include <class_draw_panel_gal.h>
+#include <kicad_string.h>
 #include <view/view.h>
 #include <view/view_controls.h>
 #include <view/view_group.h>

include/eda_text.h

@@ -27,7 +27,6 @@
 
 #include <common.h>                 // wxStringSplit
 #include <eda_rect.h>
-#include "kicad_string.h"
 #include "painter.h"
 
 class SHAPE_COMPOUND;